Commit Graph

54539 Commits

Author SHA1 Message Date
Sihua Ma
f8b30f4493 Merge "Remove app widget view when widget id is deleted" into tm-qpr-dev am: 0f30c095f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21951079

Change-Id: Iec8884a1aaefc6c4519a26d86d8ac5d4afda4e3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 23:30:21 +00:00
Fengjiang Li
d14b11ad3c Merge "[Predictive Back] Fix bug where closing task bar's all apps will show scale animation even if predicitve back is disabled" into tm-qpr-dev am: 47c03be9fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21911161

Change-Id: I1b74b3a49c48936039c501ca07ca4d7aa0ceeb3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 23:26:29 +00:00
Sihua Ma
0f30c095f4 Merge "Remove app widget view when widget id is deleted" into tm-qpr-dev 2023-03-10 23:16:10 +00:00
Fengjiang Li
47c03be9fc Merge "[Predictive Back] Fix bug where closing task bar's all apps will show scale animation even if predicitve back is disabled" into tm-qpr-dev 2023-03-10 21:27:40 +00:00
Sebastián Franco
b8614e298c Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I274f6eae4cda80ea45ee48328b6d2a5abfb1e648
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 19:47:55 +00:00
Sebastián Franco
4122868216 Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev 2023-03-10 19:19:42 +00:00
Fengjiang Li
b167a803fb Merge "[Predictive Back] Fix small bottom gap in widget to home animation" into tm-qpr-dev am: 20a343e740
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21934197

Change-Id: I142754b178563b7ec325bba16eb806737354b1ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 17:59:03 +00:00
Brandon Dayauon
e0bddb5b42 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: Ibf5cb36dc8e5ec0def0012b17b14e848a33d9d83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 17:58:48 +00:00
Fengjiang Li
20a343e740 Merge "[Predictive Back] Fix small bottom gap in widget to home animation" into tm-qpr-dev 2023-03-10 17:34:24 +00:00
Brandon Dayauon
5ddc6ab4da Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev 2023-03-10 17:21:37 +00:00
Fengjiang Li
37305d49fa [Predictive Back] Fix bug where closing task bar's all apps will show scale animation even if predicitve back is disabled
TaskbarAllAppsSlideInView.onBackInvoked() can be triggered by ViewGroup.dispatchKeyEvent(event) with KEYCODE_BACK, in that case we should skip scale animation

Test: manual
Fix: b/272317866
Change-Id: I19468cfe4765de5276c479b0f7fa88ec0690bbfd
2023-03-10 08:54:55 -08:00
Federico Baron
aac9a588e2 Merge "Fix bug where homescreen shows installation completed when it's technically still downloading and fix animation that repeats in apps with quick install" into tm-qpr-dev am: 0c77edb8cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21943710

Change-Id: Ie3d3ff6a2cc834b80e8d909d4753f8c0d1af9c75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 06:37:30 +00:00
Federico Baron
0c77edb8cc Merge "Fix bug where homescreen shows installation completed when it's technically still downloading and fix animation that repeats in apps with quick install" into tm-qpr-dev 2023-03-10 06:21:17 +00:00
Sihua Ma
3d9dc3551d Remove app widget view when widget id is deleted
Also clearing all the views in clearViews()

Test: N/A
Fix: 272647976
Change-Id: Ia54401279f453a31f392898c4db2dbe199d346dd
2023-03-09 21:28:15 -08:00
Sihua Ma
7560a917d9 Merge "Use app widget host instead of holder to get rid of deleteHost" into tm-qpr-dev am: 713931ec38
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21408002

Change-Id: I9a4ca72e07649daed35f4c4d4ca8b02caabe07bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 23:29:19 +00:00
Brandon Dayauon
cf88ea1e62 Support two line text in AllApps/OnDeviceSearch w/ feature flag
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.

bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after:  https://screenshot.googleplex.com/7pkwUto6HGzMYoT

Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
2023-03-09 15:13:04 -08:00
Sihua Ma
713931ec38 Merge "Use app widget host instead of holder to get rid of deleteHost" into tm-qpr-dev 2023-03-09 23:06:55 +00:00
Sebastian Franco
239ae0a995 Making sure there is a propper Chrome icon for the test to long press
In some cases, the test was long pressing on a recommendation for
google chrome and not a regular chrome icon and the events didn't
match. I don't think is good to relly on chrome getting recommended
so I'm making sure there is always a chrome app icon on the hotseat

Fix: 269163620
Test: atest TaplTestsLauncher3:testWorkspace (run on pixel 7 pro)
Change-Id: Ic8ee744a9af18d60de9bbedd42043f5abbbd7356
2023-03-09 14:59:21 -08:00
Jon Miranda
a7d7c64037 Merge "Align taskbar to the left/right in 3 button nav for certain devices." into tm-qpr-dev am: 0fe7e089ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21893967

Change-Id: I73af22d020c543f27eba846dd496d26b652a5a72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 22:46:30 +00:00
Federico Baron
db599b2d8e Fix bug where homescreen shows installation completed when it's technically still downloading and fix animation that repeats in apps with quick install
Fix: 269702659
Test: Download an app that has a lighning next to the install text and verify that the animation plays smoothly and that it doesn't animate until we finish downloading completely.
Change-Id: I11147444a85db01c75d63b5cdd09d1d911a28c75
2023-03-09 14:44:41 -08:00
Fengjiang Li
1898d16ee0 [Predictive Back] Fix small bottom gap in widget to home animation
The bug was caused by a math problem. The extrat bottom offset should be

 offset = (H / 0.9 - H) / 2

Fix: b/269393854
Test: manual
Change-Id: Ia4d6b3f2ecb53b82d6779cd385ce4d7ca3c16113
2023-03-09 14:38:06 -08:00
Jon Miranda
0fe7e089ca Merge "Align taskbar to the left/right in 3 button nav for certain devices." into tm-qpr-dev 2023-03-09 22:33:28 +00:00
Jon Miranda
e17a949950 Align taskbar to the left/right in 3 button nav for certain devices.
Otherwise we position the taskbar in the center.

Bug: 259712417
Fixes: 267997547
Test: transient taskbar unaffected
      persistent taskbar
      - test on small tablet
      - test on large tablet
      - test LTR and RTL

Change-Id: Ieb0a304d9963ebf583bc4ef2deaab747019e8d6d
2023-03-09 22:33:18 +00:00
Vinit Nayak
4eb50abbc3 Merge "Add initial split from GroupedTaskView animation" into tm-qpr-dev am: 4b0a5ed8fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21613692

Change-Id: Ie67a493178748b7d44075e672a4a1ac3f66e7029
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 21:43:25 +00:00
Vinit Nayak
4b0a5ed8fa Merge "Add initial split from GroupedTaskView animation" into tm-qpr-dev 2023-03-09 21:17:07 +00:00
Jagrut Desai
b572cfee26 Merge "Make TaskbarStashController aware of accesseibilty time to action settings." into tm-qpr-dev am: 5cef4b83d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778874

Change-Id: Iaf4c7b086975d54896cb9806fb824cfbc7575789
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 20:14:12 +00:00
Jagrut Desai
5cef4b83d5 Merge "Make TaskbarStashController aware of accesseibilty time to action settings." into tm-qpr-dev 2023-03-09 19:49:18 +00:00
Sihua Ma
cdb3c0af1a Use app widget host instead of holder to get rid of deleteHost
Also putting the calls to destroy() in try-finally blocks.

Test: N/A
Fix: 272535886
Change-Id: I57ecd90e412b3b8b59b4ed755a5d4191b05fd9b3
2023-03-09 11:19:18 -08:00
Fengjiang Li
b595d347a9 Merge "Fix NPE of TopTaskTracker" into tm-qpr-dev am: c523de6dc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21894262

Change-Id: I7b256fd8620c02797c7dc25f0943badc7b5ad437
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 18:53:52 +00:00
Fengjiang Li
c523de6dc2 Merge "Fix NPE of TopTaskTracker" into tm-qpr-dev 2023-03-09 18:25:07 +00:00
Brandon Dayauon
3f5e40eaae Merge "Play original haptic when feature flag is off. Rename feature flag" into tm-qpr-dev am: c1e12fc150
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21896830

Change-Id: I7104e588e71400dff21e330b7420d72da6e866fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 17:11:57 +00:00
Brandon Dayauon
c1e12fc150 Merge "Play original haptic when feature flag is off. Rename feature flag" into tm-qpr-dev 2023-03-09 16:44:07 +00:00
Eddie Lan
cdf797c22e Merge "Revert "Hide the splash icon when launching with no view and no ..."" into tm-qpr-dev am: cbdd6493f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21916962

Change-Id: Ie16046b1814bcf6efe92bdd86afb140f6c1e2053
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 09:30:37 +00:00
Eddie Lan
cbdd6493f1 Merge "Revert "Hide the splash icon when launching with no view and no ..."" into tm-qpr-dev 2023-03-09 09:06:11 +00:00
Eddie Lan
293688a9a0 Revert "Hide the splash icon when launching with no view and no ..."
Revert submission 21447384-no-splash

Reason for revert: build break
Bug: 272383391

Reverted changes: /q/submissionid:21447384-no-splash

Change-Id: I73565b1f4e5dd969237980b2b5dbeee7b563abcb
2023-03-09 09:00:29 +00:00
Jon Miranda
55b2ec2d70 Merge "Polish taskbar un/stash animation." into tm-qpr-dev am: 4c368373cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21751712

Change-Id: I1ce5871d5230e309acef219095c0525c247d983d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 03:45:34 +00:00
Jon Miranda
4c368373cb Merge "Polish taskbar un/stash animation." into tm-qpr-dev 2023-03-09 03:33:39 +00:00
Jon Miranda
1ffac1c8ac Merge "Hide taskbar view for app open/close animation." into tm-qpr-dev am: 1671b704b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21808184

Change-Id: I113319547da7b51366e4be2aeb94a51d976b7382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 01:04:21 +00:00
Ats Jenk
cff883d96f Merge "Remove empty desktop tile" into tm-qpr-dev am: bac6d4946a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21893975

Change-Id: Ie7d90dd608dda1288032b47375e3ca491676ecdf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 01:04:09 +00:00
Jon Miranda
1671b704b3 Merge "Hide taskbar view for app open/close animation." into tm-qpr-dev 2023-03-09 00:33:27 +00:00
Ats Jenk
bac6d4946a Merge "Remove empty desktop tile" into tm-qpr-dev 2023-03-09 00:31:50 +00:00
Brandon Dayauon
dee687c33a Play original haptic when feature flag is off. Rename feature flag
- Remove the Utilities.atLeast check since it's no longer relevant as there is no new haptics being played
in the original haptic..

When FeatureFlag is off, the haptic for all apps and qsb is played in one place. So when
FeatureFlag is on, we need to isolate where the haptic call gets played so we disable calling it from two places
and play the haptics at the respective areas.
flag: ENABLE_PREMIUM_HAPTICS_ALL_APPS=false


bug: 270634265
test: Manual
Change-Id: I7b92c427e880b196130270ed9709cf1ea0e19e0a
2023-03-09 00:14:14 +00:00
Mateusz Cicheński
efeae8e3aa Merge "Fix entry bounds for 3 button nav" into tm-qpr-dev am: 321127d14a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21847300

Change-Id: I2a4dafc799be1cc58b4cf54062571a7b39a5de6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:12:54 +00:00
Brian Isganitis
16fdd8b4f0 Ensure taskbar background always transparent in notification tray. am: 84261f9d9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21593273

Change-Id: I301369bdce2bf00ef00d95d75ae91365022e4d6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:12:04 +00:00
Jagrut Desai
545f6540c3 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev am: d301c9b628
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21735251

Change-Id: Ibdb3a308550727a8c03c83c99e1c8566b443e503
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-09 00:11:29 +00:00
Mateusz Cicheński
321127d14a Merge "Fix entry bounds for 3 button nav" into tm-qpr-dev 2023-03-08 23:52:41 +00:00
Brian Isganitis
84261f9d9b Ensure taskbar background always transparent in notification tray.
Persistent, taskbar can be in light or dark modes. Since notification
tray has its own background color, we should hide ours to avoid clashing
with it.

Test: Manual
Fix: 270758899
Change-Id: Iedc6aae42aac30987af3259ccee11c5998e10517
2023-03-08 23:51:34 +00:00
Jon Miranda
67d4b0ed6b Polish taskbar un/stash animation.
- When QSB is inline, we add it to the reveal animation
  so that it moves in coordination with the rest of the
  taskbar icons
- Hide All Apps button when transitioning from Home -> App
  to match spec
- Shorten duration icons move in x duration so that they
  stay within the taskbar background bounds.

Bug: 267806083
Bug: 246635237
Bug: 246660243
Test: transient taskbar
      with isQsbInline = true and false

Change-Id: Ie6b866311cc2ceba88cdf01652b30fee457d0359
Merged-In: Ie6b866311cc2ceba88cdf01652b30fee457d0359
2023-03-08 23:47:29 +00:00
Jagrut Desai
d301c9b628 Merge "Announce for accessiblity when taskbar is invoked/closed" into tm-qpr-dev 2023-03-08 23:34:01 +00:00
Vinit Nayak
aa7bf8b394 Add initial split from GroupedTaskView animation
* Created SplitAnimationController to prevent more
RecentsView bloat
* Extract SplitSelectSource attributes into separate class
* http://recall/-/cMb5xTTxhmZtFt04eYnmQj/eACJq1un8Ef91LgmQblpAw

Bug: 267370106
Change-Id: I5d430c091ac84bbbc30319e7b78711b610a21252
2023-03-08 15:17:57 -08:00