Commit Graph

75872 Commits

Author SHA1 Message Date
Ats Jenk
f3224cf847 Update expanded view drop target size based on value from shell
When a bubble drag starts, shell sends the current expanded view size
over as part of BubbleBarData. Update the size stored in
BubblePinController based on latest value.
Update drop target visual to match the spec. It should have 24dp insets
compared to expanded view and 28dp corner radius.

Bug: 330585402
Test: drag bubble in landscape, check that drop target for expanded view
  matches with what is shown when expanded view is dragged
Test: drag bubble in portrait, check that the drop target for expanded
  view, matches with what is shown when expanded view is dragged
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: Ic11c4c5c675107543ba08f24a4138cda422d24c1
2024-05-08 14:05:03 -07:00
Tracy Zhou
ef8872bb01 Merge "Update SUW swipe home logic for taskbar stashing" into 24D1-dev am: 63da44e7eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27239028

Change-Id: I422db33acd92b6c87ba65a6c96a146fd1d2be8e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 15:53:30 +00:00
Tracy Zhou
63da44e7eb Merge "Update SUW swipe home logic for taskbar stashing" into 24D1-dev 2024-05-07 15:33:00 +00:00
Treehugger Robot
22283fd1b8 Merge "Use TaskContainer as source of truth around Task handling" into main 2024-05-07 15:00:24 +00:00
Schneider Victor-tulias
c6c8a22daf Merge "Add debug logs for b/319168409" into main 2024-05-07 13:56:56 +00:00
Liran Binyamin
8f266507fd Merge "Animate the bubble bar for the first bubble" into main 2024-05-07 13:08:21 +00:00
Alex Chau
5b15bfe20b Use TaskContainer as source of truth around Task handling
- Renamed TaskIdAttributeContainer into TaskContainer so it's shorter
- Make mTaskContainers the source of truth for Task handling, removing mTask, mSecondaryTask, mTaskIdContainer and use mTaskContainers to derive all related information
- Remove mTasks/mSnapshotViewMap in DesktopTaskView and replace with mTaskContainers
- Mark methods that assumes a single Task as deprecated e.g. getTask, getItemInfo, getThumbnail to discourage further usage of such methods; "First" is added to the method name to make it explicit only first Task is considered; getTaskContainers is encouraged to access such information

Bug: 249371338
Test: Manual
Flag: None
Change-Id: Ieb15e0e8432913c89dc46c1011f0148095c665f8
2024-05-07 11:51:26 +01:00
Himanshu Gupta
8b0d1fb614 Merge "Adding Tapl test for locking/unlocking Private Space" into main 2024-05-07 09:57:59 +00:00
Alex Chau
6526706721 Merge "Remove TaskView.isDesktopTask" into main 2024-05-07 08:26:21 +00:00
Andy Wickham
96adbcb2a8 Merge "Remove unused AssistStateManager methods." into main 2024-05-07 01:43:46 +00:00
Tracy Zhou
afe3701c74 Merge "Fix 3-button showing up briefly on the AllSet page in setup" into 24D1-dev am: 2155a925fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27237053

Change-Id: I96c0ce0c4909e3e8663f1616ed22791cb6e1a7e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 01:38:44 +00:00
Tracy Zhou
2155a925fc Merge "Fix 3-button showing up briefly on the AllSet page in setup" into 24D1-dev 2024-05-07 01:26:01 +00:00
Willie Koomson
c81ffaf821 Merge "Remove shadow on Add button" into main 2024-05-07 01:15:37 +00:00
Liran Binyamin
aa73f595cf Animate the bubble bar for the first bubble
This change animates the bubble bar for the first bubble.
When we're in home -- the bubble bar bounces in and stays visible
When we're in app -- the bubble bar bounces in, then animates to
the stashed handle.
When the bubble bar auto expands, we currently animate the bubble
bar already expanded. In the future we'll time the expansion
until after the bubble bar settles in.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/hIGwtb3YKyCT9Ke9adZNgY

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 339066271
Test: atest BubbleBarViewAnimatorTest
Change-Id: I80ce55676b72a50bab23623e0b5c1e602690682f
2024-05-06 20:17:28 -04:00
Andy Wickham
17526db32a Merge "Implement animateNavBarLongPress for stashed taskbar." into main 2024-05-06 23:12:32 +00:00
Treehugger Robot
8ba31bedb3 Merge "Fix null pointer in FloatingWidgetView" into 24D1-dev am: c5fec774b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27238353

Change-Id: I95c1eca1587c91e3406d4e50764a7c8fc26e125c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-06 23:10:58 +00:00
Treehugger Robot
c5fec774b2 Merge "Fix null pointer in FloatingWidgetView" into 24D1-dev 2024-05-06 22:55:57 +00:00
Shamali Patwa
4f8ef8f54b Merge "Readjust the available size for the recommendations in 2-pane sheet" into main 2024-05-06 22:53:19 +00:00
Tracy Zhou
6d3a1d8f50 Update SUW swipe home logic for taskbar stashing
- Reverted the previous change. It doesn't fix the issue when launching setup mode with command line. The fact that it looked as if it's fixed from factory reset might be a fluke
- Found out that we unstash the task bar to home from setup somewhere in TaskbarStashController. This is related to stashed alpha only.

Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I04daf41ae9a1c3b7e6e4962dd4a8c62b708e0a54
(cherry picked from commit b297d4fb83)
2024-05-06 22:34:36 +00:00
Tracy Zhou
052b4c924f Merge "Update SUW swipe home logic for taskbar stashing" into main 2024-05-06 22:34:24 +00:00
Willie Koomson
49e364cd0b Remove shadow on Add button
Set android:stateListAnimator to @null to remove default shadow on Add
button.

Bug: 333736273
Test: manual, check shadow on device
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ifa66801963e69582935806eb8a39dcfe624ffdc7
2024-05-06 22:26:24 +00:00
Tony Wickham
bc549958d9 [automerger skipped] Merge "Remove obsolete binder calls to TaskTransitionSpec" into 24D1-dev am: 4f54ccebb5 -s ours
am skip reason: Merged-In Ie20dc8d4bb0c85a8a256b001fbb92405679618a8 with SHA-1 a179a77e09 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27214071

Change-Id: I6525e3bb8ccfc6bd0823e9813675a0014a03615b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-06 21:29:32 +00:00
Tony Wickham
7b4ac19a7d [automerger skipped] Remove obsolete binder calls to TaskTransitionSpec am: 35b08fe4b2 -s ours
am skip reason: Merged-In Ie20dc8d4bb0c85a8a256b001fbb92405679618a8 with SHA-1 a179a77e09 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27214071

Change-Id: Ia168669b664ae781fb8091bf246dfb7c16b4f34e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-06 21:29:28 +00:00
Tony Wickham
4f54ccebb5 Merge "Remove obsolete binder calls to TaskTransitionSpec" into 24D1-dev 2024-05-06 21:09:27 +00:00
fbaron
7435831cbd Fix null pointer in FloatingWidgetView
Flag: NONE
Test: NONE
Bug: 331868669
Change-Id: I350e6660ea1936bb9ee799c3d2c840c57876fef4
(cherry picked from commit c0c0bdbc38)
2024-05-06 20:58:14 +00:00
Sunny Goyal
499b9d067f Merge "Creating a custom runner for multivalent tests with Launcher specific features" into main 2024-05-06 20:55:00 +00:00
Treehugger Robot
bdbb43679c Merge "Add screenrecord and demote TaplUninstallRemoveTest#testAddDeleteShortcutOnHotseat" into main 2024-05-06 20:25:22 +00:00
Tracy Zhou
b297d4fb83 Update SUW swipe home logic for taskbar stashing
- Reverted the previous change. It doesn't fix the issue when launching setup mode with command line. The fact that it looked as if it's fixed from factory reset might be a fluke
- Found out that we unstash the task bar to home from setup somewhere in TaskbarStashController. This is related to stashed alpha only.

Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I04daf41ae9a1c3b7e6e4962dd4a8c62b708e0a54
2024-05-06 13:05:41 -07:00
Sunny Goyal
0f4bc92653 Creating a custom runner for multivalent tests with Launcher specific features
Bug: 338128923
Test: Verified by modifying a test
Flag: None
Change-Id: I1f04e28847ff9c0f7af3c0d952038ad24d03c17e
2024-05-06 12:10:21 -07:00
Tracy Zhou
3196b7ca5c Fix 3-button showing up briefly on the AllSet page in setup
Fixes: 338883705
Test: Go through setup. Make sure the 3-button doesn't show up anytime during setup
Change-Id: Idd62486465d608235abe61b994718311c72cb20c
(cherry picked from commit cb8eb189f1)
2024-05-06 19:06:23 +00:00
Tracy Zhou
74ed411d07 Merge "Fix 3-button showing up briefly on the AllSet page in setup" into main 2024-05-06 19:06:07 +00:00
Himanshu Gupta
bf51b4882e Adding Tapl test for locking/unlocking Private Space
In this test:
1. Private Space is created.
2. Lock Button is clicked, locked view is verified.
3. Unlock Button is clicked, unlocked view is verified.
4. Private Space is removed.

Doc: go/private-space-tapl

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I1c399a96ea14a4464113576d31eed8db1caf1f2a
2024-05-06 20:03:23 +01:00
fbaron
5498d1e73e Add screenrecord and demote TaplUninstallRemoveTest#testAddDeleteShortcutOnHotseat
Flag: NONE
Test: TaplUninstallRemoveTest#testAddDeleteShortcutOnHotseat
Bug: 338869019
Change-Id: Ia2a3ce8808d63e2d6197cf5ef26b274817b7729a
2024-05-06 11:17:35 -07:00
Brandon Dayauon
9fa457e876 Merge "Update private space animation timings" into main 2024-05-06 18:15:05 +00:00
Sukesh Ram
251f81adbf [automerger skipped] Merge "Replace Contextual Rotation Button with Floating Action Button" into 24D1-dev am: f1b3a2fc12 -s ours
am skip reason: Merged-In I8bd9acdeec8ade4c8183c42056bf67b1c825906c with SHA-1 1187fd817e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27182859

Change-Id: Ifba2b08a5e2b6628f5c2d741ec8d26b41a3f5a87
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-06 17:37:41 +00:00
Sukesh Ram
6151108b96 [automerger skipped] Replace Contextual Rotation Button with Floating Action Button am: 8bce9e5940 -s ours
am skip reason: Merged-In I8bd9acdeec8ade4c8183c42056bf67b1c825906c with SHA-1 1187fd817e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27182859

Change-Id: Iad4ffb37fd53712d86d536b32c59178f5e85793e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-06 17:37:39 +00:00
Sukesh Ram
f1b3a2fc12 Merge "Replace Contextual Rotation Button with Floating Action Button" into 24D1-dev 2024-05-06 17:31:49 +00:00
Schneider Victor-tulias
8288819aa6 Add debug logs for b/319168409
Flag: N/A
Bug: 319168409
Test: TaplDragTest#testDragAppIcon

Change-Id: I96d26cc78af0a3f4145fc3486c4b6adfbd110c9e
2024-05-06 16:22:03 +00:00
Liran Binyamin
b4b5e79ffe Merge "Interrupt bubble animation on stash change" into main 2024-05-06 16:06:55 +00:00
Shamali P
c0e4dcf238 Readjust the available size for the recommendations in 2-pane sheet
Now that we exclude the space taken by size string and description,
offsetting the size provided to the recommendation table to keep the
widgets within non-scrollable view as much possible.

Bug: N/A
Test: Screenshot
Flag: N/A

Change-Id: I0193cd1ba5de0b0ff98dab9aeb352264afd3ff3a
2024-05-06 15:50:42 +00:00
Liran Binyamin
209c764175 Interrupt bubble animation on stash change
This change handles cancelling the currently running bubble animation when the stash state is changing.

Demo - http://recall/-/bJtug1HhvXkkeA4MQvIaiP/4jnBgnFaIPez6m7fVLSlf

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I34628f8ad741228dd21285ad66e45ef2909fbdab
2024-05-06 09:55:34 -04:00
Tracy Zhou
cb8eb189f1 Fix 3-button showing up briefly on the AllSet page in setup
Fixes: 338883705
Test: Go through setup. Make sure the 3-button doesn't show up anytime during setup
Change-Id: Idd62486465d608235abe61b994718311c72cb20c
2024-05-05 21:39:54 -07:00
Sunny Goyal
8dec848ad2 Merge "Adding a special runner to run simulate multiple devices when running robo tests" into main 2024-05-04 03:13:27 +00:00
Andy Wickham
3a7a76f88e Implement animateNavBarLongPress for stashed taskbar.
I think ideally we would tie this into the taskbar's outline
provider, but it seemed more complicated to deal with existing
stashing animations.

Instead I've just animated the stashed taskbar scale to 0.85 or
1.18, depending on the SHRINK_NAV_HANDLE_ON_PRESS flag. These
are based on the existing navbar shrink/expand animations.

Demo (the flickering doesn't happen on-device):
https://drive.google.com/file/d/1CWCPRsuD3kjtOUbwXspkQ_ZJ6Ln7FnUo/view?usp=sharing&resourcekey=0-kJjfgnuEca1de4u8mbHrig

Bug: 308693847
Test: Manual
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Flag: LEGACY ANIMATE_LPNH DISABLED
Change-Id: I6ecbc849ac1c066a4c018325f0237a61641d99aa
2024-05-03 17:53:34 -07:00
Federico Baron
aed966daae Merge "Add screenrecord and demote TaplTestsTrackpad#switchToOverview" into main 2024-05-03 23:54:32 +00:00
Bill Yi
60829aa8a2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-03 23:19:17 +00:00
Bill Yi
562900921d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-03 23:19:17 +00:00
Sunny Goyal
86145f49fb Adding a special runner to run simulate multiple devices when running robo tests
Bug: 338128923
Test: Verrified by modifying a test
Flag: None
Change-Id: I133842d68e437b971da39e2081c8859515463cd3
2024-05-03 15:54:40 -07:00
Treehugger Robot
7ade04b55e [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: b46bea2e3e -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27209135

Change-Id: I76a01872ad4d46bb92ca9eb86a657fee816bad0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 22:36:45 +00:00
Bill Yi
430e54c9d4 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 259b5de19e -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27209135

Change-Id: I2b72540823c8dde5660ee7e0b2b5e12182a75c40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 22:36:42 +00:00