Commit Graph

2643 Commits

Author SHA1 Message Date
Andrew Cole
eddc230d71 Turning back on flaky test
Because of a fix that has been merged here ag/23680187 this test should also be able to be turned on and not become flakey.

Bug: 256615483
Test: testUninstallFromWorkspace
Change-Id: I7096f5e9392ddedf1c4c2ab23b922b352bb5d7b1
2023-06-15 08:12:28 -07:00
Thales Lima
961e683187 Merge "Create AllApps responsive spec" into udc-qpr-dev 2023-06-14 17:09:20 +00:00
Thales Lima
981bca7355 Merge "Migrate DeviceProfile dump tests to files" into udc-qpr-dev 2023-06-14 17:07:52 +00:00
Andrew Cole
ee1e3b3686 Merge "Test Uninstall Flakiness" into udc-qpr-dev 2023-06-14 16:50:51 +00:00
Thales Lima
196e44baec Create AllApps responsive spec
Copy the parser from WorkspaceSpec and modify to use AllApps attributes.

Bug: 284152932
Test: AllAppsSpecsTest
Test: CalculatedAllAppsSpecTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I9362e126c64cb1a1abdef61894b003f14701b8e3
2023-06-14 15:02:58 +01:00
Thales Lima
9cc14e3610 Migrate DeviceProfile dump tests to files
Using files makes it easier to update the changed properties.

Fix: 286049633
Test: DeviceProfileDumpTest
Flag: N/A
Change-Id: I5f51a99c1bb1688c59466282c836ef30466ae53d
2023-06-14 11:03:27 +01:00
Jordan Silva
296a9f3389 Merge "Update SizeSpec attributes to accept max size threshold" into udc-qpr-dev 2023-06-14 09:37:42 +00:00
Andrew Cole
b9b75281b1 Test Uninstall Flakiness
Fixing a flake in a e2e test that is occuring in testUninstallFromAllApps. The offending test was not always waiting for the platform to uninstall the app, which would remove the app from AllApps.

Bug: 258071914
Test: testUninstallFromAllApps
Change-Id: I38d162ba09f38feca49a96fa126db7ffc22ce935
2023-06-13 15:02:24 -07:00
Jordan Silva
1b336110a4 Update SizeSpec attributes to accept max size threshold
Add maxSize attribute to SizeSpec to limit the cell size up to a max size when matchWorkspace is true. The same validation was added when using fixedSize, ofAvailableSpace and ofRemainderSpace, so they could have a maxSize as a threshold.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: SizeSpecTest
Test: WorkspaceSpecsTest
Change-Id: I113657c241e6618eb3e501243412d8c5626fc3d5
2023-06-13 18:09:37 +01:00
Jordan Silva
b1dc7718be Merge "Add FolderSpec for responsive grid support" into udc-qpr-dev 2023-06-13 15:41:49 +00:00
Jordan Silva
7ae9e3a6f5 Add FolderSpec for responsive grid support
Adds responsive grid implementation for folders. It follows the same concept as WorkspaceSpecs, so we have a parser similar to WorkspaceSpecs for FolderSpecs.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: FolderSpecsTest
Test: CalculatedFolderSpecsTest
Change-Id: Iea6d7d88ef42d1273aed7cf2ed5b397035518a52
2023-06-13 15:01:39 +01:00
Thales Lima
eb83006b0b Merge "Correct AllApps horizontal padding" into udc-qpr-dev 2023-06-13 11:04:47 +00:00
Jordan Silva
d22a85cd64 Merge "Adding match workspace to SizeSpec for responsive grid support" into udc-qpr-dev 2023-06-09 20:04:54 +00:00
Jordan Silva
2b8556ce1a Adding match workspace to SizeSpec for responsive grid support
Added matchWorkspace property to support responsive grid implementation for AllApps and Folders. This property indicates whether the attribute value will be used from the workspace instead of defining a fixed value in the AllApps and Folders XML. The class was updated to be a data class and added a auxiliar constructor new make it more flexible for testing and to add other initializers to support AllApps and Folders.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: WorkspaceSpecsTest
Test: SizeSpecTest
Change-Id: I65b71e66be7b8236a1dee62b56a487b87881d991
2023-06-09 17:05:22 +00:00
Vadim Tryshev
6d31bf9368 Merge "Adding a rule for analyzing view capture data" into udc-qpr-dev 2023-06-09 00:13:38 +00:00
Schneider Victor-tulias
cc390e0737 Merge "Debug MemoryTests activity count" into udc-dev am: 56c5189c3c am: a4e8ceaf31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23540634

Change-Id: Ie1944a098120e6355136d3fda756a09eccf0ddf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 22:36:03 +00:00
Schneider Victor-tulias
7a42f25401 Debug MemoryTests activity count
Flag: not needed
Bug: 260260325
Test: MemoryTests
Change-Id: Iabb1dfc6d474066d8facea09e1948a571b1fe623
2023-06-08 17:11:59 +00:00
Thales Lima
0bd7a37971 Correct AllApps horizontal padding
There was one extra border space being added to handheld, which makes AllApps and Workspace icons to not align.

Fix: 284151671
Test: DeviceProfileDumpTest
Test: HomeScreenAllAppsImageTest
Test: DeviceProfileResponsiveDumpTest
Test: HomeScreenAllAppsImageTest
Flag: N/A
Change-Id: I6e4a0d93336a3c59db2a25805d90adfaf7a231cf
2023-06-08 12:09:24 +01:00
vadimt
de54cb8fa5 Adding a rule for analyzing view capture data
For now, the rule is basically empty, to start with. In the following CLs it will
invoke the search for anomalies in the data collected by ViewCaptureRule
after the test succeeds and fail the test if an anomaly is found.

Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I373ea0d7ee85206101fb15584889ea5933e7d7b8
2023-06-07 17:39:54 -07:00
Sunny Goyal
7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
TreeHugger Robot
859d0d87e2 Merge "Simplifying some test utility methods" into udc-qpr-dev 2023-06-05 23:10:06 +00:00
Sunny Goyal
6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
TreeHugger Robot
3b7285f61c Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev am: 4ad5ffd0a1 am: ef529447b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537958

Change-Id: I774fa87ee58d684ab27114a68354ffd42538077c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 20:26:50 +00:00
TreeHugger Robot
4ad5ffd0a1 Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev 2023-06-02 18:59:47 +00:00
Vadim Tryshev
d8b470cf2f Revert "Adding tracing for workspace loading that never finishes"
This reverts commit 80bb8a12da.

Reason for revert: Cleanup after the bug is fixed. Tracing is not necessary anymore.

Change-Id: I1bb2bc59dd5debb51b094f14430cd18a203ed33c
2023-06-02 15:28:18 +00:00
Sunny Goyal
ee9740462e Simplifying some test utility methods
Bug: 283821111
Test: Presubmit
Flag: N/A
Change-Id: I7b9690bc0cc53d097d26cd4f0ab2dd36ba88e1cb
2023-06-02 13:30:55 +00:00
Santiago Aboy Solanes
0edac04688 Merge "Revert "Adding main thread binder tracing in development build."" into udc-qpr-dev 2023-06-02 09:06:26 +00:00
Santiago Aboy Solanes
ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Anushree Ganjam
87cb7ad06a Merge "Add UID in AppInfo." into udc-dev am: 9b4f62e681 am: eb9cd7e26e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23331302

Change-Id: I2bfbbf5fd5ec777baca79d89c13204857e600f8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 01:46:38 +00:00
Anushree Ganjam
9b4f62e681 Merge "Add UID in AppInfo." into udc-dev 2023-06-02 01:17:29 +00:00
Anushree Ganjam
97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Sunny Goyal
cbb13841f5 Merge "Revert "Add hover state border line to overview task item by usi..."" into udc-qpr-dev 2023-06-01 21:39:15 +00:00
Sunny Goyal
8dbdd3d702 Revert "Add hover state border line to overview task item by usi..."
Revert submission 23378417-cherrypick-overview-border-249859410-786docmioso

Reason for revert: flaky implementation

Reverted changes: /q/submissionid:23378417-cherrypick-overview-border-249859410-786docmioso

Change-Id: I6792fc25dbbd80db24df93ebd7a974b0dc0ba5d5
2023-06-01 21:29:13 +00:00
Sunny Goyal
50c9126cc3 Merge "Adding main thread binder tracing in development build." into udc-qpr-dev 2023-06-01 17:27:21 +00:00
Sunny Goyal
3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Helen Cheuk
ed4c2acf58 Merge "Add hover state border line to overview task item by using the same approach used by keyboard focus state" into udc-qpr-dev 2023-06-01 15:45:01 +00:00
Treehugger Robot
77b9c764b8 Merge "Removing memory object checks based on "dumpsys meminfo"" into udc-dev am: c0f24b4e7e am: 243011384c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23421682

Change-Id: I24e31426f5973cd04c6737ee452d45370a3acc80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 00:53:50 +00:00
Treehugger Robot
c0f24b4e7e Merge "Removing memory object checks based on "dumpsys meminfo"" into udc-dev 2023-05-31 23:11:53 +00:00
TreeHugger Robot
f95fca0f5d Merge "Insert a check that keyguard is invisible into waitForLauncherCondition" into udc-dev am: db7009544e am: 03d0cd83a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23441208

Change-Id: Ib4549e9712251a6c9eb85dfb5229d2d7addc4482
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 21:26:42 +00:00
TreeHugger Robot
db7009544e Merge "Insert a check that keyguard is invisible into waitForLauncherCondition" into udc-dev 2023-05-31 20:00:08 +00:00
helencheuk
64975ae992 Add hover state border line to overview task item by using the same approach used by keyboard focus state
Reviewed TAPL DD: https://docs.google.com/document/d/1OmCLgTDw3gFOMXjEvH0W1XoAe0n2J5pPdyMcAHtflMA/edit?resourcekey=0-bXle-rOnQqOR_RJBffRybQ
Fix: 249859410
Test: OverviewTaskImageTest

Change-Id: Ic9ce4e9fe90f38a4bf4be6c7deed302a12a3192a
2023-05-30 21:30:14 +01:00
Stefan Andonian
55d0d21040 Merge "Revert "Keep ViewCaptureRule logic self-contained."" into udc-dev am: 57eaf86f8d am: fc7e8fa4c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23454664

Change-Id: I0da767add8247c3530af0a26e965d6830018ef75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 19:02:56 +00:00
TreeHugger Robot
7ae39b1bee Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev am: 78b6e76486 am: dcf359c459
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23455279

Change-Id: I0409212df4be2e1554a6a489c65453d65e9e78c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 19:02:32 +00:00
Stefan Andonian
4439bec7aa Merge "Use LockedUserState in TouchInteractionService." into udc-qpr-dev 2023-05-30 18:55:02 +00:00
Stefan Andonian
57eaf86f8d Merge "Revert "Keep ViewCaptureRule logic self-contained."" into udc-dev 2023-05-30 17:49:54 +00:00
TreeHugger Robot
78b6e76486 Merge "Add logs to see if launcher model isn't loaded when work profile app is added" into udc-dev 2023-05-30 17:26:53 +00:00
Alex Chau
6565b68168 Merge "Add Portrait/Landscape support for NexusLauncher screenshot tests" into udc-qpr-dev 2023-05-30 15:54:10 +00:00
Vinit Nayak
2c353f29a2 Add logs to see if launcher model isn't loaded when work profile app is added
* Add helper method to avoid checking sDebugTracing when
logging for tests

Bug: 243688989
Flag: None
Change-Id: Id6cc3b286171eb598e593c5a8aaea6f2466aad60
2023-05-26 15:45:42 -07:00
Stefan Andonian
0a8fab01da Revert "Keep ViewCaptureRule logic self-contained."
This reverts commit eec7a9d90f.

Reason for revert: Failing tests.

Change-Id: Idf16453bbd7f0ace17d8e80d3303fae26b50333b
2023-05-26 21:11:41 +00:00
Stefan Andonian
cf36a3f3a8 Use LockedUserState in TouchInteractionService.
This change was previously attempted, but failed because of a tricky issue where the LockedUserState singleton object was getting permanently set to a mock context in LockedUserStateTest, and then was failing TaplTests because isUserUnlocked was always false.

This fixes that by avoiding using the singleton LockedUserState instance in the unit tests.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly. Post-submit was tested and this CL passed all previously
failing tests: https://android-build.googleplex.com/builds/abtd/run/L12900000960898179

Change-Id: I045c9f2558a6bdacb4bfa029fbf6a07c3c190fe7
2023-05-26 17:06:09 +00:00