Commit Graph

62052 Commits

Author SHA1 Message Date
Andrew Cole
eddc230d71 Turning back on flaky test
Because of a fix that has been merged here ag/23680187 this test should also be able to be turned on and not become flakey.

Bug: 256615483
Test: testUninstallFromWorkspace
Change-Id: I7096f5e9392ddedf1c4c2ab23b922b352bb5d7b1
2023-06-15 08:12:28 -07:00
Anushree Ganjam
1f85e98181 Merge "Adding OVERVIEW entry state for Rocket Gesture." into udc-qpr-dev 2023-06-14 17:45:15 +00:00
Thales Lima
961e683187 Merge "Create AllApps responsive spec" into udc-qpr-dev 2023-06-14 17:09:20 +00:00
Thales Lima
981bca7355 Merge "Migrate DeviceProfile dump tests to files" into udc-qpr-dev 2023-06-14 17:07:52 +00:00
Andrew Cole
ee1e3b3686 Merge "Test Uninstall Flakiness" into udc-qpr-dev 2023-06-14 16:50:51 +00:00
Vinit Nayak
9ab1a4a835 Merge "Remove mFirstFloatingTaskView from recents view" into udc-qpr-dev 2023-06-14 16:31:23 +00:00
Brandon Dayauon
383cc17a6f Merge "Fix custom buttons with translated string" into udc-qpr-dev 2023-06-14 16:13:48 +00:00
Thales Lima
196e44baec Create AllApps responsive spec
Copy the parser from WorkspaceSpec and modify to use AllApps attributes.

Bug: 284152932
Test: AllAppsSpecsTest
Test: CalculatedAllAppsSpecTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I9362e126c64cb1a1abdef61894b003f14701b8e3
2023-06-14 15:02:58 +01:00
Thales Lima
9cc14e3610 Migrate DeviceProfile dump tests to files
Using files makes it easier to update the changed properties.

Fix: 286049633
Test: DeviceProfileDumpTest
Flag: N/A
Change-Id: I5f51a99c1bb1688c59466282c836ef30466ae53d
2023-06-14 11:03:27 +01:00
Jordan Silva
296a9f3389 Merge "Update SizeSpec attributes to accept max size threshold" into udc-qpr-dev 2023-06-14 09:37:42 +00:00
Anushree Ganjam
959d2f73c4 Adding OVERVIEW entry state for Rocket Gesture.
Bug: 276820117
Test: NA
Flag: NA
Change-Id: Ibc9062ab0137a554600d278a18fe1243facd3d8a
2023-06-14 01:27:09 +00:00
Sihua Ma
d655e07dcc Merge "Fix widget foreground disappearing when swiping back" into udc-qpr-dev 2023-06-14 00:03:34 +00:00
Sebastián Franco
29a13676f4 Merge "Remove flags ENABLE_TWO_PANEL_HOME FOLDABLE_WORKSPACE_REORDE and FOLDABLE_SINGLE_PAGE" into udc-qpr-dev 2023-06-13 23:08:40 +00:00
Andrew Cole
b9b75281b1 Test Uninstall Flakiness
Fixing a flake in a e2e test that is occuring in testUninstallFromAllApps. The offending test was not always waiting for the platform to uninstall the app, which would remove the app from AllApps.

Bug: 258071914
Test: testUninstallFromAllApps
Change-Id: I38d162ba09f38feca49a96fa126db7ffc22ce935
2023-06-13 15:02:24 -07:00
Treehugger Robot
74a27fb3de Merge "Making UserCache the source of truth for all user events" into udc-qpr-dev 2023-06-13 21:55:40 +00:00
TreeHugger Robot
0a13b2de85 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-06-13 19:58:54 +00:00
TreeHugger Robot
5e93596e19 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-06-13 19:58:54 +00:00
Vinit Nayak
62a9635970 Remove mFirstFloatingTaskView from recents view
* Part of effort to slowly migrate split state out
of RecentsView and into SplitSelectStateController

Test: Existing split flows work
Bug: 276361926
Change-Id: I099a59cf4820b4b2e4af94b59c464158c5e62806
2023-06-13 12:04:53 -07:00
Brian Isganitis
cca18d8028 Merge "Support zero-state suggestions in Taskbar All Apps." into udc-qpr-dev 2023-06-13 18:26:36 +00:00
Jordan Silva
1b336110a4 Update SizeSpec attributes to accept max size threshold
Add maxSize attribute to SizeSpec to limit the cell size up to a max size when matchWorkspace is true. The same validation was added when using fixedSize, ofAvailableSpace and ofRemainderSpace, so they could have a maxSize as a threshold.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: SizeSpecTest
Test: WorkspaceSpecsTest
Change-Id: I113657c241e6618eb3e501243412d8c5626fc3d5
2023-06-13 18:09:37 +01:00
Jordan Silva
b1dc7718be Merge "Add FolderSpec for responsive grid support" into udc-qpr-dev 2023-06-13 15:41:49 +00:00
Jordan Silva
7ae9e3a6f5 Add FolderSpec for responsive grid support
Adds responsive grid implementation for folders. It follows the same concept as WorkspaceSpecs, so we have a parser similar to WorkspaceSpecs for FolderSpecs.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: FolderSpecsTest
Test: CalculatedFolderSpecsTest
Change-Id: Iea6d7d88ef42d1273aed7cf2ed5b397035518a52
2023-06-13 15:01:39 +01:00
Schneider Victor-tulias
3b9c654669 Merge "Polish redesgined tutorial home and overview animations" into udc-qpr-dev 2023-06-13 13:47:21 +00:00
Thales Lima
eb83006b0b Merge "Correct AllApps horizontal padding" into udc-qpr-dev 2023-06-13 11:04:47 +00:00
Randy Pfohl
27e1e8eddc Merge "switching animation to screenshot to avoid visual jank" into udc-dev am: f5bec7dd30 am: c338164e7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23665476

Change-Id: Id99b6964e18cc7ec7daca9993ec2cffe5c8044b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:50:06 +00:00
Saumya Prakash
07ed097042 Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev am: cb5e2cfd3e am: 83301267f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23632910

Change-Id: I1f12a7dddfa9fd9efbd762fad142e87a2e5842e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:49:43 +00:00
Randy Pfohl
c338164e7e Merge "switching animation to screenshot to avoid visual jank" into udc-dev am: f5bec7dd30
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23665476

Change-Id: I2ec3b3fee1e8f385286ff674635bb41b549cb22e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:08:04 +00:00
Saumya Prakash
83301267f4 Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev am: cb5e2cfd3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23632910

Change-Id: Iad90f231e391346aa4a3ea691c455aad3752c012
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:07:39 +00:00
Randy Pfohl
f5bec7dd30 Merge "switching animation to screenshot to avoid visual jank" into udc-dev 2023-06-13 05:43:21 +00:00
Saumya Prakash
cb5e2cfd3e Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev 2023-06-13 05:38:01 +00:00
Saumya Prakash
afda61d92c Merge "Update the strings in the gesture nav tutorial" into udc-dev am: 0d87c4766e am: 87085d3b4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23659350

Change-Id: I7718af3e47d2d076e73812f277040dd89e01e3a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 05:25:55 +00:00
Saumya Prakash
87085d3b4a Merge "Update the strings in the gesture nav tutorial" into udc-dev am: 0d87c4766e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23659350

Change-Id: I07a3637ad58d6232d8de88802cc01906ec749c81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 04:44:00 +00:00
Saumya Prakash
0d87c4766e Merge "Update the strings in the gesture nav tutorial" into udc-dev 2023-06-13 03:39:38 +00:00
TreeHugger Robot
a9d2db38f5 Merge changes from topics "draglayer-inline-qsb", "draglayer-search" into udc-qpr-dev
* changes:
  Allow LauncherState to define floating search side margins.
  Put the "floating" in ENABLE_FLOATING_SEARCH_BAR.
2023-06-13 03:19:49 +00:00
randypfohl
d3cc664391 switching animation to screenshot to avoid visual jank
Test: built locally, recorded, and slow replayed it to verify no jank/visual anomalies visible.

Bug: 245750127
Change-Id: If7e72512d3303222f4d006a9e2a1639b2f86b1af
2023-06-12 18:28:57 -07:00
Sebastian Franco
76a1ceb5f2 Remove flags ENABLE_TWO_PANEL_HOME FOLDABLE_WORKSPACE_REORDE and FOLDABLE_SINGLE_PAGE
Fix: 270392643
Fix: 270395070
Fix: 270395274
Test: atest FoldableItemsIntegrity
Change-Id: I2d7af312da8aeb070588ca94a2a256d2def65eeb
2023-06-12 18:05:22 -07:00
Andy Wickham
bd9a180fbc Allow LauncherState to define floating search side margins.
This lets home screen align to workspace icons while All Apps
aligns with those icons. In addition, on tablets where the QSB
is inlined with the hotseat, floating search bar can also move
horizontally accordingly.

Bug: 275635606
Bug: 259619990
Test: Manual on tablet as well as foldable.
Flag: ENABLE_FLOATING_SEARCH_BAR

Change-Id: I67745c66390736cdf39d969ef7767096ae13c671
2023-06-13 00:28:59 +00:00
Vadim Tryshev
167ff73108 Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev am: af641a6e80 am: 27e2251b7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23662872

Change-Id: I81d60e0d7d92267cadad309450a90ed39be0bc84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 23:07:01 +00:00
Vadim Tryshev
27e2251b7d Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev am: af641a6e80
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23662872

Change-Id: I7ba5c6153938ba208976c71d137ef025094ce909
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 22:23:06 +00:00
Andy Wickham
64896f3098 Put the "floating" in ENABLE_FLOATING_SEARCH_BAR.
This means adding the search view to the drag layer, so it can
persist and animate across Launcher states (i.e. Home, All Apps,
Overview, Overview from App).

Some high level things:
 - LauncherState now has a flag indicating if the floating
   search bar should be visible, as well as a method indicating
   how high it should rest when the keyboard is not showing. By
   default the height is set negative if the flag is not present,
   so the search bar will rest off screen in that state.
 - LauncherState also has a new method indicating if the search
   bar should show as a pill when not focused. Currently this is
   done in phone portrait mode in all apps and overview.
 - SearchUiManager now has a method for gestures to hint that
   the search bar will be focused or unfocused soon, e.g. for
   the app -> overview case, we hint that it will be focused
   when crossing the threshold, and unfocused if retracting.
   This allows the search bar to animate during the gesture
   and take or release focus after the state change completes.
 - AllAppsTransitionController lets the apps panel translate in
   from the bottom of the screen, for example when coming from
   an app and we don't want to pop it in halfway up the screen.
   Instead it can slide in gracefully from behind the keyboard
   and floating search bar.
 - KeyboardInsetAnimationCallback can now notify listeners of
   keyboard alpha changes during controlled animations. And
   StateAnimationConfig has a new animation type to control
   the keyboard alpha during the all apps transition.
 - This new ANIM_ALL_APPS_KEYBOARD_FADE is used to pop the
   keyboard in at the threshold for going from an app to all apps.
   Note that its position moves linearly before this, so the
   search bar starts moving up accordingly before the keyboard
   alpha is non-0.

Fix: 266761289
Fix: 268845147
Fix: 267683921
Fix: 265849321
Fix: 266446733
Fix: 269301440
Bug: 275635606
Bug: 259619990
Bug: 261866704
Test: Manual with all the state transitions on phone and tablet
(also folding/unfolding foldable).
Flag: ENABLE_FLOATING_SEARCH_BAR, ENABLE_ALL_APPS_FROM_OVERVIEW
(latter just for the background app interpolator changes).

Change-Id: I6f06552e95747348a62260279626cf407bf145b0
2023-06-12 21:55:24 +00:00
Vadim Tryshev
af641a6e80 Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev 2023-06-12 21:49:39 +00:00
Brandon Dayauon
076dcdfd54 Fix custom buttons with translated string
The reason why the buttons aren't being updated with the translated string is because the cache the views get the string from is not updated/loaded with the new language.
Rather, the update happens after the view has been inflated. With this change, when the string cache updates in bindStringCache(), we update the UI right then.

bug: 280958663
test: Manual
Change-Id: I7a49ee401d5a5f3268cfaef1abee8153e913a8ce
2023-06-12 14:33:08 -07:00
Saumya Prakash
b932cf4b64 Update the strings in the gesture nav tutorial
Change the strings for the instructions and feedback for the gesture navigation tutorial to align with new UX changes.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 286547594
Test: Manually went through the redesigned tutorial and verified that
the new strings correctly show up. Also checked that the previous
tutorial remains unchanged.

Change-Id: I27a3e8c0f09e7755e6087ce5b004b687f229d153
2023-06-12 21:26:43 +00:00
Schneider Victor-tulias
1c2c5a58a2 Polish redesgined tutorial home and overview animations
- Added a 6th hotseat icon to the tablet and unfolded foldable
- not animating the previous task view when animating to hotseat from the home step
- updating the first hotseat icon's color and visibility at the correct times
- cross fading the animating task view and hotseat icon's color

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 283967613
Test: ran the tutorial on handheld, tablet and foldable with ENABLE_NEW_GESTURE_NAV_TUTORIAL true and false
Change-Id: I7a76646ca71502e924f45bba76d72be17d31249d
2023-06-12 21:03:30 +00:00
Anushree Ganjam
405e79df8d [automerger skipped] Merge "Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED." into udc-d1-dev am: d9ee0fd054 -s ours
am skip reason: Merged-In I5374e7cab6551d44fc995adb3b3a46173169ab6c with SHA-1 caf2c0ffb0 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23636343

Change-Id: Icfc720c10035f4df08aa4fd6901aa86c2934785e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 18:31:43 +00:00
Anushree Ganjam
b04fb8f09b [automerger skipped] Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED. am: ab58a0a005 -s ours
am skip reason: Merged-In I5374e7cab6551d44fc995adb3b3a46173169ab6c with SHA-1 caf2c0ffb0 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23636343

Change-Id: Ia0d6739f75796e6bebdb8df5194c964af71be56f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 18:31:40 +00:00
Anushree Ganjam
d9ee0fd054 Merge "Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED." into udc-d1-dev 2023-06-12 18:20:58 +00:00
Brian Isganitis
4337083b40 Merge changes If4669756,Ide702745 into udc-dev am: 77a40999e1 am: d0e61e3eef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23603557

Change-Id: I6140b46469c6e4251819afdd124bc869bceeadac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 18:07:50 +00:00
Saumya Prakash
08a2708739 Scale the gesture tutorial animation to work on smaller devices
The lottie animations in the gesture navigation tutorial would get cut
off due to having to crop them to smaller devices. This change uses a
matrix to correctly scale the animation such that the aspect ratio is
maintained.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 283969417
Test: Went through the tutorial on devices of different sizes and aspect
ratios and ensured that the lottie animation isn't cut off.

Change-Id: I4b4cc9e11a68daef29fa31d6a89a1c9006041937
2023-06-12 17:55:00 +00:00
Vadim Tryshev
b5057c496a Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"
This reverts commit 1a2462914d.

Reason for revert: Likely culprit for b/286115393

Change-Id: I613ca9f62c5b9f43f2e3cd240e45bc1a0db0e661
2023-06-12 17:40:22 +00:00