Commit Graph

13825 Commits

Author SHA1 Message Date
Vinit Nayak
e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Vinit Nayak
f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham
4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brandon Dayauon
5ba5c76c76 Merge "fixed scalable grid allApps to match home screen icons in largest display size" into tm-dev 2022-05-26 16:06:02 +00:00
Alex Chau
56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
Abhilasha Chahal
d18c5085c5 Merge "Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView" into tm-dev 2022-05-25 18:31:59 +00:00
Alex Chau
179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau
a2ecf75082 Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau
158caf466c Only setup SecondaryDropTarget in onDragStart
- In LauncherAccessibilityDelegate.getsupportedActions, it calls supportsAccessibilityDrop on each button regardless if DropTargetBar is visible or not. SecondaryDropTarget.supportsAccessibilityDrop attempts to setupUi which causes measure/layout of DropTargetBar (as well as DragLayer) each time LauncherAccessibilityDelegate.getsupportedActions is called
- To avoid this, only setupUi in onDragStart. In other cases don't call setUi.
- Also fixed a bug that when accessibility is on, upon dragging a suggested app, the secondary action suddenly changed to Uninstall

Fix: 233383721
Test: Enable accessibility, observe no excessive amount of onLayout is called on DropTargetBar
Change-Id: I4d1a00d320cceed81fa1312b5fc5f1081637bea8
2022-05-25 11:04:42 +00:00
Alex Chau
e2e1509d55 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
Andy Wickham
2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Stefan Andonian
748195421c Merge "Change accessibility announcement for workspace from "Pixel Launcher" to "Home"." into tm-dev 2022-05-24 22:47:50 +00:00
TreeHugger Robot
69149d07ff Merge "Fixing ConcurrentModificationException in FirstScreenBroadcast" into tm-dev 2022-05-24 19:52:32 +00:00
Stefan Andonian
45fc301b0e Change accessibility announcement for workspace from "Pixel Launcher" to "Home".
Bug: 228410736
Test: Verified correct talkback announcements.
Change-Id: Ic0a5295cde3cd23d2fc5a6fcd19b6cf8e0f3e386
(cherry picked from commit 83bc5f5050)
2022-05-24 18:21:33 +00:00
Sunny Goyal
f7a48aae65 Merge "Adding support for customiting the animation in PropertySetter" into tm-dev 2022-05-24 18:21:24 +00:00
Stefan Andonian
af8b7d3313 Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev 2022-05-24 18:19:03 +00:00
Brandon Dayauon
6bb327888e Merge "Fixes scroll bar issues." into tm-dev 2022-05-24 18:10:42 +00:00
Anushree Ganjam
223bfe0908 Merge "Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."" into tm-dev 2022-05-24 17:38:08 +00:00
Alex Chau
5b0193026a Center drop target button alignment across devices
- Partial re-land of http://ag/18520765

Fix: 229789612
Fix: 231711806
Test: manual
Change-Id: I0630c19901435a30379596378e9c0cd4beb2e764
2022-05-24 18:31:57 +01:00
TreeHugger Robot
ec3723beb1 Merge "Fix widget span" into tm-dev 2022-05-24 17:31:13 +00:00
Sunny Goyal
425bfa320f Fixing ConcurrentModificationException in FirstScreenBroadcast
Bug: 232333237
Test: Not sure, unable to reproduce
Change-Id: I3eeabf76c14651d2fb64c82955851efa883760ce
2022-05-24 09:17:39 -07:00
Brandon Dayauon
c472da1e5e Fixes scroll bar issues.
Fix issue where the letter bubble stays showing. Now it is able to disappear.
Fix fast scroll so its smoother and able to grab

Bug: 233607012
Bug: 233076260
Test: Manual
Change-Id: Ieccc72079602f4606da6ded7ee48d82440882ef7
2022-05-24 08:50:07 -07:00
Thales Lima
4f3cf5d05f Fix widget span
Need to take the horizontal margin of the view into consideration.

Fix: 233302799
Test: manual
Change-Id: I5f584977db85d5436b22c3701f586a5b079099ae
2022-05-24 14:49:26 +01:00
Anushree Ganjam
13b3922af9 Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."
Revert submission 18568158-revert-18500283-dismissEduCard-SCFTOPONPS

Reason for revert: b/233680944 , This is a build merger issue. 
Reverted Changes:
Ia39781c78:Revert "Add "incrementEventCountBy" function to On...
Ibba14f7c2:Revert "Save the value to sharedPreference When ed...

Change-Id: I1c0e4be10cf7e9b21623a056604618cbea2639d4
2022-05-24 02:19:57 +00:00
Cherry Ng
6a4ea4c849 Merge "Revert "Add "incrementEventCountBy" function to OnboardingPrefs."" into tm-dev 2022-05-24 02:16:40 +00:00
Anushree Ganjam
514979dd2d Revert "Add "incrementEventCountBy" function to OnboardingPrefs."
Revert submission 18500283-dismissEduCard

Reason for revert: Reverting because of build failures.
Reverted Changes:
I727cefb70:Save the value to sharedPreference When edu card i...
I180ab3bd6:Add "incrementEventCountBy" function to Onboarding...

Change-Id: Ia39781c78776a629d4678c78dd4ca75f49abbb6d
2022-05-24 00:44:55 +00:00
Anushree Ganjam
218703d5a9 Merge "Add "incrementEventCountBy" function to OnboardingPrefs." into tm-dev 2022-05-23 23:55:36 +00:00
Stefan Andonian
28f61b5177 Fix folder app icon truncation after rotating to landscape.
The folder bubble text views were being recycled after the launcher's
cache was cleared. This caused the new orientation's folders to re-use
the old views with their stale configuration. After this change, the
cache won't recycle views whose cache entry has been recreated,
implying that their environment might have changed and new setup is
required.

Bug: 230304658
Test: Verified erroneous UX on device was no longer reproducible after fix.
Change-Id: Ib01cf5792d83df752e05534e5aa08ab8e8763bdc
2022-05-23 23:42:04 +00:00
Abhilasha Chahal
23dd0006ad Merge "Add LAUNCHER_SYSTEM_SHORTCUT_APP_SHARE_TAP event" into tm-dev 2022-05-23 21:44:27 +00:00
Sunny Goyal
52bbef9d94 Adding support for customiting the animation in PropertySetter
Bug: 233223446
Test: Manual
Change-Id: I53fc39fa4871c9ea5b6eaf324ec1054140ccc292
2022-05-23 09:55:56 -07:00
Alex Chau
906d882f91 Update drop target button alignment across devices
- Partial re-land of http://ag/18520765
- Layout the buttons from center of screen for two panels, or from center of workspace for all other cases

Bug: 229789612
Fix: 231706480
Fix: 232063941
Fix: 232283628
Test: manual
Change-Id: Icbc9e2a19140ce3127d5dfe9f798a8ada336cea8
2022-05-23 15:08:52 +00:00
TreeHugger Robot
2940565595 Merge "Remove obsolete TODO for verifying all apps on 2nd display." into tm-dev 2022-05-20 18:49:33 +00:00
Pat Manning
b29dabce18 Revert "Update drop target button alignment across devices."
This reverts commit 27bfcaa651.

Reason for revert: b/232636570

Bug: 229789612
Bug: 231711806
Bug: 231706480
Bug: 232063941
Bug: 232283628
Change-Id: Ic83515173f4a64228a80f63d75db938243cbf625
2022-05-20 18:20:26 +00:00
Brandon Dayauon
969f6a8c4d fixed scalable grid allApps to match home screen icons in largest display size
fixed allApps Icon's text size to scale

Test: Pictures in bug thread
Bug: 232908037
Change-Id: I4b171e76c61d1fe913c23034b823f16668839f1b
2022-05-20 09:49:56 -07:00
Anushree Ganjam
0d345e5e04 Add "incrementEventCountBy" function to OnboardingPrefs.
This will help to increment the count by a value rather than just by 1.

Bug: 231659198
Test: Manual
Change-Id: I180ab3bd622df3bee2a6cb2b0cd8793e07a4f114
2022-05-19 23:07:06 +00:00
Brian Isganitis
b811a29b7d Remove obsolete TODO for verifying all apps on 2nd display.
It works \o/.

Test: No
Change-Id: I5b2c6c1b3bb656ad3d5bb21188ac9e9f8cdc0fec
2022-05-19 13:30:55 -07:00
Abhilasha Chahal
ee14d4761a Add LAUNCHER_SYSTEM_SHORTCUT_APP_SHARE_TAP event
Bug: 233224567
Test: Manually verified the event in logs
Change-Id: Ie81ca8774adb241f1c8635444dad884f34f3929d
2022-05-19 19:21:45 +00:00
Pat Manning
3c0f4c156d Bound drop target layout values to left and right.
Test: manual
Fix: 232636570
Bug: 233225825
Change-Id: I388cb3407cb9f887ccc222f4804636f9f7651884
2022-05-19 18:48:14 +01:00
Luca Zuccarini
175fc66aa8 Merge "Additional polish for the NORMAL<->ALL_APPS transitions." into tm-dev 2022-05-18 14:21:27 +00:00
Abhilasha Chahal
e2aca3e664 Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView
Test: Manually verified that the Floating view appears
Bug: 217360015
Change-Id: Id9edd3f9c2ef06ece4f541830c2080aeed11f1b1

Change-Id: I7f89a191ff55bcc03ec70c49aea659188083f0dd
2022-05-18 11:32:51 +00:00
Sunny Goyal
a292987030 Merge "Adding support for extending back behavior in Launcher" into tm-dev 2022-05-17 23:02:50 +00:00
Luca Zuccarini
3eb149b055 Merge "Update the NORMAL<->ALL_APPS swipe transitions on phones." into tm-dev 2022-05-17 16:06:27 +00:00
Vinit Nayak
cfdb076d12 Merge "Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar" into tm-dev 2022-05-17 13:56:51 +00:00
TreeHugger Robot
8eaf87e77b Merge "Log the reason why a WorkspaceItemInfo was removed" into tm-dev 2022-05-17 05:01:15 +00:00
Vinit Nayak
2cb5cb5d00 Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar
Bug: 205493938
Change-Id: I196bc52c1bec75b5442f3546f466799ba9c3831b
2022-05-16 21:38:28 -07:00
Brandon Dayauon
1460a6a0fb Merge "Fix issue when preference screen title won't change depending on the device.." into tm-dev 2022-05-16 22:47:17 +00:00
Sunny Goyal
3f2637faee Adding support for extending back behavior in Launcher
Bug: 231224820
Test: Manual
Change-Id: I9accc30c01dce5f6920b611cfeed9fa0584d2846
2022-05-16 14:40:19 -07:00
Pinyao Ting
6a41d56b50 Log the reason why a WorkspaceItemInfo was removed
In the past we've seen a WorkspaceItem disappeared from the workspace
but wasn't able to determine why it was removed. This CL includes the
reason why it was removed in the error log, which hopefully would help
us debugging similar issues in the future.

Bug: 231239260
Test: make
Change-Id: Iba3d57568c9b3e011a6b65b26f0d4170d42fe1a5
2022-05-16 20:17:47 +00:00
TreeHugger Robot
4608bd00dc Merge "Revert "Set mState = mCurrentStableState in onAnimationCancel()"" into tm-dev 2022-05-16 18:15:14 +00:00
Brandon Dayauon
303b4e8aae Fix issue when preference screen title won't change depending on the device..
previously it defaults to just "Search your phone"
Now it correctly displays Phone/Tablet

Before: https://screenshot.googleplex.com/3PJrsP9mGvwMr98
After: https://screenshot.googleplex.com/B2nnUQHeHmEXXPd

Bug: 231611501
Change-Id: I49eab7e827ce4bb31a2722fbf21c244f98145907
2022-05-16 10:25:12 -07:00