Commit Graph

47142 Commits

Author SHA1 Message Date
Vinit Nayak
e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Vinit Nayak
f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham
4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brandon Dayauon
5ba5c76c76 Merge "fixed scalable grid allApps to match home screen icons in largest display size" into tm-dev 2022-05-26 16:06:02 +00:00
Alex Chau
56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
TreeHugger Robot
c907fd0a17 Merge "Allows work apps to be dragged down while work edu is showing." into tm-dev 2022-05-26 00:06:08 +00:00
Sunny Goyal
279911fafc Merge "Creating the transaction on the UI thread" into tm-dev 2022-05-25 22:24:04 +00:00
Andy Wickham
ff3721fe96 Allows work apps to be dragged down while work edu is showing.
Also fixes jumpiness of the personal/work tabs while scrolling
with this card showing.

Cause: AllAppsRecyclerView#getCurrentScrollY() calculates the
current scroll based on the top of the first item in the view.
This is used to determine if pulling down should move the
container (if you are scrolled to the top), and it is also used
to align the personal/work tabs as you scroll down (they stop
moving when the top item reaches their bottom).

Fix: The top of the Work Edu card was lower than the top of the
recycler view because it was offset by a top margin. Switching
this to padding in the card's container fixes the associated
calculations while keeping the visual positioning from before.

Fix: 233836148
Test: Manually tried dragging down and scrolling. Tried it with
and without my refactor.

Change-Id: Idaf4b3801174c1dfeceda5c0f112e405908e856d
2022-05-25 14:55:39 -07:00
Schneider Victor-tulias
467f30dbb7 Merge "Add screen recording to drag to splitscreen taskbar tests to help with debugging." into tm-dev 2022-05-25 21:03:04 +00:00
TreeHugger Robot
9557b10c59 Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev 2022-05-25 18:48:17 +00:00
Bill Yi
06d2238892 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-05-25 18:43:37 +00:00
Bill Yi
e965dfe6eb Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-05-25 18:43:37 +00:00
Abhilasha Chahal
d18c5085c5 Merge "Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView" into tm-dev 2022-05-25 18:31:59 +00:00
Schneider Victor-tulias
3efef1ce5a Attempt to preload the Launcher activity when the user reaches the All Set Page.
Preloading the Launcher activity once the user reaches the SUW All Set app allows for a smoother first reveal transition. Refactored TIS and TISBinder to make this possible.

Fixes: 226726244
Test: factory reset and flashed a build onto a pixel 6 pro
Change-Id: I1be3383bafdde17b951329de4c7d6b87affd210c
2022-05-25 10:02:20 -07:00
Alex Chau
179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau
a2ecf75082 Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau
158caf466c Only setup SecondaryDropTarget in onDragStart
- In LauncherAccessibilityDelegate.getsupportedActions, it calls supportsAccessibilityDrop on each button regardless if DropTargetBar is visible or not. SecondaryDropTarget.supportsAccessibilityDrop attempts to setupUi which causes measure/layout of DropTargetBar (as well as DragLayer) each time LauncherAccessibilityDelegate.getsupportedActions is called
- To avoid this, only setupUi in onDragStart. In other cases don't call setUi.
- Also fixed a bug that when accessibility is on, upon dragging a suggested app, the secondary action suddenly changed to Uninstall

Fix: 233383721
Test: Enable accessibility, observe no excessive amount of onLayout is called on DropTargetBar
Change-Id: I4d1a00d320cceed81fa1312b5fc5f1081637bea8
2022-05-25 11:04:42 +00:00
Alex Chau
e2e1509d55 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
Sunny Goyal
cdc111a158 Creating the transaction on the UI thread
This avoids the error when the transaction is created after
the surface is released. In case the surface is released after
transaction object is created, the apply() call simply ignores
that error, whereas previously the transactionCreation will throw
an error

Bug: 231889963
Test: Verified by manually releasing the surface that there is no crash
Change-Id: I9a4b9ca0be2ed687b2fc692570415256e3e479f7
2022-05-24 17:14:44 -07:00
Andy Wickham
2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Stefan Andonian
748195421c Merge "Change accessibility announcement for workspace from "Pixel Launcher" to "Home"." into tm-dev 2022-05-24 22:47:50 +00:00
Bill Yi
16026ae9f9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1d33db6f290ae068d29aea6a405cd0436c3d5341
2022-05-24 14:51:03 -07:00
Bill Yi
dbaeaa5c05 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8dab647a81e5f333a8c4d9ad5dbe13247429f7c1
2022-05-24 14:49:54 -07:00
Sunny Goyal
689b000316 Merge "Avoiding updating task via scroll if RectF spring animation is running" into tm-dev 2022-05-24 21:13:00 +00:00
TreeHugger Robot
69149d07ff Merge "Fixing ConcurrentModificationException in FirstScreenBroadcast" into tm-dev 2022-05-24 19:52:32 +00:00
Schneider Victor-tulias
aa5ae621c5 Add screen recording to drag to splitscreen taskbar tests to help with debugging.
Test: presubmit and local
Bug: 231615831
Change-Id: I87ea5eb30eaf9ec1f4f96572c78bc9daf976a589
2022-05-24 11:46:31 -07:00
Stefan Andonian
45fc301b0e Change accessibility announcement for workspace from "Pixel Launcher" to "Home".
Bug: 228410736
Test: Verified correct talkback announcements.
Change-Id: Ic0a5295cde3cd23d2fc5a6fcd19b6cf8e0f3e386
(cherry picked from commit 83bc5f5050)
2022-05-24 18:21:33 +00:00
Sunny Goyal
f7a48aae65 Merge "Adding support for customiting the animation in PropertySetter" into tm-dev 2022-05-24 18:21:24 +00:00
Stefan Andonian
af8b7d3313 Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev 2022-05-24 18:19:03 +00:00
Brandon Dayauon
6bb327888e Merge "Fixes scroll bar issues." into tm-dev 2022-05-24 18:10:42 +00:00
Anushree Ganjam
223bfe0908 Merge "Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."" into tm-dev 2022-05-24 17:38:08 +00:00
Alex Chau
5b0193026a Center drop target button alignment across devices
- Partial re-land of http://ag/18520765

Fix: 229789612
Fix: 231711806
Test: manual
Change-Id: I0630c19901435a30379596378e9c0cd4beb2e764
2022-05-24 18:31:57 +01:00
TreeHugger Robot
ec3723beb1 Merge "Fix widget span" into tm-dev 2022-05-24 17:31:13 +00:00
Sunny Goyal
425bfa320f Fixing ConcurrentModificationException in FirstScreenBroadcast
Bug: 232333237
Test: Not sure, unable to reproduce
Change-Id: I3eeabf76c14651d2fb64c82955851efa883760ce
2022-05-24 09:17:39 -07:00
Brandon Dayauon
c472da1e5e Fixes scroll bar issues.
Fix issue where the letter bubble stays showing. Now it is able to disappear.
Fix fast scroll so its smoother and able to grab

Bug: 233607012
Bug: 233076260
Test: Manual
Change-Id: Ieccc72079602f4606da6ded7ee48d82440882ef7
2022-05-24 08:50:07 -07:00
Thales Lima
4f3cf5d05f Fix widget span
Need to take the horizontal margin of the view into consideration.

Fix: 233302799
Test: manual
Change-Id: I5f584977db85d5436b22c3701f586a5b079099ae
2022-05-24 14:49:26 +01:00
Anushree Ganjam
13b3922af9 Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."
Revert submission 18568158-revert-18500283-dismissEduCard-SCFTOPONPS

Reason for revert: b/233680944 , This is a build merger issue. 
Reverted Changes:
Ia39781c78:Revert "Add "incrementEventCountBy" function to On...
Ibba14f7c2:Revert "Save the value to sharedPreference When ed...

Change-Id: I1c0e4be10cf7e9b21623a056604618cbea2639d4
2022-05-24 02:19:57 +00:00
Cherry Ng
6a4ea4c849 Merge "Revert "Add "incrementEventCountBy" function to OnboardingPrefs."" into tm-dev 2022-05-24 02:16:40 +00:00
Anushree Ganjam
514979dd2d Revert "Add "incrementEventCountBy" function to OnboardingPrefs."
Revert submission 18500283-dismissEduCard

Reason for revert: Reverting because of build failures.
Reverted Changes:
I727cefb70:Save the value to sharedPreference When edu card i...
I180ab3bd6:Add "incrementEventCountBy" function to Onboarding...

Change-Id: Ia39781c78776a629d4678c78dd4ca75f49abbb6d
2022-05-24 00:44:55 +00:00
TreeHugger Robot
6112a28b0b Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-dev 2022-05-24 00:38:21 +00:00
Anushree Ganjam
218703d5a9 Merge "Add "incrementEventCountBy" function to OnboardingPrefs." into tm-dev 2022-05-23 23:55:36 +00:00
Stefan Andonian
28f61b5177 Fix folder app icon truncation after rotating to landscape.
The folder bubble text views were being recycled after the launcher's
cache was cleared. This caused the new orientation's folders to re-use
the old views with their stale configuration. After this change, the
cache won't recycle views whose cache entry has been recreated,
implying that their environment might have changed and new setup is
required.

Bug: 230304658
Test: Verified erroneous UX on device was no longer reproducible after fix.
Change-Id: Ib01cf5792d83df752e05534e5aa08ab8e8763bdc
2022-05-23 23:42:04 +00:00
Abhilasha Chahal
23dd0006ad Merge "Add LAUNCHER_SYSTEM_SHORTCUT_APP_SHARE_TAP event" into tm-dev 2022-05-23 21:44:27 +00:00
Bill Yi
ab218eccd7 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: fbe7a74f05 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18515745

Change-Id: I2d8db2635a6d24525589225564381df583c61441
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-23 19:30:01 +00:00
Alex Chau
618047355d Merge "Update drop target button alignment across devices" into tm-dev 2022-05-23 18:49:55 +00:00
Brandon Dayauon
3e4d9c79d5 Merge "Label is no longer Unlabeled. Now says "closed"" into tm-dev 2022-05-23 18:21:26 +00:00
Sunny Goyal
617f9fae3d Avoiding updating task via scroll if RectF spring animation is running
Bug: 231333965
Test: Verified no update at the end of home transition
Change-Id: I2a106f4d7661f9d409425ce2ed755e74e1abe14b
2022-05-23 10:13:10 -07:00
Sunny Goyal
52bbef9d94 Adding support for customiting the animation in PropertySetter
Bug: 233223446
Test: Manual
Change-Id: I53fc39fa4871c9ea5b6eaf324ec1054140ccc292
2022-05-23 09:55:56 -07:00
Alex Chau
906d882f91 Update drop target button alignment across devices
- Partial re-land of http://ag/18520765
- Layout the buttons from center of screen for two panels, or from center of workspace for all other cases

Bug: 229789612
Fix: 231706480
Fix: 232063941
Fix: 232283628
Test: manual
Change-Id: Icbc9e2a19140ce3127d5dfe9f798a8ada336cea8
2022-05-23 15:08:52 +00:00
TreeHugger Robot
2940565595 Merge "Remove obsolete TODO for verifying all apps on 2nd display." into tm-dev 2022-05-20 18:49:33 +00:00