Commit Graph

6667 Commits

Author SHA1 Message Date
Holly Sun
dbd01bf6f9 Log a-z apps count.
Test: manual
Bug: 247432075
Change-Id: I9538a75bc3cb3d1e8e9089fc5e27d5d770cafb62
2022-10-18 15:57:53 -07:00
Vinit Nayak
44e788a9d3 Merge "Prevent restoring split selection state for fallback overview" into tm-qpr-dev 2022-10-18 18:50:19 +00:00
Sunny Goyal
dd11f089cc Revert "Revert "Using Transaction directly instead of building s..."
Revert^2 "Removing unused surface transaction wrappers"

2460910c8c454bc2d3c9ae35bd32eeb590851788

Bug: 221961069
Test: Presubmit
Change-Id: I0028c9fe0de6fde6a77de84e4858fda14cd578dd
2022-10-18 16:30:26 +00:00
Alex Chau
950a10738b Fix STATE_DEPTH stuck at 1 after setting wallpaper
- Made BaseDepthController.setDepth/mDepth private, all get/set should be done through STATE_DEPTH or WIDGET_DEPTH
- Generified ClampedDepthProperty into Utilities.ClampedProperty to apply on STATE_DEPTH

Bug: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: I53cdedf970fd7ffba6a952c4edf4b34251b01f07
2022-10-18 17:07:17 +01:00
Thales Lima
e9d4044483 Remove KtR workaround
Bug: 229947409
Test: m -j128 Launcher3QuickStep Launcher3QuickStepGo Launcher3 Launcher3Go NexusLauncherRelease NexusLauncherDebug SearchLauncherQuickStep SearchLauncher LauncherGoGoogle
Change-Id: I5792cc6b30dfa856747a1576ef3cb195952c25c7
(cherry picked from commit 51e164688e)
Merged-In: I5792cc6b30dfa856747a1576ef3cb195952c25c7
2022-10-18 13:06:23 +00:00
Vinit Nayak
392f8878cd Prevent restoring split selection state for fallback overview
* Add flag to explicitly not restore
OVERVIEW_SPLIT_SELECT
* FallbackRecentsView then resets state in
RecentsView if our endState is ever not split selection

Fixes: 253178217
Test: Used launcher developer option to
force use separate recents activity. Tested w/
3 button nav + gesture.

Change-Id: I26c9994bf853e9a005300a02aa143991958fc461
2022-10-17 17:52:16 -07:00
Vinit Nayak
d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Schneider Victor-tulias
e738336001 Fix missing screenshots on rotate from recents view select state
Rotating while in the recents view select state causes all taskview screenshots to disappear. Removing the transition to overview also fixes this, but leaves launcher in an incorrect state.

- Updated API to allow transitioning states without animation.
- Removed the animation to update the state correctly while keeping the ui working.

Fixes: 251067808
Test: rotated back and forth on large and small devices, before and after entering select mode
Change-Id: I5bf89ceb1f6b27cde9f7638f32fee3a78ad85ff6
2022-10-17 09:56:03 -07:00
Pat Manning
5889bc3729 Add launcher metrics for tracking kids nav mode change events.
Fix: 241762670
Test: wwdebug && wwlogcat
Change-Id: I24432f2cd0dddbcc5991645b60a1a8e91dc431e5
2022-10-17 14:06:38 +01:00
Brian Isganitis
2d6371aa34 Implement overlay window for Taskbar EDU and All Apps.
Having EDU in the same window as Taskbar causes it to be above All Apps
and other system views such as the notification tray. This change
refactors the existing All Apps window to accomodate more AFVs so that
EDU can also exist in it.

Demo: http://shortn/_Qcki3gwvf7

Test: Manual
Fix: 232177330
Change-Id: I1bef31d798041a90a0c3e033e71be63898fa5fbc
2022-10-14 22:36:14 +00:00
Sebastián Franco
73b8ee9390 Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev 2022-10-14 20:43:34 +00:00
TreeHugger Robot
6ccf536f94 Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-14 18:42:05 +00:00
Alex Chau
47a07bc704 Decouple taskbar background from overveiw scrim if taskbar is in overview
- Removed all forceHideBackground calls if taskbar would be in overview
- Make overview scrim transparent regardless of stash state if taskbar would be in overview

Fix: 234139692
Test: Go to overview from app with ENABLE_TASKBAR_IN_OVERVIEW on/off and taskbar stashed/unstashed
Change-Id: I29e811cb93894e6c9e7a75c0ea493719f15eeccb
2022-10-14 17:45:41 +01:00
Pat Manning
31cf44c48c Add launcher metrics for tracking kids nav mode change events.
Bug: 241762670
Test: wwdebug && wwlogcat
Change-Id: I5bf05ce1660078951896e0e331bbe74f8f2ebc5f
2022-10-14 16:24:32 +00:00
TreeHugger Robot
a1734ad12e Merge "Update taskbar state when launcher pauses" into tm-qpr-dev 2022-10-14 03:23:40 +00:00
Alex Chau
41ab3f3e14 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev 2022-10-14 00:31:32 +00:00
Evan Rosky
14145d131a Update taskbar state when launcher pauses
With shell-transit, we need to defer updating state when resumed
(until we commit a transient launch state); however, for pause
this isn't necessary. In fact, now that taskbar exists in overview,
we must update state on-pause since the taskbar is no-longer
already-closed.

Bug: 253473765
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep#testOverview
Change-Id: I347da03a211f5b2685f7b18666b2ebb93a1731ef
2022-10-14 00:11:25 +00:00
Nicolò Mazzucato
4afab0b210 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev 2022-10-13 23:06:50 +00:00
Vinit Nayak
0f6526e0c4 Improve TaskMenuView layouts for split pairs
* Instead of basing calculations on the TaskView view,
use the TaskThumbnailView as the anchor.
This helps us prevent having to re-calculate positions
that were already done to layout the thumbnails
* TODO: Gracefully handle re-positioning task menu view
on rotation

Bug: 249693334
Test: Manual, opening task menu view in
land/seascape in portrait, w/ and w/o home rotation

Change-Id: I02da96d2735657d5340e23056de69392ff8452c4
2022-10-13 14:15:14 -07:00
Alex Chau
e966537123 Merge "Only support manual stashing while in app" into tm-qpr-dev 2022-10-13 13:48:46 +00:00
Nicolo' Mazzucato
74c3a0024b Cancel unfold animation when rotation changes
In DeviceFoldStateProvider.kt, FOLD_UPDATE_FINISH_HALF_OPEN is emitted if the rotation changes while the animation is in progress.

 This targets the case when the device goes to tabletop mode during the transition.

+ Using RotationChangeProvider to fix problems when the new orientation change was received in a background thread unexpectedly. This fixes: (1) wrong launcher icons movement after the rotation, and (2) wrong dark overlay scrim after rotation.

+ Minor formattig fixes by ktfmt

Bug: 241743859
Test: DeviceFoldStateProviderTest && NaturalRotationUnfoldProgressProviderTest && manual stress testing
Change-Id: Iee234e4b832cad8298b69356fce7c14d75e89ccc
2022-10-13 09:16:44 +00:00
TreeHugger Robot
24dd3f57b2 Merge "Desktop tile that is a snapshot of desktop" into tm-qpr-dev 2022-10-12 21:10:16 +00:00
Alex Chau
38dae63910 Only support manual stashing while in app
- For taskbar in overview, don't allow stashing

Fix: 253042515
Test: With taskbar in overview, long press do nothing. Taskbar is still stashable in app
Test: Without taskbar in overview, taskbar still transform to nav handle in overview
Change-Id: I8f353a473a8570df72acda2338c4b984a69dc5c0
2022-10-12 18:16:50 +01:00
Sebastian Franco
d468299c0f Moving the class LayoutParams to a file outside CellLayout
I'm moving the LayoutParams to another file to start the decoupling
of the Reorder outside of the CellLayout.

Also, I change the name from LayoutParams to LauncherLayoutParams to prevent confusion with ViewGroup.LayoutParams making it explicit that this are different LayoutParams.

Bug: 188081026
Test: atest ReorderWidget
Change-Id: I92251c5540ffcf5ece7b933e6f6c836eb825c997
2022-10-12 16:14:42 +00:00
Pat Manning
a283b551d2 Merge "Use wm shell splash screen animation to reveal app after tasks have appeared." into tm-qpr-dev 2022-10-12 11:34:41 +00:00
TreeHugger Robot
5c4b6b50d7 Merge "First pass at Taskbar layout UI polish for SUW" into tm-qpr-dev 2022-10-12 02:27:37 +00:00
TreeHugger Robot
1337b31b3f Merge "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly." into tm-qpr-dev 2022-10-12 00:17:33 +00:00
Vinit Nayak
2081742cb7 First pass at Taskbar layout UI polish for SUW
Bug: 231906478
Change-Id: I5d55d1e33f928d4b8034c356565a0f9d8bc5c3fb
2022-10-12 00:04:27 +00:00
Schneider Victor-tulias
a0be92c830 Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly.
Bug: 244593270
Test: Manually checked logs
Change-Id: Ie6d0395a45a025d1562a722154d3dd3b42618ccc
2022-10-11 15:12:13 -07:00
Alex Chau
e2791f0cf6 Merge "Fix positioning of split instruction and share targets with taskbar in overview" into tm-qpr-dev 2022-10-11 14:04:57 +00:00
Alex Chau
0733ebd3c1 Run setCurrentPage in applyLoadPlan after scroll initialized
- Also combined the 2 setCurrentPage call in applyLoadPlan into 1
- Otherwise setCurrentTask may set to page 1 unexpectedly due to page 0's scroll being invalid and out of range

Bug: 246283207
Bug: 238461210
Test: Split screen with 2 apps, click back, go to overview again, should snap to focsued task
Change-Id: I3b57655c810668fe244659437fbd4a745ca02d21
2022-10-11 12:36:35 +01:00
Ats Jenk
3c59d9b345 Desktop tile that is a snapshot of desktop
Create a desktop recents tile that shows a snapshot of the freeform
tasks running on desktop.
Scales them down and positions them in the same location as they would
be on the desktop.

Bug: 244348395
Test: manual
Change-Id: Ieb5830a331691844769003189f557c4b7e4cd35c
2022-10-10 15:50:31 -07:00
Alex Chau
86924eed57 Merge "Fix taskbar in overview touch and stash behavior" into tm-qpr-dev 2022-10-10 10:02:12 +00:00
Alex Chau
8949c583ee Fix positioning of split instruction and share targets with taskbar in overview
- When taskbar is in overview, overview actions has dedicated space and no need to align to nav buttons
- Add a bottom margin to split instruction and share targetse that is equal to the space below overview actions

Bug: 245320601
Test: Test split select and share target with different screen sizes
Change-Id: I6aec325da9cc4c43c84ba8bed5f0e087c57d6925
2022-10-08 10:15:58 +01:00
Winson Chung
0c1dfbc1d8 Merge "Update constants used for resolving shell services" into tm-qpr-dev 2022-10-07 16:55:55 +00:00
Alex Chau
b7b88b66bb Merge "Add logging to help debug flake when swiping home to overview." into tm-qpr-dev 2022-10-07 11:24:43 +00:00
Jeremy Sim
65d95a8dae Merge "Use correct interpolator for tablet split confirm" into tm-qpr-dev 2022-10-07 08:20:58 +00:00
Jeremy Sim
15bab334cc Merge "Fix bug with DWB banners causing Action Bar to vanish" into tm-qpr-dev 2022-10-07 08:20:16 +00:00
Jerry Chang
21373a8521 Merge "Support starts a pair of intent/shortcut and task to split" into tm-qpr-dev 2022-10-07 04:33:32 +00:00
Jerry Chang
6aca959b5b Merge "Remove stage concept from split screen APIs" into tm-qpr-dev 2022-10-07 04:32:29 +00:00
Jeremy Sim
696fbd66bd Fix bug with DWB banners causing Action Bar to vanish
This patch fixes a bug where entering Overview with 3+ DWB banners active would cause the Actions Bar to disappear, rendering it unusable.

The bug occurred because while the Actions Bar was animating itself in, the entry animation of the DWB banners caused a competing animation to be fired, which attempted to set the Actions Bar alpha back to 0 in a race-conditiony situation.

Fixed by using setAutoCancel() on the Actions View alpha animator, which auto-cancels a running animation when another animation is called on the same target, preventing race conditions.

Outstanding issue: 251277899
Fixes: 241163178
Test: Manual

Change-Id: I4edb5678b4aad5612cd5ef58141d8e22bf8587f0
2022-10-06 17:01:47 -07:00
Jeremy Sim
a1d24cb85e Use correct interpolator for tablet split confirm
This patch makes it so that the split-to-confirm animation on tablets uses the EMPHASIZED interpolator instead of the (incorrect) LINEAR interpolator.

Fixes: 241126570
Test: Manual
Change-Id: Ic3c91d439a79a492da7f32bdcd56b954edf6c947
2022-10-06 16:23:20 -07:00
Winson Chung
73ab56a355 Update constants used for resolving shell services
Bug: 238217847
Test: atest WMShellUnitTests
Change-Id: I0bf0d258fb9c6c9e7d6ce2a17bd120fe7a45ad9f
Merged-In: I0bf0d258fb9c6c9e7d6ce2a17bd120fe7a45ad9f
2022-10-06 22:49:26 +00:00
Alex Chau
2e72e4cda6 Fix taskbar in overview touch and stash behavior
- When taskbar is unstashed in Launcher (e.g. overview), make the unstashed height touchable
- When AllApps button is pressed in taskbar overview, also stash taskbar

Bug: 245320601
Test: manual
Change-Id: Iadd0bea13cf9a779c68e953d25f21f663c15865a
2022-10-06 21:37:56 +01:00
Pat Manning
24b9554086 Add logging to help debug flake when swiping home to overview.
Bug: 238461210
Bug: 246283207
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: I8ee9af4f4a331c43761ba3738e12acb376ababc2
(cherry picked from commit 1edba8b0a6)
Merged-In: I8ee9af4f4a331c43761ba3738e12acb376ababc2
2022-10-06 15:37:47 +00:00
Saumya Prakash
9860628fcc Merge "Updated overview exit animation for 3 button navigation" into tm-qpr-dev 2022-10-05 22:02:09 +00:00
Alex Chau
d5bccf19c4 Merge "Set controllersInitialized to false when destroying taskbar controllers" into tm-qpr-dev 2022-10-05 20:24:04 +00:00
Alex Chau
72c08d9255 Set controllersInitialized to false when destroying taskbar controllers
Bug: 250912179
Test: presubmit
Change-Id: I16532e99b8f74542def4283b6cc753673eb5ee2d
2022-10-05 15:46:31 +01:00
Nick Chameyev
3e7c611358 Merge "Extract PreviewPositionHelper to shared library" into tm-qpr-dev 2022-10-05 12:52:02 +00:00
Johannes Gallmann
72f5b73f5d Merge "Disable split button instead of hiding it" into tm-qpr-dev 2022-10-05 10:29:55 +00:00