When clicking on desktop tile, we need to explicitly move launcher state
to NORMAL. Freeform apps float on top of launcher and launcher remains
visible in the background. When on desktop, launcher should be in normal
state, with icons and widgets hidden. Hiding of the icons etc is handled
already by DesktopVisibilityController.
TODO:
- need to fix home screen icons flicker, can be solved with new
launcher state (b/255649902)
Bug: 244348395
Test: manual, click on desktop tile in overview, observe freeform apps
brought to front and overview closes
Change-Id: I214b0d6b622e673e0b0cb82f84b2080b479a7fb9
When freeform tasks are visible in desktop mode, capture a screenshot of
the tasks when opening overview.
Also use RecentsView instead of RecentsAnimationController when
finishing the recents animation. RecentsView.finishRecentsAnimation
method has an extra call to onRecentsAnimationComplete() which ensures
that screenshot does got used.
Bug: 244348395
Test: manual, open freeform task, swipe up to go overview, observe a
screenshot of the task
Change-Id: I066b25ec7ae25d1e09aba0ff0a379d35bbe2b636
On desktop environment, we want the AllAppsButton to be on the left side
of the taskbar instead of the hotseat, but retain the functionality of
the button.
Bug: 251372204
Test: Manual
Change-Id: Ia2c95a20583cb98785ab6f8c719559d93982c06f
This change is only for the visual appearance of the
transient taskbar.
Bug: 252905206
Test: manual
Change-Id: I4990b20b39089a0c27ec2a72dd3010cf64ddba1d
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.
Test: Manual
Fix: 230508197
Change-Id: I17628f1fa3869b575ec404a2a630a6927e3c1d14
This patch makes it so that the DWB banner transitions out neatly when a user in Overview drags a tile downward to launch the app. Previously, the banner would stick around throughout the transition, creating visual clutter and drawing attention to the corners of the app.
Fixed by creating an exit transition in setFullscreenProgress(), similar to other UI elements like Overview action chips.
There is another outstanding issue where sometimes the transition can get clipped and jump to the final frame. The cause is still unknown, but issue is tracked at b/250976138 for a future fix.
Fixes: 249825524
Test: Manual
Change-Id: Iea47a9bc643537f0b716ce11b104803d9ca25fd2
This logic was used as a workaroung for 2-button navigation mode. This mode is now obsolete, however the leftover logic clashes with gesture navigation mode. Removed old logic and unused variables.
Test: manually tapped nav handle, then quickly swipped up
Fixes: 255348258
Change-Id: Ib4e179c0c4d9769acae24f93cfde65d2c7a4dfd9
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.
Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
This CL introduces a new controller to manage the visibility of the
launcher workspace when desktop mode is active and freeform tasks
are visible.
This controller will be notified when the sysui state flag related
to freeform task visibility is changed.
The controller will modify the workspace visibility as well as
the flags on the activity indicating if it's been paused / resumed
based on freeform tasks being visible or not.
Bug: 245569277
Test: manual - enable desktop mode and open some freeform tasks
=> observe that the contents of launcher is hidden and
taskbar shows
- remove all of the freeform tasks
=> observe that the contents of launcher reappears along
with the hotseat.
Change-Id: I378ab97b40cbb954a06f4e2426b195efddad905c
* During a merge conflict we prevented
updateButtonLayoutSpacing() from running if device was
in setup mode, however the code that does setup layout
is in there.
Fixes: 254589281
Test: Went through setup, back button shows up
where expected
Change-Id: Ib496bfc0e3ac9023a9fc5071867c3779721ab8ab
Override launchTasks() method from TaskView to ensure we always call
into WMShell to bring desktop apps to front. And don't run single task
animation logic.
Bug: 254738174
Test: manual, enable shell transitions, click on desktop tile in recents
Change-Id: Ibe85cbe14d3378a89ba7bfd5f394f0c3e44f304d
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.
Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
Merged-In: I9a4679ba82cacb5e2648481274876dbfc95d80ce
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
This allows us to reuse the bitmap generated for themed icons, instead of
creating a new everytime
Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
Using the value calculated in layout was not working because TaskbarView onLayout() was being called after TaskbarEduView onMeasure(). Now uses the same value on all orientations based on taskbar icon size.
Fixes: 252945031
Test: manual
Change-Id: Ib6914901638c82f3b3ec4c9b86f6c20e84d34d0f
Swipe up snapshot only capture the top one task, but for split
screen case it should capture two tasks otherwise the snapshot
in overview would be empty in some cases.
Fix: 247420799
Test: manual
Test: pass existing tests
Change-Id: I3acd477eaca3cb98d86e2446dbb2dbd6295c687d
* Instead of passing in screenWidth to be that
of entire screen when using split, scale screenWidth
to that of only the amount that the given split app
is taking.
* Created TODO(b/254378592) to consolidate different
SplitBounds classes
Fixes: 250817893
Test: Checked phone/tablet swiping quickswitching
portrait and landscape
Change-Id: I5c3b2076110e358366284b2c794fd8df8a79f034
It is the same as ActivityAllAppsContainerView#createAdapter, so it can
be cleaned up.
Test: Manual
Fix: 254545341
Change-Id: Ib23369a53c8c0a1f8f05b671526eb82a07b6f0e3
This adds Jank instrumentation every time recent tasks are scrolled.
Bug: 231130484
Bug: 228969045
Test: recorded prefetto trace while scrolling
Change-Id: I3904257ef60a4e09c91a0d5297beadad0bce8785
