Commit Graph

80181 Commits

Author SHA1 Message Date
Gustav Sennton
cbb7ecddfe Only set task surface corner radius once in TransformParams
When setting the corner radius constantly in TransformParams sometimes
we set the radius after the end of the recents transition, causing
Desktop tasks to have non-rounded corners at the end of recents
transitions.

Bug: 378657004
Test: manual + TransformParamsTest
Flag: com.android.window.flags.enable_desktop_recents_transitions_corners_bugfix
Change-Id: I2ae919424602d655d0995b4dc1951d96c7dfd3d8
2025-02-07 07:16:33 +00:00
Alex Chau
11c035cb2f Merge "Consider tasks with INVALID_DISPLAY as it's on DEFAULT_DISPLAY" into main 2025-02-03 02:06:51 -08:00
Alex Chau
5ab6c2e68a Consider tasks with INVALID_DISPLAY as it's on DEFAULT_DISPLAY
- In the test environment, some main display tasks can have INVALID_DISPLAY (-1) as their displayId, we should consider them as main display tasks or else they'll be sorted to an unexpected section in RecentsView

Bug: 391311008
Test: TaplTestsQuickstep#testQuickSwitchFromHome
Flag: com.android.launcher3.enable_separate_external_display_tasks
Change-Id: I5a89d91e342557e114eae6796e153a160d729301
2025-02-01 10:01:44 +00:00
Treehugger Robot
85b6ba2821 Merge "Don't close Folder from system nav region while editing name" into main 2025-01-31 22:46:53 -08:00
Treehugger Robot
0012e24fbc Merge "Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons." into main 2025-01-31 19:10:15 -08:00
Treehugger Robot
5c11f67ca3 Merge "[CD Taskbar] Refactor TaskbarManager - Make Window Contexts also follow map pattern" into main 2025-01-31 18:02:23 -08:00
Charlie Anderson
0905744966 Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons.
- includes loading icons for AllApps as archived apps show there as well

Bug: 391913214
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: LoaderTaskTest, LoaderCursorTest and manually doing backup + restore
Change-Id: Icc9dc292551d4a3c6ac23de89aea4cb14856744c
2025-02-01 01:11:04 +00:00
Tony Wickham
e6cb984fdf Don't close Folder from system nav region while editing name
Fixes: 359127164
Test: Manual, add language, change it from IME switcher while
editing folder name
Flag: EXEMPT bug fix

Change-Id: I275bf8ee43d591d1adce98cef99e59c9ffa2baf1
2025-02-01 00:30:45 +00:00
Treehugger Robot
d038e1945c Merge "Add grid icon for wallpaper picker" into main 2025-01-31 14:33:03 -08:00
Sukesh Ram
2f74082b3b [CD Taskbar] Refactor TaskbarManager - Make Window Contexts also follow map pattern
Make Window Contexts also follow map pattern.

Flag: EXEMPT not adding new behavior
Bug: 391706879
Test: Manual
Change-Id: Ib0672e653b9dbfcb3597210ca244f110515cd4dc
2025-01-31 21:53:46 +00:00
Matthew Mourgos
cdc67c5768 Merge "Stop mouse long press from opening workspace menu" into main 2025-01-31 12:55:09 -08:00
Treehugger Robot
634c3a0f8f Merge changes I8af39b58,I9a3e8ee2 into main
* changes:
  Finally remove `task1` and `task2` from `GroupTask`
  Remove `GroupTask.mSplitBounds`
2025-01-31 11:51:02 -08:00
Treehugger Robot
340720e8a7 Merge "Remove all external usages of GroupTask.task1/2 from Launcher3" into main 2025-01-31 11:42:55 -08:00
fbaron
9ed02b841b Add grid icon for wallpaper picker
Bug: 384938435
Test: n/a
Flag: com.android.launcher3.one_grid_specs
Change-Id: I3480244d63cd8b4796ff656245a862094a1b5854
2025-01-31 19:26:02 +00:00
Treehugger Robot
b8fc998679 Merge "If onegrid is on we don't check if destination db is new or not" into main 2025-01-31 09:53:40 -08:00
Ahmed Fakhry
129a3a0097 Finally remove task1 and task2 from GroupTask
See go/refactor-group-task for details. This is the final CL
in this refactor, where `task1` and `task2` are finally removed,
and `DesktopTask` is allowed to have empty tasks.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I8af39b58138f11030981311efc2e95a77cef125b
2025-01-31 17:14:46 +00:00
Ahmed Fakhry
c590a62c80 Remove GroupTask.mSplitBounds
See go/refactor-group-task for details. This CL removes `mSplitBounds`
from `GroupTask` and adds `splitBounds` to `SplitTask`. This makes its
usages more intentional.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I9a3e8ee2e96d46f9eb79a58ffcf5efc257615aac
2025-01-31 17:14:46 +00:00
Ahmed Fakhry
b6ecf5889e Remove all external usages of GroupTask.task1/2 from Launcher3
See go/refactor-group-task for details. This CL removes all the usages
of `task1` and `task2` from `GroupTask` in Launcher3. Follow-up CLs will
remove it from NexusLauncher and remove the fields altogether.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I902c8135b3a0aae95acf25267b3bcbf286bd4e7d
2025-01-31 17:14:44 +00:00
samcackett
5df5144b45 Add task menu shortcut for closing apps
Fix: 383977717
Test: OverviewMenuImageTest
Flag: EXEMPT bugfix

Change-Id: I24338a821e1ec9be21d22a5d1c4295dd6e28d13d
2025-01-31 08:37:18 -08:00
Treehugger Robot
815b265cf7 Merge "Move enable_taskbar_connected_displays to lse_desktop_experiences" into main 2025-01-30 22:17:28 -08:00
Treehugger Robot
dfa11eb35e Merge "Not calling updateCallback in constructor as it can cause initialization error" into main 2025-01-30 20:36:38 -08:00
Charlie Anderson
6009fa94b6 Merge "Add folder shapes for corresponding icon shapes" into main 2025-01-30 19:29:51 -08:00
Treehugger Robot
94eadd7529 Merge changes from topic "tc-refactor" into main
* changes:
  Introduce leftTop and rightBottom TaskContainer to GroupedTaskView
  Refactor TaskView to allow no TaskContainers
2025-01-30 19:22:41 -08:00
Sukesh Ram
65042fde52 Move enable_taskbar_connected_displays to lse_desktop_experiences
Removing launcher flag for taskbar in secondary display and adding it to lse_desktop_experiences.

Test: m
Bug: 393398093
Bug: 383634014
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: Ia73f31346eb1b3bd273ecb7801eb1264d92e6863
2025-01-31 00:11:02 +00:00
Federico Baron
7938a50b28 If onegrid is on we don't check if destination db is new or not
We just migrate them using the special case where everything shifts up
if we meet the criteria

Bug: 392978014
Test: GridSizeMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I4efda781d6fbe6f3e1854b22685abd1b923c3dc4
2025-01-30 15:51:54 -08:00
Treehugger Robot
821572007d Merge "Revert^2 "Unifying various model update callbacks into one"" into main 2025-01-30 15:45:47 -08:00
Matthew Mourgos
5adb3b4b09 Stop mouse long press from opening workspace menu
This feature is intended for the desktop use case.

Bug: 388898277
Test: Manual
Flag: com.android.launcher3.enable_mouse_interaction_changes
Change-Id: Ifc2da01b248c7dbdbe272f4fa124b6d1182c599d
2025-01-30 14:55:10 -08:00
Sunny Goyal
430fd3104f Not calling updateCallback in constructor as it can cause initialization error
Bug: 390930809
Flag: EXEMPT bugfix
Test: atest ActiveTrackpadListTest
Change-Id: Ifb14e2949f1f399fbb8b63f493f96d0dd54cc081
2025-01-30 13:25:04 -08:00
Sunny Goyal
dfbbebc9e3 Revert^2 "Unifying various model update callbacks into one"
72f9943f64

Change-Id: I38901714947a2b7926723ea25df4a2b8216303e4
2025-01-30 13:19:32 -08:00
Priyanka Advani (xWF)
da2e19a821 Merge "Revert "Unifying various model update callbacks into one"" into main 2025-01-30 13:12:33 -08:00
Adnan Begovic
6a69b19389 Merge "Launcher3: Introduce lint checks for Launcher3." into main 2025-01-30 11:25:25 -08:00
Treehugger Robot
db04d745b1 Merge "When doing the special case migration where cells shift up, only modify workspace items" into main 2025-01-30 10:28:11 -08:00
minch
353e0ed184 Introduce leftTop and rightBottom TaskContainer to GroupedTaskView
Flag: EXEMPT refactor
Bug: 391918297
Test: m
Change-Id: Id00dc0769e0a38311d203f14f90a7184e0f2f6e7
2025-01-30 18:25:45 +00:00
minch
dbdf49726f Refactor TaskView to allow no TaskContainers
Flag: EXEMPT refactor
Bug: 391918297
Test: m
Change-Id: I3343da2b6d73a0b0283334a37be5ae288d94f776
2025-01-30 18:23:57 +00:00
Treehugger Robot
602213809f Merge "Fixing leaks in LauncherPreview" into main 2025-01-30 09:04:29 -08:00
Charlie Anderson
8fc63d0657 Merge "Refactor ShortcutsChangedTask to Kotlin" into main 2025-01-30 06:50:30 -08:00
Sunny Goyal
986d7cb9c0 Fixing leaks in LauncherPreview
> Do not add listeners when binding FolderIcon for preview
> Cleaning up preview object when the caller is no longer holding
  on to the communication channel for preview.

Bug: 393086035
Flag: EXEMPT bugfix
Test: Verified manually
Change-Id: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
2025-01-30 00:16:08 -08:00
Federico Baron
12856a32b7 When doing the special case migration where cells shift up, only modify workspace items
Fix: 393212285
Test: Verified DB values
Flag: com.android.launcher3.one_grid_specs
Change-Id: I6cd1d520a2128925664ff3ac65ec75c86a7fb54b
2025-01-30 07:00:42 +00:00
Pechetty Sravani (xWF)
72f9943f64 Revert "Unifying various model update callbacks into one"
Revert submission 31445615-model-callbacks

Reason for revert: <Droidmonitor crested revert due to b/393222548. Will be verified through ABTD for stanadard investigation.>

Reverted changes: /q/submissionid:31445615-model-callbacks

Change-Id: If6893a125756e5abfbb215af377576429bb1c91b
2025-01-29 22:46:55 -08:00
Eghosa Ewansiha-Vlachavas
064af3dfa7 Merge "[2/n] Include default home package in windowing exemptions check" into main 2025-01-29 21:52:45 -08:00
Treehugger Robot
4a17c7ab0d Merge "Move SimpleOrientationTouchTransformer to Dagger." into main 2025-01-29 19:42:42 -08:00
Lingyu Feng
b06120f793 Merge "Rename onDisplayReady to onDisplayAddSystemDecorations" into main 2025-01-29 17:24:01 -08:00
Treehugger Robot
1a7e8991fe Merge "Using a dedicated thread executor for MSDL haptics" into main 2025-01-29 17:21:07 -08:00
Anushree Ganjam
4597aae947 Move SimpleOrientationTouchTransformer to Dagger.
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I2c7adf5da76f0a60c167f4c650622ba8dfeac98d
2025-01-29 17:15:03 -08:00
Charlie Anderson
722f6f3143 Refactor ShortcutsChangedTask to Kotlin
Bug: 375414891
Test: ShortcutsChangedTaskTest
Flag: EXEMPT no functionality change
Change-Id: If80b74a80abf9bed90f1572a9fee2494d39a6829
2025-01-29 16:41:29 -08:00
Treehugger Robot
473bd5c0a0 Merge "Unifying various model update callbacks into one" into main 2025-01-29 16:05:25 -08:00
Charlie Anderson
fcb3d2ec38 Add folder shapes for corresponding icon shapes
Bug: 372886883
Bug: 389329983
Test: Presubmit && IconShapesProviderTest
Flag: com.android.launcher3.enable_launcher_icon_shapes

Change-Id: I46b27b391fef5f379c65d81816353c93f56f2e1d
2025-01-29 14:16:56 -08:00
Adnan Begovic
a610285dfa Launcher3: Introduce lint checks for Launcher3.
As part of the initial check in, add a test to ensure
  that custom Dialogs are not utilized inside of the codebase.

Bug: 389709580
Test: DialogDetectorTest
Flag: NONE Lint checks
Change-Id: I7e3f98c729cdbf4d062419c53a209d12a23b1806
2025-01-29 13:54:27 -08:00
Anushree Ganjam
dc53407678 Merge "Remove flag_check.py, we now have flag directive check in gerrit presubmit." into main 2025-01-29 13:33:25 -08:00
Treehugger Robot
a804d02912 Merge "Refactor: Extract Thumbnail and sysUiStatusNavFlags from TaskContainerVM" into main 2025-01-29 12:04:37 -08:00