Commit Graph

72299 Commits

Author SHA1 Message Date
Fengjiang Li
c83d96daea Merge "Trace unlock animation progress" into main 2023-10-13 15:35:11 +00:00
Jeremy Sim
20410d25f9 Merge "Migrate ENABLE_APP_PAIRS flag to aconfig" into main 2023-10-13 05:22:36 +00:00
Sunny Goyal
73c9ef3368 Merge "Generalize userproperties to support for more user types in iconCache" into main 2023-10-13 01:13:11 +00:00
Hyunyoung Song
b1126a221a Merge "Add flag_check.py to the preupload" into main 2023-10-12 23:30:19 +00:00
Vadim Tryshev
aa5070f7e3 Merge "Adding an annotation for tests that change nothing on screen and may produce no view capture data" into main 2023-10-12 23:19:51 +00:00
Jeremy Sim
7dc3bdcd85 Migrate ENABLE_APP_PAIRS flag to aconfig
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
fbaron
6ebfd954df Add NullPointerException to try/catch since it's possible to have such an error am: 9ffd90a85b am: eb8d8e8066
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25031355

Change-Id: I54d0ea98c0cc4219726a9dc2f12634ca214c0486
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-12 21:56:16 +00:00
Sunny Goyal
c173c04422 Generalize userproperties to support for more user types in iconCache
Bug: 305062259
Flag: None
Test: Presubmit
Change-Id: I35cd20a03520ada233809930fcc56cdea1dabec6
2023-10-12 21:25:59 +00:00
fbaron
eb8d8e8066 Add NullPointerException to try/catch since it's possible to have such an error am: 9ffd90a85b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25031355

Change-Id: I935bb241e0b08ddb806f32d233ee359355d95df9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-12 21:23:31 +00:00
Sunny Goyal
4588031286 Merge "Moving onboarding prefs to use LauncherPrefs" into main 2023-10-12 20:51:45 +00:00
Jon @
5cae6965ae Merge "Fix bug where All Apps button loads in late in taskbar." into main 2023-10-12 20:10:11 +00:00
Tyler Freeman
22781d97d9 Merge "Revert "Combine icon app tests to allow overriding flag for new ..."" into main 2023-10-12 20:06:56 +00:00
Fengjiang Li
25b1675d21 Trace unlock animation progress
The unlock animation is subject to interruption from sysui. Adding trace would help us find root cause easier in the future.

Bug: 301903832
Test: grab perfetto trace and verify the unlock progress is shown
Change-Id: Iab0ca483beb01752b1dd67bd28f401d3e2e9cef7
2023-10-12 11:22:57 -07:00
Vadim Tryshev
ec072e081b Adding an annotation for tests that change nothing on screen and may produce no view capture data
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I3a6822648981400a426a09315aba36cb4977e6e9
2023-10-12 18:07:20 +00:00
Tyler Freeman
1468467706 Revert "Combine icon app tests to allow overriding flag for new ..."
Revert submission 25007147-tapl-flag

Reason for revert: Breaks build: https://b.corp.google.com/issues/305033049

Reverted changes: /q/submissionid:25007147-tapl-flag

Change-Id: I99b5883e64ae25476394a4207c5d6a4d22fc27dc
2023-10-12 18:04:05 +00:00
hyunyoungs
2a165ae76d Add flag_check.py to the preupload
Bug: 273661677
Test: repo upload .
Flag: not needed, python script for repo hook
Change-Id: Ieb48c7ab59b2dffbbf47e3ee0a45698e9adfda9c
2023-10-12 17:38:33 +00:00
Pat Manning
18ce47f535 Merge "Set FastBitmapDrawable's badge alpha when updating drawable alpha." into main 2023-10-12 17:32:30 +00:00
Jon Miranda
330b7754c6 Fix bug where All Apps button loads in late in taskbar.
We need to re-create the icon alignment controller if the
stash status changes, otherwise it will use an old value.

Bug: 296414290
Test: home to app then quickly unstash
Change-Id: I35f23842f289fce95d102a9a93dc94cd033fa8cc
2023-10-12 17:14:49 +00:00
fbaron
9ffd90a85b Add NullPointerException to try/catch since it's possible to have such an error
getShortcutIconDrawable could return null "Method invocation 'getShortcutIconDrawable' may produce 'NullPointerException'" and it leads to the code crashing. Adding  NullPointerException as one of the exceptions in the try/catch would resolve this issue

Fix: 299525046
Test: verify after merging that the null pointer exception stops occurring
Flag: no flag
Change-Id: I52cfba9c7b08ea4e1b0f4506c461e79c3e91dc6c
(cherry picked from commit 7e6107caaf)
2023-10-12 17:02:28 +00:00
Jagrut Desai
a187ab0ec8 Merge "Adding test protocol support for getting num all apps columns" into main 2023-10-12 16:20:18 +00:00
Pat Manning
654c05837e Merge "Combine icon app tests to allow overriding flag for new icon app chip menu testing as well." into main 2023-10-12 15:59:17 +00:00
Pat Manning
236e738907 Combine icon app tests to allow overriding flag for new icon app chip menu testing as well.
Platinum exlude cl update: cl/572225659

Test: TaplOverviewAppIconMenuTest
Test: TaplAppIconAppChipMenuTest
Bug: 303329286
Bug: 303266562
Fix: 304470271
Change-Id: I4ca163401d6a42961e8955e06c164af0254b1231
2023-10-12 14:53:08 +01:00
Pat Manning
43e46a3d86 Set FastBitmapDrawable's badge alpha when updating drawable alpha.
Test: FastBitmapDrawableTest
Fix: 304559962
Change-Id: Ie545cc5da506c77af18f99b5d045cafc37110a5a
2023-10-12 13:57:26 +01:00
Vinit Nayak
e489bd45e6 Merge "Call split finish callback if split invocation fails" into main 2023-10-11 23:33:18 +00:00
Stefan Andonian
3925bdfdf8 Merge "Remove some direct usage of getDevicePrefs()" into main 2023-10-11 23:09:26 +00:00
Stefan Andonian
2171d09fe6 Remove some direct usage of getDevicePrefs()
Bug: 261635315
Test: Manually did testing on device.
Change-Id: I47c88bdc031d330f6efa573411ab5dbf154ec8a2
2023-10-11 23:06:41 +00:00
Tracy Zhou
0dbcbfc08f Merge "Fix transient task bar not automatically stashed in app when ENABLE_TASKBAR_NO_RECREATION is enabled" into main 2023-10-11 22:19:43 +00:00
Charlie Anderson
102a06f810 Merge "Fix status bar flicker on adding widgets requiring configuration." into main 2023-10-11 22:00:40 +00:00
Treehugger Robot
bcd5555863 Merge "Adding Mateusz as an OWNER for Launcher tests" into main 2023-10-11 21:53:30 +00:00
Vadim Tryshev
e86761a225 Adding Mateusz as an OWNER for Launcher tests
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I07a891fe766549208e4402726ee66998db22956d
2023-10-11 14:48:17 -07:00
Vadim Tryshev
9bf8a4bbc1 Merge "Moving verifyKeyguardInvisible() after other initializations" into main 2023-10-11 20:17:04 +00:00
Jeremy Sim
271fc9540c Merge "Set up to use aconfig flags from WM Shell" into main 2023-10-11 19:21:00 +00:00
Vadim Tryshev
4c3757dd2b Merge "Improving diagnostics from fallback recents tests when phone is not unlocked" into main 2023-10-11 18:50:37 +00:00
Schneider Victor-tulias
276420a869 Merge "Fix janky Alt+Tab through overview animation" into main 2023-10-11 18:28:10 +00:00
Tracy Zhou
fbc01a0b4f Fix transient task bar not automatically stashed in app when ENABLE_TASKBAR_NO_RECREATION is enabled
Currently the task bar root layout consumes all the events and does not pass the events to drag layer, without explictly routing those events

Fixes: 303910224
Test: go to an app, swipe home, and then go back to the app. Make sure the task bar is stashed
Change-Id: I6f5e481c267dad25544118134ff95b0cb9bb1a45
2023-10-11 11:25:45 -07:00
Alex Chau
6ae2c4d77d Merge "Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""" into main 2023-10-11 15:38:57 +00:00
Vinit Nayak
77ce4c261e Merge "Update API for OneShotRemoteHandler" into main 2023-10-11 15:13:25 +00:00
Vinit Nayak
c4f653c24c Merge "Null out context for all split controllers" into main 2023-10-11 15:12:24 +00:00
Alex Chau
4989f4f36d Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""
This reverts commit 7b5472f986.

Reason for revert: aconfig/SetFlagsRule actually works with TAPL tests (http://ag/c/platform/packages/apps/Launcher3/+/24991890/comment/8303a3c6_030ae00b/)
Bug: 270397206

Change-Id: I7529a64c3197e4c2b4d5fb1e46fb29bdea1e52e9
2023-10-11 14:08:22 +00:00
Hyunyoung Song
e0a25fbd51 Merge "Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH" into main 2023-10-11 07:54:26 +00:00
Tracy Zhou
9633e5b74c Merge "Fix phone mode task bar inset values not correctly initialized" into main 2023-10-11 05:32:09 +00:00
Vinit Nayak
def3e9d7f4 Call split finish callback if split invocation fails
Bug: 295981634
Test: Splitting w/ Google TV widget no longer
keeps placeholder views on screen
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I1d4df9deb9aaaaeef3741a05130429d0091293e8
2023-10-10 21:01:35 -07:00
Vinit Nayak
a439c912d8 Null out context for all split controllers
* Destroy context for AppPairsController and
SplitSelectDataHolder

Bug: 302551868
Change-Id: I5636ecf50d51ad383ac89a457697984bc8d907ca
2023-10-10 20:42:42 -07:00
Vadim Tryshev
f782eaba73 Improving diagnostics from fallback recents tests when phone is not unlocked
Failing earlier so that we don't get strange messages from the middle of the test.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1e3c70623e6f907bcc6bd0486b6c75afecb610e3
2023-10-10 19:18:22 -07:00
Krzysztof Kosiński
c1d05a7101 Merge "Clean up obsolete aliases for Truth." into main am: a4bc505d01 am: 6247399c9b am: f56d690e22 am: 42c39649a7 am: b085f9e819
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2778094

Change-Id: Id239979be76a11ce08d564c13f174aa5d02deb3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-11 00:16:49 +00:00
Automerger Merge Worker
d12de08601 Merge "[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: 2e3aea5133 -s ours am: 2d42f8724e -s ours" into udc-qpr-dev-plus-aosp am: 281ad63c31 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: I45649ea677a532e7c31ba7e8f3b779c2b7728bb0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:42:43 +00:00
Bill Yi
67af07f460 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: 2e3aea5133 -s ours am: 2d42f8724e -s ours am: 5adb4d0f59 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: Ie4fbc3742037475b5009b0fe84df57856b7d93c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:42:31 +00:00
Vadim Tryshev
3c1def4810 Moving verifyKeyguardInvisible() after other initializations
verifyKeyguardInvisible can fail, and then tear down will be called,
potentially accessing fields that currently get assigned after this
call, causing crashes.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I865dfd70ce1821cee26800f57a13fb202626ea84
2023-10-10 16:37:14 -07:00
Automerger Merge Worker
d31ef63ae0 Merge "[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: f145e084cc -s ours am: a2a4b84db1 -s ours" into udc-qpr-dev-plus-aosp am: 644a5bd5b4 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: I5aedd906a161051723f5cb660fea2be59de69c2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:35:19 +00:00
Bill Yi
2c74d95768 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: f145e084cc -s ours am: a2a4b84db1 -s ours am: 9909efb8d5 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: I6ef62cbff5140a69698bf3cf90bcdd3230265040
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:35:05 +00:00