Commit Graph

11266 Commits

Author SHA1 Message Date
Sunny Goyal
c82916fecb Some cleanup in RecentsView
> Merging overview and all-apps scrims into a single View
> Decoupling TaskMenuView from taskView

Bug: 184676497
Test: Manual

Change-Id: I49f7249eaa2a800054385ab8e73a441d6a1b5e16
2021-04-06 15:47:33 -07:00
TreeHugger Robot
e77fc9cc25 Merge "Add split placeholder view above OverviewScrim" into sc-dev 2021-04-06 02:34:19 +00:00
Tony Wickham
2e0eee4d63 Merge "Send a notification when there's an uncaught exception" into sc-dev 2021-04-05 23:58:22 +00:00
Tony Wickham
e78a70ba83 Send a notification when there's an uncaught exception
Guarded by FeatureFlag.NOTIFIY_CRASHES and IS_DEBUG_DEVICE

Test: Add a crash in the code, ensure a notification is posted
and can share the stack trace

Change-Id: I828cca3a99debf62f492960eb3cdc699cc0d7f9a
2021-04-05 15:18:12 -07:00
Andy Wickham
dd2b8b6f2e Merge "Updates OptionsPopupView to allow non-resource strings/icons." into sc-dev 2021-04-05 21:24:50 +00:00
Zak Cohen
7ec7c22b07 Merge "Overview - add the ability to color scrim task views." into sc-dev 2021-04-05 21:05:25 +00:00
Vinit Nayak
e3f7d0d1b4 Add split placeholder view above OverviewScrim
Only show single split option for landscape and
seascape overview menu options.

Bug: 181705607
Change-Id: I577fbaed41b5debd007c953851ec2056988057d9
2021-04-05 12:41:06 -07:00
Samuel Fufa
ee9aff9b5b [Search][Motion] Normal<->AllApps transition revamp
Preview video attached to BR

Key changes:

- SearchUiManager#getScrollRangeDelta is removed. AllApps initial vertical offset is now controlled by deviceProfile.allAppsOpenVerticalTranslate.
- ShelfScrimView is renamed to AllAppsScrimView. Scrim no longer does vertical translate with AllApps open.  Shelf/overview related code removed.
- Scrim and AllApps content transition are animated with different interpolators. Scrim color is a blend of accentColor and allAppsScrim with proportion determined by progress*TINT_DECAY_MULTIPLIER

Bug: 183001675
Test: Manual
Change-Id: Id6bde7ee65c55c83c2973fe41f458b9364d39ecd
2021-04-05 13:32:51 -05:00
Zak Cohen
ec4407b4ef Overview - add the ability to color scrim task views.
Bug: 184202238
Test: local build and flash
Change-Id: If700cb6dffc3966fe860c40d98d40a5899c236e4
2021-04-05 11:17:02 -07:00
thiruram
0eabc781b1 [AA+] Fix missing InstanceId for LAUNCHER_ALLAPPS_CLOSE_DOWN event.
Before: https://screenshot.googleplex.com/8ZYxhujUR3amgmF.png
After: https://screenshot.googleplex.com/AZ7PExbBhGW2pAC.png

Bug: 178562918
Test: Manual
Change-Id: Id0bc54049e3a13cd53aaa37d0acee27ec7433fab
2021-04-02 14:34:26 -07:00
Andy Wickham
7d821d98f1 Updates OptionsPopupView to allow non-resource strings/icons.
This will be needed for Smartspace which gets its menu options
from AiAi.

Test: Hard-coded strings passed to Smartspace from the fake
data Launcher plugin. Also verified could access the menu
using TalkBack.
Bug: 184179894

Change-Id: I724c09db18085585c7a5224e32c0d8973acdab7c
2021-04-01 18:27:20 -07:00
Jonathan Miranda
ed85ee6ca6 Merge "Set FLAG_IMMUTABLE flag on FirstScreenBroadcast PendingIntent." into sc-dev 2021-04-01 21:28:07 +00:00
TreeHugger Robot
20efbbbb1c Merge "Fixing notification dots settings not updated properly" into sc-dev 2021-04-01 20:14:34 +00:00
Sunny Goyal
7a5b6f868a Merge "Removing some unused classes" into sc-dev 2021-04-01 20:11:14 +00:00
Jon Miranda
b62fba0d01 Set FLAG_IMMUTABLE flag on FirstScreenBroadcast PendingIntent.
Bug: 183927137
Test: restore phone and ensure broadcast is sent
Change-Id: I8d8e38a1aa6bdf13879d460cfa84cabe6c6bb1f2
2021-04-01 13:20:12 -04:00
Pierre Barbier de Reuille
8c3f8d3f71 Merge "Prevent launcher crash when an App Widget is removed." into sc-dev 2021-04-01 15:07:01 +00:00
Pierre Barbier de Reuille
712a8bf004 Prevent launcher crash when an App Widget is removed.
If an App Widget with a scrollable element is removed, we may end up in
a situation where we try to draw the view directly on a canvas while the
it has already been detached from the workspace. This can crash as some
of the drawing the scroll indicators require the view to be attached.

In general, we should never draw a view by calling the draw method
directly, even more so when the view is detached: the behavior is
undefined as the method expects the canvas to be properly set up, and it
is not. A crash can therefore be expected. This patch should avoid
crashing the launcher until we stop doing that altogether.

Fix: 183386115
Test: Manally add a view with a preview layout
Test: Manually remove an app widget with a list view
Change-Id: I8e1aa581700a08d6747eab085199c2b293e0e3fb
2021-04-01 13:32:45 +01:00
Winson Chung
80988abae3 Merge "Expose the full task info with the remote animation target" into sc-dev 2021-04-01 03:56:56 +00:00
TreeHugger Robot
ab9476461f Merge "Fixing all-apps appearing as blank" into sc-dev 2021-04-01 00:31:28 +00:00
Sunny Goyal
58530bd64b Fixing notification dots settings not updated properly
Also avoiding settings cache reset whenever someone registers
a new listener

Bug: 184200027
Test: Manual
Change-Id: I0c8b7084b6b4656102e9041b779b80a98624ddd8
2021-03-31 15:57:49 -07:00
Jonathan Miranda
4c5a08e122 Merge "Only hide workspace labels if there is not enough space for it in the cell." into sc-dev 2021-03-31 22:02:40 +00:00
Sunny Goyal
0b5b8d4969 Fixing all-apps appearing as blank
Since all-apps and homescreen do not share any QSB, we can
change the alpha for hotseat QSB directly

Bug: 184122599
Test: Manual
Change-Id: Ifa610fe75ad22cfe8a7d816ed2b48e2b9411c4c1
2021-03-31 14:59:54 -07:00
Zak Cohen
00611188e5 Merge "Overview - update UI to use solid color scrim." into sc-dev 2021-03-31 20:34:00 +00:00
Sunny Goyal
157a9ee7dd Removing some unused classes
Bug: 184183801
Test: Manual
Change-Id: I946b4b4d486d52e467bb3df7dcac65e534803b7d
2021-03-31 12:59:57 -07:00
Jonathan Miranda
f072b062a2 Merge "Folder cell should match grid cell aspect ratio if isScalableGrid is true." into sc-dev 2021-03-31 19:15:30 +00:00
Jonathan Miranda
1536248f3d Merge "Snap to destination page before animating folder close." into sc-dev 2021-03-31 19:14:56 +00:00
Jon Miranda
941375eda4 Only hide workspace labels if there is not enough space for it in the cell.
- Also increases the spacing in all apps to reduce visual clitter.

Bug: 175329686
Test: manual, change grid to mw, smaller grid, and verify labels
Change-Id: I75c7fa9c69b8446ce0e48f4353fb225004e2a2fc
2021-03-31 14:52:49 -04:00
Zak Cohen
a547b781ee Overview - update UI to use solid color scrim.
Also required updates to colors and status bar icons to match with new
color.

Bug: 179922117
Test: local build and flash on two devices

Change-Id: Ibec54107f52c01f125e6d100abe32434f2067b71
2021-03-31 11:25:41 -07:00
Alex Chau
21dfadab76 Merge "Changes page alignment in PagedView calcualtion" into sc-dev 2021-03-31 10:36:12 +00:00
András Klöczl
ea2b30d7fd Merge "Fix app close animation for two panel home" into sc-dev 2021-03-31 09:14:22 +00:00
TreeHugger Robot
70c3d5f98b Merge "Using an independent drawable for rounded corners" into sc-dev 2021-03-31 09:02:00 +00:00
TreeHugger Robot
75d190651c Merge "Revert "Revert "Enable device search""" into sc-dev 2021-03-30 22:45:11 +00:00
Tony Wickham
7e7116278b Merge changes I2af1792e,Ice314d46,Ib17d4a5e into sc-dev
* changes:
  Invert StateAnimationConfig.PLAY_ANIMATION as SKIP_ALL_ANIMATIONS
  Remove Overview atomic animation support
  In 2 button mode, animate to HINT_STATE instead of OVERVIEW directly
2021-03-30 22:27:07 +00:00
Andras Kloczl
35d23a62f0 Fix app close animation for two panel home
Change getFirstMatchForAppClose to check all the visible
pages not just the page with the currentPage index.

Test: manual
Bug: 183606840
Change-Id: If5280797f821f7d10f82376aeef5e8eb4d352e2a
2021-03-31 00:09:07 +02:00
Sunny Goyal
940c27ef1a Using an independent drawable for rounded corners
Bug: 183641907
Test: Manual
Change-Id: I3114d43d07c03884348e1c33805545f19bb8d540
2021-03-30 14:47:44 -07:00
Hyunyoung Song
04d432ee41 Revert "Revert "Enable device search""
This reverts commit 8ffdc4b6c4.

Reason for revert: b/183683148

Change-Id: I8429671f460e2ecbd187b8279aeed85009ffb334
2021-03-30 20:18:21 +00:00
Sunny Goyal
07fb2fea34 Merge "Simplifying all-apps seach pipeline" into sc-dev 2021-03-30 19:50:23 +00:00
Hyunyoung Song
cd64f3eec4 Merge "Revert "Enable device search"" into sc-dev 2021-03-30 17:39:17 +00:00
Hyunyoung Song
8ffdc4b6c4 Revert "Enable device search"
This reverts commit 6323aa270c.

Reason for revert: 4 tests failing in tapl
Bug: 184030316
Bug: 184030696
Bug: 184030463
Bug: 184030324

Change-Id: Ib5daebbca9bad4eefd20ca51755f5a02a9c4f6aa
2021-03-30 17:37:43 +00:00
Sunny Goyal
b456429a95 Merge "Using edgeEffect for overscroll in all-apps and widget tray" into sc-dev 2021-03-30 17:13:04 +00:00
Sunny Goyal
04e9f39f19 Simplifying all-apps seach pipeline
Bug: 183607616
Test: Verified on device
Change-Id: Id7ded3c244b747a577cdfcf298db6dddf19fa4eb
2021-03-30 10:07:32 -07:00
Hyunyoung Song
8a5e0c8e27 Merge "Remove AA+ decorator logic from aosp code" into sc-dev 2021-03-30 16:19:58 +00:00
Jonathan Miranda
efeb27ce9c Merge "Update All Apps apps per row when DeviceProfile changes." into sc-dev 2021-03-30 14:52:44 +00:00
Jonathan Miranda
2d2f50fe86 Merge "Migrate existing 4x5 and 4x4 grid users to a new 4x5 grid." into sc-dev 2021-03-30 13:18:06 +00:00
Jon Miranda
ec1277eec1 Migrate existing 4x5 and 4x4 grid users to a new 4x5 grid.
Due to the dogfood 4x5 grid using the wrong db, there may
be some rearranging of items.

The goal is to completely remove the old 4x4 and 4x5 grid,
but first we need to silently migrate users to the new grid.

We still  need to keep the old grids in the device profile
so we hide them from the Styles & Wallpaper app.

We also need to reset and remove the ENABLE_FOUR_COLUMN feature
flag from the UI.

- Added TODO to remove this logic in the tracking doc

Bug: 183965808
Bug: 175329686
Test: have old 4x4 or 4x5 grid set up
      install apk with these changes
      confirm that we are now using the new grid and the
      other grid options are inaccessible to the user
Change-Id: I81a91b8415effbe0bf7ba722f11ab44a4169e3df
2021-03-30 13:17:37 +00:00
András Klöczl
35793a8643 Merge "Fix two panel home folder opening display issue" into sc-dev 2021-03-30 11:52:42 +00:00
Alex Chau
b5c4d1108f Changes page alignment in PagedView calcualtion
- Align pages to right (instead of left) in RTL, to make scroll calculation for grid overview easier for out of orientation tasks
- Changed TaskView pivot direction to be consistent with page alignment
- Add scroll offset for ClearAllButton to align to left in RTL
- Fixed Workspace scroll issues in RTL, and removed needs to use panelCount when calculating page scroll

Bug: 175939487
Test: Test carousel/grid overveiw, Workspace, Folder scroll view for normal/RTL
Change-Id: Ic0ba88e5d58638e1149d97a68a978d80fbf26774
2021-03-30 12:05:16 +01:00
Hyunyoung Song
6df27bfd08 Merge "Enable device search" into sc-dev 2021-03-30 03:53:11 +00:00
Andras Kloczl
3a4ba0bec3 Fix two panel home folder opening display issue
Change the rect calculation logic that is used to
display an opening folder. If multiple panels are
displayed then we calculate the union of the pages.

Test: manual
Bug: 181962118
Change-Id: I504f22890115ceebc16d60929149fe634bf820d0
2021-03-29 22:51:57 +02:00
Sunny Goyal
c5797893e7 Using edgeEffect for overscroll in all-apps and widget tray
Bug: 183966408
Test: Manual
Change-Id: Iea1b67504fc59fc7ce2ec657bf8ac7e3d8bfff1c
2021-03-29 12:35:39 -07:00