Commit Graph

31495 Commits

Author SHA1 Message Date
Sunny Goyal
c82916fecb Some cleanup in RecentsView
> Merging overview and all-apps scrims into a single View
> Decoupling TaskMenuView from taskView

Bug: 184676497
Test: Manual

Change-Id: I49f7249eaa2a800054385ab8e73a441d6a1b5e16
2021-04-06 15:47:33 -07:00
Tony Wickham
fc3bc6098f Merge "Explicitly set which taskbar view is visible at each caller" into sc-dev 2021-04-06 19:37:18 +00:00
Tony Wickham
0b0c173ec0 Merge "Ensure taskbar animation ends when running window animation does" into sc-dev 2021-04-06 19:35:38 +00:00
Tony Wickham
c9846dc6e7 Merge "Cleanup taskbar touchableInsets" into sc-dev 2021-04-06 18:36:05 +00:00
Samuel Fufa
50c6a37ea9 Merge "[Search][Layout] Fix blank space when predictions are disabled" into sc-dev 2021-04-06 17:56:51 +00:00
Zak Cohen
fd9af2f017 Merge "Overview - update Clear All and Empty message drawing" into sc-dev 2021-04-06 17:42:05 +00:00
TreeHugger Robot
d69407c02e Merge "Update device padding to allocate more space to workspaceBottomPAdding." into sc-dev 2021-04-06 16:55:33 +00:00
Samuel Fufa
5461089baa [Search][Layout] Fix blank space when predictions are disabled
This regression is caused due to getExpectedHeight relying on view visibility state while AlphaUpdateListener.updateVisibility was reseting the views visibility.

Bug: 184211402
Test: local
Change-Id: Ib756f5eb8f6356a18a025626008b97fd7c77fec9
2021-04-06 04:05:20 -05:00
TreeHugger Robot
ce271c1067 Merge "[Hotseat] Don't show hotseat edu in tests" into sc-dev 2021-04-06 06:18:56 +00:00
TreeHugger Robot
e77fc9cc25 Merge "Add split placeholder view above OverviewScrim" into sc-dev 2021-04-06 02:34:19 +00:00
Tony Wickham
9f436dfe8e Ensure taskbar animation ends when running window animation does
- Store the possible parallel animation to cancel/end in
  AbsSwipeUpHandler#endRunningWindowAnim()

Test: 1. remove taskbar during transition, ensure cleaned up properly
2. open a second app during transition to home, ensure taskbar
maintains correct visibility
Bug: 182512211

Change-Id: I71a6b6ce624113d43ad5a599cb5cfec28a555310
2021-04-05 17:52:38 -07:00
Tony Wickham
e13a4a4475 Cleanup taskbar touchableInsets
- Remove obsolete visibleInsets hack and isDraggingItem() check
- Have TaskbarController determine whether taskbar is touchable,
  rather than TaskbarContainerView.
- Disallow touches during transition to home (can potentially
  improve this later)

Test: Swupe home, tap taskbar folder during transition, ensure
don't end up in broken state with the uninteractable folder open
Bug: 182512211

Change-Id: Id625ce8b9b876a8a1b450b7d6fb771540e23bc08
2021-04-05 17:33:44 -07:00
Tony Wickham
2e0eee4d63 Merge "Send a notification when there's an uncaught exception" into sc-dev 2021-04-05 23:58:22 +00:00
Zak Cohen
23b7fea6eb Overview - update Clear All and Empty message drawing
Update Clear All and Empty message to use primary color, not workspace
color, as they are drawn on floating background now, not wallpaper.

Bug: 184260454
Fixes: 184260454
Test: local build, flash and run
Change-Id: Ie8ef4b7ace3053c2068a27b7cbedbbb039fc36d8
2021-04-05 23:45:02 +00:00
Tony Wickham
6a74e65953 Explicitly set which taskbar view is visible at each caller
This makes it more clear which taskbar view is expected for particular
code flows. Also makes it easier to set it to null in cleanup().

Test: call cleanup() while taskbarOnHome is invisible, ensure hotseat
icons go back to being visible
Bug: 182512211
Fixes: 183633496

Change-Id: I680a15582c8034a049b20e035b4d54f5ea5aee04
2021-04-05 16:42:17 -07:00
Becky Qiu
9b85dc836d Merge "Shared element transition between image and sharesheet." into sc-dev 2021-04-05 22:18:34 +00:00
Tony Wickham
e78a70ba83 Send a notification when there's an uncaught exception
Guarded by FeatureFlag.NOTIFIY_CRASHES and IS_DEBUG_DEVICE

Test: Add a crash in the code, ensure a notification is posted
and can share the stack trace

Change-Id: I828cca3a99debf62f492960eb3cdc699cc0d7f9a
2021-04-05 15:18:12 -07:00
Samuel Fufa
2043f2009f [Hotseat] Don't show hotseat edu in tests
Bug: 180972179
Test: presubmit
Change-Id: I2e82c0c90804d0149717ebdcd83fdac9c822ce7d
2021-04-05 16:49:47 -05:00
Andy Wickham
dd2b8b6f2e Merge "Updates OptionsPopupView to allow non-resource strings/icons." into sc-dev 2021-04-05 21:24:50 +00:00
Zak Cohen
7ec7c22b07 Merge "Overview - add the ability to color scrim task views." into sc-dev 2021-04-05 21:05:25 +00:00
Jon Miranda
71b954a257 Update device padding to allocate more space to workspaceBottomPAdding.
Bug: 175329686
Test: verify using DeviceProfile dump
Change-Id: I7054a49bf33e2c44bd1886a88dbed75c6807ab37
2021-04-05 16:59:15 -04:00
Vinit Nayak
e3f7d0d1b4 Add split placeholder view above OverviewScrim
Only show single split option for landscape and
seascape overview menu options.

Bug: 181705607
Change-Id: I577fbaed41b5debd007c953851ec2056988057d9
2021-04-05 12:41:06 -07:00
Sreyas
8a9cc9689a Shared element transition between image and sharesheet.
Bug: 182373655
Test: Manual
Change-Id: I6f5abffa0c4911d939ba45476fe1301d65b840cf
2021-04-05 19:15:55 +00:00
Samuel Fufa
ee9aff9b5b [Search][Motion] Normal<->AllApps transition revamp
Preview video attached to BR

Key changes:

- SearchUiManager#getScrollRangeDelta is removed. AllApps initial vertical offset is now controlled by deviceProfile.allAppsOpenVerticalTranslate.
- ShelfScrimView is renamed to AllAppsScrimView. Scrim no longer does vertical translate with AllApps open.  Shelf/overview related code removed.
- Scrim and AllApps content transition are animated with different interpolators. Scrim color is a blend of accentColor and allAppsScrim with proportion determined by progress*TINT_DECAY_MULTIPLIER

Bug: 183001675
Test: Manual
Change-Id: Id6bde7ee65c55c83c2973fe41f458b9364d39ecd
2021-04-05 13:32:51 -05:00
Zak Cohen
ec4407b4ef Overview - add the ability to color scrim task views.
Bug: 184202238
Test: local build and flash
Change-Id: If700cb6dffc3966fe860c40d98d40a5899c236e4
2021-04-05 11:17:02 -07:00
Thiru Ramasamy
9efbf6f39b Merge "[AA+] Fix missing InstanceId for LAUNCHER_ALLAPPS_CLOSE_DOWN event." into sc-dev 2021-04-05 17:01:27 +00:00
thiruram
0eabc781b1 [AA+] Fix missing InstanceId for LAUNCHER_ALLAPPS_CLOSE_DOWN event.
Before: https://screenshot.googleplex.com/8ZYxhujUR3amgmF.png
After: https://screenshot.googleplex.com/AZ7PExbBhGW2pAC.png

Bug: 178562918
Test: Manual
Change-Id: Id0bc54049e3a13cd53aaa37d0acee27ec7433fab
2021-04-02 14:34:26 -07:00
Sunny Goyal
11d7d34f0d Removing unnessary resource split in overview
Bug: 184169818
Test: Presubmit
Change-Id: Iff5a8510be337472f05acb5629712ec088361471
2021-04-02 11:43:29 -07:00
Alex Chau
5bd9ba2a80 Merge "Focus running task in overview grid" into sc-dev 2021-04-02 03:57:58 +00:00
Andy Wickham
7d821d98f1 Updates OptionsPopupView to allow non-resource strings/icons.
This will be needed for Smartspace which gets its menu options
from AiAi.

Test: Hard-coded strings passed to Smartspace from the fake
data Launcher plugin. Also verified could access the menu
using TalkBack.
Bug: 184179894

Change-Id: I724c09db18085585c7a5224e32c0d8973acdab7c
2021-04-01 18:27:20 -07:00
Jonathan Miranda
ed85ee6ca6 Merge "Set FLAG_IMMUTABLE flag on FirstScreenBroadcast PendingIntent." into sc-dev 2021-04-01 21:28:07 +00:00
TreeHugger Robot
20efbbbb1c Merge "Fixing notification dots settings not updated properly" into sc-dev 2021-04-01 20:14:34 +00:00
Sunny Goyal
7a5b6f868a Merge "Removing some unused classes" into sc-dev 2021-04-01 20:11:14 +00:00
Jon Miranda
b62fba0d01 Set FLAG_IMMUTABLE flag on FirstScreenBroadcast PendingIntent.
Bug: 183927137
Test: restore phone and ensure broadcast is sent
Change-Id: I8d8e38a1aa6bdf13879d460cfa84cabe6c6bb1f2
2021-04-01 13:20:12 -04:00
Pierre Barbier de Reuille
8c3f8d3f71 Merge "Prevent launcher crash when an App Widget is removed." into sc-dev 2021-04-01 15:07:01 +00:00
Alex Chau
dfde4d96ea Focus running task in overview grid
- calculateTaskSize now returns the Rect for focused task
- Introduced calculateGridTaskSize for non-focused task, and translate non-focused tasks to fit the grid
- As Task Rect is now vertically centered, removed ClearAllButton's grid vertical translation
- When ClearAllButton is not shown (e.g. quickswitch), make sure ClearAllButton's scroll won't be used when page snapping. This happens when page scrolls are translated so they're negative.
- Added back ActionsView when task is focused below the TaskView, which become invisible as you scroll
- In Modal state, move the ActionsView down so it won't cover the TaskView

Bug: 175939487
Test: manual
Change-Id: Idfa94a51f856418adc0503cf04211dcb4b1814fe
2021-04-01 14:52:25 +01:00
Pierre Barbier de Reuille
712a8bf004 Prevent launcher crash when an App Widget is removed.
If an App Widget with a scrollable element is removed, we may end up in
a situation where we try to draw the view directly on a canvas while the
it has already been detached from the workspace. This can crash as some
of the drawing the scroll indicators require the view to be attached.

In general, we should never draw a view by calling the draw method
directly, even more so when the view is detached: the behavior is
undefined as the method expects the canvas to be properly set up, and it
is not. A crash can therefore be expected. This patch should avoid
crashing the launcher until we stop doing that altogether.

Fix: 183386115
Test: Manally add a view with a preview layout
Test: Manually remove an app widget with a list view
Change-Id: I8e1aa581700a08d6747eab085199c2b293e0e3fb
2021-04-01 13:32:45 +01:00
TreeHugger Robot
8626706fae Merge "Move disabled test out" into sc-dev 2021-04-01 07:37:13 +00:00
Winson Chung
063e350fa3 Move disabled test out
Bug: 182844465
Test: presubmit
Change-Id: I543c43db3fb27e671eea00d112bab2a4f485dbc9
2021-04-01 04:24:46 +00:00
Winson Chung
80988abae3 Merge "Expose the full task info with the remote animation target" into sc-dev 2021-04-01 03:56:56 +00:00
TreeHugger Robot
ab9476461f Merge "Fixing all-apps appearing as blank" into sc-dev 2021-04-01 00:31:28 +00:00
Sunny Goyal
58530bd64b Fixing notification dots settings not updated properly
Also avoiding settings cache reset whenever someone registers
a new listener

Bug: 184200027
Test: Manual
Change-Id: I0c8b7084b6b4656102e9041b779b80a98624ddd8
2021-03-31 15:57:49 -07:00
Zak Cohen
31e18d6fe7 Merge "TAPL Increase size of Background to Overview swipe gesture" into sc-dev 2021-03-31 22:19:04 +00:00
Zak Cohen
b391ebf798 TAPL Increase size of Background to Overview swipe gesture
The instrumentation is using the swipe height, not width, for when in
landscape. Ideally this should be plumbed through but it isn't yet so fix
with a bigger gesture.

Test: TaplTestNexus#testBackground
Bug: 184059820
Change-Id: Id19f65f51468af707baea0a1b31569bb84f7fcb8
2021-03-31 15:10:21 -07:00
Jonathan Miranda
4c5a08e122 Merge "Only hide workspace labels if there is not enough space for it in the cell." into sc-dev 2021-03-31 22:02:40 +00:00
Sunny Goyal
0b5b8d4969 Fixing all-apps appearing as blank
Since all-apps and homescreen do not share any QSB, we can
change the alpha for hotseat QSB directly

Bug: 184122599
Test: Manual
Change-Id: Ifa610fe75ad22cfe8a7d816ed2b48e2b9411c4c1
2021-03-31 14:59:54 -07:00
Marvin Bernal
a090cfc836 Merge "Add System Back function to SystemUiProxy" into sc-dev 2021-03-31 20:59:03 +00:00
Zak Cohen
00611188e5 Merge "Overview - update UI to use solid color scrim." into sc-dev 2021-03-31 20:34:00 +00:00
Sunny Goyal
157a9ee7dd Removing some unused classes
Bug: 184183801
Test: Manual
Change-Id: I946b4b4d486d52e467bb3df7dcac65e534803b7d
2021-03-31 12:59:57 -07:00
Jonathan Miranda
f072b062a2 Merge "Folder cell should match grid cell aspect ratio if isScalableGrid is true." into sc-dev 2021-03-31 19:15:30 +00:00