Commit Graph

3664 Commits

Author SHA1 Message Date
Federico Baron
c4bb97b64e Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"
This reverts commit 2b724ec00d.

Reason for revert: cleanup

Change-Id: I59140f34ac86ef1d25e707509bd52ddeb3ddf061
2024-09-14 00:13:59 +00:00
Sebastian Franco
2b724ec00d Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Test: NA
Flag: NA
Change-Id: I86c0620d6207b09f04c8038932ed34f4444a6626
2024-04-02 11:42:17 -07:00
Jeremy Sim
da4ba9336e Merge "Reparent folders and app pairs" into main 2024-03-30 03:06:44 +00:00
Mateusz Cicheński
bc77683210 Merge "Support going home from immersive fullscreen in 3 button nav" into main 2024-03-29 23:21:23 +00:00
Jeremy Sim
742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00
Mateusz Cicheński
5f8124ad05 Support going home from immersive fullscreen in 3 button nav
In gesture nav the swipe happens at the bottom of the screen,
which brings the navbar handle into the view.

In 3 button nav the swipe needs to happen from the right edge of
the screen, because the 3 button nav is always staying fixed in
the "bottom portrait" position, unless it is large screen, in
which case it should happen on the bottom landscape edge.

This can be detected via config_navBarCanMove resource value.

Bug: 313928629
Test: atest NetflixEnterPipTest
Test: above command on foldable in folded and unfolded state
Flag: n/a

Change-Id: I0a94757687fd9eb491b2a5cf0086ae51589ae0aa
2024-03-29 17:31:29 +00:00
Brandon Dayauon
4958ecfadb Merge "Move adding views logic to privateProfileManager" into main 2024-03-29 04:03:42 +00:00
Brandon Dayauon
136f9d6f8a Move adding views logic to privateProfileManager
- Have the animation happen according to the state of private space.
- Have the transition happen only once by setting the current transition to null at the end of transition and by ensuring
where the transitions are allowed.
- Removing controller class.

- The onClick controls the enablement of the profile. On reset (when getting the transition) is what controls the animation
during expand.

tldr- In the collapse case:  execute() is called -> animation happens  -> addPsHeader
tldr- Expand case: post() is called -> addPsHeader -> animation happens.

Collapse:
onClick() -> AACV.onAppsUpdated() that resets & apply/RUNS runnable because EXECUTE
-> AAList.onAppsUpdated() (which is called at the same time animating happens which we should cancel and do at end callback)
-> AAList.onAppsUpdated() gets called again

Expand:
onCLick() -> AACV.onAppsUpdated() that resets & apply runnable
-> AAList.onAppsUpdated() (no animation running)
-> AAList.onAppsUpdated() (no animation running)
-> addPrivateSpaceHeader
-> then unlockAction() runnable because its posted at this point

bug: 326206132
bug: 330444548
bug: 299294792
Test: manually locally and presubmit: https://screenshot.googleplex.com/9wavvwKQ8hY6oUw & https://screenshot.googleplex.com/BiqmidLFjPwS28j
video: https://drive.google.com/file/d/1XGhmTncdUFtJj188_l7alGyyNz_fhXNw/view?usp=sharing

Scrolling fix before: https://drive.google.com/file/d/1XykDm4UELoCvcwZdj8ZlJ6TszptB8W0W/view?usp=sharing
scrolling fix after when not a lot of apps: https://drive.google.com/file/d/1Y4VY1eX7WE8ShSLXRrT56ieBdAuJo_zn/view?usp=sharing
scrolling fix after with a lot of apps: https://drive.google.com/file/d/1Y58c-Z9xnU1GILp0Ih-oLORXYkMB-jWn/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation

Change-Id: I8d03ae60e2c9fe0ec145c4b0a2e9604b9e6e9017
2024-03-28 17:39:42 -07:00
Sebastián Franco
0ec7c1e4a8 Merge "Generate grid migration cases and test if they are valid" into main 2024-03-28 16:31:37 +00:00
Sebastian Franco
efab2489d6 Generate grid migration cases and test if they are valid
This makes sure the grid migration logic always produces
valid results.

Bug: 313900847
Bug: 323525592
Flag: NA
Test: ValidGridMigrationUnitTest.kt
Change-Id: I76b19e1fa315f8a997afad34e5a4df7cc465b0c2
2024-03-27 14:03:07 -07:00
Uwais Ashraf
6e9927e61f Add test and android lifecycle coroutine libs
Fix: 330128421
Bug: 330127493
Test: Presubmit build passes
Flag: NA
Change-Id: I87cf3b5faaee6bcdb99c5afbe1999a11d031d98e
2024-03-27 10:23:36 +00:00
Sunny Goyal
77954bae4e Cleaning up some build configurations
> Removing Launcher3Go-without-quickstep
> Removing src_ui_overrides to src_no_quickstep
> Removing unnecessary code swpa for GO builds

Bug: 330920490
Flag: None
Test: Presubmit, everything builds
Change-Id: I5746dbc7c5a37c1d99d78b55bf2a6adce1a711c9
2024-03-26 17:16:52 +00:00
Schneider Victor-tulias
cbdf4d3eef Merge "Add debug logs for b/321775748" into main 2024-03-25 20:26:43 +00:00
Schneider Victor-tulias
d3b014ea91 Add debug logs for b/321775748
Flag: N/A
Bug: 321775748
Test: FallbackRecentsTest
Change-Id: I0dde08c4e6b2942713274d2ae29e52d5504ea25d
2024-03-25 14:24:35 -04:00
Schneider Victor-tulias
02e57b3d62 Add ExtendedLongPressTimeoutRule to all AbstractLauncherUiTest
When devices run slow in pre/post-submit, it is possible for a drag to be processed at a long press before the first move event can be created and dispatched. Added a rule to artificially increase this long press timeout in tests.

Flag: N/A
Fixes: 319257820
Test: TAPL tests
Change-Id: I24e0f3baec15db7558351d0cb2bd93a4e49640e8
2024-03-25 11:22:31 -04:00
Treehugger Robot
9a8a3091ba Merge changes from topic "revert-26664190-revert-26605558-robolectric-enable-androidx-rules-OWMAZEJUYZ-JTFGVYILBL" into main
* changes:
  Revert^2 "Move FastBitmapDrawableTest to Robolectric"
  Revert^2 "Include AndroidX test rules in Robolectric tests"
2024-03-23 00:14:35 +00:00
Priyanka Advani
7b9f1893b8 Merge "Revert "add more unit tests for WorkspaceItemProcessor"" into main 2024-03-22 20:05:32 +00:00
Priyanka Advani
d9ed5f301b Revert "add more unit tests for WorkspaceItemProcessor"
This reverts commit 13b5177a8d.

Reason for revert: Droid-monitor created revert due to test breakages in b/330906931.

Change-Id: If1afc3fb0e655ce3b1d10018723bc013ae03673e
2024-03-22 19:10:16 +00:00
Treehugger Robot
f4148a9a13 Merge "add more unit tests for WorkspaceItemProcessor" into main 2024-03-22 16:41:37 +00:00
Sebastián Franco
b55987f834 Merge "Move test failing on presubmit to postsubmit" into main 2024-03-22 16:29:24 +00:00
Charlie Anderson
13b5177a8d add more unit tests for WorkspaceItemProcessor
Bug: 294386159
Test: unit tests passing locally and in presubmit
Flag: N/A

Change-Id: Iea281418b4737c85e3cff36dc8b7f6cd6ce06a0b
2024-03-22 11:22:46 -04:00
Sebastian Franco
5103c551d3 Move test failing on presubmit to postsubmit
Bug: 316910614
Test: testResizeWidget
Flag: NA
Change-Id: I3fdc1aaab6d6479b04575f9e1540a36d5d563184
2024-03-21 17:24:27 -07:00
Sihua Ma
9b1a028bd4 Revert^2 "Move FastBitmapDrawableTest to Robolectric"
393477ca54

Change-Id: I051d2456c6930336c92ffe4c6101e6dd77a502c0
2024-03-21 21:50:20 +00:00
Sihua Ma
444b8e6d0f Revert^2 "Include AndroidX test rules in Robolectric tests"
c041b5c625

Change-Id: I0b93613ff8544cbe2a0a108da53bc085a532b074
2024-03-21 21:50:20 +00:00
Vadim Tryshev
2b9047a931 Merge "Removing SecondaryDisplayLauncherTest that are all @Ignored" into main 2024-03-21 21:06:42 +00:00
Priyanka Advani
c041b5c625 Revert "Include AndroidX test rules in Robolectric tests"
Revert submission 26605558-robolectric-enable-androidx-rules

Reason for revert: Droid-monitor created revert due to build breakages in b/330752689.

Reverted changes: /q/submissionid:26605558-robolectric-enable-androidx-rules

Change-Id: I7737d713be09faff78327df80232d084e836b500
2024-03-21 19:07:50 +00:00
Priyanka Advani
393477ca54 Revert "Move FastBitmapDrawableTest to Robolectric"
Revert submission 26605558-robolectric-enable-androidx-rules

Reason for revert: Droid-monitor created revert due to build breakages in b/330752689.

Reverted changes: /q/submissionid:26605558-robolectric-enable-androidx-rules

Change-Id: I7cb746baffc9bec3315dd324173fd9bde100e4cf
2024-03-21 19:07:50 +00:00
Vadim Tryshev
9ae560d247 Removing SecondaryDisplayLauncherTest that are all @Ignored
Bug: 241166788
Test: presubmit
Flag: N/A
Change-Id: I2288bb0178b86517c44f5c6b572eb63236bb2986
2024-03-21 11:39:12 -07:00
Sihua Ma
f62002bb7d Merge "Include AndroidX test rules in Robolectric tests" into main 2024-03-21 17:06:45 +00:00
Sihua Ma
cc54051d12 Merge "Move FastBitmapDrawableTest to Robolectric" into main 2024-03-21 17:06:45 +00:00
Federico Baron
09ec3e2623 Merge "Add screenrecord for simple reorder widgets test" into main 2024-03-21 16:12:31 +00:00
fbaron
8248279894 Add screenrecord for simple reorder widgets test
Bug: 330019521
Test: TaplReorderWidgetsTest#simpleReorder
Flag: NONE
Change-Id: Ief042efa088246f964e0b35f1c1ae10a95c5a671
2024-03-20 13:46:47 -07:00
Sunny Goyal
5ca50490a3 Making some classess accessible in multivalent tests
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I2e4b18fc279cb96b3f68d64f95703c11bb885b2a
2024-03-20 13:30:40 -07:00
Federico Baron
3a7432d782 Merge "Make touch outside container touch at the middle of the container in terms of height" into main 2024-03-20 18:08:14 +00:00
Fengjiang Li
b7e9427dc9 Merge "[Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding" into main 2024-03-20 01:21:09 +00:00
fbaron
30bd886364 Make touch outside container touch at the middle of the container in terms of height
Bug: 326839375
Test: TaplTestsQuickstep#testOverviewDeadzones
Flag: NONE
Change-Id: I7a013ab7d146756cbff009c21b838881e09e044a
2024-03-19 16:44:07 -07:00
Kevin Lim
44d9d1370c Merge "[Deviceless] Create launcher-multivalent-src for referring from NexusLauncherRoboTests" into main 2024-03-19 23:40:49 +00:00
Fengjiang Li
ea7cb497f5 [Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding
Bug: 325930715
Test: Added unit test
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I509546ac4ee1fa851cf0648d365a5348362267cc
2024-03-19 15:28:38 -07:00
Tony Wickham
86d8386ab6 Merge "Add TaplTestsQuickstep#testExcludeFromRecents" into main 2024-03-19 20:28:58 +00:00
Sihua Ma
4ff471c2f0 Move FastBitmapDrawableTest to Robolectric
Flag: N/A
Bug: 297950111
Test: atest Launcher3RoboTests
Change-Id: Icef741a1c19bb494f7b74078ce1e7f52ed55a769
2024-03-19 20:27:29 +00:00
Sihua Ma
6da8d07f83 Include AndroidX test rules in Robolectric tests
Test: atest Launcher3RoboTests
Bug: 297950111
Flag: N/A
Change-Id: I6f3c9ddeac9cb676644b3a236a00575c4faaa921
2024-03-19 20:26:40 +00:00
Kevin Lim
a14145aad4 [Deviceless] Create launcher-multivalent-src for referring from
NexusLauncherRoboTests

Bug: b/297950111
Bug: b/322393087
Flag: NA
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Change-Id: I8ac58862d53f8574a6678502fcf9488f812eaa1f
2024-03-19 20:11:37 +00:00
Tony Wickham
b84b8524a1 Add TaplTestsQuickstep#testExcludeFromRecents
- Add ExcludeFromRecentsTestActivity, and add it to the manifest
  with excludeFromRecents="true"
- Add the test to check the current Overview task content
  description, ensuring that the excludeFromRecents task is
  present directly after a gesture but not after going home.
Bug: 324495241
Flag: None
Test: TaplTestsQuickstep#testExcludeFromRecents

Change-Id: I06be53673f0ac06924f79b44f19744da066cc7ea
2024-03-18 22:30:13 +00:00
Willie Koomson
078737f22b Merge "Add tap-to-add button to widget picker" into main 2024-03-15 23:26:05 +00:00
Himanshu Gupta
13bf70c7e8 Merge "Ignoring the failing test." into main 2024-03-15 23:03:22 +00:00
Willie Koomson
cdc26951ff Add tap-to-add button to widget picker
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.

Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT

Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
Fengjiang Li
00711e68a5 Merge "Enable predictive back in TAPL tests" into main 2024-03-15 14:52:58 +00:00
Fengjiang Li
e90f098d4f Enable predictive back in TAPL tests
With ag/26349940 we have fixed the bug where back swipe is not working

Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
2024-03-15 00:00:37 -07:00
Himanshu Gupta
0f1fe9722f Ignoring the failing test.
LauncherIntentTest#testAllAppsIntent is a newly added
TAPL test that seems to be breaking on a few devices.

Disabling it until the root issue is fixed.

Bug: 329152799
Test: Manual
Flag: NA
Change-Id: I3c1d145a444d4d2a85b3f5d2a968d120eee7cca0
2024-03-14 13:53:38 -07:00
Sebastián Franco
892ffb8b15 Merge "Making 2 flags read only since they are used on backup and restore" into main 2024-03-14 20:12:05 +00:00