Commit Graph

74979 Commits

Author SHA1 Message Date
Federico Baron
c4bb97b64e Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"
This reverts commit 2b724ec00d.

Reason for revert: cleanup

Change-Id: I59140f34ac86ef1d25e707509bd52ddeb3ddf061
2024-09-14 00:13:59 +00:00
Sebastian Franco
2b724ec00d Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Test: NA
Flag: NA
Change-Id: I86c0620d6207b09f04c8038932ed34f4444a6626
2024-04-02 11:42:17 -07:00
Liran Binyamin
1bc33421de Merge "Initial animation of new bubble bar bubble" into main 2024-04-01 17:54:59 +00:00
Ats Jenk
599ed3ba06 Merge "Create drop target for bubble bar" into main 2024-04-01 17:14:55 +00:00
Jeremy Sim
6c585ca7d7 Merge "Update save app pair icon" into 24D1-dev am: 370d05a276
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26743078

Change-Id: I35ba86a1e032467a3bbc1775bf3a4271533060f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-30 03:49:36 +00:00
Jeremy Sim
370d05a276 Merge "Update save app pair icon" into 24D1-dev 2024-03-30 03:36:21 +00:00
Jeremy Sim
da4ba9336e Merge "Reparent folders and app pairs" into main 2024-03-30 03:06:44 +00:00
Mateusz Cicheński
bc77683210 Merge "Support going home from immersive fullscreen in 3 button nav" into main 2024-03-29 23:21:23 +00:00
Jeremy Sim
742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00
Automerger Merge Worker
adf1df2e7e Merge changes from topic "am-d6f679a9148840b4beaadf3677246075" into main
* changes:
  [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: ff0d5f0b6a -s ours
  [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 2e779a3301 -s ours
  [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a8c1f8aca3 -s ours
2024-03-29 22:37:12 +00:00
Treehugger Robot
2bdd3bddef [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: ff0d5f0b6a -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26750325

Change-Id: I6be449ed42a512f84f96ec8150521a240c842b87
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-29 22:36:31 +00:00
Bill Yi
825bc026f9 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 2e779a3301 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26750325

Change-Id: I97f2a509a2c58174b3a4fba493c71cc157c44736
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-29 22:36:24 +00:00
Treehugger Robot
124a9596b6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-29 22:36:18 +00:00
Treehugger Robot
9f599f0636 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-29 22:36:18 +00:00
Bill Yi
1de3231787 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a8c1f8aca3 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26745380

Change-Id: I44a63130f477d2528710a41fc120c712ad919689
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-29 22:36:13 +00:00
Treehugger Robot
ff0d5f0b6a Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-03-29 22:17:51 +00:00
Mateusz Cicheński
5f8124ad05 Support going home from immersive fullscreen in 3 button nav
In gesture nav the swipe happens at the bottom of the screen,
which brings the navbar handle into the view.

In 3 button nav the swipe needs to happen from the right edge of
the screen, because the 3 button nav is always staying fixed in
the "bottom portrait" position, unless it is large screen, in
which case it should happen on the bottom landscape edge.

This can be detected via config_navBarCanMove resource value.

Bug: 313928629
Test: atest NetflixEnterPipTest
Test: above command on foldable in folded and unfolded state
Flag: n/a

Change-Id: I0a94757687fd9eb491b2a5cf0086ae51589ae0aa
2024-03-29 17:31:29 +00:00
Treehugger Robot
520d91f93b Merge "Don't toggle scrollbar during predicitve back swipe to avoid flicker" into main 2024-03-29 09:56:10 +00:00
Brandon Dayauon
4958ecfadb Merge "Move adding views logic to privateProfileManager" into main 2024-03-29 04:03:42 +00:00
Brandon Dayauon
391e53d2fc Merge "Fix private space settings cog margin" into main 2024-03-29 01:08:43 +00:00
Brandon Dayauon
136f9d6f8a Move adding views logic to privateProfileManager
- Have the animation happen according to the state of private space.
- Have the transition happen only once by setting the current transition to null at the end of transition and by ensuring
where the transitions are allowed.
- Removing controller class.

- The onClick controls the enablement of the profile. On reset (when getting the transition) is what controls the animation
during expand.

tldr- In the collapse case:  execute() is called -> animation happens  -> addPsHeader
tldr- Expand case: post() is called -> addPsHeader -> animation happens.

Collapse:
onClick() -> AACV.onAppsUpdated() that resets & apply/RUNS runnable because EXECUTE
-> AAList.onAppsUpdated() (which is called at the same time animating happens which we should cancel and do at end callback)
-> AAList.onAppsUpdated() gets called again

Expand:
onCLick() -> AACV.onAppsUpdated() that resets & apply runnable
-> AAList.onAppsUpdated() (no animation running)
-> AAList.onAppsUpdated() (no animation running)
-> addPrivateSpaceHeader
-> then unlockAction() runnable because its posted at this point

bug: 326206132
bug: 330444548
bug: 299294792
Test: manually locally and presubmit: https://screenshot.googleplex.com/9wavvwKQ8hY6oUw & https://screenshot.googleplex.com/BiqmidLFjPwS28j
video: https://drive.google.com/file/d/1XGhmTncdUFtJj188_l7alGyyNz_fhXNw/view?usp=sharing

Scrolling fix before: https://drive.google.com/file/d/1XykDm4UELoCvcwZdj8ZlJ6TszptB8W0W/view?usp=sharing
scrolling fix after when not a lot of apps: https://drive.google.com/file/d/1Y4VY1eX7WE8ShSLXRrT56ieBdAuJo_zn/view?usp=sharing
scrolling fix after with a lot of apps: https://drive.google.com/file/d/1Y58c-Z9xnU1GILp0Ih-oLORXYkMB-jWn/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation

Change-Id: I8d03ae60e2c9fe0ec145c4b0a2e9604b9e6e9017
2024-03-28 17:39:42 -07:00
Brandon Dayauon
7e50fa9624 Fix private space settings cog margin
Inset on the lock button already exists, so in reality there are 4dp +
8dp margin from the settings button. To fix this, we can just reduce
8dp -> 4dp on the settings button.

bug: 331742915
Test: before: https://drive.google.com/file/d/1z6-U5eO5oM6h6uULNdmJciMCP_F33rDn/view?usp=sharing
after: https://drive.google.com/file/d/1yzCysJRaRKDp0kivhi6GWE83qsloh39U/view?usp=sharing
Flag: none
Change-Id: Iafb1101b8029398c139ba02f31a027db272132f3
2024-03-28 22:01:55 +00:00
Ats Jenk
f221b8a7de Create drop target for bubble bar
When dragging bubble bar in launcher, show drop target when drag passes
middle of the screen.

Bug: 330585397
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual
Change-Id: I52c3e9ac0b7c36e2207640baf75dc44300b522ef
2024-03-28 14:21:33 -07:00
Stefan Andonian
f6867d48d9 Merge "Make "Undo" button not be long-clickable explicitly." into main 2024-03-28 20:00:11 +00:00
Stefan Andonian
462c80831c Merge "Explicitly set the Hotseat to not long or short clickable." into main 2024-03-28 19:59:27 +00:00
Bill Yi
a8c1f8aca3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I05ace27fef4679f480b62d861c341b57d554a9b9
2024-03-28 12:08:33 -07:00
Bill Yi
c18cafda4a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I725d6479c36e7ee0e9978eef413a76dd431aa67d
2024-03-28 12:08:06 -07:00
Bill Yi
2e779a3301 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I76dd0d716268b03eddb9f4fadee7b7f186505d7b
2024-03-28 12:07:12 -07:00
Bill Yi
fb288950d3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I29eec7ffbf29c7498b9ece028ae2584d09677420
2024-03-28 12:06:48 -07:00
Sebastián Franco
0ec7c1e4a8 Merge "Generate grid migration cases and test if they are valid" into main 2024-03-28 16:31:37 +00:00
Liran Binyamin
074a3a66b0 Initial animation of new bubble bar bubble
This change animates a new bubble bar bubble. Currently only handles the case where the bubble is added when the bubble bar is stashed.
There's no synchronization with the stash handle yet either.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Test: atest BubbleBarViewAnimatorTest
Change-Id: Ic3f5edc0dde204f871cf7e1288bd50620e6beebb
2024-03-28 11:30:56 -04:00
Uwais Ashraf
1e6d1112ba Merge "Add test and android lifecycle coroutine libs" into main 2024-03-28 14:04:29 +00:00
Uwais Ashraf
1a4052a44f Merge "Remove unused code and fix warnings" into main 2024-03-28 14:03:36 +00:00
Alex Chau
cf452cbb3b [automerger skipped] Align action_buttons at bottom of OverviewActionsView am: 3c34c89cca -s ours
am skip reason: Merged-In Iadcdf5731485f42f9586703e34e55ed9b4121bf9 with SHA-1 6431d6e879 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26748369

Change-Id: Icc22d3c9da0ed1d75a1a20fd91e95ae4287b74c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 13:40:53 +00:00
Alex Chau
ff7ec04234 [automerger skipped] Revert "Log split button visibility to debug spacing issue" am: 2165ad7b0e -s ours
am skip reason: Merged-In I88a4350277ea3e965493da6386cf4c83c5c564e4 with SHA-1 a5d55fe5ef is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26745016

Change-Id: I7bfe12c11511cc704f853059c6904c54f4edbd7f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 13:10:54 +00:00
Alex Chau
3c34c89cca Align action_buttons at bottom of OverviewActionsView
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct

Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6431d6e87910bc7c7767c40d42f51961dc462134)
Merged-In: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
2024-03-28 13:03:03 +00:00
Alex Chau
76d04b46df Merge "Align action_buttons at bottom of OverviewActionsView" into main 2024-03-28 13:00:11 +00:00
Alex Chau
2165ad7b0e Revert "Log split button visibility to debug spacing issue"
This reverts commit 2d55c9c679.

Reason for revert: Logs not helpful in figuring out the issue and is too spammy
Bug: 321291049
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a5d55fe5efad4db1678dfe7960f82df68b664b7d)
Merged-In: I88a4350277ea3e965493da6386cf4c83c5c564e4
Change-Id: I88a4350277ea3e965493da6386cf4c83c5c564e4
2024-03-28 12:13:30 +00:00
Alex Chau
c7dea26289 Merge "Revert "Log split button visibility to debug spacing issue"" into main 2024-03-28 12:12:29 +00:00
Jeremy Sim
de9b132f08 Update save app pair icon
This CL changes the save app pair menu icon to the latest spec. It looks good!

Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
(cherry picked from commit 1d48159bd5)
2024-03-28 04:44:18 +00:00
Jeremy Sim
75216f9108 Merge "Fix bug with long strings not aligning left on menu items" into main 2024-03-28 01:45:15 +00:00
Jeremy Sim
c61f4ede3c Merge "Update save app pair icon" into main 2024-03-28 01:44:55 +00:00
Fengjiang Li
61102b66e8 Merge "Extend CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK to start as early as when user starts predictive back swipe" into main 2024-03-28 01:02:00 +00:00
Luca Zuccarini
b65bc82efb Merge "Move interfaces to the shared library." into main 2024-03-28 00:17:47 +00:00
Andy Wickham
355d4e25c7 [automerger skipped] Merge "Consolidate settings for Assist." into 24D1-dev am: d6b0dc8970 -s ours
am skip reason: Merged-In Id4463345c44fa4daba4eac67b5ad00aff7f3a606 with SHA-1 3081537398 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26652400

Change-Id: I9de3a0741557c8a308a19d5ddb6c23c2cdf6ecac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 00:09:27 +00:00
Andy Wickham
61696f901a [automerger skipped] Consolidate settings for Assist. am: 88972311a2 -s ours
am skip reason: Merged-In Id4463345c44fa4daba4eac67b5ad00aff7f3a606 with SHA-1 3081537398 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26652400

Change-Id: I18c2bee1e18f72e1ab01240cbcea61c9e27352cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 00:09:24 +00:00
Andy Wickham
d6b0dc8970 Merge "Consolidate settings for Assist." into 24D1-dev 2024-03-27 23:56:23 +00:00
Fengjiang Li
10c03e499d Extend CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK to start as early as when user starts predictive back swipe
Bug: 330405993
Test: prefetto trace https://ui.perfetto.dev/#!/?s=58c0513fe0190f84ea1621a96d790a53b83fefc1ee402085b0d75bfc7b51e019
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I76c32975e5ae6dcb0395d2eee68417f761455262
2024-03-27 16:03:47 -07:00
Sebastian Franco
efab2489d6 Generate grid migration cases and test if they are valid
This makes sure the grid migration logic always produces
valid results.

Bug: 313900847
Bug: 323525592
Flag: NA
Test: ValidGridMigrationUnitTest.kt
Change-Id: I76b19e1fa315f8a997afad34e5a4df7cc465b0c2
2024-03-27 14:03:07 -07:00
Brandon Dayauon
8838a68cbe [automerger skipped] Disable two line text legacy flag. am: 50f9dbd0a5 -s ours
am skip reason: Merged-In Idef427bad6551ae56b13e35393e076b8e000af5a with SHA-1 68c18236ad is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26733768

Change-Id: If1705f04d5dd2b94bb7661c80e532295defce197
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-27 20:30:55 +00:00