Commit Graph

72336 Commits

Author SHA1 Message Date
Uwais Ashraf
c1eecf21e9 Merge "[Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp." into main 2023-10-17 14:09:47 +00:00
Riddle Hsu
a60c091c94 Merge "Finish recents animation for standalone recents on home" into main 2023-10-17 10:56:28 +00:00
Anushree Ganjam
6ee3a32b12 [Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp.
Bug: 294913042
Flag: NA
Test: Unit tests
Change-Id: Ib570ce67f53d4af7407b36f6fee1a3517800155f
2023-10-17 10:27:54 +00:00
Riddle Hsu
aeb3ff6b5c Finish recents animation for standalone recents on home
(This is to reland with fixing FallbackRecentsTest#testOverview
by excluding fallback overview panel which doesn't show visual
difference from AnomalyDetector)
There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.

Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.

Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.

Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.

This can also fix various issues when using a 3p launcher:
 - When auto rotation is enabled and put device in landscape:
    - Unable to enter recents from gesture mode
    - System bars are disappeared when pressing recents key
 - Jump-cut when pressing home key to leave recents on home.

Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
      The app should not receive onPause.
Change-Id: I387fcb26aa01072dfd5a215107c9c15b28513a82
2023-10-17 05:45:16 +00:00
Fengjiang Li
c4f9dd2c04 Merge "Double pre-inflate counts if work profile is enabled" into main 2023-10-16 21:36:52 +00:00
Pat Manning
d0bf41bcc6 Set FastBitmapDrawable's badge alpha when updating drawable alpha. am: 08f89425bb am: 43f230bcc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25058707

Change-Id: Ied1832fbaf8d95f23283e6e6201d97dfc41822f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-16 21:13:43 +00:00
Pat Manning
43f230bcc8 Set FastBitmapDrawable's badge alpha when updating drawable alpha. am: 08f89425bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25058707

Change-Id: Id7103d1ac790e02434df1a891913d70ba9c67280
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-16 20:44:43 +00:00
Alex Chau
d7bd142267 Merge "Avoid drawing live tile behind recents when launching on grid overview" into main 2023-10-16 19:48:23 +00:00
Sebastián Franco
879efc7b2a Merge "Cleaning up some and removing unused calculations code in CellLayout" into main 2023-10-16 18:35:56 +00:00
Alex Chau
1f5de2483b Avoid drawing live tile behind recents when launching on grid overview
Fix: 304911154
Flag: none
Test: Swipe up in tablet, scroll to side, launch focused task
Change-Id: I91dd8b4088f02af9dc5e603853d8e26606acc38f
2023-10-16 18:27:10 +01:00
Shan Huang
90f17d44d2 Merge "Fix scrim attachment and detachment issues." into main 2023-10-16 17:17:14 +00:00
Pat Manning
7365f575e1 Merge "Fix condition checking that scale of taskbar changes on hover." into main 2023-10-16 15:49:22 +00:00
Pat Manning
02eab16f2d Fix condition checking that scale of taskbar changes on hover.
Fix: 304455999
Test: TaplTestsTransientTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I95e6a5a34c433b5fbe19b9dbcc9c6b7b8bdc43a7
2023-10-16 14:22:00 +01:00
Pat Manning
08f89425bb Set FastBitmapDrawable's badge alpha when updating drawable alpha.
Test: FastBitmapDrawableTest
Fix: 304559962
Change-Id: Ie545cc5da506c77af18f99b5d045cafc37110a5a
2023-10-16 09:52:06 +00:00
Alex Chau
74e68c69e8 Merge "Use SandboxContext in AbstractDeviceProfileTest" into main 2023-10-16 09:41:59 +00:00
Uwais Ashraf
d174fcaa99 Merge "Revert "Finish recents animation for standalone recents on home"" into main 2023-10-16 08:57:59 +00:00
Uwais Ashraf
35af2d967c Revert "Finish recents animation for standalone recents on home"
Revert submission 24941288-b302703228

Reason for revert: Most likely cause of droidmonitored test failures. b/305629625. Original change was merged at this point https://screenshot.googleplex.com/99p3F266XUYYbA2 causing a 100% failure on main.

Reverted changes: /q/submissionid:24941288-b302703228

Bug: 305629625

Change-Id: Id27c68ec70410d16aeae3bde8b361d9b347ec7eb
2023-10-16 08:56:24 +00:00
Riddle Hsu
290aa6f266 Merge "Finish recents animation for standalone recents on home" into main 2023-10-16 05:46:48 +00:00
Sebastián Franco
c3a2919fd1 Merge "Moving getPagesToBindSynchronously to ModelCallbacks" into main 2023-10-13 23:49:02 +00:00
Tracy Zhou
6bfdfd011b Merge "Correct signal for showing contextual buttons for taskbar" into main 2023-10-13 21:04:13 +00:00
Shan Huang
b78f7de733 Fix scrim attachment and detachment issues.
Attaching: The surface control from Launcher's ViewRootImpl is
occiasionally invalid when back gesture starts, and parenting scrim to
it would fail. We work around this by retrying later on back progressed.

Dettaching: The scrim is not detached in all code paths. We now always
check and detach in finishAnimation() if needed.

This also fixes a possible flicker at the beginning of the transition.
We wait until Launcher is started (and draws at least one frame) to animate the top window.

Test: m -j
Test: Repeatedly trigger back to home animation. Make sure the scrim
attaches and detaches always.

Bug:271606843
Bug:297808832
Bug:217988970
Fixes:271606843
Fixes:297808832
Fixes:217988970

Change-Id: I8b9b023f1fd54bcedd0be15196165e19e8400af7
2023-10-13 13:51:46 -07:00
Jon @
189fc92d90 Merge "Fix bug where All Apps button loads in late in taskbar." into udc-qpr-dev am: 5838767cc2 am: 9f3945cfff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25021492

Change-Id: Iac125aa58535a5d6e23f8b05ba37d291aa8af559
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-13 19:29:25 +00:00
Jon @
9f3945cfff Merge "Fix bug where All Apps button loads in late in taskbar." into udc-qpr-dev am: 5838767cc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25021492

Change-Id: I027ebf7933332b48434144f9776fb8a29c783fb6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-13 18:58:06 +00:00
Jon @
5838767cc2 Merge "Fix bug where All Apps button loads in late in taskbar." into udc-qpr-dev 2023-10-13 18:37:04 +00:00
Sebastian Franco
69fd742a60 Moving getPagesToBindSynchronously to ModelCallbacks
Changes are part of go/launcher_SoR .

Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I5e57b73edfa23e9f12ea94c0f9c5005e2d8fccd2
2023-10-13 11:34:23 -07:00
Sebastián Franco
87d482cd3e Merge "Unifying constant app names used in Tests" into main 2023-10-13 18:28:38 +00:00
Sebastian Franco
0dd5db84e4 Cleaning up some and removing unused calculations code in CellLayout
Using cellToRect and removing some calculation that where unnecesary
because the variable are later overwritten.

Fix: 194414754
Bug: 294841331
Test: ImageTest
Change-Id: I31e0527cbbea463a32a36a172185a41985ed0d57
2023-10-13 18:24:41 +00:00
Ats Jenk
a89365c2be Merge "Use desktop mode flag for split logic" into main 2023-10-13 18:00:53 +00:00
Schneider Victor-tulias
a96537fa65 Merge "Increase the ActiveGestureLog tracked gesture limit" into main 2023-10-13 16:08:32 +00:00
Fengjiang Li
c83d96daea Merge "Trace unlock animation progress" into main 2023-10-13 15:35:11 +00:00
Jeremy Sim
20410d25f9 Merge "Migrate ENABLE_APP_PAIRS flag to aconfig" into main 2023-10-13 05:22:36 +00:00
Sunny Goyal
73c9ef3368 Merge "Generalize userproperties to support for more user types in iconCache" into main 2023-10-13 01:13:11 +00:00
Hyunyoung Song
b1126a221a Merge "Add flag_check.py to the preupload" into main 2023-10-12 23:30:19 +00:00
Ats Jenk
cd789874c3 Use desktop mode flag for split logic
Remove launcher specific split from desktop flag and use the desktop
windowing feature flag.

Bug: 305095670
Flag: persist.wm.debug.desktop_mode_2
Test: enable desktop mode flag, toggle split from a desktop task
Change-Id: I62b91de3deaa5bba3435faf3a268f5b58cda8276
2023-10-12 23:28:42 +00:00
Vadim Tryshev
aa5070f7e3 Merge "Adding an annotation for tests that change nothing on screen and may produce no view capture data" into main 2023-10-12 23:19:51 +00:00
Jeremy Sim
7dc3bdcd85 Migrate ENABLE_APP_PAIRS flag to aconfig
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
fbaron
6ebfd954df Add NullPointerException to try/catch since it's possible to have such an error am: 9ffd90a85b am: eb8d8e8066
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25031355

Change-Id: I54d0ea98c0cc4219726a9dc2f12634ca214c0486
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-12 21:56:16 +00:00
Sunny Goyal
c173c04422 Generalize userproperties to support for more user types in iconCache
Bug: 305062259
Flag: None
Test: Presubmit
Change-Id: I35cd20a03520ada233809930fcc56cdea1dabec6
2023-10-12 21:25:59 +00:00
fbaron
eb8d8e8066 Add NullPointerException to try/catch since it's possible to have such an error am: 9ffd90a85b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25031355

Change-Id: I935bb241e0b08ddb806f32d233ee359355d95df9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-12 21:23:31 +00:00
Sunny Goyal
4588031286 Merge "Moving onboarding prefs to use LauncherPrefs" into main 2023-10-12 20:51:45 +00:00
Jon @
5cae6965ae Merge "Fix bug where All Apps button loads in late in taskbar." into main 2023-10-12 20:10:11 +00:00
Tyler Freeman
22781d97d9 Merge "Revert "Combine icon app tests to allow overriding flag for new ..."" into main 2023-10-12 20:06:56 +00:00
Schneider Victor-tulias
912b37e45c Increase the ActiveGestureLog tracked gesture limit
Many bugs are coming in where the logs only start shortly after the bug repro. Increasing the limit to capture these logs more reliably.

Flag: not needed
Bug: 303424896
Test: printed gesture logs
Change-Id: I9d02108c7d0def3c0280a2ca6d84aa3c3773b1a7
2023-10-12 14:31:25 -04:00
Fengjiang Li
25b1675d21 Trace unlock animation progress
The unlock animation is subject to interruption from sysui. Adding trace would help us find root cause easier in the future.

Bug: 301903832
Test: grab perfetto trace and verify the unlock progress is shown
Change-Id: Iab0ca483beb01752b1dd67bd28f401d3e2e9cef7
2023-10-12 11:22:57 -07:00
Vadim Tryshev
ec072e081b Adding an annotation for tests that change nothing on screen and may produce no view capture data
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I3a6822648981400a426a09315aba36cb4977e6e9
2023-10-12 18:07:20 +00:00
Tyler Freeman
1468467706 Revert "Combine icon app tests to allow overriding flag for new ..."
Revert submission 25007147-tapl-flag

Reason for revert: Breaks build: https://b.corp.google.com/issues/305033049

Reverted changes: /q/submissionid:25007147-tapl-flag

Change-Id: I99b5883e64ae25476394a4207c5d6a4d22fc27dc
2023-10-12 18:04:05 +00:00
Tracy Zhou
f11604ee49 Correct signal for showing contextual buttons for taskbar
Apparently isContextualButtonShowing is not the right signal. Checking on dp.isGestureMode instead

Fixes: 300849078
Test: manual
Change-Id: Iac44bb4adbbdd5faf52100c88c2a4a6d95d58b98
2023-10-12 10:43:46 -07:00
hyunyoungs
2a165ae76d Add flag_check.py to the preupload
Bug: 273661677
Test: repo upload .
Flag: not needed, python script for repo hook
Change-Id: Ieb48c7ab59b2dffbbf47e3ee0a45698e9adfda9c
2023-10-12 17:38:33 +00:00
Pat Manning
18ce47f535 Merge "Set FastBitmapDrawable's badge alpha when updating drawable alpha." into main 2023-10-12 17:32:30 +00:00
Jon Miranda
330b7754c6 Fix bug where All Apps button loads in late in taskbar.
We need to re-create the icon alignment controller if the
stash status changes, otherwise it will use an old value.

Bug: 296414290
Test: home to app then quickly unstash
Change-Id: I35f23842f289fce95d102a9a93dc94cd033fa8cc
2023-10-12 17:14:49 +00:00