Commit Graph

331 Commits

Author SHA1 Message Date
Brian Isganitis
b21ad2da8c Implement initial transient Taskbar EDU tooltips.
Since this tooltip looks and behaves differently than the existing EDU
sheet, it has its own view and controller implementations (I also may
have wanted to write some Kotlin).

To keep transient taskbar open while on the second EDU step, another
autohide suspend flag is defined. Additionally, special casing is added
to avoid hiding transient taskbar if autohiding is currently suspended.

Tooltips use the same assets as the bottom sheet for now, and are scaled
down to fit the tooltip dimensions.

Reset `Taskbar Education` in Developer Options to try EDU again.

[Demos]
- First: https://screenshot.googleplex.com/ASBeGvrb2EA5wEF.png
- Second: https://screenshot.googleplex.com/7fnfcTh9bMYezDc.png

Test: Manual
Test: Open app, see swipe-up tooltip.
Test: Swipe up to show transient taskbar, see features tooltip.
Bug: 263157739
Fix: 258460203
Change-Id: I473f5fccbae279db0614763b640da0a120b6b7f7
2023-01-20 15:16:12 -08:00
Johannes Gallmann
c047a8885c Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7 am: f2709309bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: I13c25d2e87498a6a28dd018dacf6451cbaabb092
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:49:01 +00:00
Johannes Gallmann
f2709309bb Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: Ia1e8d8830a99268870f4c9f3cf59ca5d32a731b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 17:55:35 +00:00
Johannes Gallmann
4aa135f3c7 Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev 2023-01-13 17:28:42 +00:00
Johannes Gallmann
031fbcc564 Prevent workspace enter animation for predictive back
Bug: 263913711
Test: Manual, i.e. testing predictive back for four scenarios: Back to all apps, Back to home. Both with the closed app icon visible or not.
Change-Id: Id87686098e6ad413819dc75545071da00291db65
2023-01-12 10:06:18 +01:00
Luca Zuccarini
bbcd92caab Merge "Make LauncherAnimationRunner compatible with RemoteAnimationRunner." into tm-qpr-dev am: d23cd42875 am: 2192689237
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20836635

Change-Id: Ic5f8ccc13e5ec0907dd50dac344a8ce55cef8c5e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 14:48:40 +00:00
Luca Zuccarini
2192689237 Merge "Make LauncherAnimationRunner compatible with RemoteAnimationRunner." into tm-qpr-dev am: d23cd42875
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20836635

Change-Id: I8ce7a076dc78912445c56a2d39369ad611631e5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 14:12:02 +00:00
Luca Zuccarini
3913716ece Make LauncherAnimationRunner compatible with RemoteAnimationRunner.
Nothing changes in its current usage and behavior, but instead of a
RemoteAnimationFactory we can now also pass a RemoteAnimationRunner.

Bug: 250588519
Test: manual
Change-Id: I51f5a95360401d5f17104519ef91a81aef60923f
2023-01-05 14:12:13 +00:00
TreeHugger Robot
7b7253db66 Merge "Fade in/out taskbar when launching apps from or back to AllApps/-1" into tm-qpr-dev am: c10a003aa0 am: 979fa6725c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411894

Change-Id: I8afb35dee1feb91b2b27563efd1c58efc51d97c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 13:04:33 +00:00
TreeHugger Robot
979fa6725c Merge "Fade in/out taskbar when launching apps from or back to AllApps/-1" into tm-qpr-dev am: c10a003aa0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411894

Change-Id: Idbed5a030b1e000a250c1a59446553ab7b4dc73d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-02 12:28:57 +00:00
Alex Chau
cd76ac24b6 Fade in/out taskbar when launching apps from or back to AllApps/-1
- Added isHotseatIconTopWhenAligned to control both iconAlignment and stash animation to just fade in if hotseat icon isn't on top of the screen in the aligned state

Fix: 257355864
Fix: 213455090
Test: Launch apps from/back to home, taskbar animate from/to hotseat
Test: Launch apps from/back to AllApps/-1, taskbar fade in/out
Test: Repeat aboth with transient or persistent taskbar
Change-Id: I6bdae615ff9e199d23cbfe2d26c8d46a08fbc436
2022-12-01 18:56:30 +00:00
TreeHugger Robot
1450e67a32 Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev am: 104517cefb am: 3ea711d992
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411886

Change-Id: I17213ea8abe889aa6498da94ec543514202af6fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 19:26:30 +00:00
TreeHugger Robot
3ea711d992 Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev am: 104517cefb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411886

Change-Id: I0a4f2a8755c49d230417c9b71afaa9ccd6ff410d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-21 18:49:35 +00:00
TreeHugger Robot
104517cefb Merge "Fix janky close animation when taskbar is unstashed" into tm-qpr-dev 2022-11-21 18:30:19 +00:00
Alex Chau
aee9c12a8b Fix janky close animation when taskbar is unstashed
- Updated startRect for close animation when taskbar is unstashed

Fix: 258167450
Test: Use back gesture to close app when taskbarw is stashed or unstashed
Change-Id: I56913c2770024bcb47a74c28941bc59f60b4666b
2022-11-17 10:57:40 +00:00
TreeHugger Robot
421eac46b3 Merge "Update transient taskbar transition duration to match spec (417ms)." into tm-qpr-dev am: 1b30bab1e1 am: 7d385f3135
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469888

Change-Id: I7616c8adc7837475649312216c1dca6dcd78803e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 03:28:55 +00:00
TreeHugger Robot
7d385f3135 Merge "Update transient taskbar transition duration to match spec (417ms)." into tm-qpr-dev am: 1b30bab1e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469888

Change-Id: Ia7df964eabebe9816099b5ca0d1689dcc9cc7f3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 03:03:23 +00:00
Jon Miranda
5eba9000df Update transient taskbar transition duration to match spec (417ms).
Bug: 246632728
Bug: 246641848
Test: manual
Change-Id: If3f73774444c6074a81101d91d291ef33edcaf9c
2022-11-14 12:28:20 -08:00
Sunny Goyal
ac725654dd Merge "Removing RemoteTransitionCompat and related wrappers" into tm-qpr-dev am: fc01c382bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20275893

Change-Id: Id2f05ba29fc0c5f65074f1a9f3b3f100db12b1fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 17:24:28 +00:00
Sunny Goyal
fc01c382bf Merge "Removing RemoteTransitionCompat and related wrappers" into tm-qpr-dev 2022-11-03 16:40:27 +00:00
Sunny Goyal
a084dbd3bd Merge "Fixing background jump when closing a widget" into tm-qpr-dev am: 031ee4cbcb am: 6988b7b308
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20304438

Change-Id: I578ef759545b5bebcf314a2022f99e428bb7ee1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 02:02:24 +00:00
Sunny Goyal
6988b7b308 Merge "Fixing background jump when closing a widget" into tm-qpr-dev am: 031ee4cbcb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20304438

Change-Id: I3d706ddc9847d75f4a5db5966675aa1d7f2be39d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 01:14:26 +00:00
Sunny Goyal
1319de88b4 Removing RemoteTransitionCompat and related wrappers
Bug: 221961069
Test: Presubmit
Change-Id: Ib93640d27a9eb0401882574e37b466163dafa5b3
Merged-In: Ib93640d27a9eb0401882574e37b466163dafa5b3
2022-11-02 23:40:48 +00:00
Sunny Goyal
39b07fd66c Fixing background jump when closing a widget
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
2022-11-02 19:17:18 +00:00
Sunny Goyal
b4f2568c69 Removing RemoteTransitionCompat and related wrappers
Bug: 221961069
Test: Presubmit
Change-Id: Ib93640d27a9eb0401882574e37b466163dafa5b3
2022-11-02 02:51:36 +00:00
Jon Miranda
aa2ef5c4bd Merge "Add transient taskbar UI" into tm-qpr-dev am: 661f38cdb8 am: e095ae843f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20197462

Change-Id: I5b170eca6e19ce8e771d3dea7994cb6b3750e2a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-26 15:59:32 +00:00
Jon Miranda
e095ae843f Merge "Add transient taskbar UI" into tm-qpr-dev am: 661f38cdb8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20197462

Change-Id: I91430a307d76ec249f1f5b711a03fbaffefd6351
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-26 15:22:03 +00:00
Jon Miranda
661f38cdb8 Merge "Add transient taskbar UI" into tm-qpr-dev 2022-10-26 14:56:15 +00:00
Sunny Goyal
c5d63bcac5 Merge "Merging MultiValueAlpha with MultiPropertyFactory" into tm-qpr-dev am: 3912808183 am: 34da3ed6df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944063

Change-Id: Iecd1429f926172eea4c551667d7995c1a9750bc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 23:12:13 +00:00
Sunny Goyal
34da3ed6df Merge "Merging MultiValueAlpha with MultiPropertyFactory" into tm-qpr-dev am: 3912808183
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944063

Change-Id: Ia9d46bc255560cd4b8801158db4510ffcae2d7bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 22:17:40 +00:00
Jon Miranda
184a04266d Add transient taskbar UI
This change is only for the visual appearance of the
transient taskbar.

Bug: 252905206
Test: manual
Change-Id: I4990b20b39089a0c27ec2a72dd3010cf64ddba1d
2022-10-25 13:46:19 -07:00
TreeHugger Robot
b4977f4f38 Merge "Removing unnecessary RemoteAnimationTargetCompat" into tm-qpr-dev am: b9bced07c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20239831

Change-Id: I435e09e315997ed9ac0cdf3e691a6573371a7ce6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 21:43:02 +00:00
Sunny Goyal
d859060860 Merging MultiValueAlpha with MultiPropertyFactory
Bug: 246644619
Test: Presubmi
Change-Id: Id5abc5f3169544656f1139ae17ca59e34ac65dac
2022-10-24 14:38:18 -07:00
Sunny Goyal
8a11443333 Removing unnecessary RemoteAnimationTargetCompat
Merged-In: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
2022-10-24 17:17:36 +00:00
Sunny Goyal
0d77cd7166 Merge "Removing unnecessary RemoteAnimationTargetCompat" 2022-10-24 17:16:49 +00:00
Treehugger Robot
5f65096bfe Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3 am: 14946c1fa3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: Id765742b2e4767888137a01116f2bad1bba859a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:32:40 +00:00
Treehugger Robot
14946c1fa3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I748f2372116aa8bba282a0f1925e3968a9fed0ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:16:08 +00:00
Treehugger Robot
533b937fd3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I6b47e8706afe05f5fdac403e79c87a533fbcc2c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 22:45:27 +00:00
Sunny Goyal
a18e285fe7 Removing unnecessary RemoteAnimationTargetCompat
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
2022-10-20 16:25:21 +00:00
Sunny Goyal
361da47493 Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev am: d79f84fffe am: cc6290d81f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20215466

Change-Id: Iee38fc975ce911b3a0fa3b43a97047dd094ce956
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 01:33:32 +00:00
Sunny Goyal
d79f84fffe Merge "Revert "Revert "Using Transaction directly instead of building s..."" into tm-qpr-dev 2022-10-20 00:26:13 +00:00
TreeHugger Robot
8831852781 Merge "Decouple taskbar background from overveiw scrim if taskbar is in overview" into tm-qpr-dev am: 913b5afb43 am: e260265fe2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20189272

Change-Id: I38e2678daed46f612f14470b8c9629da27604405
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 18:33:18 +00:00
Sunny Goyal
dd11f089cc Revert "Revert "Using Transaction directly instead of building s..."
Revert^2 "Removing unused surface transaction wrappers"

2460910c8c454bc2d3c9ae35bd32eeb590851788

Bug: 221961069
Test: Presubmit
Change-Id: I0028c9fe0de6fde6a77de84e4858fda14cd578dd
2022-10-18 16:30:26 +00:00
Cole Faust
50ec4afe25 Fix errorprone warnings that should be errors
This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: If17d2944bfd3e7ab10592a4c74c956203c356f81
2022-10-16 13:35:16 -07:00
Alex Chau
47a07bc704 Decouple taskbar background from overveiw scrim if taskbar is in overview
- Removed all forceHideBackground calls if taskbar would be in overview
- Make overview scrim transparent regardless of stash state if taskbar would be in overview

Fix: 234139692
Test: Go to overview from app with ENABLE_TASKBAR_IN_OVERVIEW on/off and taskbar stashed/unstashed
Change-Id: I29e811cb93894e6c9e7a75c0ea493719f15eeccb
2022-10-14 17:45:41 +01:00
TreeHugger Robot
cee4a9b588 Merge "Revert "Using Transaction directly instead of building surface p..."" into tm-qpr-dev am: 3187928c51 am: c3f2fcea3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19971330

Change-Id: I0d5f920d02125a61380c32007b01956a0baa9a54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 01:42:14 +00:00
Sunny Goyal
9925bbd147 Revert "Using Transaction directly instead of building surface p..."
Revert "Removing unused surface transaction wrappers"

Revert submission 19933596-tcompat

Reason for revert: b/246899728
Reverted Changes:
I31123dff7:Using Transaction directly instead of building sur...
I2e2526d21:Removing unused surface transaction wrappers

Change-Id: I63d1d8bb723b7bd05d345fb21a67f88e5fb36bc1
2022-09-15 14:07:51 -07:00
Sunny Goyal
e5f8f0ec23 [conflict] Using Transaction directly instead of building surface params am: fd2c9eb04e am: bb2c85a3eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19933596

Change-Id: Id10383b9dfd5319ba0570a65863fd0cf2156226b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 21:11:20 +00:00
Winson Chung
3f649ef892 Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
Merged-In: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-14 17:14:32 +00:00
Winson Chung
d51fdaa573 Merge "Update Launcher for removed shared wrappers" 2022-09-14 16:30:42 +00:00