After exiting the search, we clear the search results and hide the
results lists (because that recycler view shouldn't be accessible after it). However, it often doesn't get chance to layout the empty data.
So, the next time we show the search results list again with new data,
it first animates to clear the old results and then animates in the new
ones. In this fix,
[demo](http://screencast/cast/NDg5OTg2NzIyMTU1NzI0OHxhMTk0NzEzZS1hYw), we swap the adapter to remove any old views, because old search results aren't valid anymore. Spoke with yigit who worked on RV in past and they suggested swapAdapter
was fine for this.
Other options explored:
1. set item animator = null; so, it doesn't animate flushing out old
results -> but we want animations
2. delay the visibility update to let layout happen -> but, if we are
hiding the section, why wait making the other UI updates until
layout?
Bug: 274051332
Flag: N/A
Test: Manual
Change-Id: I9f9c5a67b47b5415b2d9e4caa23fd4b6daf7cdea
- Now that we display app logo, it will already be badged. So, another
badge on widget itself is not necessary. Moreover, when widget previews
don't fill bounds, its position feels inconsistent.
Bug: 331838199
Test: Manual (see screenshot in bug comment)
Flag: N/A
Change-Id: Id411d054de634d7735b70fff9540e580b078b741
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.
Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
In gesture nav the swipe happens at the bottom of the screen,
which brings the navbar handle into the view.
In 3 button nav the swipe needs to happen from the right edge of
the screen, because the 3 button nav is always staying fixed in
the "bottom portrait" position, unless it is large screen, in
which case it should happen on the bottom landscape edge.
This can be detected via config_navBarCanMove resource value.
Bug: 313928629
Test: atest NetflixEnterPipTest
Test: above command on foldable in folded and unfolded state
Flag: n/a
Change-Id: I0a94757687fd9eb491b2a5cf0086ae51589ae0aa
- Have the animation happen according to the state of private space.
- Have the transition happen only once by setting the current transition to null at the end of transition and by ensuring
where the transitions are allowed.
- Removing controller class.
- The onClick controls the enablement of the profile. On reset (when getting the transition) is what controls the animation
during expand.
tldr- In the collapse case: execute() is called -> animation happens -> addPsHeader
tldr- Expand case: post() is called -> addPsHeader -> animation happens.
Collapse:
onClick() -> AACV.onAppsUpdated() that resets & apply/RUNS runnable because EXECUTE
-> AAList.onAppsUpdated() (which is called at the same time animating happens which we should cancel and do at end callback)
-> AAList.onAppsUpdated() gets called again
Expand:
onCLick() -> AACV.onAppsUpdated() that resets & apply runnable
-> AAList.onAppsUpdated() (no animation running)
-> AAList.onAppsUpdated() (no animation running)
-> addPrivateSpaceHeader
-> then unlockAction() runnable because its posted at this point
bug: 326206132
bug: 330444548
bug: 299294792
Test: manually locally and presubmit: https://screenshot.googleplex.com/9wavvwKQ8hY6oUw & https://screenshot.googleplex.com/BiqmidLFjPwS28j
video: https://drive.google.com/file/d/1XGhmTncdUFtJj188_l7alGyyNz_fhXNw/view?usp=sharing
Scrolling fix before: https://drive.google.com/file/d/1XykDm4UELoCvcwZdj8ZlJ6TszptB8W0W/view?usp=sharing
scrolling fix after when not a lot of apps: https://drive.google.com/file/d/1Y4VY1eX7WE8ShSLXRrT56ieBdAuJo_zn/view?usp=sharing
scrolling fix after with a lot of apps: https://drive.google.com/file/d/1Y58c-Z9xnU1GILp0Ih-oLORXYkMB-jWn/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation
Change-Id: I8d03ae60e2c9fe0ec145c4b0a2e9604b9e6e9017
When dragging bubble bar in launcher, show drop target when drag passes
middle of the screen.
Bug: 330585397
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual
Change-Id: I52c3e9ac0b7c36e2207640baf75dc44300b522ef
This change animates a new bubble bar bubble. Currently only handles the case where the bubble is added when the bubble bar is stashed.
There's no synchronization with the stash handle yet either.
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Test: atest BubbleBarViewAnimatorTest
Change-Id: Ic3f5edc0dde204f871cf7e1288bd50620e6beebb
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct
Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6431d6e87910bc7c7767c40d42f51961dc462134)
Merged-In: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
This CL changes the save app pair menu icon to the latest spec. It looks good!
Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
(cherry picked from commit 1d48159bd5)
