Commit Graph

22624 Commits

Author SHA1 Message Date
TreeHugger Robot
75dcd82a67 Merge "Don't handle task appeared during second quick switch transition" into ub-launcher3-rvc-dev 2020-05-13 03:35:23 +00:00
Tracy Zhou
9a1becebec Merge "Fade in grid preview" into ub-launcher3-rvc-dev 2020-05-13 00:45:37 +00:00
TreeHugger Robot
0276b7e2a7 Merge "Adds westworld logging events for drag and drop on target bar buttons." into ub-launcher3-rvc-dev 2020-05-13 00:31:19 +00:00
TreeHugger Robot
7c604edf92 Merge "[Overview Actions] Put the taskview in the middle of the screen." into ub-launcher3-rvc-dev 2020-05-12 23:01:25 +00:00
Tony Wickham
f6be443eb4 Don't handle task appeared during second quick switch transition
Instead of using shared gesture state, use the swipe handler's
internal state. This ensures that only the handler that started
the new task can finish the controller for it (i.e. starting a
new gesture, which creates a new handler, will ignore the
onTaskAppeared() that the previous handler initiated).

Test: Quick switch to delayed task A, then quick switch to B right
before onTaskAppeared() such that we get onTaskAppeared() during
the transition (easier to repro if you increase animation durations
with springs off). Before this change, A appeared on top.

Bug: 156412706
Change-Id: Ic7d3cd43399005095b2e7c7382218edffefdc27b
2020-05-12 17:46:02 -05:00
TreeHugger Robot
7839eaa9b7 Merge "Generating a long-press even only when it's expected" into ub-launcher3-rvc-dev 2020-05-12 22:22:52 +00:00
thiruram
ff48451ecd Adds westworld logging events for drag and drop on target bar buttons.
This would add below set of LauncherEvents:
* LAUNCHER_ITEM_DROPPED_ON_REMOVE
* LAUNCHER_ITEM_DROPPED_ON_CANCEL
* LAUNCHER_ITEM_DROPPED_ON_DONT_SUGGEST
* LAUNCHER_ITEM_DROPPED_ON_UNINSTALL
* LAUNCHER_ITEM_UNINSTALL_COMPLETED
* LAUNCHER_ITEM_UNINSTALL_CANCELLED

Sample Logs: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.3ndtl1dalhdt

Bug: 152978018
Change-Id: I055a1b001524753eea71384b4765522f5946fbbc
2020-05-12 15:09:28 -07:00
Becky Qiu
073cbca370 [Overview Actions] Put the taskview in the middle of the screen.
Using horizontal padding 48dp to adjust the scale of the taskview and put it in the middle of the vertical space.

Test: local
Bug: 155444014
Change-Id: Iee6096baf18ae1106c24c83b4675abd4d3ff4d4f
2020-05-12 15:00:54 -07:00
Tracy Zhou
0d880c876b Fade in grid preview
Fixes: 156406762
Test: https://drive.google.com/open?id=1JshUMjd1ASjHcAhnAiG3PEC-6wCRY7EE
Change-Id: I6a99650796fe64a6c11ee9fad6904b14373c6363
2020-05-12 14:43:44 -07:00
Sunny Goyal
3f948e3f42 Adding state manager to fallback recents activity
Bug: 156398988
Change-Id: Id0a106ef888ade5223940ac8243108c39b4d6b98
2020-05-12 13:31:48 -07:00
TreeHugger Robot
7dcd4d6ed6 Merge "Simplifying animation creating logic for app-to-overview" into ub-launcher3-rvc-dev 2020-05-12 18:42:22 +00:00
TreeHugger Robot
2830c99bee Merge "Even more additional logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-12 17:35:42 +00:00
vadimt
60bc43d0cc Even more additional logging for pause non-detection
Bug: 156044202
Change-Id: I7c1a8a9ef4149bd64597908c0b6797cfe33fd4b6
2020-05-12 09:51:24 -07:00
Sunny Goyal
4888790bde Simplifying animation creating logic for app-to-overview
Removing optional 'shouldAnimate' flag. This was false only in 3-button mode but
the code was also handling animation, leading to inconsistent expectations. Instead
always assuming animation and finishing the animation promptly.

Change-Id: Ic56476dc5ea64c9a7d7e9744f3e33cd61dfde9e8
2020-05-12 16:37:27 +00:00
TreeHugger Robot
b8759f9b26 Merge "Fixing pullback factor not initialized after launcher process death" into ub-launcher3-rvc-dev 2020-05-12 03:06:29 +00:00
TreeHugger Robot
3d3c41a3a6 Merge "Make educational half-sheet black in dark mode" into ub-launcher3-rvc-dev 2020-05-12 01:07:21 +00:00
TreeHugger Robot
eb0136b7c4 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev 2020-05-12 00:29:52 +00:00
TreeHugger Robot
badfff4469 Merge "Restart running task if another task was started but not appeared" into ub-launcher3-rvc-dev 2020-05-12 00:03:52 +00:00
TreeHugger Robot
c8b81d72a4 Merge "Make darkmode allapps backgrounds solid black" into ub-launcher3-rvc-dev 2020-05-11 23:44:30 +00:00
TreeHugger Robot
e123ac8fb5 Merge "String translation updates" into ub-launcher3-rvc-dev 2020-05-11 23:44:00 +00:00
TreeHugger Robot
c03cfeec36 Merge "Remove bold from work paused overlay text" into ub-launcher3-rvc-dev 2020-05-11 23:43:20 +00:00
TreeHugger Robot
072a6e01bc Merge "Even more logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-11 23:42:30 +00:00
TreeHugger Robot
3d668090af Merge "Resolve Test flakes" into ub-launcher3-rvc-dev 2020-05-11 23:40:43 +00:00
Sunny Goyal
35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
Tony Wickham
a57000c33d Restart running task if another task was started but not appeared
If we just finish the controller to resume the running task like
we normally would, the delayed task will appear on top when it's
ready. Instead, we need to start the original task in this case.

- Move mLastStartedTaskId to GestureState, shared between swipe
  handlers when continuing the gesture.
- Update logic to change LAST_TASK to NEW_TASK if a task was
  started (but not appeared) during the same gesture; likewise,
  only change NEW_TASK to LAST_TASK if no task was started.
- Finish the controller when successfully starting the task
  that already appeared, since we won't get onTaskAppeared().

Bug: 156132424
Change-Id: I1e9af297840745ab3d5e90214425f10a2616d90a
2020-05-11 18:26:06 -05:00
vadimt
d5cb9a7a18 Even more logging for pause non-detection
Bug: 156044202
Change-Id: I31fead73a6a64617aea67e66b01c365841229b92
2020-05-11 15:56:54 -07:00
TreeHugger Robot
ed31f24dbf Merge "Fixing current task not overshooting on swipe-up in overview" into ub-launcher3-rvc-dev 2020-05-11 22:55:45 +00:00
Sunny Goyal
84376f305b Fixing current task not overshooting on swipe-up in overview
> also fixing flicker during swipe-up when scroll is applied before recents
has been initialized

Bug: 154761552
Change-Id: I45c2b6801b8b87097c2816e26a234bab41b72ed4
2020-05-11 14:39:32 -07:00
TreeHugger Robot
6459397e3d Merge "Temporarily removes Settings button from Back tutorial." into ub-launcher3-rvc-dev 2020-05-11 21:10:46 +00:00
TreeHugger Robot
e4350a56d0 Merge "Don't check TIS events mismatch for successful gestures" into ub-launcher3-rvc-dev 2020-05-11 20:53:59 +00:00
Sunny Goyal
ef44cf8f45 Fixing pullback factor not initialized after launcher process death
Instead of storing it on first swipe-up, computing it when required

Change-Id: I4b37002a016328e3b2d1c8535198ec8a6b56faf3
2020-05-11 13:28:53 -07:00
Andy Wickham
168aaf9682 Temporarily removes Settings button from Back tutorial.
Currently it just crashes, so it shouldn't be there. If
and when we decide to add it back, we will need to get
our package whitelisted to send the necessary Intent.

Bug: 149348244
Change-Id: I5ab292d04ebc5679e34e5a92141df3d86ef6e551
2020-05-11 13:24:06 -07:00
vadimt
5d59df4fd9 Don't check TIS events mismatch for successful gestures
Perhaps, due to a framework bug, events sometimes don't get delivered to
TIS; this doesn't seem to cause user-visible problems.

Later we'll need to investigate why this happens.

Bug: 154157191
Change-Id: I25f45ccab10f6c537c14610e40c2d02d2d3f28ad
2020-05-11 13:14:06 -07:00
TreeHugger Robot
ae5afa74cd Merge "Using TaskViewSimulator for both Launcher and fallback recents" into ub-launcher3-rvc-dev 2020-05-11 19:32:26 +00:00
Vinit Nayak
115e70ddcf Merge "Infer launcher rotation when initializing RecentsOrientedState" into ub-launcher3-rvc-dev 2020-05-11 19:07:54 +00:00
TreeHugger Robot
17d3fe81c4 Merge "[Overview Actions] Change actions view UI based on different nav modes." into ub-launcher3-rvc-dev 2020-05-11 18:52:13 +00:00
Zak Cohen
02a25be89d Merge "Overview Actions - shows a message if action is blocked by policy." into ub-launcher3-rvc-dev 2020-05-11 18:43:55 +00:00
Adam Cohen
400dfe0d93 Merge "Fix animation for non-default grids when dragging icon from All Apps into a Folder" into ub-launcher3-rvc-dev 2020-05-11 18:38:28 +00:00
Adam Cohen
2438d40607 Merge "Fix issues with drag and drop from All Apps in non-default grids" into ub-launcher3-rvc-dev 2020-05-11 18:38:15 +00:00
Vinit Nayak
b9522d334a Infer launcher rotation when initializing RecentsOrientedState
fixes: 154776599
Change-Id: I9b95f7f96836a974be0fd1236547efb4b405fda5
2020-05-11 11:23:49 -07:00
Hyunyoung Song
e745f50128 Merge "Hookup statsd for workspace layout logging" into ub-launcher3-rvc-dev 2020-05-11 18:18:57 +00:00
Becky Qiu
7d12134240 [Overview Actions] Change actions view UI based on different nav modes.
1. Change the overview actions container to 66dp height.
2. For 3 button mode, container will have 8dp bottom margin.
3. For gesture mode, container will have 16dp bottom margin.
4. Action buttons and close button will always be in the center vertically.

Spec: https://docs.google.com/presentation/d/1gXWNdCRXvXuEhgDmE0TX2KYqCxIQBXVtWKdl4pKrno8/edit#slide=id.g840c32b190_3_6

Demo:
- 3 button: https://screenshot.googleplex.com/2Y3uMaJMi9E
- gesture: https://screenshot.googleplex.com/XzaKHpp5ke9
Test: tested for both modes and when switch between.
Bug: 155444592

Change-Id: If66d369df0218b7ee2abab8a3f345488bf223b16
2020-05-11 10:46:21 -07:00
vadimt
7b7e62e5eb Additional logging for pause non-detection
Bug: 156044202
Change-Id: I6d7dcdcf73722e66fcbd180c9e309c518766b9b8
2020-05-11 10:10:53 -07:00
TreeHugger Robot
3141c99e92 Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev 2020-05-10 22:56:59 +00:00
Samuel Fufa
0826bc1b0b Remove bold from work paused overlay text
Bug: 151405736
Change-Id: I35a26bfd6196ef5d3a82efa7b89c2fa80debf93d
2020-05-10 14:40:20 -07:00
Samuel Fufa
eb1d77aa08 Make darkmode allapps backgrounds solid black
Bug: 154930029
Test: Manual
Change-Id: I7906bfa8460afb409b205afbf86648dd154d7da5
2020-05-10 14:02:10 -07:00
Samuel Fufa
6610fd0950 String translation updates
-> make dismiss_prediction_label and pin_prediction translatable
issue 155846260

-> use ' instead of ’ for work_apps_paused_body
issue 155639533

Test: Manual
Change-Id: Ibb291bb803f8fa8a39c7ddf81db5d8a253a26766
2020-05-10 13:56:37 -07:00
Bill Yi
561e1c3777 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I48b5667682d4f964d8471237bf3629e0b26fd20f
2020-05-10 20:53:25 +00:00
Bill Yi
91e0db3905 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I2f2cda2793113a012d86b0d18cccf3e6fabb7e69
2020-05-10 20:53:08 +00:00
Samuel Fufa
b549819676 Resolve Test flakes
-> Synchronize calls in LoaderTask.java
issue 156041043

-> Remove non system users on setup
If a work test crashes before getting to run its teardown - we might end up with a user profile that could throw off subsequent tests.
issue 156022161

Test: Manual
Change-Id: Ife708a3de01572f7cb2187078d592d8d570dd951
2020-05-10 13:51:41 -07:00