Commit Graph

72156 Commits

Author SHA1 Message Date
Holly Sun
6ec3d23a4b [PS] Add private space icon and strings.
Bug: 298227797
Test: manual and unit
Flag: inject_private_space_tile
Change-Id: Ic7ec649ac69f02a82a6ee0b4e63262d8ad3e0916
2023-10-13 12:29:19 -07:00
Ats Jenk
186e60e94c Merge changes from topic "overview-to-desktop" into main
* changes:
  Account for freeform tasks being visible in overview
  Enable live tile for desktop
2023-10-06 22:05:06 +00:00
Brian Isganitis
447b09057a Merge "Prevent NPE from changing all apps visibility in shared state." into main 2023-10-06 20:59:33 +00:00
Brian Isganitis
f79785065b Merge "Have dragged search items return to All Apps icon if cancelled." into main 2023-10-06 20:44:06 +00:00
Federico Baron
0bd2c4ea75 Merge "Add smartspace removal option as a toggle" into main 2023-10-06 20:35:14 +00:00
Federico Baron
97789c9c5e Merge "Add flag for smartspace removal toggle" into main 2023-10-06 20:35:14 +00:00
Vadim Tryshev
acfb180a3d Merge "Next batch of modifications to ignore-lists of anomaly detectors" into main 2023-10-06 20:33:52 +00:00
Schneider Victor-tulias
8265d04e0a Merge "Fix NullPointerException in OverviewInputConsumer" into main 2023-10-06 20:30:39 +00:00
Vadim Tryshev
75fae9b0b4 Next batch of modifications to ignore-lists of anomaly detectors
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: Ic5eb0a7bfa95c5a3cd890582e7ddf3de2f2bda1c
2023-10-06 11:00:01 -07:00
Brian Isganitis
96224ef755 Merge "Migrate Kotlin tests to use mockito-kotlin2." into main 2023-10-06 17:54:56 +00:00
Sunny Goyal
b34296face Merge "Making AsyncClockEventDelegate a singleton" into main 2023-10-06 16:58:41 +00:00
Schneider Victor-tulias
4a0a867dcc Merge "Fix NullPointerException in RotationHelper" into main 2023-10-06 15:21:32 +00:00
Vinit Nayak
0f9d9a825f Merge "Null reference to split callback" into main 2023-10-06 14:21:18 +00:00
Vinit Nayak
a7b491e35e Null reference to split callback
Bug: 302551868
Test: Ran atest NexusLauncherTests:com.android.quickstep.TaplTestsSplitscreen
which caused some regressions last time. Passed locally

Change-Id: I94b28296cf12c5087ee3e878352c057d1d1a73de
2023-10-05 17:22:46 -07:00
Tracy Zhou
528356e744 Merge "Fix task bar crash in gesture nav mode with task bar / nav bar unification on" into main 2023-10-05 23:38:13 +00:00
Ats Jenk
0927251a7b Account for freeform tasks being visible in overview
When live tiles are enabled, desktop tasks remain visible while in
overview. This is due to tasks remaining in running state.
Update DesktopVsibilityController to handle this case. If in freeform,
it should return that freeform tasks are not visible to any callers.
Also move launcher state handling to inside the controller so we don't
have this handling in other places.
Introduce separate handling of background and overview state. In
background state we want to keep the freeform task visibility state
matching the actualy visibility. And show the launcher views and resume
the activity.
In overview state we want to override the freeform visibility and show
launcher views.

Bug: 297590571
Test: open an app on desktop
      - swipe up for taskbar multiple times, observe that we remain on
        desktop
      - swipe up for taskbar and launch an app, observe it launches on
        desktop
      - swipe up to recents, observe that recents UI is shown and task
        remains running
      - swipe up to recents, launch desktop again from recents
      - swipe up to recents, launch another fullscreen app from recents
      - swipe up from a fullscreen, launch desktop from recents
Change-Id: Id5cef7111da6929c8435ef9d221db1abd8361b15
2023-10-05 15:53:42 -07:00
Stefan Andonian
9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Andy Wickham
57fd004867 Merge "Add awickham to OWNERS file" into udc-qpr-dev am: bf4a08acef am: 3f42cf5fea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24955693

Change-Id: I592f78bb1d54027ae00ec3a101681df59cf9e405
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 21:12:33 +00:00
Sunny Goyal
6ad6cfa300 Merge "Removing unused interfaces from Launcher" into main 2023-10-05 21:00:49 +00:00
Andy Wickham
3f42cf5fea Merge "Add awickham to OWNERS file" into udc-qpr-dev am: bf4a08acef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24955693

Change-Id: I97341587170042a3731440fb3917884bac517514
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 20:42:22 +00:00
Sunny Goyal
df178f5320 Making AsyncClockEventDelegate a singleton
RemoteViews can get inflated after the activity is destroyed during
async inflation. This can cause the delegate to loose the destroy event.

Bug: 303686041
Test: Presubmit
Flag: N/A
Change-Id: Iecb9d69d95b2c924e1189ac15515fac327d8f44d
2023-10-05 13:23:58 -07:00
Stefan Andonian
23f869f0f0 Merge "Don't show FloatingIconView during Back to Home Animation when animations are disabled." into main 2023-10-05 20:22:49 +00:00
Andy Wickham
bf4a08acef Merge "Add awickham to OWNERS file" into udc-qpr-dev 2023-10-05 20:07:25 +00:00
Sebastián Franco
4823dca49e Merge "Moving tests form TaplTestsLauncher3 to TaplTestsAllAppsIconsWorking" into main 2023-10-05 19:56:58 +00:00
Sebastián Franco
86efdfb964 Merge "Moving the simple methods related to binding to a delegate" into main 2023-10-05 19:48:22 +00:00
Tony Wickham
d7c43cab9b Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev am: cf596d4178 am: 3809c0a278
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24840504

Change-Id: Id81adcfc07d2c6a01655b4d88df524764b38e5fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:37:58 +00:00
Tony Wickham
3809c0a278 Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev am: cf596d4178
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24840504

Change-Id: I4a2cc03328d09757ff1a5454138b61794a5cadee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:05:04 +00:00
Vinit Nayak
c939620fd1 Merge changes Id9a74edd,Iab1f1e99 into main
* changes:
  Support fullscreen split selection launch for contextual
  Add icon when launching widgets in split
2023-10-05 18:31:15 +00:00
Mark Fasheh
9a0a03d080 Merge "Add tracepoint to track Launcher cold startup latency" into main 2023-10-05 18:26:54 +00:00
Tony Wickham
cf596d4178 Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev 2023-10-05 18:16:40 +00:00
Stefan Andonian
ce72ccf714 Merge changes Ic52bede8,I97ab2818 into main
* changes:
  Delete App Icons from Test Data Assets
  Reapply "Add unit tests for LoaderTask"
2023-10-05 17:44:59 +00:00
Stefan Andonian
17ee527e15 Don't show FloatingIconView during Back to Home Animation when animations are disabled.
Bug: 235915161
Test: Reproduced the issue locally, then verified that the fix worked as
desired without introducing unwanted side effects.

Change-Id: I3db3b2ddbd34a2ef19eae10282758df32c2d5b3f
2023-10-05 17:44:12 +00:00
Schneider Victor-tulias
127ce4a3d6 Fix NullPointerException in RotationHelper
A possible race condition between RotationHelper and DisplayController is causing RotationHelper.onDisplayInfoChanged to be called after it has already been destroyed. Added checks to make Rotationhelper a no-op after being destroyed.

Flag: not needed
Fixes: 303506682
Test: AllAppsImageTest
Change-Id: Ief1946a356698eda9c2b806f9d49e08b1d66dae1
2023-10-05 13:37:58 -04:00
fbaron
c0e687bad8 Add smartspace removal option as a toggle
Bug: 303471576
Test: try removing smartspace by going to home settings and turning it off
Flag: ENABLE_SMARTSPACE_REMOVAL
Change-Id: Idd95da1b302927885a8c469e38db6d3c5130f8c1
2023-10-05 17:26:03 +00:00
Sebastian Franco
bd7919c97a Moving the simple methods related to binding to a delegate
Other more involved methods should require their own cl so that
we can do a more thurough analysis.

Changes are part of go/launcher_SoR .

Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I332a6b92cfd8dc6a9632c225da634bc4b57f01e2
2023-10-05 09:50:16 -07:00
Anushree Ganjam
d0da4c001b [automerger skipped] Developer options should reflect the correct DeviceConfig value for ReleaseFlag. am: 13517070d8 am: 2fbb34fc7b -s ours
am skip reason: Merged-In I5d83207cf454c60278fd02e59199207e855d51a8 with SHA-1 9eb68bb7cf is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24945015

Change-Id: Ic3fe88d01200c559c326047e9a1bc707460eb84b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 16:39:27 +00:00
hyunyoungs
0bac78be6e Add awickham to OWNERS file
Change-Id: Ib7cec7caf615ed8974f09df4eb9d93ea117e756b
2023-10-05 09:18:19 -07:00
Anushree Ganjam
2fbb34fc7b Developer options should reflect the correct DeviceConfig value for ReleaseFlag. am: 13517070d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24945015

Change-Id: Ic0b22dd740409cafc3a4224e3dba3ed7ac60516f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 16:09:05 +00:00
Alex Chau
2ca7481b04 Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag" into main 2023-10-05 15:40:17 +00:00
Schneider Victor-tulias
6c58b1db66 Fix NullPointerException in OverviewInputConsumer
OverviewInputConsumer should wait until the root view is attached to the window before using the ViewRootImpl.

Flag: not needed
Fixes: 303117246
Test: used the OverviewInputConsumer with the keyboard
Change-Id: I78c23cb146f35cdb1f4b87f42726d6260d4a2b87
2023-10-05 10:05:47 -04:00
Uwais Ashraf
cfaba6e814 Merge "Align empty recents message+icon to center of View." into main 2023-10-05 09:00:28 +00:00
Stefan Andonian
865898e303 Delete App Icons from Test Data Assets
Previously, the test assets were being pulled into the release APK.
Unfortunately, it isn't possible to build the Release APK from within
SysUi Studio. Since the tests don't test the image loading, I am opting
to simply delete the large image strings, rather than try to figure out
why the release APK is including these test assets.

Bug: 301105199
Test: The tests still pass. That being said, it is difficult to test
this other than see if the APK size doesn't get flagged for growing too
large. It should be ok though, since the test assets are now WAY
smaller.

Change-Id: Ic52bede8296624740e4ca1573955494c3b94bf87
2023-10-05 03:51:54 +00:00
Stefan Andonian
18fe81864f Reapply "Add unit tests for LoaderTask"
This reverts commit e4735d77f1.

Bug: 301105199
Test: This already passed presubmit before.
Change-Id: I97ab28186ba1d4da4abe82686fe1a11d5e51c4b3
2023-10-05 03:51:44 +00:00
Tracy Zhou
27d7769000 Fix task bar crash in gesture nav mode with task bar / nav bar unification on
a11yButton is reserved for 3-button mode so it can be null. Also TaskbarNavLayoutter is used for large screen both in gesture nav and 3-button mode, so need to check isContextualButtonShowing to add contextual buttons

Fixes: 300849078
Test: Make sure that it doesn't crash in large screen gesture nav mode
Change-Id: I9d0694b7f4c95461f24efb2af1af905e68e3cd8d
2023-10-04 20:17:23 -07:00
Anushree Ganjam
13517070d8 Developer options should reflect the correct DeviceConfig value for ReleaseFlag.
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.

After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.

This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.

Bug: 297202824
Test: Manual
Flag: NA

Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
Merged-In: I5d83207cf454c60278fd02e59199207e855d51a8
(cherry picked from commit 9eb68bb7cf)
2023-10-05 01:45:32 +00:00
Brandon Dayauon
d45403ee2d Merge "Fix text jumping from one line -> two line when scrolling" into main 2023-10-05 00:36:17 +00:00
Brandon Dayauon
6c345f4d4c Fix text jumping from one line -> two line when scrolling
The issue this happens is because the paint letter spacing can change during checkForEllipsis()
so during vertical calculation for two line, set the paint letter spacing to the MIN_LETTER_SPACING that is used
in checkForELlipsis()

bug: 303319642
Test: After: https://drive.google.com/file/d/14YfmEWNpmllSAdLeUamUpewa8ljbqXAU/view?usp=sharing
before: https://drive.google.com/file/d/14Y_I-iuyOGHCr809AlqNL8o1IdFjk3_8/view?usp=sharing
Flag: disabled
Change-Id: I1f56a9e9d22ab45b0491e5fa65b5bfc5b10fc720
2023-10-04 16:44:03 -07:00
Sebastian Franco
547ddd4830 Moving tests form TaplTestsLauncher3 to TaplTestsAllAppsIconsWorking
Removing testGetAppIconName since that behaviour is already tested.

I'm also using this change to remove the TISBinder rule since it's not
needed.

Bug: 302869930
Test: atest TaplTestsAllAppsIconsWorking
Change-Id: Ie6b4f801254ca69b2485fe574914a73f947fc434
2023-10-04 16:43:19 -07:00
Stefan Andonian
54495f3018 Permanently provide functionality for LauncherPref items that don't need
to be migrated, but are boot aware.

Bug: 251502424
Test: Tested that Migration works as expected, as well as shared
preference information that doesn't need to be migrated. Also sanity
tested phone in general.

Change-Id: Ie8460e360856cbe20a7770b1747f75c7154759ab
2023-10-04 23:32:58 +00:00
Vinit Nayak
ae3c5749ef Support fullscreen split selection launch for contextual
* Migrate animating split placeholder to fullscreen into
SplitAnimationController from RecentsView to consolidate
* Reset state from RecentsView via a callback

Fixes: 295457117
Test: Tapping on placeholder in overview and home works
as expected

Change-Id: Id9a74eddc134a0470110845b90729c05193a1f93
2023-10-04 16:05:03 -07:00