Commit Graph

2296 Commits

Author SHA1 Message Date
Sunny Goyal
5fc8131b60 Merge "Introducing CellPosMapper which allows mapping between UI position and model position" into tm-qpr-dev am: 126ac14112 am: a19f661961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21128574

Change-Id: Id2cdf2a5262def0401cd2a60fbe89044f55a9c98
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 19:30:30 +00:00
Sunny Goyal
a19f661961 Merge "Introducing CellPosMapper which allows mapping between UI position and model position" into tm-qpr-dev am: 126ac14112
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21128574

Change-Id: Ia74b38af165fa317c4d562730652f960026912a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 18:47:36 +00:00
Sunny Goyal
669b71f5b3 Introducing CellPosMapper which allows mapping between UI position
and model position

Test: atest CellPosMapperTest
Bug: 188081026
Change-Id: If5c6b3df5ad240317bb535c675f6ead94084238e
2023-01-30 12:17:09 -08:00
hyunyoungs
50b824392a Add @ScreenRecord to testPressHomeOnAllAppsContextMenu
Bug: 264538883
Test: seems to run fin on tm-qpr-dev
Change-Id: If395260ba58496282b651e1938e28f3cef22654f
2023-01-28 18:55:05 -08:00
Becky Qiu
9b9209acc6 Merge "Revert "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev am: 70c9aee083 am: 145c75eafd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21128653

Change-Id: Iabcdcab1f642f7e1b95b177253bea2b5602f6761
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-27 22:21:20 +00:00
Becky Qiu
145c75eafd Merge "Revert "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev am: 70c9aee083
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21128653

Change-Id: Ibb5459b813b3e15b600224faf268d649727897ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-27 21:21:07 +00:00
Becky Qiu
70c9aee083 Merge "Revert "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev 2023-01-27 20:52:26 +00:00
Becky Qiu
d5311f6541 Revert "Expose getSearchBox from the HomeAllApps class"
Revert submission 20714047-b_255390519

Reason for revert: broken test b/266169958 (P0 bug) and broken UI for the EDU card

Reverted changes: /q/submissionid:20714047-b_255390519

Change-Id: I250003c1b3d07637dde596225f08a6bd3cb84365
2023-01-27 20:11:26 +00:00
Thales Lima
e31106b036 Merge "Create attr for padding between icon and text in cells" into tm-qpr-dev am: 91b9de1fe2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20980937

Change-Id: I28a303a6de429baa94325f911555a2271d4978ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-27 12:01:17 +00:00
Thales Lima
d852d65693 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 22:50:18 +00:00
Thales Lima
903d0a3e63 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
(cherry picked from commit 60cab75576e9f844fcaae8f0723a075f2a00bb1f)
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 15:40:27 +00:00
Sebastián Franco
1b3d1cfa64 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev am: 68f5667338 am: 56f91702d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20890013

Change-Id: I3b9bad730707d9e5dca8f10acdb43991cd51c290
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 23:11:45 +00:00
Sebastián Franco
56f91702d2 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev am: 68f5667338
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20890013

Change-Id: I83d66d694897da0463e93bfc740fc48e99428a8c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 21:13:11 +00:00
Sebastián Franco
68f5667338 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev 2023-01-24 20:02:35 +00:00
Sunny Goyal
d77858ecd9 Merge "Moving all intent receiver register calls to a single place" into tm-qpr-dev am: e1daf91dfd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20933568

Change-Id: Iaf7284b1aa81da22d223ee0af4cdc8ec1cf45656
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 00:58:02 +00:00
Sunny Goyal
a992ac9e8d Moving all intent receiver register calls to a single place
This is eventually allow us to move all register to background thread
Also creating a single ScreenOn tracked which is used at multiple places

Bug: 264465756
Test: Verified on device
Change-Id: Ibadf9ca43218e578954420d97a733adfa0a94fc7
Merged-In: Ib410e5bf02773cefde5bf0a0a1f2f1c108718d24
2023-01-22 05:24:48 +00:00
Sunny Goyal
a1692a467f Moving all intent receiver register calls to a single place
This is eventually allow us to move all register to background thread
Also creating a single ScreenOn tracked which is used at multiple places

Bug: 264465756
Test: Verified on device
Change-Id: Ibadf9ca43218e578954420d97a733adfa0a94fc7
2023-01-20 23:50:00 +00:00
Ling Wo
a83e753c9b Merge "Expose getSearchBox from the HomeAllApps class" into tm-qpr-dev am: 38aa60c38f am: 6dafb0359c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20273481

Change-Id: I75db89675672c9c08a4e48f7ebbc8448aec51a6e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-19 22:44:20 +00:00
Ling Wo
6dafb0359c Merge "Expose getSearchBox from the HomeAllApps class" into tm-qpr-dev am: 38aa60c38f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20273481

Change-Id: Iccad1a308b2c5a022b54013a1750b5db983484d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-19 22:06:55 +00:00
Ling Wo
38aa60c38f Merge "Expose getSearchBox from the HomeAllApps class" into tm-qpr-dev 2023-01-19 21:29:12 +00:00
Sebastián Franco
a1707e3007 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev am: 48651b2109 am: c18a4081d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20831584

Change-Id: Ie10f728d6e544214f2ac91a209fd500635030a5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 02:29:42 +00:00
Sebastián Franco
c18a4081d5 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev am: 48651b2109
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20831584

Change-Id: I7a3f5ed328fa68a139dd464fd7a672cf910dd36b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 01:52:26 +00:00
Sebastián Franco
48651b2109 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev 2023-01-18 01:12:23 +00:00
Stefan Andonian
6a651e63c9 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a am: 60e3b74522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I7a69b534e3df890034eb897e8d61517e75828702
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 19:29:02 +00:00
Stefan Andonian
60e3b74522 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I291aeed8952555e9dd35b4dfe2e1c73db889351a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 18:52:00 +00:00
Stefan Andonian
1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Sebastian Franco
de1fe14a47 Adding the avility to add icons on multiple CellLayouts on tests.
I needed to change the code so that you can pass the CellX/Y
position to the drag function instead of the pixel coordinates
and we can pass X position bigger than one CellLayout.

Also, I notice that getCellCenter only worked for 1x1 items
so I added the option to specify the widget size.

Fix: 262431878
Test: atest ReorderWidgets#multipleCellLayoutsSimpleReorder
Change-Id: I3b09de770e8f99aa10cae8cea32e7e6bc02c7b8b
2023-01-16 10:32:40 -06:00
Sebastián Franco
075bd276ca Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev am: 519714449f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838734

Change-Id: Id6707d575fecfeae28b704fd8701c82f4288a9f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 01:14:48 +00:00
Stefan Andonian
d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Sebastian Franco
877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Sebastián Franco
f55e3690ea Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" 2023-01-12 21:14:23 +00:00
Christophe Pinelli
2acf5a8492 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4 am: ab2c2d9576
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: Iafef3bf70a5dfb0c5a72bf814d23d952cfd7f2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 20:02:04 +00:00
Christophe Pinelli
ab2c2d9576 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: I251cb1edf4e02cd919225d25c05e2e49f820208d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:08:49 +00:00
Sebastian Franco
9db35f7a37 Remove unused Throw Throwable from clearHomescreen method
Test: presubmit
Bug: 263802298
Change-Id: I4b81e044eb4f6a84730fb4d61403cbfcadefd282
2023-01-12 10:41:34 -06:00
Christophe Pinelli
9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Stefan Andonian
53b21fae3b Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7 am: 167d350981
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I7591e1af8af6bcd6b11dea1571668d80ada06201
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:57:55 +00:00
Stefan Andonian
167d350981 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I16987862cffc3730518fe14adf61595d62b8faad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:11:16 +00:00
Stefan Andonian
2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Treehugger Robot
a26bb5cb0f Merge "Assign default bug component for Launcher3" am: e78e42fcf3 am: c72d17fc28 am: fdbf120a04
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2382992

Change-Id: I37e56f95785ba581a1e6e2b198ab097957660a77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 18:17:44 +00:00
Treehugger Robot
fdbf120a04 Merge "Assign default bug component for Launcher3" am: e78e42fcf3 am: c72d17fc28
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2382992

Change-Id: Id9dfd686f40cdf673e0fa046d93ae702e859073a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 17:38:11 +00:00
Sebastian Franco
a955403ba9 Change the access of cellX/Y of CellLayoutLayoutParams to private
Cherry pick needed for changes on workspace lily

Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-11 15:25:23 +00:00
David Saff
c15e2a3a5d Assign default bug component for Launcher3
This is the "Pixel Launcher" component, let me know if another would be more appropriate.

See go/android-codereviews#buganizer-component-links-in-owners for how this is (I believe) used.

Change-Id: I85ff57211616315e08f8e3913707ee34f6055e8a
2023-01-10 19:06:29 +00:00
Thales Lima
bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00
Thales Lima
03ac377a34 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-10 13:24:43 +00:00
Thales Lima
47a40a8bd3 Merge "Check kotlin format before uploading" 2023-01-10 13:23:59 +00:00
Sebastián Franco
aeaaef068d Merge "Printing the workspace items to improve flake investigation." into tm-qpr-dev am: b66293e96d am: b1bb6d37d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680953

Change-Id: I6556acee7b4a44ed4a39aefa749cdfca4f305f26
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 00:25:48 +00:00
Sebastian Franco
1328764f1e Removing screen recording for testShortcutIconWithTheme am: 1cf1e3b025 am: 4a1dd0b422
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20913765

Change-Id: Ia76ee43a6ba9c1643f11a12670716b7b4bee5c28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 00:25:14 +00:00
Sebastián Franco
b66293e96d Merge "Printing the workspace items to improve flake investigation." into tm-qpr-dev 2023-01-09 23:20:51 +00:00
Sebastian Franco
1cf1e3b025 Removing screen recording for testShortcutIconWithTheme
Bug: 260722220
Test: compiles
Change-Id: I7f5ac09bc7e9deb9af3e90dbd99826bb8c4db11f
2023-01-09 14:19:14 -06:00
Thales Lima
7a3c1e10a7 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-09 17:45:42 +00:00