Commit Graph

2296 Commits

Author SHA1 Message Date
Sam Dubey
c07b410a3c Merge "Revert "Support multi users scenarios in Tapl"" into tm-qpr-dev am: 52a3bcd4bb am: 33c4597ca2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20352019

Change-Id: I42996e6b2a3496cf98db4453e82e725bfaf04857
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 14:11:14 +00:00
Sam Dubey
52a3bcd4bb Merge "Revert "Support multi users scenarios in Tapl"" into tm-qpr-dev 2022-11-03 11:40:24 +00:00
Sam Dubey
a3577293b6 Revert "Support multi users scenarios in Tapl"
Revert "Reduce multi users tests runtime"

Revert "Add PlatformTesting to dependency."

Revert "Move platform testing util to separate gradle module"

Revert submission 20311444-user-switch-nosleep

Reason for revert: Part of DM+Platinum montiro as a likely culprit for b/257210412. Won't be submitted if proven otherwise.
Reverted Changes:
I90b1069de:Support multi users scenarios in Tapl
I706da86a3:Add PlatformTesting to dependency.
I605cd76c4:Move platform testing util to separate gradle modu...
I64b571dc4:Reduce multi users tests runtime

Change-Id: I6310efa59fe1755feb29bef28d890e684b7164c6
2022-11-03 10:08:13 +00:00
Benno Lin
ba4a0ee4c0 Merge "Support multi users scenarios in Tapl" into tm-qpr-dev am: 8f669d20d7 am: e1594e8984
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20311444

Change-Id: Iae67e72a27051373898c5451c2d6b4397a37beb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 07:56:19 +00:00
Benno Lin
8f669d20d7 Merge "Support multi users scenarios in Tapl" into tm-qpr-dev 2022-11-03 06:42:19 +00:00
Winson Chung
38779f75da Add delay after installing dummy app
- Testing hypothesis that it's taking a while for the app to be
  properly installed and showing in all apps

Bug: 256659409
Test: com.android.launcher3.ui.TaplTestsLauncher3#testUninstallFromAllApps
Change-Id: Icb1bb8bb9d98751ac8c97b300ecc39372f39c345
2022-11-03 03:47:01 +00:00
Sunny Goyal
a084dbd3bd Merge "Fixing background jump when closing a widget" into tm-qpr-dev am: 031ee4cbcb am: 6988b7b308
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20304438

Change-Id: I578ef759545b5bebcf314a2022f99e428bb7ee1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 02:02:24 +00:00
Saumya Prakash
f70e339dfc Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev am: ccc8e9fcf4 am: c8964d66a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20342916

Change-Id: I051cbfe6c23c6242fa54e9bf223cd5645efbc744
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 19:42:17 +00:00
Sunny Goyal
39b07fd66c Fixing background jump when closing a widget
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
2022-11-02 19:17:18 +00:00
Saumya Prakash
ccc8e9fcf4 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-11-02 18:30:21 +00:00
Tony Wickham
0d3f247ac6 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev am: 6b32ce07b1 am: cbfc9a1f0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19560161

Change-Id: Ia4c7f142e2263361ae7d9d0b03735956adb8aa81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 16:57:47 +00:00
Tony Wickham
6b32ce07b1 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev 2022-11-02 15:39:45 +00:00
Saumya Prakash
12731af30d Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I64c91c682009808690d696032ffadefc86dfbac9
2022-11-01 21:49:19 +00:00
Benno Lin
2e35f5152d Support multi users scenarios in Tapl
Tapl uses ContentProvider to get information from Launcher.
By default, it uses system user, who usually spwans the process
of instrumented tests, to send requests. Therefore, it can't get
the information of secondary user's Launcher process.

To solve the problem, the CL proposes to allow tests providing
UserInfo to Tapl, so that Tapl can use the right user's context
to get the test information. For more details, please refer to
go/multi-users-waiting-dd.

Test: https://android-build.googleplex.com/builds/abtd/run/L62400000957107134
Bug: 254402688
Change-Id: I90b1069de31e979138683049586bd87a7e7d813a
2022-11-01 14:36:24 +00:00
David Saff
31aabd93ee Merge "Mark broken tests that are blocking presubmit" 2022-11-01 13:37:21 +00:00
Sunny Goyal
7550a67d90 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev am: c93eb630e6 am: 4f5d276233
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330482

Change-Id: I039c65677505a6e77b6d2b2e87ef0f21afad30f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 00:57:57 +00:00
Sunny Goyal
c93eb630e6 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev 2022-10-31 23:53:43 +00:00
Sunny Goyal
d6e9c601d8 Adding screenrecord for debug failing test
Bug: 256659409
Test: n/a
Change-Id: I1d804a92f81069df8d86f5b4ee2f21179f390d98
2022-10-31 13:25:17 -07:00
David Saff
ef47bf0071 Mark broken tests that are blocking presubmit
Bug: 256615483
Test: presubmit
Change-Id: Ie42885b65f1e4652a36cf9018bf43573fd0fec9f
2022-10-31 16:31:05 +00:00
Sebastian Franco
285b749bcf Wait in ReorderWidgets test for the workapce to load after changing it.
Fix: 252860608
Test: atest ReorderWidgets
Change-Id: Idf99188837a475d0327174e264ab1d23d646d75d
2022-10-27 14:42:19 -07:00
Sihua Ma
ce1b37ccd4 Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev am: 17137e8bce am: fe121a99c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20106227

Change-Id: I67fff40251e2feb6beaf0b45e5352dd5dae642de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-27 19:01:32 +00:00
Sihua Ma
17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Saumya Prakash
e1cd65d10d Merge "Revert "Removed disabled overview actions at end of scroll"" into tm-qpr-dev am: 5db9942c61 am: ccb46bd18f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20293338

Change-Id: Ifa97e85f081441321df7106f9455e374542f36e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-26 23:15:18 +00:00
Saumya Prakash
5db9942c61 Merge "Revert "Removed disabled overview actions at end of scroll"" into tm-qpr-dev 2022-10-26 22:10:39 +00:00
Saumya Prakash
6ae248f35f Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev am: f1a4121784 am: 3fcd628839
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20158096

Change-Id: I010e14cf8ed71eea02e68230116d1ab511c66ede
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-26 21:47:38 +00:00
Saumya Prakash
19250d69f7 Revert "Removed disabled overview actions at end of scroll"
This reverts commit 96cad794d7.

Reason for revert: Breaks build test_suites_x86_64_coverage (linux) build 9222442 in git_tm-qpr-dev. 

Change-Id: I482f526da169505cf5d3f42ef999303dcc162a1f
2022-10-26 20:59:30 +00:00
Saumya Prakash
f1a4121784 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-10-26 20:31:44 +00:00
Sihua Ma
0593a0d3ec Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost
The wrapper class is created for further changes that will run the wrapped host in the background.

Test: N/A
Bug: 235358918
Change-Id: I9bd6fc2749c5d4a4d3391fb75d0c3ff1e13d17bf
2022-10-26 10:57:13 -07:00
Sunny Goyal
c5d63bcac5 Merge "Merging MultiValueAlpha with MultiPropertyFactory" into tm-qpr-dev am: 3912808183 am: 34da3ed6df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19944063

Change-Id: Iecd1429f926172eea4c551667d7995c1a9750bc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 23:12:13 +00:00
Saumya Prakash
96cad794d7 Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I17628f1fa3869b575ec404a2a630a6927e3c1d14
2022-10-24 22:47:24 +00:00
Sunny Goyal
d859060860 Merging MultiValueAlpha with MultiPropertyFactory
Bug: 246644619
Test: Presubmi
Change-Id: Id5abc5f3169544656f1139ae17ca59e34ac65dac
2022-10-24 14:38:18 -07:00
Hui Kang
9a34b122bf Merge "Fix AddWidgetTest flake Test: ABTD" into tm-qpr-dev am: 07949ff3c8 am: ae9ee2bc27
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20261595

Change-Id: I1378c314d0921b80847e4ed027368e7ef9a4a69d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 21:29:20 +00:00
Sunny Goyal
85cf449fcc Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev am: 0cf401d0eb am: 1baaac662b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20260484

Change-Id: I38c6cec592377e77294e02c70af28ab72d70e90c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 20:16:56 +00:00
Hui Kang
4b87b9e521 Fix AddWidgetTest flake
Test: ABTD

200 all PASS: https://android-build.googleplex.com/builds/tests/view?invocationId=I20300010100881398

Without this CL, 1/100 FAIL: https://android-build.googleplex.com/builds/abtd/run/L73700000956982533

Change-Id: Ia9d7746144e9838798332f4eea223a9529551713
2022-10-24 18:09:15 +00:00
Sunny Goyal
f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
2022-10-22 15:37:47 +00:00
Ling Wo
7c35298a40 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev am: ac29981a42 am: 12949e8abb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20158848

Change-Id: I3f79292d7c813808a61ca82ea31121daa5ee3eba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 22:44:45 +00:00
Ling Wo
ac29981a42 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev 2022-10-21 21:44:35 +00:00
Schneider Victor-tulias
ee0bc03d58 Decrease TAPL All Apps scrolling flakiness
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
2022-10-21 12:12:38 -07:00
Sukesh Ram
c6d4df87f0 Added Tests for Secondary Display Launcher
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
Merged-In: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
2022-10-20 22:58:46 +00:00
TreeHugger Robot
7c9144328a Merge "Making Launcher TAPL check orientation only when the expected orientation is set by the test" into tm-qpr-dev 2022-10-17 22:58:51 +00:00
Hui Kang
70765883c5 Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev am: 2a28ae8a3f am: da45ddb921
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20213328

Change-Id: Ib0198ed6d4c19b1889bde9144ed33b30a0dedae7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 22:24:43 +00:00
TreeHugger Robot
be8c42e5a1 Merge "Making Launcher TAPL check orientation only when the expected orientation is set by the test" 2022-10-17 21:58:11 +00:00
Hui Kang
2a28ae8a3f Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev 2022-10-17 21:20:09 +00:00
Hui Kang
cee6ddf3de Revert "Updating the scroll calculation from recyclerView to avoid view inflation"
This reverts commit 20bbe95ddb.

Reason for revert: Causing flake in Ironwood test: b/248295569

Test: ABTD
Before: Flaky, 14/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L33900000956890639

Revert: 50/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L49200000956887317

Change-Id: I41f4428c74e581323f90c716a7852b5e553ae27d
2022-10-17 20:37:49 +00:00
vadimt
9853497f6c Making Launcher TAPL check orientation only when the expected orientation is set by the test
This makes life simpler for tests that don't care about orientation

Bug: 245576832
Test: presubmit
Change-Id: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
Merged-In: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
2022-10-17 19:48:46 +00:00
vadimt
b18ac9a01a Making Launcher TAPL check orientation only when the expected orientation is set by the test
This makes life simpler for tests that don't care about orientation

Bug: 245576832
Test: presubmit
Change-Id: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
2022-10-17 19:45:53 +00:00
TreeHugger Robot
17ccbb9058 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev am: 126d178358 am: 5b9e0cf902
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20207527

Change-Id: Id785ae174b5c77844457da44bf949280e689fcc9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 18:40:13 +00:00
TreeHugger Robot
126d178358 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev 2022-10-17 17:40:17 +00:00
Alex Chau
6f0b0fe742 Revert "Enable taskbar in overview by default"
This reverts commit 517131ae1c.

Reason for revert: Reverting until b/251747761 is addressed
Bug: 245320601

Change-Id: Ic5ebc071f092c8f91ff879a59d89c3be4326c90e
2022-10-17 14:38:09 +00:00
Pat Manning
1a2e1ea4fc Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev am: 956631ec3a am: 423ad32120
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852201

Change-Id: Ic7287a3a8e99e3b82c0fd28e3e4d0c14044c299f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 14:09:26 +00:00