Commit Graph

25054 Commits

Author SHA1 Message Date
Xin Li
535cd59c6c [automerger skipped] DO NOT MERGE - Skip QQ1A.191003.001 in stage-aosp-master am: db631e7f97
am: 6da429a4c4 -s ours
am skip reason: subject contains skip directive

Change-Id: I8e34ddfbe463e87eb0feb3a1263d8db268660c93
2019-11-22 12:03:05 -08:00
Xin Li
6da429a4c4 DO NOT MERGE - Skip QQ1A.191003.001 in stage-aosp-master
am: db631e7f97

Change-Id: I2c6053312332e242d75f08c950756d72ada207f1
2019-11-22 11:13:20 -08:00
Xin Li
db631e7f97 DO NOT MERGE - Skip QQ1A.191003.001 in stage-aosp-master
Bug: 144955631
Change-Id: Ib89d21099be0a67844fe674b35196e3198bfe732
2019-11-22 10:47:04 -08:00
Hyunyoung Song
51ba729f5d [automerger skipped] Merging from ub-launcher3-qt-future-dev @ build 6018744 am: 793f5c5186
am: 8b406b8d31 -s ours
am skip reason: change_id I8a1e20d0b175f03a1a05c81749f07ab5314e872a with SHA1 73b84ce47f is in history

Change-Id: If28a800615a8a50ec5bf9b15f12a43658012e998
2019-11-20 12:35:25 -08:00
Hyunyoung Song
8b406b8d31 Merging from ub-launcher3-qt-future-dev @ build 6018744
am: 793f5c5186

Change-Id: I482ace6717063630d3c5018c471601cfd21a2f19
2019-11-20 12:31:54 -08:00
Hyunyoung Song
793f5c5186 Merging from ub-launcher3-qt-future-dev @ build 6018744
Test: manual, presubmit on the source branch
http://x20/teams/android-launcher/merge/ub-launcher3-qt-future-dev_6018744.htmlMerge commit '9353b00616ac688d2df6b9f8513c4895bb4119d7' into merge_ub-launcher3-qt-future-dev_6018744

Change-Id: Ie6235a262b7bba0aa9f2a2962a7aa499a0a2cb53
Merged-In: I8a1e20d0b175f03a1a05c81749f07ab5314e872a
2019-11-20 08:40:59 +00:00
Hyunyoung Song
73b84ce47f Merging from ub-launcher3-master @ build 6018909
Test: manual, presubmit on the source branch
http://x20/teams/android-launcher/merge/ub-launcher3-master_6018909.html

Change-Id: I8a1e20d0b175f03a1a05c81749f07ab5314e872a
2019-11-19 17:12:13 -08:00
Hyunyoung Song
a45552c090 Merge commit '40f875679387c0f6f908428d0142eacefeda0247'
This CL adds git history that is missing in: ag/q/topic:merge_5945220

How was this generated:
$ git merge -s ours 40f8756793

More context:
40f8756793 is Launcher3 SHA from build 5945220

Test: on top of this git history CL, I executed merge and only two files
had merge conflicts BaseIconFactory and QuicksteLauncher.

Change-Id: Ifd9b738aa681202cff09ccfc18c2a2f8a08acbe3
2019-11-19 14:23:57 -08:00
Vadim Tryshev
8bdd83ec1b Merge "Staring swipe-to-all-apps gesture from above bottom gesture area" into ub-launcher3-master 2019-11-19 21:49:20 +00:00
vadimt
4d627f09c0 Staring swipe-to-all-apps gesture from above bottom gesture area
Bug: 139682945
Change-Id: I2fe8929c1dea8448c23394afd6f9d711b73f2562
2019-11-19 21:48:55 +00:00
TreeHugger Robot
f982b0dcc8 Merge "[a11y] fix the issue where launcher announces item added to homescreen before it does" into ub-launcher3-master 2019-11-19 07:29:44 +00:00
Samuel Fufa
a9e9444070 Merge "Report app pin/unpin to AppPredictor" into ub-launcher3-master 2019-11-19 01:18:15 +00:00
TreeHugger Robot
23ac34a42c Merge "When scrolling in All apps, scroll to last clickable row" into ub-launcher3-master 2019-11-19 00:01:10 +00:00
Winson Chung
ea91205f66 Merge "Fix two small thumbnail leaks" into ub-launcher3-master 2019-11-18 18:41:49 +00:00
Samuel Fufa
4031d65171 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev
am: 9353b00616

Change-Id: I37fab57d0c01b413ca05049326ca519d6d74323e
2019-11-18 10:32:02 -08:00
Samuel Fufa
9353b00616 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev 2019-11-18 18:19:14 +00:00
Samuel Fufa
7a8be030aa Report app pin/unpin to AppPredictor
Test: Manual
Bug: 142753423
Change-Id: I380e58f31ed508d812d0bf8dfc35905a752dc029
2019-11-18 10:14:53 -08:00
Tracy Zhou
897813aa34 Merge "Check if returned surface params are null before adding them for surface transform" into ub-launcher3-master 2019-11-15 21:45:25 +00:00
vadimt
73cd121122 When scrolling in All apps, scroll to last clickable row
Not the last row. This fixes tests broken after some assumption broke in
platform at an unknown moment.

Since the gesture distance became smaller in some cases, the speed of
the gesture became slower, and on some devices, the scroll gesture
triggers icon dragging.

To prevent this, I reduced the number of steps in the gesture to 10, but
added a slow-down at the end of the gesture to avoid inertia.

Also made some names and calculations clearer.

Bug: 144180777
Change-Id: Ie6c5776606ecff64d553fa836bdb3d90f32c5d9e
2019-11-15 13:40:29 -08:00
Tracy Zhou
fdf954a353 Check if returned surface params are null before adding them for surface transform
We call finish recents animation before app switch animation finishes. When we finish, the live tile params are not cleared up.

This change takes care of
- clean up recents animation targets when it's finished
- do a sanity check on live tile surface params before adding them to the surface transform array

Fixes: 143889142
Test: Swipe up to Overview in live tile mode, switch to a different task, and make sure it doesn't crash anymore
Change-Id: I089cf0a97744461d1fec4d0c97e0c3c6c1049ae3
2019-11-15 13:06:36 -08:00
Winson Chung
9b5f4aa48d Fix two small thumbnail leaks
- Even though the object wrapper is used within the same process, the
  call to start the fallback recents activity means that the system
  still ends up holding a reference to a copy of the intent and its
  extras, including the reference to the wrapper and the thumbnail it
  references, until the activity is destroyed (or next restarted).
  We need to clear the actual object strong ref after it's used when
  handling the new intent.
- The running task can have an associated thumbnail, so we should also
  clear the tmp running task ref when we leave overview.

Change-Id: Icdc0b1989b13927d112949797752615014856970
2019-11-15 11:31:15 -08:00
TreeHugger Robot
1dca644311 Merge "Disabling FallbackRecents tests" into ub-launcher3-master 2019-11-15 16:50:02 +00:00
Pinyao Ting
96df2cb8b3 [automerger skipped] Merge "fix custom shortcut test" into ub-launcher3-qt-future-dev
am: f7b75392fc -s ours
am skip reason: change_id I296452faea67568b39a35968bb813dc4e51a51fc with SHA1 44677f7e88 is in history

Change-Id: I880b94cbc3f5dfcd98f8886c454657bba466885e
2019-11-14 18:16:26 -08:00
Pinyao Ting
f7b75392fc Merge "fix custom shortcut test" into ub-launcher3-qt-future-dev 2019-11-15 01:55:40 +00:00
Pinyao Ting
838f4393b6 fix custom shortcut test
Bug: 143725213
Change-Id: I296452faea67568b39a35968bb813dc4e51a51fc
Merged-In: I296452faea67568b39a35968bb813dc4e51a51fc
2019-11-15 01:55:13 +00:00
vadimt
cbc9bffd7e Disabling FallbackRecents tests
Even though they don't block presubmit, the fact that they are failing:
1. Causes sheriffs no not notice other issues;
2. Would block switching to 24hr fix-it policy and Quarterdeck.

Bug: 143488140
Change-Id: I95e3e15b69e0487946919f3f6889e286a1fae141
2019-11-14 17:23:52 -08:00
Vadim Tryshev
d82d667194 Merge "Revert "When scrolling in All apps, scroll to last clickable row"" into ub-launcher3-master 2019-11-15 00:58:22 +00:00
TreeHugger Robot
498c9d63e1 Merge "fix custom shortcut test" into ub-launcher3-master 2019-11-15 00:48:29 +00:00
Pinyao Ting
c90742775b [a11y] fix the issue where launcher announces item added to homescreen before
it does

Test:
1. long press on home screen -> widgets
2. enable talkback
3. add a custom shortcut to home screen (i.e. 1x1 widgets, e.g. drive
scan in Google Drive, Driving Mode in Google Maps ... e.t.c )
4. verify talkback announces "item addded to homescreen" after it does
get added to the homescreen
5. repeat the same test for widgets (e.g. calendar)

Bug: 141527338
Change-Id: I232e6e796c9edb81128f816c71a33310c3700e73
2019-11-14 22:37:24 +00:00
Vadim Tryshev
a354835c6e Revert "When scrolling in All apps, scroll to last clickable row"
This reverts commit 7afd271a17.

Reason for revert: b/144522058

Bug: 144522058

Change-Id: Ie104b092a44e3a2fee0803fa83f1af7f8fd0afdf
2019-11-14 22:34:08 +00:00
Pinyao Ting
44677f7e88 fix custom shortcut test
Bug: 143725213
Change-Id: I296452faea67568b39a35968bb813dc4e51a51fc
2019-11-14 14:13:22 -08:00
Thiru Ramasamy
445cc2421e Merge "Fixes missing LauncherEvent for TAP action on FOLDER_ICON" into ub-launcher3-qt-future-dev
am: 9d9c42ef38

Change-Id: I1d67cb5a77c46e05ddfdfa547a12d8c64c7b4fdd
2019-11-14 14:07:42 -08:00
Samuel Fufa
ddab25da6b Merge "Enable a11y scrolling with item drag" into ub-launcher3-qt-future-dev
am: 574e8413ba

Change-Id: I37c71d6f55d2478d029a9509ca61d32599582442
2019-11-14 14:04:35 -08:00
Thiru Ramasamy
9d9c42ef38 Merge "Fixes missing LauncherEvent for TAP action on FOLDER_ICON" into ub-launcher3-qt-future-dev 2019-11-14 22:02:09 +00:00
Samuel Fufa
574e8413ba Merge "Enable a11y scrolling with item drag" into ub-launcher3-qt-future-dev 2019-11-14 21:53:04 +00:00
Samuel Fufa
10b106dc8a Merge "Icon left side badging" into ub-launcher3-master 2019-11-14 21:10:47 +00:00
Samuel Fufa
d145647301 Merge "Make home setting edge-to-edge" into ub-launcher3-qt-future-dev
am: 16691a72bf

Change-Id: I7b74c8171b26ea38b4b284e900abce03baf5ea79
2019-11-14 12:56:32 -08:00
Samuel Fufa
16691a72bf Merge "Make home setting edge-to-edge" into ub-launcher3-qt-future-dev 2019-11-14 20:40:02 +00:00
Samuel Fufa
1c8d90aed0 Fix folder available height calculation
Bug: 139456471
Test: Manual
Change-Id: Ic86c481e76f8b6629ad74109ef98900f1c00e16c
2019-11-14 11:02:49 -08:00
vadimt
fa6f56761b Improving error message
The old one could be misunderstood as "the whole Launcher is missing".

Change-Id: I91cad52ee297b0250cba23215743a47c24757ae1
2019-11-13 18:26:28 -08:00
Samuel Fufa
a4431f8abe Icon left side badging
Test: Manual
Bug:138947443
Change-Id: I8a7ce6e1cccfbfd6c2c6fad96768ab64cfdb41b1
2019-11-13 17:06:16 -08:00
vadimt
132b5a0bf8 [automerger skipped] Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-qt-future-dev
am: 49e72ac059 -s ours
am skip reason: change_id I19e3ba7cfa25de75a47202845d0838bea46af92c with SHA1 480083490f is in history

Change-Id: I615cd69e7442139be0270ed655c578a29a799233
2019-11-13 14:13:18 -08:00
TreeHugger Robot
49e72ac059 Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-qt-future-dev 2019-11-13 22:03:11 +00:00
vadimt
ec7c044c89 Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the icon on AllApps is higher that 2 paddings.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
Merged-In: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 21:45:16 +00:00
Samuel Fufa
8fb487413c Enable a11y scrolling with item drag
Bug:142300278
Test:Manual
Change-Id: Ieb79dac8a793f5adfe715b1cbe5b7ecae95a26b5
2019-11-13 13:22:49 -08:00
TreeHugger Robot
236ef051fd Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-master 2019-11-13 20:52:36 +00:00
vadimt
480083490f Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the whole icon is visible.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 20:20:57 +00:00
Pinyao Ting
fed4d8e8da disable custom shortcut test in oop
am: d9dd8ef3ba

Change-Id: I6cb1f18c3e7ca1cd79aa5f58a0e03ef07eb797ee
2019-11-13 10:40:01 -08:00
Pinyao Ting
d9dd8ef3ba disable custom shortcut test in oop
Bug: 142154748
Change-Id: I08ec8f665a3cc45610f8f2b27a60f7334a2b1b24
2019-11-12 23:37:20 -08:00
Pinyao Ting
88267345d8 [automerger skipped] include predicted_rank in app launch logging
am: 1397a42fc2 -s ours
am skip reason: change_id I07a62f07057537a6c09384cf944bbc5aa5888d22 with SHA1 2cf2871392 is in history

Change-Id: I7fe54e69c6a6ed9909264c771f423ade8dad868d
2019-11-12 18:04:05 -08:00