Commit Graph

82209 Commits

Author SHA1 Message Date
Treehugger Robot
51c9c19e89 Merge "Remove RecentTasksList implement of DesktopVisibilityController" into main 2025-05-02 18:26:06 -07:00
Treehugger Robot
418a8e4aa9 Merge "Update All Apps divider color." into main 2025-05-02 17:43:28 -07:00
Treehugger Robot
b393e253de Merge "Fix Data Import for folder-internal items" into main 2025-05-02 17:17:51 -07:00
Andy Wickham
34fba0fcb7 Merge "Ensure an opaque scrim is used for legacy all apps." into main 2025-05-02 16:39:53 -07:00
Treehugger Robot
f3fceaca6c Merge "Update All Apps sheet interpolators." into main 2025-05-02 16:35:06 -07:00
Treehugger Robot
1a597d619b Merge "Remove IME-specific touch passthrough for Taskbar" into main 2025-05-02 14:42:04 -07:00
Liran Binyamin
00dc879e2c Merge "Send bubble bar distance to shell" into main 2025-05-02 14:35:40 -07:00
Ats Jenk
e2c8c68edb Merge "Make sure animation is cancelled for existing flyout" into main 2025-05-02 14:22:24 -07:00
Andy Wickham
4efae39779 Ensure an opaque scrim is used for legacy all apps.
When there's no background panel, we should ensure an opaque
background scrim is used.

Fix: 414718408
Test: Manual with all_apps_blur and all_apps_sheet_for_handheld off.
Flag: EXEMPT bugfix
Change-Id: I1ac9f5f8fbb01f2c6a42e9f79823b5f293ebf709
2025-05-02 13:49:51 -07:00
Andy Wickham
28f422544e Update All Apps sheet interpolators.
This is a bit of a stopgap until we are able to adopt a more
versatile mechanism similar to SysUI, but here's the high level:
 - Workspace scale finishes more quickly than blur (53% vs 83% of
   the transition)
 - Closing All Apps reverses the opening interpolators (avoid blur
   disappearing too quickly).

Design intent is described in the bug.

Demo: https://drive.google.com/file/d/14Y28NeHoh_RBh3acXijhhx_ZIUK8GmYy/view?usp=drive_link&resourcekey=0-A9AUbEZcJsmP1GtSqbbrgg

Bug: 415247657
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Flag: com.android.launcher3.all_apps_blur
Test: Manual
Change-Id: Iffa8e6f9dd98817899aadb3fb28fecd6c53bca7e
2025-05-02 13:36:27 -07:00
Treehugger Robot
7a2d5b454f Merge "Add magnetic detach to task dismiss using MotionValue library." into main 2025-05-02 12:34:47 -07:00
Treehugger Robot
21779a4192 Merge "Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused" into main 2025-05-02 11:46:48 -07:00
Treehugger Robot
d2cf9a98f2 Merge "Ignore KeyboardQuickSwitchControllerTest to fix robo failure" into main 2025-05-02 11:06:08 -07:00
Xiaoqian (Daisy) Dai
276e0be2a4 Merge "desktop-exploded-view: temporarily disable the functionality..." into main 2025-05-02 10:55:42 -07:00
Stefan Andonian
1725d9d75f Fix Data Import for folder-internal items
Bug: 379378706
Test: Verified this works locally.
Flag: com.android.launcher3.external_data_access
Change-Id: I0396a593bd02591ae599e0eb9b9e44922bd17960
2025-05-02 10:55:17 -07:00
Jagrut Desai
d95a630277 Merge "Tapl widget change" into main 2025-05-02 10:49:24 -07:00
Pat Manning
d2f050ab26 Add magnetic detach to task dismiss using MotionValue library.
Fix: 389081766
Test: TaplTestsQuickstep
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I77f980f9851f4b1c041cbf3bb7247b972c1730fd
2025-05-02 17:13:57 +01:00
Sunny Goyal
46b13eb184 Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused
Bug: 390572144
Flag: EXEMPTY refactor
Test: Presubmit
Change-Id: I41c5fea73452d7f4c1fd9980a89bcb7199eb19d7
2025-05-02 08:55:21 -07:00
Liran Binyamin
34024fe26a Send bubble bar distance to shell
We previously sent the top coordinate of the bubble bar to shell.
However when the screen height changes, launcher takes a bit longer
to update than shell. So instead of calculating the top coordinate
on the launcher side, we now send the amount of space between the
bubble bar and the bottom of the screen to shell, where we can offset
that as needed.

Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
       - send some bubbles
       - launch app
       - expand
       - swipe to home
       - fold and unfold
Change-Id: I57b96db49dab1e2304fde8dc55a99eaaf85e40f8
2025-05-02 10:54:39 -04:00
Schneider Victor-tulias
9b468c5b24 Merge changes Id95b36da,I6a2225be into main
* changes:
  Fix recents window activity leak
  Update TAPL tests to dismiss all tasks safely
2025-05-02 07:38:30 -07:00
Alex Chau
14f266442b Merge "Don't consider IME insets in mSystemGestureRegion" into main 2025-05-02 01:47:08 -07:00
Treehugger Robot
5f38710c0e Merge "Only use RecentsWindowManager instances for CDs" into main 2025-05-01 22:42:17 -07:00
Ajinkya Chalke
d616551419 Only use RecentsWindowManager instances for CDs
Bug: 414767197
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I8f2f143ef8ca885c089b83559899746ac594400a
2025-05-02 00:13:53 +00:00
Xiaoqian Dai
b9d3a5cc44 desktop-exploded-view: temporarily disable the functionality...
... to launch an individual task window from desktop tile in Overview
when multi-desks is enabled, until the fix for b/413378320 is landed.

Note the changes in
http://ag/q/topic:%22activate-window-from-exploded-view%22 is the right
implementation, however it will only work for multi-desks with the fix
for b/413378320 is in place.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413378320
Change-Id: I72914d60fb0ec2e80af6faa7441a67e743720c38
2025-05-01 23:59:05 +00:00
Vadim Tryshev
bc6b9ea148 Merge "Failures caught by launcher.checkForAnomaly did not produce screenshots." into main 2025-05-01 16:29:38 -07:00
Ajinkya Chalke
98ce0f4ccb Ignore KeyboardQuickSwitchControllerTest to fix robo failure
Bug: 413540825
Flag: EXEMPT ignoring test
Test: atest
Change-Id: I75a15563fbc8cc500df73c9b1d1e9bf2e2d378b8
2025-05-01 16:16:19 -07:00
Jagrut Desai
4fde59e821 Tapl widget change
- scroll if the header is under gesture region and click in same scroll loop

Test: Local, Presubmit
Bug: 402828709
Flag: EXEMPT bugfix

Change-Id: I90a5cf2829591aafd18ef625244def2c4d9e3980
2025-05-01 16:15:25 -07:00
Treehugger Robot
2d65e55681 Merge "Use DesktopExperienceFlags instead of DesktopModeFlags for enableRecentsWindowProtoLog" into main 2025-05-01 15:51:42 -07:00
Treehugger Robot
c3a397b01c Merge "Skip already running check when switching in KQS" into main 2025-05-01 15:29:28 -07:00
Schneider Victor-tulias
23244b6944 Merge "Move ExtendedLongPressTimeoutRule implementation to shared sysui test library" into main 2025-05-01 15:27:41 -07:00
Brian Isganitis
3b9b36255b Merge "Use LauncherPrefs for stashed handle region dark." into main 2025-05-01 13:46:44 -07:00
Sunny Goyal
982dafadc9 Merge "Using List instead of ArrayList in CollectionInfo to avoid typecast in subclasses" into main 2025-05-01 13:30:47 -07:00
Vadim Tryshev
9b0d61a803 Failures caught by launcher.checkForAnomaly did not produce screenshots.
Fix to handle failures caught by launcher.checkForAnomaly so that they
are also reported to the test watcher.

Bug: 406906811
Test: presubmit
Flag: NONE Not production code
Change-Id: I379fcf09e3cd2e6321be9f4bc3dd6f3272e9c2fd
2025-05-01 13:29:18 -07:00
Schneider Victor-Tulias
3818462d0e Fix recents window activity leak
- When we clean up the recents window, the recents view gets dettached, which causes a activity leak in tests and prod through RecentsView.mOnTaskLaunchCancelledRunnable. Fixing this leak across all uses of RecentsView, rather than just for RecentsWindowManager
- Also cleaning up a potential leak in RecentsWindowManager.callbacks

Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Bug: 292269949
Test: swiped up from running app, checked leak canary and heap dump; pre/post-submit tests
Change-Id: Id95b36dad6e41e5b21d1af8ede489f84ef987e50
2025-05-01 16:07:27 -04:00
Schneider Victor-Tulias
a56aa0d539 Update TAPL tests to dismiss all tasks safely
Flag: EXEMPT test refactor
Bug: 377678992
Test: pre/post-submit tests
Change-Id: I6a2225bea4f004bdc598e2c67ce26da9fd42f7a6
2025-05-01 16:04:32 -04:00
Schneider Victor-Tulias
42d6c08d41 Move ExtendedLongPressTimeoutRule implementation to shared sysui test library
Flag: EXEMPT test fix
Fixes: 396862825
Test: TaskbarExpandCollapse
Change-Id: I950ed4ede8db150234d843422982792f5b6bfd8e
2025-05-01 11:38:27 -07:00
Treehugger Robot
5d600e171d Merge "Fix folder close animation from jumping by initializing animation manager correctly." into main 2025-05-01 11:01:13 -07:00
Ats Jenk
506b2a8b35 Make sure animation is cancelled for existing flyout
When we show a new flyout, it is possible for the previous flyout to
still be there and animating out.
We were removing the existing flyout, but did not cancel the animation.
This meant that there could have been a hide animation running for the
previous flyout. Once that animation finished, it removed the current
flyout from the container. It was possible for the current flyout to
already be updated to the new one. In which case the animation for the
previous flyout hid the new flyout.

Bug: 414808503
Test: atest PlatformScenarioTests:BubbleBarTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I4229297fa999d815c12eefd9d583bdfc915ec00a
2025-05-01 10:52:41 -07:00
Xiaoqian (Daisy) Dai
8eda6e708f Merge "desktop-exploded-view: Implement the activate window behavior" into main 2025-05-01 10:41:06 -07:00
Tony Wickham
41b1c52c7f Remove IME-specific touch passthrough for Taskbar
It doesn't seem necessary anymore (and anyway, existing cases like
Taskbar being stashed while IME is showing handle this as well).
Removing the specific block fixes a bug where touches were going
to the underlying app even though Taskbar window is fullscreen
while editing a Folder name.

Fixes: 400859085
Test: TaskbarInsetsControllerTest
Flag: EXEMPT bugfix

Change-Id: If30acd0b3b9c3fd0b29b94ca963beb1c70162416
2025-05-01 16:43:31 +00:00
Ajinkya Chalke
011422cdb4 Skip already running check when switching in KQS
- In KQS existing code there is a check that returns early if a user is
  trying to switch to a running task. This check returns true for a task
  that is not running thus creating an issue when user tries to switch
  to that task using KQS.
- While the root cause of the issue will take time to fix, this
  temporary check ensures that we workaround it when flatenning
  heirarchy feature is enabled. This issue happens when multi-desk
  backend flag is true and flatenning flag will always be true when
  multi-desk is true (given how the features are timed for release).

Flag: com.android.launcher3.enable_alt_tab_kqs_flatenning
Test: m
Bug: 414410702
Change-Id: Ia35d6706a1512efbb4feca0128a9d59cd930df2f
2025-05-01 15:22:28 +00:00
Alex Chau
033c8535c7 Don't consider IME insets in mSystemGestureRegion
- A recent change applied IME insets equal to keyboard's height to Launcher's BaseDragLayer
- mSystemGestureRegion takes a max of both IME insets and gesture insets, and caused a bug that while a live tile have keyboard open is in Overview, bottom half of the screen ignored touches to dismiss the task
- The bug that ointroduceds IME insets consideration no longer repros, thus removing IME insets from mSystemGestureRegion to sovle the issue

Fix: 404376494
Test: manual
Flag: EXEMPT bug fix
Change-Id: I5d8861ea204df9898b10cb7ccdeba94e94e5909c
2025-05-01 15:54:06 +01:00
Jordan Silva
de6ce21ed5 Reset IconAppChipView when DesktopTaskView is recycled
Bug: 411406340
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Change-Id: I119599d575c82b6cce71ac3cbb4b709914f34bda
2025-05-01 03:07:55 -07:00
Treehugger Robot
21df4da217 Merge "Remove dark mode Launcher3 colors for blur." into main 2025-04-30 23:50:48 -07:00
Andy Wickham
3a282d3c28 Remove dark mode Launcher3 colors for blur.
These were intended to be placeholders for non-quickstep builds,
but it seems soong ends up using the base version instead of the
override in quickstep. So now we always use the non-night version
which gets overridden correctly (and that color resource itself
defines a dark mode variant).

Test: mp launcherd - verify light and dark mode use themed colors.
Bug: 414732288
Flag: com.android.launcher3.all_apps_blur
Change-Id: I21bf8e66bf1715a8b3532931ed64725ccc3f86b9
2025-05-01 04:23:40 +00:00
Treehugger Robot
675282b181 Merge "Revert^2 "Restrict nav mode UI checks within primary display"" into main 2025-04-30 20:53:19 -07:00
Andy Wickham
1e2e88a884 Update All Apps divider color.
Also update how theming is applied. We pass a ContextThemeWrapper
to relevant views to retrieve the updated colors.

Demos switching blur on and off with adb:
 - From top (QSB, handle, divider): https://drive.google.com/file/d/1FHNzp5bNbNtH8tM7rSjKELPr6hsETPST/view?usp=drive_link&resourcekey=0-JuiAUJoNh4Pe_xKa74h0-g
 - Scrolled down (header protection + private space): https://drive.google.com/file/d/1gb1GCH3tJHS7HzOjvXgrTxNQ9gfD59dw/view?usp=drive_link&resourcekey=0-AK58FpfN-sDfWhWkmqaEmA

Test: Manual
Flag: com.android.launcher3.all_apps_blur
Fix: 413143411
Change-Id: I5da3b7c38ea4f81dec1011b6cc15ad8b591c761b
2025-05-01 02:25:02 +00:00
Treehugger Robot
1ca1bf9c9d Merge "Apply fallback overview scrim, overviewactions and clearall in battery saver mode." into main 2025-04-30 19:13:54 -07:00
Treehugger Robot
3a21402211 Merge "Fix crash when previously selected shape no longer exists" into main 2025-04-30 17:13:19 -07:00
Sunny Goyal
9ec1c5f691 Using List instead of ArrayList in CollectionInfo to avoid typecast in subclasses
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I57c1a7c0c0ea32e710e1d7c03f249f84fc937196
2025-04-30 16:07:43 -07:00