Commit Graph

74422 Commits

Author SHA1 Message Date
Bill Yi
4cc2559564 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9f2e6decb861db72d2ca01385992ac8cd3873d32
2024-03-01 19:33:16 -08:00
Jagrut Desai
02c56e8258 Merge "Fixing taskbar being unstashed after opening to unfolded mode" into main 2024-03-01 21:43:24 +00:00
PODISHETTY KUMAR
b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Jeremy Sim
c8c4fd8aeb Merge "Fix disabled state for non-resizeable app pairs" into main 2024-03-01 05:14:48 +00:00
Vinit Nayak
5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Jagrut Desai
3c3bef333a Fixing taskbar being unstashed after opening to unfolded mode
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: I91aa947a707e3fc918e617f207e823b2f1460466
2024-02-29 16:17:24 -08:00
Bill Yi
4b12762881 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-29 23:12:58 +00:00
Bill Yi
08fe4d0135 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-29 23:12:58 +00:00
Zak Cohen
e3e00c6e26 Merge "Widget Picker - show app icon next to recommended app label." into main 2024-02-29 21:55:37 +00:00
Jeremy Sim
31b934f28f Fix disabled state for non-resizeable app pairs
This CL makes it so that app pair creation includes updating some flags on the newly created WorkspaceItemInfos -- specifically the FLAG_NON_RESIZEABLE flag. Previously, flag updating only happened upon launcher restart or package change, which meant that newly created app pairs were missing some flags.

This caused App+Camera pairs to not have the FLAG_NON_RESIZEABLE flag immediately on app pair creation, which affected the disabled state.

Fixes: 323088270
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I96c6ec3723bec2ddaa0af625890b983faf2fe2c7
2024-02-29 13:42:43 -08:00
Saumya Prakash
3fb35d3fb8 Merge "Remove the tint from taskbar themed icons for dark mode." into main 2024-02-29 20:05:15 +00:00
Jeremy Sim
164d162ec6 Merge "Update app pair error strings with UXW-approved ones" into main 2024-02-29 19:47:41 +00:00
Jeremy Sim
8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Vadim Tryshev
0fa523bb32 Merge "Removing logging for verifying internal Launcher state from tests" into main 2024-02-29 19:18:04 +00:00
Tony Wickham
47a85e4607 Merge "Call showCurrentTask again if applyLoadPlan doesn't include running task" into main 2024-02-29 17:19:11 +00:00
Federico Baron
835b9610bc Merge "Update some dimens for portrait edit state" into main 2024-02-29 17:17:19 +00:00
Jakob Schneider
a9338897a4 Merge "Add dedicated a11y label for archived apps." into main 2024-02-29 10:54:31 +00:00
Bill Yi
99f1bf8af6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I493a63156b699e6251b4a8c64d50600513969a8e
2024-02-28 21:56:05 -08:00
Bill Yi
70799d4540 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If0d3c974835120248fb17d97fd678ef5921a46a8
2024-02-28 21:55:23 -08:00
Jeremy Sim
41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Vinit Nayak
2b4e99344d Merge "Remove A11y node info for SplitInstructionsView" into main 2024-02-29 03:16:28 +00:00
Federico Baron
b68a6e581c Merge "Add ScreenRecord for workTabExists tapl test" into main 2024-02-29 02:56:55 +00:00
Jeremy Sim
bdabf0f072 Update app pair error strings with UXW-approved ones
Fixes: 327432662
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: N/A
Change-Id: Ie437a67be7029da404dbb2c8f326a2140ac36138
2024-02-28 18:56:31 -08:00
Treehugger Robot
bdd76bed63 Merge "Add toString() dump for Launcher SplitBounds" into main 2024-02-29 00:43:17 +00:00
Brandon Dayauon
343ecb7cf8 Merge "Don't show fastScrollBar when collapsing" into main 2024-02-29 00:41:11 +00:00
Tony Wickham
bf885ceb5f Call showCurrentTask again if applyLoadPlan doesn't include running task
Test: swipe up from an app that has excludeFromRecents=true, e.g.
Volume Dialog, Home quick settings tile, and Routines widget; ensure
the gesture works as expected (e.g. can quick switch, go home, or to
overview with all tasks visible).
Flag: none
Fixes: 324495241

Change-Id: If3b61f7d1725ee573fad38140bfeb77f3a6cea1e
2024-02-29 00:36:16 +00:00
Treehugger Robot
e5f02039eb Merge "Debugging Logs for TaplDragTest#testDragAppIconToMultipleWorkspaceCells" into main 2024-02-28 23:59:38 +00:00
Saumya Prakash
ba04c0c1dc Remove the tint from taskbar themed icons for dark mode.
We remove the added tint to taskbar themed icons to match how they look
in the hotseat on launcher home screen specifically for dark mode.

Fix: 323952706
Test: Turn on themed icons and dark mode. Compare app icons in taskbar
and in hotseat
Flag: N/A

Change-Id: I4dfe352ca17ef5537e48fcc3cff66ba4fd4f603a
2024-02-28 23:07:07 +00:00
fbaron
bd528add50 Add ScreenRecord for workTabExists tapl test
Bug: 325383911
Test: TaplWorkProfileTest#workTabExists
Flag: NONE
Change-Id: I83c92376b16c9b0de352a03ce297e7a9ae51123d
2024-02-28 12:07:49 -08:00
Sukesh Ram
872b9f9a61 Debugging Logs for TaplDragTest#testDragAppIconToMultipleWorkspaceCells
Add logging for TaplDragTest#testDragAppIconToMultipleWorkspaceCells.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326908466
Change-Id: Icb3262d6af66c9b947cb0cc92c1c67556fba315f
2024-02-28 19:28:07 +00:00
Vadim Tryshev
544f6e228c Add TestStabilityRule so that @Stability annotation works
Bug: 319923578
Test: presubmit
Flag: N/A
Change-Id: I5613a2ee658a458871ea89219764d13796d07b83
2024-02-28 18:27:39 +00:00
Sebastián Franco
8833826b00 Merge "Adding grid_migration_fix and narrow_grid_restore flag" into main 2024-02-28 17:20:31 +00:00
Jagrut Desai
07959348e6 Merge "Fixing taskbar unstashing after unfolding" into main 2024-02-28 15:21:40 +00:00
Eghosa Ewansiha-Vlachavas
7cc75c6a43 Merge changes from topics "removeDesktopMode2", "replaceDesktopWindowingFlag" into main
* changes:
  [2/n] Remove use of `persist.wm.debug.desktop_mode_2`
  [2/n] Replace read-only desktop windowing flag with runtime flag
2024-02-28 14:24:09 +00:00
Federico Baron
6f7916d647 Merge "Fix TaplOpenCloseAllAppsTest#testAllAppsFromHome" into main 2024-02-28 06:17:13 +00:00
Federico Baron
c2b06abd6c Merge "Add screenrecord for testOverviewDeadzones" into main 2024-02-28 06:16:32 +00:00
Vinit Nayak
0edcfa4979 Merge "Update animation timing for split dismiss animation" into main 2024-02-28 04:14:28 +00:00
Vinit Nayak
75306186e0 Add toString() dump for Launcher SplitBounds
Bug: 286509643
Change-Id: I57e04c571678dbb553c7d35128d8e63700a2f382
2024-02-27 17:07:44 -08:00
Sukesh Ram
1909570ed3 Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu
Add logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: I5f08192bb1143c1d23f8884bb207ce69c5830a41
2024-02-28 01:06:14 +00:00
Vinit Nayak
dfbf253f90 Remove A11y node info for SplitInstructionsView
* Individual text view and cancel button still
have their own a11y actions, but top level
view doesn't need one

Test: Tested w/ switches to ensure parent view
doesn't get selected. Tested w/ Talkback to
ensure we can still cancel through talkback
Fixes: 323462927

Change-Id: I60d21f6e768c59f29f51007f56ff784821487895
2024-02-27 16:54:02 -08:00
fbaron
f1bbcbd743 Fix TaplOpenCloseAllAppsTest#testAllAppsFromHome
Bug: 322228038
Flag: NONE
Test: TaplOpenCloseAllAppsTest#testAllAppsFromHome
Change-Id: I13b31dc16fca02a4e8770aca56e35e8606dd21b3
2024-02-27 16:24:10 -08:00
Treehugger Robot
90182bffc1 Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-02-28 00:02:38 +00:00
fbaron
eb65ca1600 Add screenrecord for testOverviewDeadzones
Bug: 326839375
Test: TaplTestsQuickstep#testOverviewDeadzones
Flag: NONE
Change-Id: Ic7e889be042a76aa0979cc32d3d43a562a80f491
2024-02-27 14:55:11 -08:00
Jagrut Desai
e424570af1 Fixing taskbar unstashing after unfolding
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: Iddd10df6e40ee2de4ef08eb18df88d48b7468035
2024-02-27 14:44:26 -08:00
Zak Cohen
26c26fe837 Widget Picker - show app icon next to recommended app label.
https://screenshot.googleplex.com/42gUGuSADdrW2CS

Bug: 323887132
Test: Manual, no test for widget cell yet.
Flag: NA
Change-Id: I95e7a645b3664361222d5045114224b17d8fdf34
2024-02-27 13:34:15 -08:00
Vadim Tryshev
dae8b65dea Removing logging for verifying internal Launcher state from tests
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: I25afcc30446d429171445f8e1b6033b277166725
2024-02-27 20:23:49 +00:00
Vinit Nayak
9c29c1e1c4 Update animation timing for split dismiss animation
* We weren't specifying an animation duration for the
dismiss placeholder animation, and it wasn't inheriting
from the animatorSet since that didn't have any duration
set on it.
* Now we explicitly set a duration (usually matching that of
the current launcher state config) to the timings line up
well

Test: Repro steps don't show bug. Also tested on large screen dismissing
contextual split from overview and home, seems fine
Fixes: 314860754

Change-Id: I701e4f88c1ddd92561da4fb76715a859f587c91e
2024-02-27 12:10:44 -08:00
Sukesh Ram
41c2a9a900 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I1309e8c1b2ce7b6c06cb520818ef109bbf2f2d23
2024-02-27 19:36:55 +00:00
Schneider Victor-tulias
7e0703eca0 Merge "Fix blocked gesture handling on failed startRecentsActivity calls" into main 2024-02-27 18:53:13 +00:00
Hyunyoung Song
caa54620e8 Merge "Fix container for aconfig flags." into main 2024-02-27 18:36:43 +00:00