From e2c5578ede49a3a3cad344e2129a48d40eb613f1 Mon Sep 17 00:00:00 2001
From: Terrence <terrence@tenclass.com>
Date: Sun, 19 Jan 2025 03:53:48 +0800
Subject: [PATCH] fixbug: getting empty value

---
 main/protocols/mqtt_protocol.cc | 4 ----
 main/protocols/mqtt_protocol.h  | 1 -
 main/settings.cc                | 2 +-
 3 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/main/protocols/mqtt_protocol.cc b/main/protocols/mqtt_protocol.cc
index 70455e18..8052c011 100644
--- a/main/protocols/mqtt_protocol.cc
+++ b/main/protocols/mqtt_protocol.cc
@@ -39,7 +39,6 @@ bool MqttProtocol::StartMqttClient() {
     client_id_ = settings.GetString("client_id");
     username_ = settings.GetString("username");
     password_ = settings.GetString("password");
-    subscribe_topic_ = settings.GetString("subscribe_topic");
     publish_topic_ = settings.GetString("publish_topic");
 
     if (endpoint_.empty()) {
@@ -92,9 +91,6 @@ bool MqttProtocol::StartMqttClient() {
     }
 
     ESP_LOGI(TAG, "Connected to endpoint");
-    if (!subscribe_topic_.empty()) {
-        mqtt_->Subscribe(subscribe_topic_, 2);
-    }
     return true;
 }
 
diff --git a/main/protocols/mqtt_protocol.h b/main/protocols/mqtt_protocol.h
index 4dd84ea3..7fd46cd1 100644
--- a/main/protocols/mqtt_protocol.h
+++ b/main/protocols/mqtt_protocol.h
@@ -37,7 +37,6 @@ private:
     std::string client_id_;
     std::string username_;
     std::string password_;
-    std::string subscribe_topic_;
     std::string publish_topic_;
 
     std::mutex channel_mutex_;
diff --git a/main/settings.cc b/main/settings.cc
index b617b3c5..751a5f46 100644
--- a/main/settings.cc
+++ b/main/settings.cc
@@ -31,7 +31,7 @@ std::string Settings::GetString(const std::string& key, const std::string& defau
     std::string value;
     value.resize(length);
     ESP_ERROR_CHECK(nvs_get_str(nvs_handle_, key.c_str(), value.data(), &length));
-    while (value.back() == '\0') {
+    while (!value.empty() && value.back() == '\0') {
         value.pop_back();
     }
     return value;