devttl/xiaozhi-esp32
1
0
Fork 0
forked from xiaozhi/xiaozhi-esp32
Code Pull Requests Activity

fix: OTA buffer overflow caused by slow SetChatMessage (#1031)

Browse Source
This commit is contained in:
Xiaoxia
2025-08-06 01:16:52 +08:00
committed by GitHub
parent da228f2582
commit 363073658a
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
main/application.cc
View File

@@ -118,9 +118,11 @@ void Application::CheckNewVersion(Ota& ota) {
vTaskDelay(pdMS_TO_TICKS(1000)); vTaskDelay(pdMS_TO_TICKS(1000));
bool upgrade_success = ota.StartUpgrade([display](int progress, size_t speed) { bool upgrade_success = ota.StartUpgrade([display](int progress, size_t speed) {
char buffer[64]; std::thread([display, progress, speed]() {
snprintf(buffer, sizeof(buffer), "%d%% %uKB/s", progress, speed / 1024); char buffer[32];
display->SetChatMessage("system", buffer); snprintf(buffer, sizeof(buffer), "%d%% %uKB/s", progress, speed / 1024);
display->SetChatMessage("system", buffer);
}).detach();
}); });
if (!upgrade_success) { if (!upgrade_success) {