mirror of
https://github.com/LawnchairLauncher/lawnchair.git
synced 2026-03-01 08:16:49 +00:00
140ed429ea
The folder bubble text views were being recycled after the launcher's cache was cleared. This caused the new orientation's folders to re-use the old views with their stale configuration. After this change, the cache won't recycle views whose cache entry has been recreated, implying that their environment might have changed and new setup is required. Bug: 230304658 Test: Verified erroneous UX on device was no longer reproducible after fix. Change-Id: Ib01cf5792d83df752e05534e5aa08ab8e8763bdc
84 lines
2.6 KiB
Java
84 lines
2.6 KiB
Java
/*
|
|
* Copyright (C) 2019 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
package com.android.launcher3.util;
|
|
|
|
import android.content.Context;
|
|
import android.util.SparseArray;
|
|
import android.view.LayoutInflater;
|
|
import android.view.View;
|
|
import android.view.ViewGroup;
|
|
|
|
import com.android.launcher3.R;
|
|
|
|
/**
|
|
* Utility class to cache views at an activity level
|
|
*/
|
|
public class ViewCache {
|
|
|
|
protected final SparseArray<CacheEntry> mCache = new SparseArray();
|
|
|
|
public void setCacheSize(int layoutId, int size) {
|
|
mCache.put(layoutId, new CacheEntry(size));
|
|
}
|
|
|
|
public <T extends View> T getView(int layoutId, Context context, ViewGroup parent) {
|
|
CacheEntry entry = mCache.get(layoutId);
|
|
if (entry == null) {
|
|
entry = new CacheEntry(1);
|
|
mCache.put(layoutId, entry);
|
|
}
|
|
|
|
T result;
|
|
if (entry.mCurrentSize > 0) {
|
|
entry.mCurrentSize --;
|
|
result = (T) entry.mViews[entry.mCurrentSize];
|
|
entry.mViews[entry.mCurrentSize] = null;
|
|
} else {
|
|
result = (T) LayoutInflater.from(context).inflate(layoutId, parent, false);
|
|
result.setTag(R.id.cache_entry_tag_id, entry);
|
|
}
|
|
return result;
|
|
}
|
|
|
|
public void recycleView(int layoutId, View view) {
|
|
CacheEntry entry = mCache.get(layoutId);
|
|
if (entry != view.getTag(R.id.cache_entry_tag_id)) {
|
|
// Since this view was created, the cache has been reset. The view should not be
|
|
// recycled since this means the environment could also have changed, requiring new
|
|
// view setup.
|
|
return;
|
|
}
|
|
if (entry != null && entry.mCurrentSize < entry.mMaxSize) {
|
|
entry.mViews[entry.mCurrentSize] = view;
|
|
entry.mCurrentSize++;
|
|
}
|
|
}
|
|
|
|
private static class CacheEntry {
|
|
|
|
final int mMaxSize;
|
|
final View[] mViews;
|
|
|
|
int mCurrentSize;
|
|
|
|
public CacheEntry(int maxSize) {
|
|
mMaxSize = maxSize;
|
|
mViews = new View[maxSize];
|
|
mCurrentSize = 0;
|
|
}
|
|
}
|
|
}
|