The two controllers don't own any unique state, other than the current
depth state. These two _should_ never diverge anyway, because there is
only one valid depth at any given time. By using the same controller all
the time we can enforce this invariant.
Everything else is basically just registered and unregistered listeners,
which the main controller already does properly and always has the same
state in that regard as the ad-hoc one that we're removing.
Finally we don't need to take care of any cleanup explicitly, as we did
before.
Bug: 293427436
Flag: N/A
Test: manual
Change-Id: If6ea68847a60254df76e806eac2679ae0415bfe0
(This is to reland with fixing FallbackRecentsTest#testOverview
by excluding fallback overview panel which doesn't show visual
difference from AnomalyDetector)
There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.
Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.
Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.
Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.
This can also fix various issues when using a 3p launcher:
- When auto rotation is enabled and put device in landscape:
- Unable to enter recents from gesture mode
- System bars are disappeared when pressing recents key
- Jump-cut when pressing home key to leave recents on home.
Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
The app should not receive onPause.
Change-Id: I387fcb26aa01072dfd5a215107c9c15b28513a82
Revert submission 24941288-b302703228
Reason for revert: Most likely cause of droidmonitored test failures. b/305629625. Original change was merged at this point https://screenshot.googleplex.com/99p3F266XUYYbA2 causing a 100% failure on main.
Reverted changes: /q/submissionid:24941288-b302703228
Bug: 305629625
Change-Id: Id27c68ec70410d16aeae3bde8b361d9b347ec7eb
Attaching: The surface control from Launcher's ViewRootImpl is
occiasionally invalid when back gesture starts, and parenting scrim to
it would fail. We work around this by retrying later on back progressed.
Dettaching: The scrim is not detached in all code paths. We now always
check and detach in finishAnimation() if needed.
This also fixes a possible flicker at the beginning of the transition.
We wait until Launcher is started (and draws at least one frame) to animate the top window.
Test: m -j
Test: Repeatedly trigger back to home animation. Make sure the scrim
attaches and detaches always.
Bug:271606843
Bug:297808832
Bug:217988970
Fixes:271606843
Fixes:297808832
Fixes:217988970
Change-Id: I8b9b023f1fd54bcedd0be15196165e19e8400af7
Remove launcher specific split from desktop flag and use the desktop
windowing feature flag.
Bug: 305095670
Flag: persist.wm.debug.desktop_mode_2
Test: enable desktop mode flag, toggle split from a desktop task
Change-Id: I62b91de3deaa5bba3435faf3a268f5b58cda8276
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
Many bugs are coming in where the logs only start shortly after the bug repro. Increasing the limit to capture these logs more reliably.
Flag: not needed
Bug: 303424896
Test: printed gesture logs
Change-Id: I9d02108c7d0def3c0280a2ca6d84aa3c3773b1a7
Apparently isContextualButtonShowing is not the right signal. Checking on dp.isGestureMode instead
Fixes: 300849078
Test: manual
Change-Id: Iac44bb4adbbdd5faf52100c88c2a4a6d95d58b98
We need to re-create the icon alignment controller if the
stash status changes, otherwise it will use an old value.
Bug: 296414290
Test: home to app then quickly unstash
Change-Id: I35f23842f289fce95d102a9a93dc94cd033fa8cc
Currently the task bar root layout consumes all the events and does not pass the events to drag layer, without explictly routing those events
Fixes: 303910224
Test: go to an app, swipe home, and then go back to the app. Make sure the task bar is stashed
Change-Id: I6f5e481c267dad25544118134ff95b0cb9bb1a45
There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.
Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.
Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.
Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.
This can also fix various issues when using a 3p launcher:
- When auto rotation is enabled and put device in landscape:
- Unable to enter recents from gesture mode
- System bars are disappeared when pressing recents key
- Jump-cut when pressing home key to leave recents on home.
Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
The app should not receive onPause.
Change-Id: I9ba9bdb3757bbdcb1cbb363b4fe6431860dac4da
Bug: 295981634
Test: Splitting w/ Google TV widget no longer
keeps placeholder views on screen
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE
Change-Id: I1d4df9deb9aaaaeef3741a05130429d0091293e8
We rely on contentHeightToReportToApps and tappableHeightToReportToApps (that ultimately call into DeviceProfile) of TaskbarStashController to initialize the insets. However, DeviceProfile only initializes those values when isTaskbarPresent is true. Rather than completely changing the initialization of DeviceProfile, we special case in TaskbarStashController that uses the bar height for inset
Bug: 274517647
Test: turn on FLAG_HIDE_NAVBAR_WINDOW and TASKBAR_NO_RECREATION, make sure the insets are correct in both 3 button and gesture nav mode
Change-Id: I164a6e2c9f9d24888155b45325ee8ce46ca2c39f
Flag: not needed
Fixes: 282172884
Test: used alt+tab in overview; also launched overview through keyboard quick switch view
Change-Id: I3d1e54cda317ee8f8d2b2d698480cd3ca01dfc85
This reverts commit 6f264a927b.
Reason for revert: Keeping old flag system so we can test in Tapl tests (b/283246928)
Bug: 270397206
Change-Id: I3e6364ebac8018facc3b22e510615735299a3dad
- Also unregistered TaskStackChangeListeners and TaskIconCache listeners in RecentsModel.close(), so clean-up will happen if it's in a SandboxContext
Bug: 303259446
Test: RecentsModelTest
Change-Id: I438a499be8e737de7df79b670ecfd26f0ee70662
