Commit Graph

2056 Commits

Author SHA1 Message Date
Brandon Dayauon
bcb6a62297 Merge "Apply icon alpha animation to expand/collapse private space." into main 2024-04-05 04:18:48 +00:00
Brandon Dayauon
5cbe7605f6 Apply icon alpha animation to expand/collapse private space.
This change is more so to the Alt 3 motion spec:
https://docs.google.com/presentation/d/1zRwJ8cZbwMleXHfC2hX4CJJMGSI954FK0V3ksXl7fyE/edit#slide=id.g2baced0bfd0_1_25

bug: 299294792
bug: 325455879
Test: locally: https://screenshot.googleplex.com/BYCwSH3yRvkkZ3v and https://screenshot.googleplex.com/44byrRx5GUQkncw
manual video:
expand and collapse from header: https://drive.google.com/file/d/1-qRdcbo6lNvUPOx4QWL6wVhTRzl2TVtE/view?usp=sharing
from toast and close container after locking: https://drive.google.com/file/d/1-ix4CcOIzMhsJH3uZdJA1vcV8BvY91T9/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: I4cde4b8626cf3271880fee697f2fb6bc780eab60
2024-04-04 14:54:28 -07:00
Vinit Nayak
247c6ac8ec Merge "Allow app pairs in folders" into main 2024-04-04 17:55:34 +00:00
Treehugger Robot
14381e119d Merge "Fix failing test." into main 2024-04-04 11:18:25 +00:00
Jeremy Sim
a596f589c4 Allow app pairs in folders
This CL substantially refactors folders to be able to take contents of type AppPairInfo. App pairs can now be moved in and out of folders, and launch from folders.

This CL contains only logic and model changes; animation and style changes (for dropping items into folders, color changes to app pair surfaces, etc.) will be in a following CL. Another CL (hopefully) will contain tests. I'm planning to submit them together, but this patch should also be able to stand alone with no issues (except janky transitions).

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, more to follow in another CL.
Change-Id: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
2024-04-03 16:47:42 -07:00
Himanshu Gupta
2cf24c84bf Fix failing test.
Moving to All Apps view is not required as we are
already on the same view during `moveToSearchView`
invocation.

Bug: 329152799
Test: LauncherIntentTest#testAllAppsIntent
Flag: NA
Change-Id: Ia618eaa1999a9db663dd09bb7c150b5a51dedc36
2024-04-03 18:51:33 +01:00
Sebastián Franco
0e0a7ed6ba Merge "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty" into main 2024-04-03 15:26:31 +00:00
Sebastián Franco
966156e363 Merge "Fix widget dissapearing because of change of appWidgetId" into main 2024-04-02 18:52:21 +00:00
Sebastian Franco
2b724ec00d Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Test: NA
Flag: NA
Change-Id: I86c0620d6207b09f04c8038932ed34f4444a6626
2024-04-02 11:42:17 -07:00
Sebastian Franco
3d04c1f3fc Fix widget dissapearing because of change of appWidgetId
When migrating the widgets might dissapear because the appWidgetId
can change and when migrating it's no longer valid.

Bug: 324931424
Bug: 330583877
Test: ValidGridMigrationUnitTest
Test: GridMigrationTest
Flag: NA
Change-Id: Ie41a01470814b252f6bb7e4409d3382951a1d70d
2024-04-01 20:19:20 -07:00
Jeremy Sim
da4ba9336e Merge "Reparent folders and app pairs" into main 2024-03-30 03:06:44 +00:00
Jeremy Sim
742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00
Brandon Dayauon
4958ecfadb Merge "Move adding views logic to privateProfileManager" into main 2024-03-29 04:03:42 +00:00
Brandon Dayauon
136f9d6f8a Move adding views logic to privateProfileManager
- Have the animation happen according to the state of private space.
- Have the transition happen only once by setting the current transition to null at the end of transition and by ensuring
where the transitions are allowed.
- Removing controller class.

- The onClick controls the enablement of the profile. On reset (when getting the transition) is what controls the animation
during expand.

tldr- In the collapse case:  execute() is called -> animation happens  -> addPsHeader
tldr- Expand case: post() is called -> addPsHeader -> animation happens.

Collapse:
onClick() -> AACV.onAppsUpdated() that resets & apply/RUNS runnable because EXECUTE
-> AAList.onAppsUpdated() (which is called at the same time animating happens which we should cancel and do at end callback)
-> AAList.onAppsUpdated() gets called again

Expand:
onCLick() -> AACV.onAppsUpdated() that resets & apply runnable
-> AAList.onAppsUpdated() (no animation running)
-> AAList.onAppsUpdated() (no animation running)
-> addPrivateSpaceHeader
-> then unlockAction() runnable because its posted at this point

bug: 326206132
bug: 330444548
bug: 299294792
Test: manually locally and presubmit: https://screenshot.googleplex.com/9wavvwKQ8hY6oUw & https://screenshot.googleplex.com/BiqmidLFjPwS28j
video: https://drive.google.com/file/d/1XGhmTncdUFtJj188_l7alGyyNz_fhXNw/view?usp=sharing

Scrolling fix before: https://drive.google.com/file/d/1XykDm4UELoCvcwZdj8ZlJ6TszptB8W0W/view?usp=sharing
scrolling fix after when not a lot of apps: https://drive.google.com/file/d/1Y4VY1eX7WE8ShSLXRrT56ieBdAuJo_zn/view?usp=sharing
scrolling fix after with a lot of apps: https://drive.google.com/file/d/1Y58c-Z9xnU1GILp0Ih-oLORXYkMB-jWn/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation

Change-Id: I8d03ae60e2c9fe0ec145c4b0a2e9604b9e6e9017
2024-03-28 17:39:42 -07:00
Sebastián Franco
0ec7c1e4a8 Merge "Generate grid migration cases and test if they are valid" into main 2024-03-28 16:31:37 +00:00
Sebastian Franco
efab2489d6 Generate grid migration cases and test if they are valid
This makes sure the grid migration logic always produces
valid results.

Bug: 313900847
Bug: 323525592
Flag: NA
Test: ValidGridMigrationUnitTest.kt
Change-Id: I76b19e1fa315f8a997afad34e5a4df7cc465b0c2
2024-03-27 14:03:07 -07:00
Sunny Goyal
77954bae4e Cleaning up some build configurations
> Removing Launcher3Go-without-quickstep
> Removing src_ui_overrides to src_no_quickstep
> Removing unnecessary code swpa for GO builds

Bug: 330920490
Flag: None
Test: Presubmit, everything builds
Change-Id: I5746dbc7c5a37c1d99d78b55bf2a6adce1a711c9
2024-03-26 17:16:52 +00:00
Schneider Victor-tulias
02e57b3d62 Add ExtendedLongPressTimeoutRule to all AbstractLauncherUiTest
When devices run slow in pre/post-submit, it is possible for a drag to be processed at a long press before the first move event can be created and dispatched. Added a rule to artificially increase this long press timeout in tests.

Flag: N/A
Fixes: 319257820
Test: TAPL tests
Change-Id: I24e0f3baec15db7558351d0cb2bd93a4e49640e8
2024-03-25 11:22:31 -04:00
Treehugger Robot
9a8a3091ba Merge changes from topic "revert-26664190-revert-26605558-robolectric-enable-androidx-rules-OWMAZEJUYZ-JTFGVYILBL" into main
* changes:
  Revert^2 "Move FastBitmapDrawableTest to Robolectric"
  Revert^2 "Include AndroidX test rules in Robolectric tests"
2024-03-23 00:14:35 +00:00
Priyanka Advani
7b9f1893b8 Merge "Revert "add more unit tests for WorkspaceItemProcessor"" into main 2024-03-22 20:05:32 +00:00
Priyanka Advani
d9ed5f301b Revert "add more unit tests for WorkspaceItemProcessor"
This reverts commit 13b5177a8d.

Reason for revert: Droid-monitor created revert due to test breakages in b/330906931.

Change-Id: If1afc3fb0e655ce3b1d10018723bc013ae03673e
2024-03-22 19:10:16 +00:00
Treehugger Robot
f4148a9a13 Merge "add more unit tests for WorkspaceItemProcessor" into main 2024-03-22 16:41:37 +00:00
Sebastián Franco
b55987f834 Merge "Move test failing on presubmit to postsubmit" into main 2024-03-22 16:29:24 +00:00
Charlie Anderson
13b5177a8d add more unit tests for WorkspaceItemProcessor
Bug: 294386159
Test: unit tests passing locally and in presubmit
Flag: N/A

Change-Id: Iea281418b4737c85e3cff36dc8b7f6cd6ce06a0b
2024-03-22 11:22:46 -04:00
Sebastian Franco
5103c551d3 Move test failing on presubmit to postsubmit
Bug: 316910614
Test: testResizeWidget
Flag: NA
Change-Id: I3fdc1aaab6d6479b04575f9e1540a36d5d563184
2024-03-21 17:24:27 -07:00
Sihua Ma
9b1a028bd4 Revert^2 "Move FastBitmapDrawableTest to Robolectric"
393477ca54

Change-Id: I051d2456c6930336c92ffe4c6101e6dd77a502c0
2024-03-21 21:50:20 +00:00
Vadim Tryshev
2b9047a931 Merge "Removing SecondaryDisplayLauncherTest that are all @Ignored" into main 2024-03-21 21:06:42 +00:00
Priyanka Advani
393477ca54 Revert "Move FastBitmapDrawableTest to Robolectric"
Revert submission 26605558-robolectric-enable-androidx-rules

Reason for revert: Droid-monitor created revert due to build breakages in b/330752689.

Reverted changes: /q/submissionid:26605558-robolectric-enable-androidx-rules

Change-Id: I7cb746baffc9bec3315dd324173fd9bde100e4cf
2024-03-21 19:07:50 +00:00
Vadim Tryshev
9ae560d247 Removing SecondaryDisplayLauncherTest that are all @Ignored
Bug: 241166788
Test: presubmit
Flag: N/A
Change-Id: I2288bb0178b86517c44f5c6b572eb63236bb2986
2024-03-21 11:39:12 -07:00
Sihua Ma
cc54051d12 Merge "Move FastBitmapDrawableTest to Robolectric" into main 2024-03-21 17:06:45 +00:00
Federico Baron
09ec3e2623 Merge "Add screenrecord for simple reorder widgets test" into main 2024-03-21 16:12:31 +00:00
fbaron
8248279894 Add screenrecord for simple reorder widgets test
Bug: 330019521
Test: TaplReorderWidgetsTest#simpleReorder
Flag: NONE
Change-Id: Ief042efa088246f964e0b35f1c1ae10a95c5a671
2024-03-20 13:46:47 -07:00
Sunny Goyal
5ca50490a3 Making some classess accessible in multivalent tests
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I2e4b18fc279cb96b3f68d64f95703c11bb885b2a
2024-03-20 13:30:40 -07:00
Fengjiang Li
b7e9427dc9 Merge "[Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding" into main 2024-03-20 01:21:09 +00:00
Fengjiang Li
ea7cb497f5 [Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding
Bug: 325930715
Test: Added unit test
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I509546ac4ee1fa851cf0648d365a5348362267cc
2024-03-19 15:28:38 -07:00
Tony Wickham
86d8386ab6 Merge "Add TaplTestsQuickstep#testExcludeFromRecents" into main 2024-03-19 20:28:58 +00:00
Sihua Ma
4ff471c2f0 Move FastBitmapDrawableTest to Robolectric
Flag: N/A
Bug: 297950111
Test: atest Launcher3RoboTests
Change-Id: Icef741a1c19bb494f7b74078ce1e7f52ed55a769
2024-03-19 20:27:29 +00:00
Tony Wickham
b84b8524a1 Add TaplTestsQuickstep#testExcludeFromRecents
- Add ExcludeFromRecentsTestActivity, and add it to the manifest
  with excludeFromRecents="true"
- Add the test to check the current Overview task content
  description, ensuring that the excludeFromRecents task is
  present directly after a gesture but not after going home.
Bug: 324495241
Flag: None
Test: TaplTestsQuickstep#testExcludeFromRecents

Change-Id: I06be53673f0ac06924f79b44f19744da066cc7ea
2024-03-18 22:30:13 +00:00
Willie Koomson
078737f22b Merge "Add tap-to-add button to widget picker" into main 2024-03-15 23:26:05 +00:00
Himanshu Gupta
13bf70c7e8 Merge "Ignoring the failing test." into main 2024-03-15 23:03:22 +00:00
Willie Koomson
cdc26951ff Add tap-to-add button to widget picker
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.

Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT

Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
Fengjiang Li
00711e68a5 Merge "Enable predictive back in TAPL tests" into main 2024-03-15 14:52:58 +00:00
Fengjiang Li
e90f098d4f Enable predictive back in TAPL tests
With ag/26349940 we have fixed the bug where back swipe is not working

Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
2024-03-15 00:00:37 -07:00
Himanshu Gupta
0f1fe9722f Ignoring the failing test.
LauncherIntentTest#testAllAppsIntent is a newly added
TAPL test that seems to be breaking on a few devices.

Disabling it until the root issue is fixed.

Bug: 329152799
Test: Manual
Flag: NA
Change-Id: I3c1d145a444d4d2a85b3f5d2a968d120eee7cca0
2024-03-14 13:53:38 -07:00
Sebastián Franco
892ffb8b15 Merge "Making 2 flags read only since they are used on backup and restore" into main 2024-03-14 20:12:05 +00:00
Federico Baron
f6fd1f3d46 Merge "Fix bug where folder with 1 icon can exist" into main 2024-03-14 20:02:04 +00:00
Sebastian Franco
5ea61960ab Making 2 flags read only since they are used on backup and restore
The flags are narrow_grid_restore and grid_migration_fix.

Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
Change-Id: Ia6a439553c3c5098115144eae532342ce73be4f2
2024-03-14 17:16:51 +00:00
fbaron
5645c3ec55 Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
2024-03-14 10:13:00 -07:00
Brandon Dayauon
69aa9a07ee Merge "Disable two line text legacy flag." into main 2024-03-14 15:11:13 +00:00
Brandon Dayauon
a7bd5cf6ee Merge changes I209e3ec7,If70df129 into main
* changes:
  Change collapse to use adapterItems instead of getting the childCount()
  Upon expanding, expand just enough so the header shows.
2024-03-13 22:49:02 +00:00