Commit Graph

824 Commits

Author SHA1 Message Date
Andreas Agvard
fd7f192a0a Enables ENABLE_SEARCH_HAPTIC_COMMIT
ENABLE_SEARCH_HAPTIC_COMMIT should be enabled for now to keep consistency in
behavior.

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Bug: 314005577
Change-Id: I98e2dea91fe58b6abaeeb63f6c92a5ee130b5204
2023-12-01 21:16:14 +01:00
Andreas Agvard
1ea0746e1c Adds support for shrinking nav handle on press
Fix: 314158312
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Test: Manual

Change-Id: Icd46467939ae9a38592ee67ee0d2a521eb8e0b6c
2023-12-01 17:54:41 +01:00
Andy Wickham
faa97d6224 Merge "Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag." into main 2023-11-30 20:17:42 +00:00
Saumya Prakash
89b93d4bbd Merge "Add taskbar pinning education for new users and update other steps" into main 2023-11-30 20:08:13 +00:00
Tracy Zhou
aa759645cf Merge "Use enableSplitContextually() to guard split keyboard shortcut feature" into main 2023-11-30 18:43:13 +00:00
Tracy Zhou
6209f34b02 Use enableSplitContextually() to guard split keyboard shortcut feature
enableSplitFromFullscreenWithKeyboardShortcuts() depends on enableSplitContextually() from the product perspective, hence merging these two flags

Bug: 270394122
Test: N/A
Change-Id: Iecf46a62bfa21ed0c3bad9ca8c9e2646b3aebc78
2023-11-29 22:20:42 -08:00
Andy Wickham
c0c420a3c2 Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag.
This controls whether a haptic is played when search invocation
starts. The assumption is that the search app will play this
haptic if the flag is disabled (default).

Test: Manual
Bug: 310659178
Bug: 314005577
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT DISABLED
Change-Id: I406c18cfaf27d004e19de26f00c997c0a03de996
2023-11-29 17:07:20 -08:00
Sebastian Franco
7a08e54eed Enabling ENABLE_NO_LONG_PRESS_DRAG
This is a simple flag, I don't think it requires the new
flagging system, I mainly added the flag for ease of debugging
if it breaks test on postsubmit.

This flag was already tested using enabled but it was disabled
before trunk stable, I think we can set this to true without risk
and then remove the flag.

Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Fix: 299748096
Test: atest TaplDragTest
Change-Id: If99027d8cec7d75eee11012615da0e0d76951755
2023-11-29 10:09:57 -06:00
Saumya Prakash
5feb491549 Add taskbar pinning education for new users and update other steps
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.

Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
2023-11-28 20:20:25 +00:00
Andreas Agvard
9ed6d0be04 Merge "Fixed incorrect naming of flags" into main 2023-11-21 12:26:17 +00:00
Andreas Agvard
fc74c095d6 Adds a debug & server configurable delay to search haptic hint
Fix: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED

Change-Id: Ic050e8426ef91b28e6bf1dc4d86839eaa20b0dc0
2023-11-20 12:49:54 +01:00
Andreas Agvard
0fc7d52863 Makes deep press for LPNH toggelable
By default when deep press is detected (https://developer.android.com/reference/android/view/MotionEvent#CLASSIFICATION_DEEP_PRESS)
during LPNH triggers the long press action immediately. This change makes this toggelable.

Flag is set to enabled by default, which leads to the default behavior.

Fix: 310952290
Test: Manual
Flag: LEGACY ENABLE_LPNH_DEEP_PRESS ENABLED
Change-Id: I970fed697979ee528e54b8be0139d842f3a64c43
2023-11-16 17:55:34 +01:00
Andreas Agvard
f2f026ba26 Fixed incorrect naming of flags
Bug: 309972570
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: Ie493e03c7e80fe0697e46dc02e9abaf1906aded4
2023-11-16 14:39:05 +01:00
Andreas Agvard
b36bcff974 Enables server side control of search hint haptic parameters
Fix: 309972570
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: I342a86546601b092b6eb40b8d00d94ee4cf1127a
2023-11-15 17:23:40 +00:00
Tracy Zhou
859edd00e9 Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig
Bug: 270394122
Test: N/A
Change-Id: I9bacd906099518b4a4c43a9f80ab0c753beac89a
2023-11-13 13:12:09 -08:00
Jagrut Desai
90dd098c85 Migrate ENABLE_TASKBAR_PINNING to aconfig flag
Test: Manual, Presubmit
Bug: 265437087
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I4800230c04feceefa2398e189c493c8c4a7b2fe5
2023-11-09 23:20:03 +00:00
Tracy Zhou
f2d7be1cec Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION
We want to turn on the flag when either of the dependent features is on

Bug: 299193589
Test: N/A
Change-Id: I7b48ff2be0cf9da3b6bc00d75370fa585ce4140d
2023-11-08 14:52:58 -08:00
Andreas Agvard
d103d230a9 Merge "Enabled haptics during long press nav handle" into main 2023-11-06 08:40:58 +00:00
Andy Wickham
402ca3e3e5 Merge "Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag" into main 2023-11-04 19:57:39 +00:00
Andreas Agvard
cb016243c7 Enabled haptics during long press nav handle
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Test: Manual
Bug: 303023676
Change-Id: Ia792fc6d00bf06320f51d56c43ed59c6dd23d456
2023-11-03 23:44:13 +01:00
Jagrut Desai
1e63858559 Merge "Turn on TASKBAR_PINNING for TEAMFOOD" into main 2023-11-01 22:06:31 +00:00
Andy Wickham
24a50df135 Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag
Bug: 306400785
Bug: 308693847
Test: Manual
Flag: LEGACY ANIMATE_LPNH TEAMFOOD
Change-Id: I996c923e5a1949e6219f900da12e2b5091597750
2023-10-31 23:45:12 -07:00
Jagrut Desai
0dbc0d0285 Turn on TASKBAR_PINNING for TEAMFOOD
Test: Presubmit
Bug: 265437087
Flag: LEGACY ENABLE_TASKBAR_PINNING TEAMFOOD
Change-Id: I13e7e5b96323a3b10d930a053fbeca7023cbba5f
2023-10-30 12:24:50 -07:00
Jon @
d2750e315c Merge "Migrate ENABLE_HOME_TRANSITION_LISTENER to launcher.aconfig" into main 2023-10-27 23:12:02 +00:00
Jon Miranda
60ae29ef08 Migrate ENABLE_HOME_TRANSITION_LISTENER to launcher.aconfig
Also set flag to TEAMFOOD.

Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TEAMFOOD
Bug: 306053414
Test: manual
Change-Id: Icf3947e61fa9f20f5b6e5ca2af96e693b55d3edc
2023-10-27 16:43:01 +00:00
Anushree Ganjam
cb571daa0b Read LPNH touch slop percentage and timeout ms from DeviceConfig.
Make CUSTOM_LPNH_THRESHOLDS as a ReleaseFlag so this can be enabled from
server for experiments since touch slop percentage and timeout are
applied only when CUSTOM_LPNH_THRESHOLDS is enabled.

Add FeatureFlags for LPNH slop multiplier is "lpnh_slop_percentage" and LPNH timeout is "lpnh_timeout_ms"

Bug: 301680992
Flag: Legacy CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual

Change-Id: Ifd066b8cb8521dceb7aa12d9e46f5b7cfce1ec7f
2023-10-26 19:03:40 -07:00
Vinit Nayak
0fcd231173 Merge "Use aconfig flag enable_split_contextual" into main 2023-10-25 23:19:27 +00:00
Tracy Zhou
867f7f8360 Merge "Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig" into main 2023-10-25 17:45:09 +00:00
Tracy Zhou
00f9e52575 Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig
Bug: 274517647
Test: manual
Change-Id: I29fe58691440ee757c9f391bd574ef80eefb5ae6
2023-10-24 18:42:15 -07:00
Vinit Nayak
a1be4c1123 Use aconfig flag enable_split_contextual
Bug: 276361926
Test: Basic split contextual operations work
as expected

Change-Id: I7202654f8452a0c57e5e728c9baaadf85fa22a96
2023-10-25 01:37:17 +00:00
Sunny Goyal
6eb256d794 Simplifying settings activity
> Removing multiple fragments
> Exposing support to select preference root
> Adding support for recreating preferences
> Moving Developer options to same fragment

Bug: 305084752
Flag: N/A
Test: Manual
Change-Id: I499be1938ef8ed58cbc7f9b0f4ad3510d4b306c8
2023-10-24 11:40:12 -07:00
Brandon Dayauon
e7396c927b Merge "ENABLE_TWOLINE_ALLAPPS to true" into main 2023-10-23 18:19:51 +00:00
Jon Miranda
00c3d78191 Add HomeTransitionListener to launcher.
Fixes: 279514548
Bug: 284474103
Bug: 306053414

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER DISABLED
Test: App launch -> Hotseat -> Taskbar stashes
      Transluscent app launch and launcher still visible -> No change
      Going home -> Hotseat visible

Change-Id: I6db5253ada3e3b37dfae124f3ee88a9805804fb8
2023-10-20 15:46:11 -07:00
Pat Manning
4c27e8c6f0 Migrate cursor feature flag to trunk stable flag.
Fix: 300054410
Test: TaplTestsTransientTaskbar, TaplTestsQuickstep
Flag: enableCursorHoverStates
Change-Id: I5c320e0fd2bdd2ed39b00b62b1399e163c3384e7
2023-10-20 12:17:36 +01:00
Andreas Agvard
d1674985d6 Adds haptic build-up during LPNH behind feature flag
Flag: Omnient flags + ENABLE_SEARCH_HAPTIC_HINT
Test: Manual
Bug: 303023676
Change-Id: Ic43d1f34a05622328add6727f36406ce75d5a115
2023-10-19 21:10:42 +02:00
Alex Chau
0e4e703215 Merge "Migrate ENABLE_OVERVIEW_ICON_MENU to aconfig flag" into main 2023-10-19 08:18:41 +00:00
Brandon Dayauon
617db544da ENABLE_TWOLINE_ALLAPPS to true
Need to use old way of changing FeatureFlag flag values in tests since this feature
also uses FeatureFlag.java flag value.

bug: 270390937
Test: presubmit/locally - https://screenshot.googleplex.com/4nCVDPb2yRwW7rh
Flag: turning to ENABLED (been in teamfood in aconfig)
Change-Id: I392de84c6fb84b7a217b953f2335160056b4ecc3
2023-10-16 10:02:06 -07:00
Ats Jenk
a89365c2be Merge "Use desktop mode flag for split logic" into main 2023-10-13 18:00:53 +00:00
Ats Jenk
cd789874c3 Use desktop mode flag for split logic
Remove launcher specific split from desktop flag and use the desktop
windowing feature flag.

Bug: 305095670
Flag: persist.wm.debug.desktop_mode_2
Test: enable desktop mode flag, toggle split from a desktop task
Change-Id: I62b91de3deaa5bba3435faf3a268f5b58cda8276
2023-10-12 23:28:42 +00:00
Jeremy Sim
7dc3bdcd85 Migrate ENABLE_APP_PAIRS flag to aconfig
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
Alex Chau
c78c53c22a Migrate ENABLE_OVERVIEW_ICON_MENU to aconfig flag
Bug: 257951354
Change-Id: I47b1c1d422ce3c510ea22ea3e1feff0263ded177
2023-10-12 16:00:14 +00:00
Alex Chau
6ae2c4d77d Merge "Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""" into main 2023-10-11 15:38:57 +00:00
Alex Chau
4989f4f36d Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""
This reverts commit 7b5472f986.

Reason for revert: aconfig/SetFlagsRule actually works with TAPL tests (http://ag/c/platform/packages/apps/Launcher3/+/24991890/comment/8303a3c6_030ae00b/)
Bug: 270397206

Change-Id: I7529a64c3197e4c2b4d5fb1e46fb29bdea1e52e9
2023-10-11 14:08:22 +00:00
Hyunyoung Song
e0a25fbd51 Merge "Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH" into main 2023-10-11 07:54:26 +00:00
Alex Chau
09d8e2ca57 Merge "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"" into main 2023-10-10 12:26:21 +00:00
Alex Chau
7b5472f986 Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"
This reverts commit 6f264a927b.

Reason for revert: Keeping old flag system so we can test in Tapl tests (b/283246928)
Bug: 270397206

Change-Id: I3e6364ebac8018facc3b22e510615735299a3dad
2023-10-10 10:38:04 +00:00
Andy Wickham
9fbc52f02d Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH
When this flag is enabled, new Developer Options appear which
allow you to customize the slop and timeout to invoke LPNH.

The slop is defined as a multiplier to the default edge slop
(which I discovered while looking into this - it appears to
be intended for touches along the device edge and is 50%
larger than the default touch slop; currently used by Back).

Timeout is defined in milliseconds, defaulting to 400, at least
on my device.

Bug: 301680992
Bug: 300955321
Flag: CUSTOM_LPNH_THRESHOLDS - should be no-op with default off
Test: Manual with flag on and adjusting sliders, and flag off
Change-Id: Iabc7b3706f4fdd6f0392c858b81a856e375ffd51
2023-10-06 15:06:13 -07:00
Federico Baron
97789c9c5e Merge "Add flag for smartspace removal toggle" into main 2023-10-06 20:35:14 +00:00
Stefan Andonian
9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Alex Chau
2ca7481b04 Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag" into main 2023-10-05 15:40:17 +00:00