Updated the logic to set the taskbar window height to accommodate the
bubble bar with its maximum flyout height before the bubble bar
animation begins. The height is reverted to the default value once the
animation is completed.
Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Set 3-button navigation mode and have the QSB placed
above the hotseat. Send a notification that will display a bubble, and
observe the bubble bar animation and final placement aligned with the
QSB.
Next, set gesture navigation mode and repeat the flow above. Observe
that the bubble bar is aligned with the hotseat icons.
Felix video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/gYMVt0sH4si0KOpaBxIPem
Tangor video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fz95MbjcjW3awStnuOl8BJ
Change-Id: I239f935743c3936fed44822c3c62652073ffefe2
Change logic to updated bubble bar alignment with the QSB vertical
center for 3 buttons navigation mode.
Fixes: 378400160
Flag: com.android.wm.shell.enable_bubble_bar
Test: PersistentBubbleStashControllerTest
Test: TransientBubbleStashControllerTest
Test: Manual. Set the buttons navigation mode and observe that the
bubble bar is centered with the QSB when the QSB is not aligned with the
hotseat. Then, switch to gestures navigation mode and observe that the
bubble bar is centered with the hotseat when the QSB is not aligned with
the hotseat.
Change-Id: I57a32ac5bde7a7055b54a89727429424e5c0ca4f
1. Scale down desktop tasks
2. Change translation start when all desktop tasks need to hidden
Fix: 378447894
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual: Add desktop window and split focussed task, desktop task(s)(also in RTL)
Change-Id: I25c11d654539efc6529a2e995d8d00cbf73c870d
- Extracted itemInfo creation in to TaskViewItemInfo and added a test
- Created a standalone atom for TaskView, logging data we want (please refer to the bug)
- Convert TaskView atom to StatsLog data in StatsLogCompatManager
- Simplified DesktopSystemShortcutTest and ExternalDisplaySystemShortcutTest to avoid extra testing on DesktopModeStatus
Fix: 341320349
Test: TaskViewItemInfoTest, DesktopSystemShortcutTest, ExternalDisplaySystemShortcutTest
Flag: EXEMPT logging
Change-Id: Icf04ff2b1670c3f3d5f6a66f99c0d28314efaf21
We now show the bubble bar edu view after a request from shell
to show it was received, and as soon as the user performs a touch
gesture on the bubble bar or flyout that causes the bar to be
expanded.
The click listener on the bubble bar is removed with this change
because the input consumer already handles taps. Removing the
listener avoids processing the tap twice which causes the edu view
to not be displayed. Removing the click listener solves the issue
but ideally we should move the edu view to launcher since that
would allow us to manage its state easily.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 374842575
Test: atest PersistentBubbleStashControllerTest
Test: atest BubbleBarSwipeControllerTest
Test: atest TransientBubbleStashControllerTest
Test: manual
- force show the bar edu view
- send a bubble
- tap the bubble bar to expand
- observe bubble bar edu is visible
- repeat with swiping on the bar and tapping the flyout
- launch an app
- swipe up to show the taskbar
- observe edu view not visible
- send a bubble with auto expand
- observe bubble bar expanded and edu view not visible
Change-Id: I98ec44e6edf6c69d6d47b5709140796c2ecab23e
Fix: 379638096
Flag: EXEMPT BUG_FIX
Test: Manual - go to overview with and without tasks. Check TalkBack.
Change-Id: I1f3faace530ed3c9b0384b94dbc163f5b8c15dda
Revert submission 30509816-raf-timing
Reason for revert: Likely culprit for b/381006945 - verified through ABTD before revert submission as part of standard investigation process.
Reverted changes: /q/submissionid:30509816-raf-timing
Change-Id: Iaed968120be662df8d915bac61e7cfa5b936f35c
- ag/28947579 add a speicifc order for children of TaskView to be added for accessibility. All TaskView children will need to added through TaskContainer.addChildForAccessibility
Fix: 379802031
Fix: 380016834
Fix: 204280593
Test: Go to Select mode, ensures Talkback can cycle through text selection boxes
Flag: EXEMPT BUG_FIX
Change-Id: Id7991a8b3e76fe47f562e338e9967c8e85fa4908
This allows us to clean up the home screen properly (close all apps and floating views)
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 380049465
Fixes: 380049942
Test: TAPL tests
Test: swipe home from home all apps, with and without an open popup menu, with and without a 3P launcher
Change-Id: I3c3c8e832329afc3ffaa1de7cf646be79d84e9a3
The dismiss logic only checks for `ACTION_DOWN` events, but when the
user frequently right-clicks OR right-press-move-release, we get
multiple `ACTION_MOVE` events instead, which are ignored by the dismiss
logic of the previous popup instance.
Attached screen recordings to the bug.
Bug: 362475367
Flag: EXEMPT bugfix
Test: manual
Change-Id: I665c3127e4b449a8f4c71e443cc6ae07c1bf2794
Refactor the TaskbarManager's existing usages of TaskbarRootLayouts to use a map, so that there can be a 1:1 relationship between TaskbarRootLayouts and TaskbarActivityContexts.
Flag: EXEMPT not adding new behavior
Bug: 380351840
Test: Manual
Change-Id: Ib4379a9b6d50b8bdd64b70d7b15ce798ebb42731
Previously home animations for 3rd party launchers were being cancelled by the recently added onFinishComplete call in AbsSwipeUpHandler.onTasksAppeared. This was because FallbackSwipeHandler.handleTasksAppeared was returning false even though mActiveAnimationFactory.handleHomeTaskAppeared was true. However, only fixing this so it returned true instead would allow AbsSwipeUpHandler.onTasksAppeared to continue to the following conditions which would fail, so this change also converts FallbackSwipeHandler.handleTasksAppeared to override onTasksAppeared instead. This allows home tasks to be handled first and skip splash screen handling since it is not needed.
Flag: NONE bug fix for recently introduced issue
Fixes: 362900007
Test: set 3rd party launcher as default and use home navigation gesture
Change-Id: I88015bd3bdbad94bd4897411714ff3f52a782499
This change addresses an issue where touching the bottom of the screen would result in the dismissal of the multi instance menu, but leave the taskbar in a state that it would not auto stash. This is because the view was being removed through another way leading to taskbar being in a bad state. Now when the view is removed, the taskbar is correctly reset.
Fix: 380304394
Bug: 315989246
Test: Manually launch the menu then tap the bottom of the screen. Ensure that taskbar eventually auto stashes.
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ie6bae803a42cf0bcd0ff6362473a63cb22a841eb
- Speculative fix, there are some scenarios where we update the swipe
touch/assistant regions without updating the OHM regions
Bug: 362039326
Flag: EXEMPT bugfix
Test: Manual
Change-Id: If5c558623073e5185827ae17a162dacf322c74a4
When using a 3P Launcher, i.e. when the ROLE_HOME is not held by QuickstepLauncher, there should be no back callback registered with SystemUI.
Bug: 374882166
Flag: EXEMPT bugfix
Test: Manual, i.e. verified back-callback registration updates in SystemUI and also verified that back-to-home navigations in Nova Launcher are responsive.
Change-Id: I03187f80a4c3c893a6529f0a22613f6fdfe7b7b3
Bug: 373544911
Test: Manual, i.e. verified that sliding away from the back button (within the taskbar window) cancels the predictive back animation
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I9a1448c7005211c87a8979261b13fe37ab64a5b2
This means that overlay is initialised in all cases, not just some. Also uses pre-existing method for `isTaskViewFullyVisible()`
Fix: 376264918
Test: Manual checking of flows in bug.
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ia898a2a869b79fb120a162fa5a3fe7df0fbf9800
