Commit Graph

5740 Commits

Author SHA1 Message Date
Schneider Victor-tulias
fc7bfd8b22 Fix taskbar 3-button truncation on rotate am: c0b30dc266 am: b3513063b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17109868

Change-Id: I2ffb6f71386b8600ba995aebb0d1b92bafc1eebb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-03 13:35:17 +00:00
TreeHugger Robot
365fc59d74 Merge "Provide the back callback instance when unregistering it from SysUI." into tm-dev am: eba6a95a29 am: ada82e188f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17650016

Change-Id: I648b5edad46ee743e0ebe06ed174be7fac53cf34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-02 23:11:59 +00:00
TreeHugger Robot
569bee229f Merge "Do not add HOTSEAT_ICONS to visible elements for device type "phone" in ALL_APPS State" into tm-dev am: 002e1fcde5 am: 5b8be11c37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18084536

Change-Id: I102a002a9c2c716e77d9a7efb8c9f6d77fcc82f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-02 23:11:02 +00:00
TreeHugger Robot
553f21b4d3 Merge "Update home, back and overview gesture tutorial introductions to be clearer for blind users" into tm-dev am: 3e8f0c9bb6 am: eabd3e8d2e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18101491

Change-Id: Ie84832243141b503604bec15e733b59b4055c214
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-02 23:10:30 +00:00
Sunny Goyal
9eac96c1e0 Merge "Removing unused SearchSessionManager" into tm-dev am: 34f51fbfc4 am: f81b1952aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18085661

Change-Id: I006e96a10cae2cd33b1dc4d60950aae3eae3cb51
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-02 23:08:50 +00:00
TreeHugger Robot
a24b87c0ed Merge "Update TaskOverlay corner radius as fullscreen parameters are updated." into tm-dev am: 47a137e05d am: 3f6d27b025
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18083412

Change-Id: I40490d4e04ca6b50331a750378173f4bab229ddc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-02 22:31:43 +00:00
Pat Manning
7764f01a9d Merge "Re-land "Animate overivew actions view hiding on scroll."" into tm-dev am: d9ddf6c12b am: 2049688659
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17707271

Change-Id: Ia3311ebc7a3296e43e555248893185c7f2ba9af6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-02 22:31:34 +00:00
Pat Manning
c1f0767302 Merge "Finish recents animation on activity destroyed." into tm-dev am: d44f9c9741 am: ec39c9ba3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17943734

Change-Id: I0c0c27ec56792a60a1240a075236b737c97713c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-02 22:31:28 +00:00
Thales Lima
b1395ceb70 Fix hotseat width to span a number of columns am: 828875cd12 am: ab5faf06a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983445

Change-Id: I58ca8e544bb47f617190a6811b9791c535be5a33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-02 22:31:09 +00:00
Schneider Victor-tulias
c0b30dc266 Fix taskbar 3-button truncation on rotate
- Fixed truncation issue in overview and home on rotation
- Fixed 3 buttons translating incorrectly when switching to/from overview

Fixes: 205057824
Fixes: 215482458
Test: Manual
Change-Id: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
Merged-In: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
(cherry picked from commit 8aa99c72b1)
2022-05-02 18:12:00 +00:00
TreeHugger Robot
eba6a95a29 Merge "Provide the back callback instance when unregistering it from SysUI." into tm-dev 2022-05-02 16:18:43 +00:00
Shan Huang
883e7e412b Provide the back callback instance when unregistering it from SysUI.
Bug: 228535747
Test: atest BackAnimationControllerTest
Test: Make sure back to home animation works on tablets and phones.
Change-Id: Iacbd581f382da50e96cfefbefe569800e9e1043b
2022-05-02 04:57:11 +00:00
TreeHugger Robot
002e1fcde5 Merge "Do not add HOTSEAT_ICONS to visible elements for device type "phone" in ALL_APPS State" into tm-dev 2022-04-30 17:12:35 +00:00
TreeHugger Robot
3e8f0c9bb6 Merge "Update home, back and overview gesture tutorial introductions to be clearer for blind users" into tm-dev 2022-04-30 02:13:14 +00:00
Anushree Ganjam
f6254c5947 Do not add HOTSEAT_ICONS to visible elements for device type "phone" in
ALL_APPS State

HOTSEAT_ICONS got added to visible elements for ALL_APPS State in ag/16992837.

============================================================
Phone
Before:
HotSeat present in view hierarchy - https://hsv.googleplex.com/4906040983289856?node=41
Video: https://b.corp.google.com/issues/228803923#comment9

After:
HotSeat not present in view hierarchy - https://hsv.googleplex.com/5379653922455552?node=42
Video: https://b.corp.google.com/issues/228803923#comment11
============================================================

Tablets

I couldn't test this implementation on tablet. But I have verified on a phone
locally by adding HOTSEAT_ICONS to visible elements and then verifying
"IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS" get set and hotseat icons are not focusable in all apps.
Video : https://b.corp.google.com/issues/228803923#comment14

============================================================

Bug: 228803923
Bug: 227565451

Test: Manual. See the video attached in bug.
Change-Id: I055e3bb61c8cfd240e0fe1000fe3a391a150f6d1
2022-04-29 23:33:48 +00:00
Sunny Goyal
34f51fbfc4 Merge "Removing unused SearchSessionManager" into tm-dev 2022-04-29 23:30:13 +00:00
Schneider Victor-tulias
8e0e88bb2f Update home, back and overview gesture tutorial introductions to be clearer for blind users
Added A11Y strings for the home, back and overview gesture tutorial step introductions. These strings give clearer instructions that work with talkback.

Fixes: 202492454
Test: manual
Change-Id: I1eefd6ecf3e3c576a7c1cf6dbf7b824e5be13860
2022-04-29 16:09:11 -07:00
TreeHugger Robot
47a137e05d Merge "Update TaskOverlay corner radius as fullscreen parameters are updated." into tm-dev 2022-04-29 22:34:31 +00:00
Shan Huang
c2ccb951ce Merge "Fix screen rounded corner flicker." into tm-dev am: 8073fc8daf am: 276a31bbf8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17948370

Change-Id: I6331e568fc55b51257e48a59d1159dfacc775ac3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 18:28:03 +00:00
Mateusz Cicheński
41bff8dedd Merge "Make Hotseat report shelf height on large screen devices." into tm-dev am: f312acc081 am: cc3cc0428e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17969666

Change-Id: I0ddee24a2ffc755ce72804b828becaa106623b10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 18:27:45 +00:00
Pat Manning
d9ddf6c12b Merge "Re-land "Animate overivew actions view hiding on scroll."" into tm-dev 2022-04-29 18:01:30 +00:00
Pat Manning
d44f9c9741 Merge "Finish recents animation on activity destroyed." into tm-dev 2022-04-29 17:43:21 +00:00
Zak Cohen
f2cd2f7748 Update TaskOverlay corner radius as fullscreen parameters are updated.
Bug: 230470826
Test: Build and run
Change-Id: I3b6914bf7423ec60d28d2d06ee5225de1b6862c1
2022-04-29 10:27:53 -07:00
Thales Lima
828875cd12 Fix hotseat width to span a number of columns
Bug: 227344807
Test: manual
Change-Id: Ice4e37929bcbb8c9cf3af340e67b6bec002578bd
2022-04-29 14:56:30 +00:00
Pat Manning
d08e03388f Re-land "Animate overivew actions view hiding on scroll."
Reverts commit f5f14acba3

Bug: 228137694
Bug: 221113300
Change-Id: I683092796f5de0476e09692897d80a3655ae6925
2022-04-29 13:49:09 +00:00
Pat Manning
0fd3b13d01 Finish recents animation on activity destroyed.
Do not remove acitivity lifecycle callback on reset.

Test: TaplTestsQuickstep.java testQuickSwitchFromApp
Fix: 228137694
Change-Id: I454db1d029af479624999f2e5736aea1a8a97b87
2022-04-29 11:55:40 +00:00
Sunny Goyal
a3f014d737 Removing unused SearchSessionManager
Bug: 220922858
Test: Presubmit
Change-Id: I8264a2e9b978a850aa6ce69fcb698b0a3494c6c5
2022-04-28 19:44:03 -07:00
Shan Huang
8073fc8daf Merge "Fix screen rounded corner flicker." into tm-dev 2022-04-28 19:34:37 +00:00
Mateusz Cicheński
f312acc081 Merge "Make Hotseat report shelf height on large screen devices." into tm-dev 2022-04-28 18:48:11 +00:00
Anushree Ganjam
98d71a1b3c Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev am: fa693be19f am: 34fc3c4aee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18011182

Change-Id: Ie5758ee4aa04d4236442fb78c6e68de92e3c54f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-28 06:04:46 +00:00
Anushree Ganjam
fa693be19f Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev 2022-04-28 04:52:01 +00:00
Anushree Ganjam
5cc7ff0990 Revert "Refactors Search results into separate RV for Toast."
This reverts commit 6729f0b950.

Reason for revert: This change caused b/230648542.

Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.

Bug: 206905515
Bug: 230648542

Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
2022-04-28 01:37:49 +00:00
TreeHugger Robot
5ed4ac94b9 Merge "Remove unnecessary updatePivots" into tm-dev am: e19522bede am: 6d7db81e74
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983443

Change-Id: I9fa56bb4e2060b00919c1014ecae2a5472f578d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 17:35:10 +00:00
Alex Chau
9f1635718c Merge "Update overview actions alignment" into tm-dev am: a80efcee9f am: c7fee694e7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17888303

Change-Id: I128b4f0f8e8990fed7df5957485089271e298807
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 13:20:27 +00:00
Alex Chau
2a6e364e91 Remove unnecessary updatePivots
- Follow-up of http://ag/17888303 to remove extra code that didn't get clean up

Bug: 209981696
Test: manual
Change-Id: I37f68dd52adacfd033eaeaeca52c98a4a06d556d
2022-04-27 13:57:39 +01:00
Alex Chau
a80efcee9f Merge "Update overview actions alignment" into tm-dev 2022-04-27 12:24:24 +00:00
Jerry Chang
1833317d5d Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94 am: 448ae578f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: Ia8b5e52d278d8ac280d5827dba3c64dcdbe93220
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 04:12:22 +00:00
Jerry Chang
59939e9e94 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev 2022-04-27 03:02:57 +00:00
Mateusz Cicheński
76fb120994 Make Hotseat report shelf height on large screen devices.
Test: http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ckTLvEEiaCugieedwOU6tj
Bug: 198311114
Change-Id: I9d5bc6ab031fb6d07d5205581c33aa5ab9b45a8c
2022-04-26 23:34:22 +00:00
Tracy Zhou
9660c41b4c Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: 7148e74f1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I3db055b4066d721eccc9ca6cdc70d25aec0b3574
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 18:25:22 +00:00
Tracy Zhou
7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
Shan Huang
3e952539a1 Fix screen rounded corner flicker.
We've previously always played transitions with a fixed start corner
radius. This should however be an interpolated value based on gesture
progress.

Bug: 230115505
Test: Turn on predictive animations. Try completing a back swipe as well
as canceling a back swipe. Observe corner radius to make sure there's no
flicker.

Change-Id: Iae2517d969ed1b779bced866407b939b3a011b68
2022-04-26 17:16:22 +00:00
TreeHugger Robot
16a13ec3e6 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: 14615df286
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I10c86da47d157bb99d3422719f2f9c8acf8fc568
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:11:39 +00:00
Alex Chau
a2fc764405 Update overview actions alignment
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile

Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
2022-04-25 19:20:21 +01:00
Jerry Chang
c3865b86e4 Fix divider bar won't fade-in as the other splitting tasks
Bug: 226271407
Test: manual check the divider bar fade-in animation after launchTasks
Change-Id: I5ea7c6ea5ac3f3550b28e9c0f854e70edcfc97b0
2022-04-25 15:41:28 +00:00
Andy Wickham
6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
TreeHugger Robot
4ebc61e76a Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 am: 9c3bd94b48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I5a02a4c0d0d22655559100c95998ceec0f7a752b
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 03:56:23 +00:00
TreeHugger Robot
1582aafbc0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev 2022-04-23 02:51:20 +00:00
Tony Wickham
96c5c67dca Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e am: cc10db044f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: I0471cb6feb14e517dea2ca0a07445335ecee45a5
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:47:33 +00:00
Tony Wickham
aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
2022-04-22 17:28:35 -07:00