Commit Graph

9200 Commits

Author SHA1 Message Date
Saumya Prakash
372de4f521 Merge "Enforce the correct orientation for the gesture navigation tutorial" into udc-dev 2023-06-11 22:24:13 +00:00
Jagrut Desai
2d5bb34b6b Merge "Set AccessibilityPaneTitle for taskbar view" into udc-dev 2023-06-09 22:26:39 +00:00
Randy Pfohl
5e1ccf2e96 Merge "Updating content description of taskview after latest update" into udc-dev 2023-06-09 22:06:41 +00:00
Saumya Prakash
e2711c254a Enforce the correct orientation for the gesture navigation tutorial
The lottie animations used for the gesture navigation tutorial are
designed for specific orientations depending on the device. This change
ensures that users are in the correct orientation for their device. For large screen users in portrait mode, we display a prompt to rotate the screen.

Flag: ENABLE_NEW_GESTURE_TUTORIAL
Fix: 277781713
Bug: 276515961
Test: Manually went through the tutorial starting from both
orientations on handheld, foldable, and tablet to ensure that the prompt
was shown and hidden correctly. Also ensured that gestures cannot be
completed in the background while the prompt is being shown.

Change-Id: I86ae566721f240264177ad4ec7fc12e58d1b95cd
2023-06-09 21:41:07 +00:00
randypfohl
62eb722726 Updating content description of taskview after latest update
Description: we wait for icon updates to receive the title of the task. However we still set the description immediately upon digitalwellbeingtoast creation.
this creates a null set for contentDescription resulting in incorrect talkbalk. This will listen for icon updates and will reiniitialize the toast ensuring
taskview is set properly.

Test: built and tested locally with talk back ensuring the titles are being set correctly

Bug: 280908761
Change-Id: I946e7190114cbdccb75883965b1fdf85ed6ad17a
2023-06-09 12:10:14 -07:00
Jagrut Desai
5e9203e737 Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev 2023-06-09 18:50:52 +00:00
Tony Wickham
0a074648c2 Suspend immersive mode autohide while pending transient taskbar timeout
Test: open Youtube fullscreen video, swipe up on taskbar; ensure taskbar autostashes before immersive mode autohides
Fixes: 260765455
Flag: none

Change-Id: I05c61de911f1bf326962d84c4f7c3e12135f23cf
2023-06-09 10:08:45 -07:00
Sunny Goyal
ef6fbb5be8 Merge "Fising launcher stuck on blur" into udc-dev 2023-06-09 06:07:31 +00:00
Jagrut Desai
78ddf47150 Set AccessibilityPaneTitle for taskbar view
we need to set pane title for taskbar view so accessibility service knows to focus/unfocus on it upon it appearing and disappearing

Test: Manual
Bug: 284081291
Flag: Not needed
Change-Id: I5404c97bdc3e1d3308942cd907e7f7701a04bee3
2023-06-08 17:08:40 -07:00
Jon Miranda
10b3e64d51 Merge "Update taskbar paddings/sizes to match spec." into udc-dev 2023-06-08 23:55:06 +00:00
Sunny Goyal
521c2a038b Fising launcher stuck on blur
The same surface can become invalid, in which case we need to wait
until the next draw to apply blur

Bug: 284411563
Test: Verified on device
Change-Id: Ifb6be94756fd00c5925e11a6b7d57f206e063a17
2023-06-08 13:18:34 -07:00
TreeHugger Robot
a11802c486 Merge "Check pendingIntent for intent fullscreen launch type" into udc-dev 2023-06-08 18:48:55 +00:00
TreeHugger Robot
737c7f21ec Merge "Fix null-pointer in AbsSwipeUpHandler.buildAnimationController" into udc-dev 2023-06-08 18:42:53 +00:00
Schneider Victor-tulias
8ee4ad6604 Merge "Fix layout issues in suw all set page" into udc-dev 2023-06-08 18:15:34 +00:00
Vinit Nayak
76ad67a07a Merge "Include assistant in RemoteTargetGluer" into udc-dev 2023-06-08 16:54:31 +00:00
Randy Pfohl
f2d46812f8 Merge "Cleaning up liveview in overview while returning home for visual fix" into udc-dev 2023-06-08 16:48:36 +00:00
randypfohl
680b8de0c9 Cleaning up liveview in overview while returning home for visual fix
Test: built and tested locally, verified bug doesn't occur during 3 button nav nor gesture nav animations. video in bug.

Bug: 245750127
Change-Id: I6e52722e73ff64e81686ee2ef3f7b2f7f5b1daa9
2023-06-07 23:55:41 +00:00
Vinit Nayak
5fa247fd43 Include assistant in RemoteTargetGluer
* The UI isn't terribly great, but this fixes the crashes

Bug: 285781761
Change-Id: Ie3376a98b16c19bbdb4e39e7a0a436ddae200c4a
2023-06-07 12:05:00 -07:00
Jon Miranda
95f4472ba9 Update taskbar paddings/sizes to match spec.
Bug: 282798528
Test: manual with screenshots
Change-Id: I00c646d9cd11a9015e14f8311ba2ff233d8321ac
2023-06-07 11:19:50 -07:00
Jagrut Desai
d94017474f Remove Hotseat Education from Large Screens
Currently there is an taskbar icon unstashing animation that happens on top of hotseat education. Hotseat education is redudunt for large screens(Tablets, Foldable-unfolded). To solve this we will remove this reduntdant feature for large screens

Test: Manual
Bug: 282617747
Flag: not needed
Change-Id: Ia5e2c51f7ef927a59cb6efa195c1cdfc627205d9
2023-06-07 10:52:39 -07:00
Schneider Victor-tulias
1834581bc0 Fix null-pointer in AbsSwipeUpHandler.buildAnimationController
Flag: not needed
Fixes: 271248485
Test: ran launcher
Change-Id: Ia9e0e68b9ee9273d82ed791b421a10ccb1fcdef2
2023-06-07 10:39:25 -07:00
Schneider Victor-tulias
bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Fengjiang Li
3dca7b3c6a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev 2023-06-06 18:19:38 +00:00
Schneider Victor-tulias
ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
Schneider Victor-tulias
b5c7086323 Fix layout issues in suw all set page
putting contents of the suw all set page in a scroll view to fix layout issues in large display/font sizes

Flag: not needed
Fixes: 275018092
Test: launched all set page on smallest and largest display/font sizes on handheld, tablet and foldable
Change-Id: I921b1becfc0627e9b77e467efe309613aa3ca9d0
2023-06-06 09:42:36 -07:00
Tony Wickham
97bada6339 Don't allow Taskbar unstash during Assistant gesture
Test: manual with "swipe to invoke assistant" enabled
Flag: none
Fixes: 282060498
Change-Id: I317d01dbbb59d020338b17d424c853a00ef03cce
2023-06-05 23:23:40 +00:00
Vinit Nayak
5512286d9c Check pendingIntent for intent fullscreen launch type
Test: Started intent split from workspace, tapping
on placeholder view doesn't crash, launches app
Bug: 283045822
Flag: None

Change-Id: I0525419e7aa7181faaf877e5948b4972a040b583
2023-06-05 14:30:02 -07:00
Vinit Nayak
868bef2f2b Prevent initiating split with task excluded from recents
Bug: 280138741
Flag: None
Test: Verified split option doesn't show on QR quick-tile app
in recents

Change-Id: I751e450ba3be4a97eba5ad4e8ed86bf9631164ce
2023-06-05 13:48:01 -07:00
Fengjiang Li
1a2462914d Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test
Fix: 282945183
Test: N/A
Change-Id: I96680f04a6946129b14c365e2300f408dfe8f0c3
2023-06-05 09:19:07 -07:00
Saumya Prakash
0ebdfc6660 Merge "Match displayed instruction with voiceover text." into udc-dev 2023-06-02 22:00:25 +00:00
Brian Isganitis
70da3e6452 Merge "Fix how task stack listener closes overlays on task changes." into udc-dev 2023-06-02 21:49:27 +00:00
Saumya Prakash
fbeb143ea6 Match displayed instruction with voiceover text.
When users are using TalkBack, the text being read aloud did not match
the text displayed on the screen. This change fixes that in accordance
to the accessibility testing principles by changing the text spoken
aloud.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 274996517
Test: Manually went through both versions of the tutorial using talkback
and without using it. Ensured the spoken text matched the displayed
text

Change-Id: I896f2c09bd220615722777c73935f70c946715b2
2023-06-02 18:32:33 +00:00
TreeHugger Robot
014a684343 Merge "Log windowManager.getPossibleMaximumWindowMetrics" into udc-dev 2023-06-02 17:09:46 +00:00
Brian Isganitis
0aa30e2292 Fix how task stack listener closes overlays on task changes.
Originally gated onTaskMovedToFront behind prototype because looked like
it was causing overlay to close when it shouldn't. However, it turns out
it was actually onTaskStackChanged that was doing this.

Additionally, changing onTaskMovedToFront to close with animation, because this will fire if swiping up from all apps (going to overview so Launcher is considered as the task moving to front). Also, registered onTaskCreated to be a bit more thorough.

Test: Manual (EDU, All Apps, and EDU + All Apps)
Fix: 283373523
Flag: none
Change-Id: I4cd3969f91a93bab190b764a656d9cfc03d1ce09
(cherry picked from commit 34c6b871af)
2023-06-02 15:34:35 +00:00
Alex Chau
eb9171c378 Log windowManager.getPossibleMaximumWindowMetrics
Bug: 283944974
Test: manual
Change-Id: I15d4bb81604b018f8a2c69c56509e2a66caae306
2023-06-02 15:44:54 +01:00
Treehugger Robot
55f38fb397 Merge "Create separate fullscreen launch type for shortcuts" into udc-dev 2023-06-02 05:22:23 +00:00
Anushree Ganjam
9b4f62e681 Merge "Add UID in AppInfo." into udc-dev 2023-06-02 01:17:29 +00:00
Vinit Nayak
e65bf2a620 Merge "Skip drawing taskbar background in setup" into udc-dev 2023-06-01 23:13:19 +00:00
Anushree Ganjam
97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Vinit Nayak
5364b0dac9 Skip drawing taskbar background in setup
Test: Manually went into SUW and observed
Fixes: 272674390
Change-Id: I102d1433692793f51d930e710d68134d4536c397
2023-06-01 10:52:39 -07:00
Jagrut Desai
e208e02aba Merge "Fixing Toast Hiding behind Taskbar - Part 2" into udc-dev 2023-05-31 20:45:37 +00:00
Schneider Victor-tulias
8f95307087 Merge "Fix launcher activity leak in TouchInteractionService" into udc-dev 2023-05-31 17:49:35 +00:00
Jagrut Desai
84e959a72a Fixing Toast Hiding behind Taskbar - Part 2
Test: Visual, Manual
Bug: 282964229
Flag: not needed
Change-Id: If2373d8f0bc44a555844c78d20877e9636a7e176
2023-05-31 10:41:16 -07:00
Vinit Nayak
52ac882e9b Merge "Resize mRemoteTargetHandles when RecentsAnimationStarts" into udc-dev 2023-05-30 22:10:28 +00:00
Vinit Nayak
8852010eb8 Create separate fullscreen launch type for shortcuts
Bug: 283045822
Test: Verified via debugger the right API is called,
still have issues on split side
Flag: none

Change-Id: Ic2fcbf4ffe05503b0c2e1fade3e3e990498cf6cf
2023-05-30 13:43:24 -07:00
Achim Thesmann
2bcfbd3739 Merge "Allow BAL in Launcher" into udc-dev 2023-05-27 17:48:16 +00:00
Schneider Victor-tulias
f304ab8e2b Fix launcher activity leak in TouchInteractionService
TouchInteractionService cannot be garbage collected until it has been cleared from the sysui process. Switching to use a WeakReference to help with garbage collection.

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
Change-Id: I37aa5f858f2ae0ac78b46478ab4c5f24770bd64f
2023-05-26 14:39:14 -07:00
Vinit Nayak
ed7b50efee Merge "Handle fullscreen app launchs in split init flow for SplitSelectDataHolder" into udc-dev 2023-05-26 20:19:19 +00:00
Schneider Victor-tulias
b4e91b14bd Merge "Update gesture nav edu motion and colors" into udc-dev 2023-05-26 16:12:06 +00:00
Schneider Victor-tulias
010a55d377 Merge "Fix keyboard quick switch d-pad left/right traversal direction" into udc-dev 2023-05-26 16:11:51 +00:00