Commit Graph

13553 Commits

Author SHA1 Message Date
Treehugger Robot
fb683dff89 Merge "Refactor all uses of DisplayController singleton INSTANCE" into main 2025-02-12 05:47:46 -08:00
Treehugger Robot
a6a4b0921a Merge "Pass TransitionInfo from onTasksAppeared() to TransformParams" into main 2025-02-12 04:28:45 -08:00
Will Osborn
5f8b6206ce Refactor all uses of DisplayController singleton INSTANCE
And make DisplayController display id aware

Test: locally tested on Tangor
Flag: EXEMPT refactor
Bug: 392858637

Change-Id: I805cd7323c48a2988c95b9fda7f6cfe4c153860c
2025-02-12 10:46:34 +00:00
Gustav Sennton
57ce690d4e Pass TransitionInfo from onTasksAppeared() to TransformParams
Pass the TransitionInfo of the merging recents-transition through to
TransformParams to allow setting the corner radius of desktop tasks to
zero during the second part of a recents transition.

Bug: 378657004
Flag: com.android.window.flags.enable_desktop_recents_transitions_corners_bugfix
Test: swipe up from fullscreen app to overview, then tap desktop tile

Change-Id: I08f87aa1b9a2feca9e9f8bed2c55279e0ddc1edb
2025-02-12 10:19:14 +00:00
Treehugger Robot
1844db355f Merge "Disable All Apps keyboard shortcut during user setup." into main 2025-02-11 19:58:28 -08:00
Treehugger Robot
4be58b0d75 Merge "Adding logs to debug test failures" into main 2025-02-11 12:46:31 -08:00
Treehugger Robot
48e89f1273 Merge "Let DesktopTaskView.bind() use DesktopTask" into main 2025-02-11 10:52:58 -08:00
Jordan Silva
4151c1eb9a Adding logs to debug test failures
Bug: 395214062
Test: TaplStartLauncherViaGestureTests
Flag: com.android.launcher3.enable_overview_icon_menu
Change-Id: I4bc612bb5b928a251ee2cf80e14bb9408d1d415c
2025-02-11 10:45:39 -08:00
Priyanka Advani (xWF)
77a5341e53 Merge "Revert "Moving TisBinder to its own class"" into main 2025-02-11 10:17:13 -08:00
Treehugger Robot
0703ed2931 Merge "[CD Taskbar] Force 3 Button Mode on External Display by Default" into main 2025-02-11 10:04:22 -08:00
ELIYAZ MOMIN (xWF)
31d6be8891 Revert "Moving TisBinder to its own class"
This reverts commit ce9ad064d6.

Reason for revert: <Potential culprit for  b/395855288  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted>

Change-Id: I12d1eb66ae03e2638a503c103d0b1fa8a863b6b5
2025-02-11 08:18:42 -08:00
Vinit Nayak
a4b1d1b8c7 Merge "Reset leashes before starting taskbar app pair launch animation" into main 2025-02-11 07:26:22 -08:00
Sunny Goyal
ce9ad064d6 Moving TisBinder to its own class
> Using callback patter for various change events instead of routing it
  via  TIS

Bug: 386288280
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I95577d6a1c17103cb947ef1200c1c22b68fd1d9c
2025-02-11 00:21:51 -08:00
Anushree Ganjam
743786b66c Merge "Move ContextualSearchHapticManager to Dagger" into main 2025-02-10 19:54:06 -08:00
Treehugger Robot
f37f0491b7 Merge "[CD Taskbar] Fix Window Context & Enable External Context adding" into main 2025-02-10 18:33:15 -08:00
Anushree Ganjam
6fada1c0f5 Move ContextualSearchHapticManager to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Id33ef349dc8d793ab7c43d6f420e224a8de515af
2025-02-10 17:17:52 -08:00
Sukesh Ram
0772f1f730 [CD Taskbar] Force 3 Button Mode on External Display by Default
Force 3 Button Mode on External Display by Default.

Test: m
Bug: 383087890
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I197be57f2abbaa533fd165d74f14a13774de5bb3
2025-02-10 17:02:50 -08:00
Treehugger Robot
c913d5317a Merge "Move RecentsModel to Dagger." into main 2025-02-10 16:25:50 -08:00
Sukesh Ram
47f0f6dc8e [CD Taskbar] Fix Window Context & Enable External Context adding
Use variable constrained within TaskbarManager for primary displays and add external window contexts as new displays are added. Ensures the lifecycle of window context map isn't tied to the required instances of primaryWindowContext.

Test: m
Bug: 395702003
Bug: 393984037
Bug: 391653300
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: Idc461b8e6e249060feffac703dff1bf7d5974512
2025-02-10 16:25:16 -08:00
Treehugger Robot
c83abcadb7 Merge "Add spring animations for neighboring tasks on dismiss cancel" into main 2025-02-10 15:32:45 -08:00
Hongwei Wang
bb3006dfd9 Merge "Update the comment on detach" into main 2025-02-10 15:01:54 -08:00
Pat Manning
a82868d7df Add spring animations for neighboring tasks on dismiss cancel
Fix: 389083088
Test: TaplTestsQuickstep#testDismissCancel
Test: TaskGridNavHelperTest
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I1240519eea499b5839d64e537588bde3cb0a424b
2025-02-10 13:24:19 -08:00
Vinit Nayak
ba25fd9523 Reset leashes before starting taskbar app pair launch animation
* This can be launched from desktop windowing, which means the
surfaces of the apps can start in any position/crop.
* Default the leash tasks to start at 0, 0 and let their parent
surfaces determine correct starting position
* Set the stage roots to start at the correct end bounds

Test: Launched from workspace, DW, taskbar
Fixes: 372837890
Flag: EXEMPT bugfix
Change-Id: Ie2cd012e117f645794e5119485cc50d8e1dd9cdf
2025-02-10 13:08:31 -08:00
minch
96308796a6 Let DesktopTaskView.bind() use DesktopTask
Flag: EXEMPT refactor
Fix: 395167255
Test: m

Change-Id: Ia072b4196ce1dc70d8f53c05ee4f793d853a43f7
2025-02-10 20:19:36 +00:00
Treehugger Robot
4c1679fe4f Merge "Re-use existing method to get split root" into main 2025-02-10 11:40:09 -08:00
Anushree Ganjam
d158433769 Move RecentsModel to Dagger.
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I0d459ee3fc012e8e371035071f1b32eb2483cdc5
2025-02-10 10:07:20 -08:00
Uwais Ashraf
3dd744a8bd Merge "Updates the app icon based on the TaskData" into main 2025-02-10 07:36:27 -08:00
Jordan Silva
e316ea5f85 Merge "Fix empty thumbnail/icon by re-fetching data from cache" into main 2025-02-10 02:56:34 -08:00
Jordan Silva
687862c4a9 Updates the app icon based on the TaskData
- Introduces `setIconState` to manage icon and text updates based on `TaskData`.
- Refactors IconAppChip to use the icon and title provided by TaskViewModel.

Fix: 388486032
Fix: 388490814
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Change-Id: Ibf469743ebc767054eaaabe1891750b7f9de827a
2025-02-10 02:24:52 -08:00
Treehugger Robot
bd93d0d4d3 Merge changes If104c67d,Id59fb236 into main
* changes:
  [CD][Alt+Tab] Show apps from all desktops for KQS on CD
  [CD][Alt+Tab] Implement skeleton code for KQS on CD
2025-02-09 13:07:46 -08:00
Ajinkya Chalke
3ef91e087d [CD][Alt+Tab] Show apps from all desktops for KQS on CD
- Even without multiple desktops, apps that are moved to connected display show up in separate desktop task.
- Further changes may be required to launch a desktop after multiple desktops is implemented.

Bug: 382762871
Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Test: manually built and run the CUJ
Change-Id: If104c67d95a1ec3de404998b06352edfa02c0f09
2025-02-09 19:06:54 +00:00
Ajinkya Chalke
4078347cbf [CD][Alt+Tab] Implement skeleton code for KQS on CD
- This change will not render KQS on connected display (CD) even with the flag ON as taskbars are not yet created for connected displays.

Bug: 382762871
Change-Id: Id59fb23630aaf0e74c35818f2a4ca56e5ef2e7bb
Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Test: manually built and run the CUJ
2025-02-09 19:06:45 +00:00
Jordan Silva
9f56a1f793 Fix empty thumbnail/icon by re-fetching data from cache
Request data for all tasks in `TasksRepository` to prevent stale data. This ensures thumbnails and icons are not replaced and become null due to race conditions. The updated code requests data for all tasks, leveraging the cache for immediate returns.

Fix: 394384233
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Change-Id: I356de13b5e9671f50bb1c2680b54b78478fadc28
2025-02-09 05:29:45 -08:00
Treehugger Robot
b3ca33ee45 Merge "Refactor: Extract splash alpha logic from TaskThumbnailViewModel" into main 2025-02-07 17:30:46 -08:00
Jordan Silva
a0c936b6ad Refactor: Extract splash alpha logic from TaskThumbnailViewModel
This commit updates how splash alpha is propagated to `TaskThumbnailView`. These changes reduces the usage of flows to handle animations to improve the performance by avoiding inherent overhead for sending messages between threads (go/sysui-flow-overhead).

Bug: 390581380
Doc: go/launcher-overview-unified-taskviewmodel
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest
Test: TaskViewModelTest
Test: TaskThumbnailViewModelImplTest
Test: TaskThumbnailViewScreenshotTest
Change-Id: I467da1a90b653fb108eb32534bc0dd2a67d95083
2025-02-07 20:52:37 +00:00
Treehugger Robot
d74a33af5a Merge "Make AddDesktopButton can be navigated to through keys" into main 2025-02-07 12:33:46 -08:00
Treehugger Robot
126566a096 Merge "desktop-exploded-view: Implement layout algorithm" into main 2025-02-07 12:00:23 -08:00
Treehugger Robot
795b36785e Merge "Initial Desks tracking on Launcher" into main 2025-02-07 11:53:55 -08:00
minch
b39d3015f8 Make AddDesktopButton can be navigated to through keys
Add the focus outline to the button as well.
Same color, ripple effect as the ClearAllButton is applied.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug:391875235
Test: TaskGridNavHelperTest
Change-Id: If93f86a1dce4df8ee6b1c50dfc44092dad2eafab
2025-02-07 18:33:23 +00:00
Xiaoqian Dai
3491fa49a7 desktop-exploded-view: Implement layout algorithm
It was ported over from ChromeOS Overview layout algorithm. In overview,
the layout is done in two stages:
1. Optimal height is determined. In this stage height is bisected to
   find maximum height which still allows all the windows to fit.
2. Row widths are balanced. In this stage the available width is reduced
   until some windows are no longer fitting or until the difference
   between the narrowest and the widest rows starts growing. Overall
   this achieves the goals of maximum size for previews (or maximum
   row height which is equivalent assuming fixed height), balanced rows
   and minimal wasted space.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: b:367353392, b:353948965

Change-Id: I1d0fd2b30ffa5bbc0853650884cf85b519be4227
2025-02-07 10:06:05 -08:00
Ahmed Fakhry
c0597ac53b Initial Desks tracking on Launcher
This CL adds the initial implementation of the desks tracking
on the launcher side inside `DesktopVisibilityController`.

Bug: 392986431
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I7ece2407a03fec1cad4663efa230ec9a1980fb75
2025-02-07 17:49:36 +00:00
Treehugger Robot
cdc1483f59 Merge "Append application name to content description for direct share targets" into main 2025-02-07 09:28:51 -08:00
Alex Chau
90fb4f883e Merge "Fix Home->Overview grid task not in top-right" into main 2025-02-07 09:28:31 -08:00
Vinit Nayak
7f6f7aad7b Re-use existing method to get split root
Test: Launching app pair from desktop, in-app,
overview from taskbar launches as expected
Bug: 372837890
Flag: EXEMPT bugfix

Change-Id: I50ab3cb1dc95a2cf20b77ae5d00cad3be7cd8e5c
2025-02-07 12:23:50 -05:00
Treehugger Robot
bc37b2c46d Merge "desktop-exploded-view: Add some comments" into main 2025-02-07 09:00:07 -08:00
Mykola Podolian
7fa6b816e9 Merge "Added application shortcut extra to allow the Shell adding bubble." into main 2025-02-07 08:17:23 -08:00
Gustav Sennton
dad84b4121 Merge "Only set task surface corner radius once in TransformParams" into main 2025-02-07 07:42:06 -08:00
Alex Chau
ee082ce6e8 Fix Home->Overview grid task not in top-right
- Use expectedCurrentTaskView's position to calculate if we should add extra gap between clear all button, instead of using the right most task's position; this fixed the case where current task is not the right most task e.g. grid task and desktop task
- The accumulated row width to expectedCurrentTaskView is tracked in the udpateGridProperties loop, and used to calculate the position of the expected position of expectedCurrentTaskView from ClearAllButton
- With this new calculation we no longer needs to adjust longRowWidth when there are onlg large tile tasks

Fix: 391306182
Test: With and without grid-only Overview, test both home and app to Overview with 0-5 tasks with a desktop task; repeat for RTL
Flag: EXEMPT BUG_FIX
Change-Id: I324208c7e063c8b043815291cc0fef7beec884b6
2025-02-07 07:30:08 -08:00
samcackett
d4d4d580da Append application name to content description for direct share targets
The direct share targets `label` will be the name of the receiving
device, so we also need to append the application name for a better
readout

Fix: 380008872
Test: MANUAL. Talkback on. Open an app with a url or image. Open Recents
. Select the url or image AiAi chip. Select the first direct share
target. Talkback should read the targets name and application name.
Share. App should dismiss.
Flag: EXEMPT bugfix

Change-Id: I3d7df44d239ae9b8a3a62b7343e65bcd6a2e9939
2025-02-07 15:25:59 +00:00
Charlie Anderson
b97431394e Merge "Adjust predicted app icon to draw better inner stroke for shapes:" into main 2025-02-07 05:39:51 -08:00