Commit Graph

7225 Commits

Author SHA1 Message Date
Jon Miranda
fa8cc97e5f Revert "Fix bug where taskbar is translated during hotseat handoff."
This reverts commit ecb55ef471.

Bug: 277942460
Test: tablet/foldable device
      check taskbar animation b/w states and during drag

Change-Id: I48e37d58afa6e168a683e1b9c73ae15432920030
2023-04-12 13:24:19 -07:00
Jon Miranda
ecb55ef471 Fix bug where taskbar is translated during hotseat handoff.
Fixes: 277271088
Test: be in app
      swipe up from bottom to top of screen without pausing then release
      observe taskbar -> hotseat handoff
      observe no jump

Change-Id: I2bb9d93d39215ca3653e2e4353391b50b7ab6417
2023-04-07 11:44:33 -07:00
Winson Chung
4b5b50be80 Merge "Always provide mandatory bottom gesture insets" into tm-qpr-dev 2023-04-06 21:40:06 +00:00
Treehugger Robot
199b08efc8 Merge "Close system dialogs on Taskbar home button tap" into tm-qpr-dev 2023-04-06 21:30:51 +00:00
Vinit Nayak
5bda089e2b Close system dialogs on Taskbar home button tap
Fixes: 255879258
Test: Able to go home w/ shade down in app and
in overview

Change-Id: Ia706148b4437e18b16b711bda572c4ba28958718
2023-04-06 12:09:35 -07:00
Winson Chung
48e6b4ccd9 Always provide mandatory bottom gesture insets
Bug: 265614886
Bug: 277185135
Test: atest WindowInsetsPolicyTest
Change-Id: I0cf4d5b72e54caf7c671a5d52a93d2066a79ed65
Merged-In: I964e0b759170c127cb05615ce5bf6fa827621187
2023-04-06 19:08:26 +00:00
Jeremy Sim
4bce4f6193 Merge "Fix bug with split screen not recognizing user differences" into tm-qpr-dev 2023-04-06 19:02:50 +00:00
Mike Schneider
0d7713780f Fade navbar-handle in/out during TRANSITION_HANDLE_FADE
The existing code relied on the INSTANT / FINAL_FRAME interpolators,
however these did not work as expected for sub-animations with shorter durations,
since the INSTANT / FINAL_FRAME interpolator applies to the sub-animations durations

This caused the stashed handle to jumpcut in/out, while the taskbar icons were
actually visible in the area of the navbar.

This is fixed to polish the lock/unlock animation (b/275319714), but happenes to fix b/276941963 as well.

Before: http://shortn/_uxw2oe7QeA
After: http://shortn/_yMY8IQIM60

Bug: 275319714
Bug: 276941963
Fixed: 275319714
Fixed: 276941963

Test: manual (http://shortn/_rnGNSkRH3w), tapl tests
Change-Id: I79e431e9ee21ede069864ee217bb343f0c32dfc7
2023-04-06 12:39:46 +02:00
Mike Schneider
975fa69260 Fade out navbar on lockscreen -> homescreen transition
Introduces a new SYSUI_STATE_STATUS_BAR_KEYGUARD_GOING_AWAY QuickStepContract flag, to get an early signal when the keyguard is going away

Bug: 275319714
Test: transitions manual (http://shortn/_ySNBaPFHRZ), existing tapl tests
Change-Id: Ie0044ea8e934afa793ca56a4eacc2b776edbdf0e
2023-04-06 05:08:28 +00:00
Jeremy Sim
1b75c85305 Fix bug with split screen not recognizing user differences
This patch fixes a bug where split screen did not fully support launching intents with different users.

The bug arose because SplitSelectStateController only had one place to store user information about the staged intent, mUser, but this disregarded the fact that the secondary app could also be passed in as an intent, and could belong to a different user from that of the initial app and the existing context. We need to support this case now since we now allow second-app selection from Taskbar.

Fixed by splitting the field into mInitialUser and mSecondUser, which will be tightly bound with mInitialTaskIntent and mSecondTaskIntent to make sure that Intents are always launched with the correct UserHandle.

Fixes: 275410160
Test: Manual
Change-Id: Ic904672769be8fd116180d457b36eb567c5ee304
Merged-In: Ic904672769be8fd116180d457b36eb567c5ee304
Merged-In: I1ec49c75d562e4309a41d98010f0eff113c81e9d
2023-04-06 03:44:33 +00:00
TreeHugger Robot
65ac592f40 Merge "Allow grids to specify if we should start align taskbar in 3 button nav." into tm-qpr-dev 2023-04-05 21:46:40 +00:00
Jon Miranda
4288be12a7 Merge "Allow user gesture to take priority over taskbar translation reset animnatiuon." into tm-qpr-dev 2023-04-05 18:20:16 +00:00
Jon Miranda
04f051045c Allow grids to specify if we should start align taskbar in 3 button
nav.

Bug: 259712417
Test: check layout on tablet
      check layout on multi_display devices

Change-Id: I282f51e5d76a30e9ad9d8c52d03d4853e965d65a
2023-04-05 10:29:51 -07:00
Mike Schneider
f0f94f2ed9 Hide taskbar content while dreaming.
When entering the dreaming state, the TaskbarDragLayer is faded out.
Upon wake up, a slight delay is added to  allow the SFPS reader to do
its magic, so the lockscreen-navbar does not pop-in just to be removed
again.

Bug: 271440683
Bug: 275319714
Fixes: 271440683
Test: manual (http://shortn/_cQudGXDSDU)
Change-Id: I34e02f02288bace39626d531d115fc994b11f371
2023-04-05 09:40:21 +02:00
Mike Schneider
2ebfc41966 Factor out explicit animation types for the stash/unstash animations.
This consolidates the logic on what animation to play into one place, and will simplify tuning the lock/unlock transitions

Bug: 275319714
Test: manually (http://shortn/_Q1dTzmIpqK), unit tests
Change-Id: I9ba9c9f13dbbff88d8515e567fdb3dfe5556553e
2023-04-05 09:40:21 +02:00
Jon Miranda
41b580bc63 Allow user gesture to take priority over taskbar translation reset animnatiuon.
Bug: 273948325
Test: open overview
      tap to open main app
      quickly swipe up to show taskbar

Change-Id: I0bbb3a354baf9b56652f029a357d8a5803281da5
2023-04-04 17:06:04 -07:00
Tony Wickham
c8d8c58f5b Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev 2023-04-04 15:40:28 +00:00
Tony Wickham
df59884370 Add debug logs for why taskbar might not be destroyed
Test: Manually read log output
Flag: None
Bug: 254119092
Change-Id: Ibaa7ffdc91030c5c999ddc5f2807a55763854331
2023-04-03 23:20:57 +00:00
Jon Miranda
175f5c865b Merge "Fix badged icons / icons with notification dot being cropped." into tm-qpr-dev 2023-04-03 21:06:21 +00:00
TreeHugger Robot
f00e831f05 Merge "Stash taskbar on swipe to go home for 3p fallback launcher." into tm-qpr-dev 2023-04-03 19:47:40 +00:00
Mike Schneider
99cd75e9e3 Merge "Change the use of ScreenLifecycle to WakefulnessLifecycle." into tm-qpr-dev 2023-04-03 19:44:23 +00:00
Jon Miranda
b0195376d4 Fix badged icons / icons with notification dot being cropped.
For icons, we use radius = 0 during the reveal animation so
that the entire view will be visible.

Fixes: 276625136
Test: - have work profile icon or badged shortcut in taskbar/hotseat
      - swipe up to close
      - also check swipe back to close
      - ensure entire icon is visible at the end of the animation so
        that there is a clean handoff
      - run same test with icons that have notification dot
Flag: ENABLE_TRANSIENT_TASKBAR true

Change-Id: I3fef1eede5cac189dab1bf1be4ebd048720727c7
2023-04-03 10:06:16 -07:00
Vinit Nayak
8e307ba50a Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev 2023-04-03 14:58:29 +00:00
Mike Schneider
65b1561a68 Change the use of ScreenLifecycle to WakefulnessLifecycle.
This is a better fit for the signal in launcher, since it identifies
whether the device is awake or asleep, where asleep also inclues AoD

Test: manual, unit tests
Bug: 275319714

Change-Id: I6d6a6694ab018d182606c5554377caec1986bc08
2023-04-03 16:47:12 +02:00
Pat Manning
9330d4991e Stash taskbar on swipe to go home for 3p fallback launcher.
Follow up to b/21916480, which was reverted due to test failures which are now fixed.

Fix: 269070986
Test: manual. Install launcher3WithoutQuickstepDebug and swipe to home from within an app.
Change-Id: I52fad88a25325e5c38a600ccf90b30ebf60bf71a
2023-04-03 10:09:11 +00:00
Winson Chung
13bf1598b9 Merge "Fix gesture insets issue for IMEs" into tm-qpr-dev 2023-04-02 03:26:14 +00:00
Winson Chung
8436e0b382 Fix gesture insets issue for IMEs
- Setting the override frame for the gesture insets sources prevents
  the insets from being calculated correctly for the IME window
- Update the set of provided insets based on the current nav mode
  so that we don't report gesture insets in button nav

Bug: 265614886
Test: Dump IME window insets for button/gesture nav
Change-Id: I22f9d09a66b50d6e2fb5002af19058657a06404d
Merged-In: I22f9d09a66b50d6e2fb5002af19058657a06404d
2023-04-01 06:37:47 +00:00
Brian Isganitis
4500171c6b Merge "Clean up device profile change listeners for AllApps." into tm-qpr-dev 2023-03-31 16:42:07 +00:00
TreeHugger Robot
d9dd75d2cc Merge "Don't stash immediately when drag was canceled" into tm-qpr-dev 2023-03-31 00:08:44 +00:00
Vinit Nayak
ecca8eacbc Default to using SplitSelectSource drawable if TaskView icon drawable is null
* Alternative solution could be to set
onTaskViewVisibilityChanged(true) for the taskView that is about
to be dismissed so it loads it's taskIcon/thumbnail back from the cache
* However, that does still leave us open to race conditions (even though
we can be reasonably confident the icon is probably in the cache)
* Also made other changes to allow already public fields on some classes
to be mockable for unit testing

Fixes: 275267738
Test: Tested with fullscreen task at end of overview,
GroupedTaskView at end of overview,
Initiating split from home,
Initiating split from overview actions,
Initiating split from overview app icon

Change-Id: Ic9059c93c07b90f61c9f418d5d36d6ba201ff96a
2023-03-30 15:26:57 -07:00
Jagrut Desai
d1d0fb8607 Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev 2023-03-29 23:26:26 +00:00
Tony Wickham
52f046e027 Don't stash immediately when drag was canceled
Instead, keep the taskbar open for the normal timeout.

Test: Drag an app from taskbar and drop back in taskbar, ensure taskbar
stays open until 5 second timeout; Drag an app from taskbar and drop
into split screen, ensure taskbar stashes immediately
Flag: ENABLE_TRANSIENT_TASKBAR true
Fixes: 275019813

Change-Id: I06ca0eccbfe313dbae8f6d96c7c09bb659f6a27b
Merged-In: I06ca0eccbfe313dbae8f6d96c7c09bb659f6a27b
2023-03-29 23:10:11 +00:00
Jon Miranda
156ff34f35 Align taskbar so that it does not overlap with nav buttons.
Fixes: 275510698
Bug: 259712417
Test: View device where taskbar should be start aligned
      Update Display size to make everything bigger
      Observe that taskbar icons never overlap nav buttons
Flag: ENABLE_TRANSIENT_TASKBAR true

Change-Id: I246374518f21c4b92d3e02e5582c929a471d9305
2023-03-29 21:04:03 +00:00
Schneider Victor-tulias
1db2fcbd19 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev 2023-03-29 18:54:22 +00:00
Brian Isganitis
d43d7c3702 Clean up device profile change listeners for AllApps.
Test: https://b.corp.google.com/issues/260177372#comment1
Bug: 260177372
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d17261029af89ef03b860686d1d3c6651e7c8e13)
Merged-In: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
Change-Id: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
2023-03-29 18:46:47 +00:00
Jagrut Desai
d2140ba498 Taskbar System Action with Broadcast Receiver.
Test: Manual
Bug: 265618836
Change-Id: I734402ef277a09cf5e41aa63f8be09375706c17a
2023-03-29 10:37:45 -07:00
Schneider Victor-tulias
90259a6db4 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev 2023-03-29 17:03:59 +00:00
Saumya Prakash
eed10f31f7 Merge "Add extra error checking for Home Gesture Tutorial" into tm-qpr-dev 2023-03-28 22:30:56 +00:00
Randy Pfohl
40f065d1fd Merge "checking if outline provider is null to handle rare NPE" into tm-qpr-dev 2023-03-28 22:02:03 +00:00
Jagrut Desai
6fcdfb166d Merge "Make taskbar accessibility announcement when user is in app only." into tm-qpr-dev 2023-03-27 22:38:54 +00:00
Schneider Victor-tulias
2851be8cba Add the gesture nav tutorial menu page
- Added the gesture tutorial menu page (launched using an intent extra)
- tutorial steps now launch the menu when complete if launched from the menu
- the new default set of tutorial steps is home -> back -> overview. this is to handle the case where an intent is launched that is meant to launch the tutorial menu, but ENABLE_NEW_GESTURE_NAV_TUTORIAL is false

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 274463555
Test: Ran the tutorial and menu on a large screen, foldable and phone
Change-Id: I2eb5f658115be4d5ecb0233a8f09d22efe6ebadc
2023-03-27 14:36:01 -07:00
Schneider Victor-tulias
7cd0ae3f73 Fix TwoPanelWorkspaceTests
- Marking the hotseat long press edu as seen on setup to allow the popup menu to be shown immediately in tests
- Recording onWorkspaceItemLongClick on prediction item long click

Flag: not needed
Fixes: 273239675
Test: TwoPanelWorkspaceTest
Change-Id: I76354fd2e3adde11b2a428374fa9c8855ce2ece9
2023-03-27 14:24:35 -07:00
Randy Pfohl
f96827b331 checking if outline provider is null to handle rare NPE
test: verified that a null value wouldn't cause a crash, and would still show the well being toasts correctly. defaulting a value could cause abnormal behavior so I have created a task to follow up with to figure out why this value is being set to null.

bug: 236918951
Change-Id: I9d4282273cb0bc5b6b095dbd082dd1ef79add0dc
2023-03-27 20:18:46 +00:00
Saumya Prakash
f641813483 Add extra error checking for Home Gesture Tutorial
Add an error message for when a user swipes horizontally from the middle
of the screen.

Fix: 275386244
Test: Manual
Change-Id: If4d0dd412c3d1625da18f9c068e5fd7b281548c5
2023-03-27 19:56:35 +00:00
Jagrut Desai
4661854dd6 Make taskbar accessibility announcement when user is in app only.
Test: Manual
Bug: 265099829
Change-Id: I9d90ed7ae3479cf51b261bba63aedccf515bd2c5
2023-03-24 17:02:58 -07:00
Bryce Lee
1276443016 Merge "Revert "Do not allow system gestures when dreaming."" into tm-qpr-dev 2023-03-24 22:58:03 +00:00
Jon Miranda
085c53869f Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev 2023-03-24 21:51:42 +00:00
Hyunyoung Song
e8abfee5e9 Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev 2023-03-24 21:41:04 +00:00
Jon Miranda
9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
Bryce Lee
340f6c0988 Revert "Do not allow system gestures when dreaming."
This reverts commit 05c9d551d8.

Reason for revert: leads to b/274525884

Test: manual
Fixes: 275081253
Change-Id: I4bef532b1d8cb4e4c71458e609f25da901ed943d
2023-03-24 18:34:11 +00:00