Commit Graph

573 Commits

Author SHA1 Message Date
vadimt
839fb7b3ae Eliminating messages that launcher activity is frozen
They were ultimately caused by killing Launcher process from tests.

Now having a test info handler request to clear db.

Bug: 152629799
Change-Id: Ia81ddc3e338718c4cff08c7396b9fda1b7091024
2020-06-22 15:39:19 -07:00
vadimt
45564c831b Removing debug requests from non-debug test info handlers
Bug: 152629799
Bug: 153670015
Change-Id: I02776be811d1d3325b35880d19d25a6638f904ef
2020-06-10 18:48:37 -07:00
vadimt
d9092e83d6 Removing instrumentation for unreproable bug
Bug: 152645831
Change-Id: Iacdb103b01375b8bf48691867b844adebcd325a0
2020-06-05 15:30:31 -07:00
TreeHugger Robot
eb0136b7c4 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev 2020-05-12 00:29:52 +00:00
TreeHugger Robot
3d668090af Merge "Resolve Test flakes" into ub-launcher3-rvc-dev 2020-05-11 23:40:43 +00:00
Sunny Goyal
35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
Samuel Fufa
b549819676 Resolve Test flakes
-> Synchronize calls in LoaderTask.java
issue 156041043

-> Remove non system users on setup
If a work test crashes before getting to run its teardown - we might end up with a user profile that could throw off subsequent tests.
issue 156022161

Test: Manual
Change-Id: Ife708a3de01572f7cb2187078d592d8d570dd951
2020-05-10 13:51:41 -07:00
vadimt
60d3333ff0 Adding waiting for Launcher initialization
This may fix or ease TIS sometimes not receiving events.

Bug: 154157191
Change-Id: I5db9e88397788014dbba9716d777a2b97347828c
2020-05-08 09:29:08 -07:00
vadimt
921f9fd254 Support for counting activity creations
Bug: 139137636
Change-Id: Ib999fd3c82eb2997662578ec35e1d9e1e75e3cbb
2020-04-27 12:41:26 -07:00
vadimt
0703464556 Checking that there are no more than 2 live activities at any moment
This is tightening the makeshift strictmode criteria.

Starting with this moment, we will know that there is
no memory growth during tests execution, which is a big deal.

Big: 139137636

Change-Id: I5edc84524463bd1736d727496ad0fc031bb9624c
2020-04-23 16:35:09 +00:00
TreeHugger Robot
d73d39b45a Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev 2020-04-23 03:22:31 +00:00
vadimt
b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
Sunny Goyal
34ff8cb3c1 Adding common code for instrumentation and robolectric tests
Change-Id: Ia338f0565868bb174ef5f6721924944792866be6
2020-04-20 14:42:30 -07:00
TreeHugger Robot
11e36db88a Merge "Cleanup code related to ag/11035582" into ub-launcher3-rvc-dev 2020-04-16 22:04:45 +00:00
Vinit Nayak
916456bb5f Cleanup code related to ag/11035582
Fixes: 154235554
Change-Id: I114d1e1b9e446e15a774a5a51bdf988070091523
2020-04-16 14:16:56 -07:00
vadimt
cf275c1bd7 Choosing better points to output "start" events for TAPL
Now doing this before branching points, thus avoiding flakes when the
execution can go to an unexpected branch and not produce an event.

Bug: 153824894
Change-Id: If117da0498eaf2d94c9610552724981be34c6569
2020-04-15 12:45:11 -07:00
Vinit Nayak
770cc42685 Revert "Cleanup code related to ag/11035582"
This reverts commit a2a1f86dff.

Reason for revert: b/154068414

Change-Id: I1db0018fa97d5a5380651cf7d04a05a0abd62857
2020-04-15 05:24:10 +00:00
Vinit Nayak
a2a1f86dff Cleanup code related to ag/11035582
Bug: 153443049
Change-Id: I2a9e46fa4ffc613751c9f427ce892ddad3878b35
2020-04-14 14:02:49 -07:00
Sunny Goyal
e396abf502 Moving model data structures to a separate file
Change-Id: I77ad7a5219e72d2e0d6c1803de2ac3ed6a65a8f7
2020-04-09 13:20:39 -07:00
Vinit Nayak
b9cb1e3c8f Merge "Re-enable orientation sensor for Overview animation" into ub-launcher3-master 2020-04-02 19:02:30 +00:00
Vinit Nayak
6b7cc3fdc2 Re-enable orientation sensor for Overview animation
Slight revert of ag/10668129 with adjustment
of disabling it for tests.

Fixes: 151456795
Test: Ran the labtest command for OOP
tests for crosshatch (where this issue
was first detected)

Change-Id: I315d138c2e4a6d4068304e9b5fb2e1b7feb34e63
2020-04-02 11:07:10 -07:00
vadimt
00a031fbab More diags for missing widgets
Bug: 152645831
Change-Id: Idf6584220328a0853cd8dd65ebb5c54bab9980fd
2020-04-01 15:33:35 -07:00
TreeHugger Robot
349e95f1e4 Merge "TAPL: Verifying activity start/stop events" into ub-launcher3-master 2020-03-28 03:45:24 +00:00
vadimt
75add7cef5 Debug tracing for "widget not present" flake
Bug: 152645831
Change-Id: I1e318650e45ab8e2a60eccef2f4f3c247b2a6b5b
2020-03-27 15:08:36 -07:00
vadimt
0dd1bd1113 TAPL: Verifying activity start/stop events
It also turned out that Pilfer event seems to come in a
non-deterministic order relative to the events from the Main and TIS
sequences. So I moved it to its own sequence.

Change-Id: Ie4ea5865afd900bebbd8287dad2372c94dce8ad5
2020-03-27 10:23:33 -07:00
vadimt
7a9f1628f2 Repeating unlocking the phone several times
Bug: 151613234
Change-Id: Id5cbc247d7827fa31c2011d817b2964c1486daeb
2020-03-21 15:09:39 -07:00
vadimt
7500c241ac Increasing wait time till unlock
Bug: 151613234
Change-Id: I47e0a87551cebf31fa309b9a65b2ecff809a7f00
2020-03-21 13:04:15 -07:00
Vadim Tryshev
b66ba0bae7 Merge "Adding more checks around unlocking the phone" into ub-launcher3-master 2020-03-21 04:03:32 +00:00
TreeHugger Robot
0ddd265fdb Merge "[Flake test] add state checks for WorkTabTest#testWorkEduIntermittent" into ub-launcher3-master 2020-03-21 02:14:49 +00:00
vadimt
330fde4aaf Adding more checks around unlocking the phone
Bug: 151613234
Change-Id: I045306cce2ce85d6895c9f050ebb4d2bd15ba232
2020-03-20 18:55:53 -07:00
TreeHugger Robot
1af6be57c8 Merge "Disable battery defender to avoid locking during the test" into ub-launcher3-master 2020-03-20 23:20:57 +00:00
vadimt
1b4247d9cd Disable battery defender to avoid locking during the test
Bug: 151613234
Change-Id: Id323025c1a3bb53cc39839aa2295fcd25436e68e
2020-03-20 14:26:31 -07:00
TreeHugger Robot
7d3a113d05 Merge "Work profile accessibility fixes" into ub-launcher3-master 2020-03-20 20:46:25 +00:00
Samuel Fufa
7f6baf9f60 [Flake test] add state checks for WorkTabTest#testWorkEduIntermittent
Bug: 151768149
Test: labtest
Change-Id: I676175629c60662763b26ce24eba4a361784fbeb
2020-03-20 13:28:00 -07:00
Samuel Fufa
45c3b10448 Work profile accessibility fixes
- Remove TextView and use work switches text
- Allow talkback to read recyclerview overlay

Bug: 151884799
Bug: 151803591
Bug: 151274763
Bug: 151585835
Test: Manual
Change-Id: Ieee0d37d0244eb12ecb923d710cbbd6a86281062
2020-03-20 11:52:03 -07:00
vadimt
d8070756f1 Making sure the device doesn't lock during test execution
Unlocking the device at the beginning
of the test does help, but perhaps we should prevent
locking during the test execution.
Some failures still remain.

Bug: 151613234
2020-03-19 20:33:47 +00:00
vadimt
14b60d77b7 Unlocking device from the test
This is a workaround for the infra not unlocking
the device properly.

I don't have access to may machine, so
I've created this CL in Gerrit editor, didn't test,
but it should work.

Bug: 151613234
2020-03-19 17:59:34 +00:00
Samuel Fufa
f5a4deb120 Hide work apps when work profile is paused
- hide overlay icon in landscape mode
- don't show edu if user has already seen legacy work profile edu
- make sure personal tab is highlighted when work profile is reinstalled
- always go home after a work profile is added or removed
- add tests for work edu flow

Bug: 150122946
Test: Manual
Change-Id: I8f80ac763acf03ca31a534464f4ddfd84528d329
2020-03-12 10:25:50 -07:00
TreeHugger Robot
d9da5a45fd Merge "Enabling widget config tests after fixing flakiness" into ub-launcher3-master 2020-03-06 06:53:51 +00:00
TreeHugger Robot
f67ab6c64d Merge "Catching everything from dumpHprofData" into ub-launcher3-master 2020-03-06 02:14:19 +00:00
vadimt
bb2bf277c0 Catching everything from dumpHprofData
Change-Id: I79ced1d4bb3e6ea43ce6fa5bd07fe22b577006f9
2020-03-05 17:22:18 -08:00
vadimt
3abc8511a5 Enabling widget config tests after fixing flakiness
Bug: 148867106
Change-Id: I8bbd9ef9b1ca574f79f3f76869051495b59734ce
2020-03-05 15:01:38 -08:00
vadimt
6d605da821 Verifying that tests run against a matching Launcher version
Change-Id: I3a6c9e1a2487cfd571abdf4bdd18ab17c7ac9406
2020-03-05 13:36:12 -08:00
Vadim Tryshev
0ae6433a61 Merge "Saving heap dump immediately as reported by StrictMode" into ub-launcher3-master 2020-03-04 19:31:55 +00:00
TreeHugger Robot
fe41c3af21 Merge "Allow Launcher to automatically restore widgets" into ub-launcher3-master 2020-03-04 00:16:09 +00:00
Samuel Fufa
9151c011b9 Allow Launcher to automatically restore widgets
This replaces PendingAppWidgetHostView with configured widget view when
OPTION_APPWIDGET_RESTORE_COMPLETED is set to True by a widget provider.

Bug: 63667276
Test: Manual
Change-Id: Ide21f5e9a7dac7e3d6a745660a38ad0b951b47d3
2020-03-03 15:35:48 -08:00
vadimt
3d9dad3b9b Saving heap dump immediately as reported by StrictMode
Can do this via API with the exact heap state that triggered the
callback because using API allows to avoid deadlock that we'd have in
main thread if we used shell command.

checkDetectedLeaks() is still needed, as I'll add throwing an
exception there soon.

Bug: 139137636
Change-Id: I3c8670071b058c5c146ac58bb16152c980553065
2020-03-03 18:21:07 +00:00
TreeHugger Robot
b83399b46e Merge "Fixing activity being referred after destroying." into ub-launcher3-master 2020-03-03 18:09:11 +00:00
vadimt
b1eaa1752e Fixing activity being referred after destroying.
This is perhaps not a leak, but it conflicts with how StrictMode
activity leak detection works.

Bug: 139137636
Change-Id: I1608e348d8b238142c42ed81ae125fd07ef6b673
2020-03-02 18:36:01 -08:00
Vinit Nayak
a406f727ad Add vertical layout support for Overview in portrait
WM is making changes which allows apps to maintain
their orientation independent of the orientation of
the foreground app. This allows recents to always start
in portrait even when the app currently running is in
landscape. This means we have to give the illusion of
a landscape oriented overview when user swipes up in
gesterual nav when launcher is started in portrait
configuration.

PagedOrientationHandler abstracts all coordinate specific
logic from Paged/RecentsView primarily, but also all
other dynamic calculations throughout launcher.
PagedViewOrientationState is the single point of exposure
to other classes that depend on those changes. The goal
is to also minimize holding state to allow for default
implementations of PagedOrientationHandler for all the
3p/Fallback classes. PagedViewOrientationState also
holds other data around rotation that isn't
specifically tied to view logic.

The fake landscape overview can be toggled with:
adb shell settings put global forced_rotation [0/1]

Fixes: 146176182
Change-Id: I65d8d4e9f92b93931cbe0053ccaf0cda8d2ffd6c
2020-03-02 18:02:35 -08:00