Commit Graph

358 Commits

Author SHA1 Message Date
TreeHugger Robot
f0c96721ba Merge "Add handling for toggling keyboard stashing from the keyboard" into udc-dev 2023-05-15 22:57:14 +00:00
Tony Wickham
4f69ca52ef Merge "Remove unused/obsolete feature flags" into udc-dev 2023-05-15 21:46:15 +00:00
Schneider Victor-tulias
eb8dce01ce Add handling for toggling keyboard stashing from the keyboard
Flag: ENABLE_KEYBOARD_TASKBAR_TOGGLE
Bug: 281726846
Fixes: 246660615
Test: toggled the transient taskbar with the meta+t input
Change-Id: I315f83850b11d24d8b55061d7111300effb43936
2023-05-15 18:41:25 +00:00
Tony Wickham
53c811fd7d Remove unused/obsolete feature flags
Flag: N/A
Test: N/A
Fixes: 270391641
Fixes: 270395077
Change-Id: I91834b43bf043a26c2fe8e5f7b2e720592830918
2023-05-12 21:09:30 +00:00
Jeremy Sim
f4835a8884 Force Taskbar to remain stashed when in 3p launcher or recents
This patch makes it so that the transient Taskbar cannot unstash when in 3P launcher.

Previously, the user was able to unstash Taskbar when in 3P launcher, causing a janky-looking UI (3P launchers may implement their own version of Taskbar on the home screen. This also caused problems with certain Taskbar commands like split screen, which provide an entry portal to Pixel-specific implementations.

Fixed by forcing the Taskbar to stay stashed when a 3P Launcher is displayed. The Taskbar is still usable inside of other non-launcher apps. This was done by using TopTaskTracker to check for ACTIVITY_TYPE_HOME or ACTIVITY_TYPE_RECENTS, and disabling Taskbar when these activities are running.

Fixes: 277963491
Test: Manual
Change-Id: Ifc0f3c07e3b76eb610f93205978fbc596bab6253
2023-05-12 00:32:24 -07:00
Mady Mellor
50e8d0ff60 Add Bubbles and BubblesListener to SystemUiProxy and use it
Adds a method to call into WMShell to set the listener and
indicate when a bubble is shown or when the expanded state
changes.

BubbleBarController sets or clears out the listener.

BubbleBarViewController calls SystemUiProxy when bubbles are shown
or when the expanded state changes.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I2364b9bbdea237fc268b0999d9c896585c194a86
2023-05-05 14:18:00 -07:00
Qiao Yang
1aee68df56 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev 2023-05-05 19:09:44 +00:00
Qiao Yang
2482c8dcd4 Revert "Revert "Listen for hover events over stashed taskbar.""
This reverts commit c27605099c.

Reason for revert: DroidMonitor-triggered revert due to breakage <https://android-build.googleplex.com/builds/quarterdeck?branch=git_udc-dev&target=cf_x86_64_phone-userdebug&lkgb=10076607&lkbb=10076982&fkbb=10076788>, bug <281093059>

Change-Id: I71e7fd07232c27a004243df0ffb0457fe53fe13b
2023-05-05 19:07:17 +00:00
Qiao Yang
51669b612f Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev 2023-05-05 18:05:16 +00:00
Pat Manning
c27605099c Revert "Listen for hover events over stashed taskbar."
This reverts commit c5882bcdfc.

Reason for revert: b/281068877

Change-Id: I431678658fc464c995df0df5e3cac5491d91b052
2023-05-05 17:22:21 +00:00
Treehugger Robot
b6f64a4465 Merge "Listen for hover events over stashed taskbar." into udc-dev 2023-05-04 23:15:44 +00:00
Pat Manning
c5882bcdfc Listen for hover events over stashed taskbar.
Bug: 243191650
Test: TaplTestsTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia189ac6a6097d073c40c69ead6ecaf398d22eba8
2023-05-04 20:35:44 +01:00
Winson Chung
c8ad4f7f43 Wait for shell drop target to be ready for handling drags in tests
- Wait for the shell drop target to be made visible and drawn before
  attempting to continue with the drag gesture

Bug: 234653212
Test: atest NexusLauncherTests

Change-Id: Ida851343873b51288460f25bba062f29019005d4
2023-05-02 05:29:36 +00:00
Tracy Zhou
7dc9e3a088 Support 4-finger gesture to quick switch
Fixes: 270610237
Test: 4-finger horizontal swipe -> quick switch
Change-Id: I981a7e93ecd07357c7a9cda075f476b397c448cc
2023-04-20 22:34:19 +00:00
Tracy Zhou
7c49cb3ac2 Merge "Support 3-finger swipe to pull down notifications from app" into udc-dev 2023-04-20 22:19:03 +00:00
Tracy Zhou
75b534e9c9 Support 3-finger swipe to pull down notifications from app
Fixes: 270211015
Test: 3-finger swipe down to bring down notifications. 3-finger swipe up to go home / to Overview

Change-Id: Id0f8ad95d9a4a1f8ecf1632ea28efb0c790c291b
2023-04-19 23:37:37 -07:00
Vinit Nayak
b0f1da28fe Merge "Prevent taskbar on phone from crashing" into udc-dev 2023-04-18 00:49:48 +00:00
Fengjiang Li
e12d344b61 Format switch case block of TouchInteractionService so that future change is not blocked by lint
Test: test launching app
Bug: 278092752
Change-Id: I6d3be682d653f7378bb4c9ce4b6a1048e49386dc
2023-04-14 12:43:27 -07:00
Vinit Nayak
f00760ac23 Prevent taskbar on phone from crashing
* Update code behind flag to work with transient taskbar
* We explicitly set the mDestroyed flag to false in
TaskbarActivityContext because it gets set to true when
the flag is on, but nothing resets it unless it gets
recreated normally.

Bug: 274517647
Flag: persist.wm.debug.hide_navbar_window
Test: Enable flag and verify no crash
Change-Id: I9a149ffb47a10efedfc9dff8399d12d4c1a31553
2023-04-13 14:33:17 -07:00
Tracy Zhou
8353a381c6 Support 3-finger swipe down on the home screen to pull down notifications
Fixes: 276605497
Test: 3-finger swipe down to pull down notifications. 3-finger swipe up to pull up overview
Change-Id: I4c1e0df15a94905fa197849f5667a5446c259ffe
2023-04-11 20:20:41 -07:00
Tracy Zhou
d8e3a96c5e Log motion event classification and pointer count in ActiveGestureLog
Fixes: 276959586
Test: N/A
Change-Id: Ia040a0bd50471b1f4cb6ba85d6b013c36548ed5f
2023-04-06 17:06:04 -07:00
Treehugger Robot
4c61c48dd4 Merge "Clean up ENABLE_INPUT_CONSUMER_REASON_LOGGING" into udc-dev 2023-04-06 21:28:38 +00:00
Schneider Victor-tulias
7d8a0df175 Clean up ENABLE_INPUT_CONSUMER_REASON_LOGGING
flag: ENABLE_INPUT_CONSUMER_REASON_LOGGING
Fixes: 270390028
Test: ran launcher and printed gesture nav logs
Change-Id: I0fd0b82c1c812ddc43beba03bd456795f68ada55
2023-04-05 15:40:32 -07:00
Stefan Andonian
3d877d3b04 Merge "Write ViewCapture data to WmTrace when WindowManager dumps." into udc-dev 2023-04-05 20:19:42 +00:00
Tracy Zhou
cb93ec5f21 Support second meta key closing the all apps tray
Bug: 270244718
Test: Tap meta key twice, see all apps tray open an close
Change-Id: I6db84aa16b7d21663053bf1b269af6ba36874e47
2023-04-03 20:26:39 -07:00
Stefan Andonian
ec6e1975dd Write ViewCapture data to WmTrace when WindowManager dumps.
This allows apps like the Launcher to write ViewCapture data to the
wmtrace directory so it can be shown in their UI. Normally, Launcher
doesn't have the correct file permissions. Also, Launcher's dump method
is called after the wmtrace dir is written to the bug report, so we need
to dump sooner via a callback method invoked inside WindowManager.

Bug: 224595733
Test: Latency tested this change and verified that a bugreport generated
the file properly, moved it to the wmtrace directory, and was picked up
properly by the go/web-hv tool.

Change-Id: I5091208c618cb43e1b65adb8e78bfcddc92e79bf
2023-03-27 16:46:33 +00:00
Tracy Zhou
a33fb69603 Disable 3-finger workspace scroll
Fixes: 274474023
Test: 3-finger horizontal scroll on the workspace doesn't do anything
Change-Id: I32ade8a5c26eae43f5ce9c8c71d47ed0d1abd5a2
2023-03-21 17:17:35 -07:00
Ats Jenk
2065586a5d Merge "Directly use launcher activity interface" into tm-qpr-dev am: 8b4ac56ee2 am: 20f89a41f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22121678

Change-Id: If06bcfcfb058b0a932bec4b1364e14da4cac1f07
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 21:37:01 +00:00
Ats Jenk
c7c9d594a1 Directly use launcher activity interface
When desktop tasks become visible or hidden, we update a SysUI state
flag. This flag update gets processed in TouchInteractionService which
then calls DesktopVisibilityController to update launcher state based on
whether desktop tasks are visible or not.
We were getting a reference to the DesktopVisibilityController through
OverviewComponentObserver. This was causing issues when device was
unlocked with desktop tasks visible. And 3-button navigation was enabled.
In this scenario, we are immediately processing a SysUI flags update
that desktop tasks are visible again (they are hidden while device is
locked). When this update is processed, OverviewComponentObserver
returns the fallback launcher interface. And not the nexus launcher.
The fallback launcher interface does not contain the
DesktopVisibilityController. Since the fallback controller does not
return the visiblity controller, we skipped processing the update that
desktop tasks are visible. Which resulted in launcher remaining in a bad
state with home screen icons visible and desktop tasks on top.

Bug: 273594452
Test: enable 3-button nav and proto 2, move an app to desktop, lock
  screen with desktop app visible, unlock screen, observe launcher icons
  hidden
Test: enable gesture nav and proto 2, move and app to desktop and lock
  screen with desktop app visible, unlock and observe launcher icons
  hidden
Test: repeat the same steps with proto 1 enabled
Change-Id: Id52ac4cf2df151b2aee2070ee2eb14de3d74fead
2023-03-16 08:58:50 -07:00
Brian Isganitis
4c4852ceda Merge "Treat setup wizard default home as null." into tm-qpr-dev am: 5248b02080 am: f5dc57a910
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21690746

Change-Id: Ia74f686795b42ab9f6d860850e7759329864ff96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 00:07:33 +00:00
Brian Isganitis
5248b02080 Merge "Treat setup wizard default home as null." into tm-qpr-dev 2023-03-03 21:11:18 +00:00
Stefan Andonian
894a19af1a Merge "Preload expensive objects before user is unlocked." into tm-qpr-dev am: 86d8db485f am: b341f31fc7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391179

Change-Id: I1774961a28e66aefedec2261002d7b2c2b7c3974
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 08:06:26 +00:00
Brian Isganitis
589cb3480a Treat setup wizard default home as null.
During setup, default home progresses setup -> null -> launcher, which
can lead us to unintentionally preload the fallback overview.

Fix: 258022658
Test: Manual
Change-Id: I952b7923b06f2d4b058f42834d1f840719c73fd0
2023-03-01 18:05:51 -08:00
Stefan Andonian
5bd9a225a8 Preload expensive objects before user is unlocked.
This change includes migrating data required for starting the launcher
from encrypted storage into device protected storage. All of the data
being moved has already been approved by the correct authorities.

Bug: 251502424
Test: Performed latency testing using logs from user unlock until first
workspace screen loaded.

Change-Id: I58b0cd1c7bad260c2252f9e172ef85ab885c7fe9
2023-03-01 23:09:07 +00:00
Sunny Goyal
98204add71 Moving flag creation to a separate file
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation

Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
Merged-In: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-28 18:05:42 +00:00
Sunny Goyal
749983b192 Moving flag creation to a separate file
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation

Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-27 23:19:39 +00:00
TreeHugger Robot
0aa1de56cd Merge "[Gesture Library Integration] Update the check for motion events on trackpad" into udc-dev 2023-02-23 23:15:59 +00:00
Tracy Zhou
d248ee7507 [Gesture Library Integration] Update the check for motion events on
trackpad

The gesture library is ported and enabled, thus we are updating our
check for motion events on trackpad.

Bug: 254783214
Test: Swipe up and hold to go to overview; swipe up to go home
Change-Id: I4b74e88c7f8b6ef86c779391b0f8064ea828ed8f
2023-02-23 20:58:22 +00:00
Tracy Zhou
87a93c6ecb Expose taskbar toggled signal to Launcher
Bug: 246660615
Test: N/A
Change-Id: I6051bffa1097c43c617cbb9e8a6b8815dd065a30
2023-02-22 08:55:38 +00:00
Stefan Andonian
64c3511087 Merge "Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"" into tm-qpr-dev am: 8989f839f5 am: bcfc5acb9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21142878

Change-Id: Ib2d66bf6b341da53bf7f835ec534e450f24f2ed6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-20 20:33:43 +00:00
Robin Lee
aafeb82613 Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"
This reverts commit 2a58ddb89f.

Reason for revert: b/266987957

Change-Id: I4a4a1f01a693d703f4dc87e8169fbf374729d274
2023-02-17 19:45:27 +00:00
Schneider Victor-tulias
556d37bf01 Merge "Add the KeyboardQuickSwitchView (1/2)" into tm-qpr-dev am: 673e6437b8 am: 031e3d38b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21087434

Change-Id: Ib0389210f200baa71f346edbc0ca78678702707a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-14 19:43:13 +00:00
Schneider Victor-tulias
f908729fa8 Add the KeyboardQuickSwitchView (1/2)
Preparatory change for adding the KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: I468481a023e82d3ef7c7d4d44c5b9435173b49ae
2023-02-13 15:34:39 -08:00
Nicolò Mazzucato
f907f4a00b Merge "Drive Launcher unfold animation from System UI" into tm-qpr-dev am: 5147b1d509 am: 8778426fa1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21298421

Change-Id: I1ef6c450692076c5af7032c60f518f8c01fdff11
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-11 11:00:38 +00:00
Nicolo' Mazzucato
8d9edd292b Drive Launcher unfold animation from System UI
Before this cl, both Launcher and System UI processes were registering for hinge angle and device state (e.g. folded/unfolded) change events to calculate the current unfold animation progress. In some cases, launcher ui thread was busy, delaying the progress calculation from the hinge angle value (that was received ~at the same time by both processes). This resulted in launcher and sysui unfold animation not being synchronized in some cases.

With this cl, System UI process uses OverviewProxyService to send the unfold events to Launcher. In this way, both process always have the exact same progress (+- 1 frame)

This is currently guarded by a launcher flag, by default with the new behaviour, to allow devs to compare the experience and easily debug potential regressions.

Bug: 268490854
Test: Analysed perfetto trace + RemoteUnfoldTransitionProgressProviderTest + manual
Change-Id: If15fd6fe39abb3d922c5fdb327100206dfa3665d
2023-02-10 22:04:19 +00:00
Stefan Andonian
89d425ccae Move ViewCapture On/Off controls to QuickSettings Tile. am: 526e168906 am: ba7ed6c66c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20946024

Change-Id: I15edf5c9064893e8b07b55179b2d3546f7e1af7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 19:22:16 +00:00
Stefan Andonian
526e168906 Move ViewCapture On/Off controls to QuickSettings Tile.
Rather than use a feature flag for this feature, the on/off state will
be stored as a system setting and will be changed via a QuickSettings
tile.

Bug: b/264452057
Test: Verified that the new QuickSettings tile doesn't crash via normal
interactions (pressing, long-pressing, etc.). Also verified that
ViewCapture is turned on when the QuickSettings tile is in the enabled
state and is turned off when it is in the disabled state.

Change-Id: I90551511ac2766dc30c51a25aec2c96e3e552ce9
2023-01-30 22:51:26 +00:00
Tracy Zhou
6692653328 Disable quickswitch for trackpad gestures
Bug: 261815244
Test: make sure (1) if user starts by swiping up, disable quickswitch (they will land either in overview, home, or the current app) (2) if user starts by quick switching, cancel the gesture

Change-Id: I6b59cec0089d5e6f22eee3241c6336345dd15dce
2023-01-29 23:56:00 -08:00
Tracy Zhou
66b9860080 Merge "Revert "Update onOverviewShown interface to get signal of whethe..."" 2023-01-20 19:19:40 +00:00
Tracy Zhou
a026d1f80a Revert "Update onOverviewShown interface to get signal of whethe..."
Revert submission 20956764-alt_tab_forward

Reason for revert: Actually we dont need these changes after all. SHIFT doesn't matter in the initial tab to overview. The subsequent tabs are handled by RecentsView and we already have a check on shift

Reverted changes: /q/submissionid:20956764-alt_tab_forward

Change-Id: I42b03d10f30ef137c98005bb46e23f8516720236
2023-01-19 19:34:34 +00:00