Commit Graph

6099 Commits

Author SHA1 Message Date
Alex Chau
ceb2aaa9e4 Merge "Refactor DeviceProfile tests based on dump() and use real device dimensions for tests." into tm-qpr-dev 2022-08-01 18:06:59 +00:00
Pat Manning
5f74bfd76d Refactor DeviceProfile tests based on dump() and use real device dimensions for tests.
- Added roundPxValueFromFloat when converting dp/sp to px to deterministically round up values around .5

Fix: 240133465
Bug: 237542518
Test: DeviceProfileTest.kt
Change-Id: If4239f714487fe5bf2ef44274e2ce415bd75c86d
2022-08-01 17:54:43 +00:00
Tony Wickham
6e59888a89 Merge "Dump mExclusionRegion bounds" into tm-qpr-dev 2022-08-01 15:26:35 +00:00
Tony Wickham
3e70b820f0 Dump mExclusionRegion bounds
Also fix the dump for mDeferredGestureRegion to more helpfully print the
bounds instead of the region (which just prints "SkRegion()").

Test: adb shell dumpsys activity service TouchInteractionService | grep
- i region
Bug: 240654796

Change-Id: Ibb14c51f92ec01d2635cee33da15bb6d0421683d
2022-07-29 16:37:11 -07:00
TreeHugger Robot
4a98d8f919 Merge "Set overview progress on fling to 1 only if going to overview state." into tm-qpr-dev 2022-07-29 22:46:35 +00:00
Jeremy Sim
b7a781b599 Merge "Update animations for TM-QPR: OverviewSplitSelect > Home transition" into tm-qpr-dev 2022-07-29 18:57:00 +00:00
Jeremy Sim
fe5bccbf6f Merge "Update calculation method for Overview UI placement on tablets" into tm-qpr-dev 2022-07-29 18:56:40 +00:00
TreeHugger Robot
96010b10f1 Merge "Keep the default display's top running task in the top of running list" into tm-qpr-dev 2022-07-29 03:15:31 +00:00
Tony Wickham
d7fb7f379a Merge "Cleanup taskbar+assistant interactions" into tm-qpr-dev 2022-07-28 23:02:35 +00:00
Winson Chung
8848152b7a Merge "Add running apps icons to taskbar for desktop environment." into tm-qpr-dev 2022-07-28 22:14:42 +00:00
Jeremy Sim
1cfe6d490a Update calculation method for Overview UI placement on tablets
This update slightly changes the calculation method for Overview UI placement, in order to line up better with spec. (The previous calculation caused a small 30dp divergence on tablets.)

Bug: 236760307
Test: Manual by measuring pixels and comparing to spec
Change-Id: I94e9e7b5a6a24c37693425ac8ec71cd066003658
2022-07-28 14:05:24 -07:00
Tony Wickham
06e5728c7e Merge "Set FLAG_RESUMED = false when expanding PiP" into tm-qpr-dev 2022-07-28 18:57:22 +00:00
Merissa Tan
5dbd289f18 Add running apps icons to taskbar for desktop environment.
This CL adds app icons for launched/running apps to the Launcher
taskbar hotseat. When the activity is closed, the app icon is
removed. The apps that are added to the taskbar on boot are never
removed.

Recall: http://recall/clips/ad6d3cfc-7358-4b37-846e-de843ad3000d

Bug: 183906774
Test: Launch an app and verify the app icon is added on the taskbar.
Close the app and verify the icon is removed from the taskbar.
Test: Switch navigation modes on the emulator and ensure that running
app icons are added to the taskbar after it is reinitialized.
Test: atest NexusLauncherTests:com.android.quickstep.RecentTasksListTest RecentTasksControllerTest

Change-Id: Ieaaf001530b5778871fb7a8d18cdcaa1ccbf0e31
Merged-In: Ieaaf001530b5778871fb7a8d18cdcaa1ccbf0e31
2022-07-28 17:50:12 +00:00
Iris Yang
282cf0867f Keep the default display's top running task in the top of running list
While we move a task to virtual display, we will receive
onTaskMovedToFront() callback to add the task(on virtual display) into
the running list. It cause the first item of Recents is virtual
display's task but the thumbnail view is showing default display's
task snapshot.
This change is to keep default display's top task in the first while
adding a virtual display's task into the running task list.

Fix: 235797788
Test: 1.Launch app1 on default display,
        launch app2 on virtual display,
        enter Recents,
        observed the recent animation and overview is showing app1.
      2.Launch app1 on default display,
        swipe app1 to home,
        launch app2 on virtual display,
        enter Recents,
        observed the overview is showing app2.
https://drive.google.com/file/d/1XkGNupJknmFKqjE3c97s6ieCKN5v-n_z/view?resourcekey=0-NLDIaK2EV2tG2ItccUdxDw
Change-Id: Ibb740986782eadf02672081cbd716fed04be6468
2022-07-28 02:43:39 +00:00
TreeHugger Robot
778f8c1833 Merge "Fix issue where System UI crashing resulted in no unlock animation." into tm-qpr-dev 2022-07-27 21:34:05 +00:00
vadimt
f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
Tony Wickham
eeb66e41e5 Cleanup taskbar+assistant interactions
- Always move the taskbar layer when voice interaction window visibility
  changes, to ensure we remove the temporary taskbar background in all
  cases (e.g. swipe to home)
- Move check to not draw taskbar background to the temporary view
  itself, so that it's at the proper layer when shown (e.g. during
  fulfillment on the home screen)
- Don't add view to window if it's already added (we already have this
  check for the removal case)

Test: Open an app, invoke Assistant, swipe home; Taskbar background is
removed; invoke and fulfill assistant from home screen, in app, in 3
button mode, and in gesture mode (all permutations)
Fixes: 236924161
Fixes: 240101132
Fixes: 235895444

Change-Id: I5958f1dbe14a6d190d3808014429f7f8146c9f96
2022-07-27 12:52:59 -07:00
Josh Tsuji
28fa196090 Fix issue where System UI crashing resulted in no unlock animation.
Fixes: 235254892
Test: adb shell am crash com.android.systemui
Test: adb shell am crash com.google.android.apps.nexuslauncher
Change-Id: Ia9644f8d1d5ffc9b162ce1608f8dd9ea9e1e3622
2022-07-27 14:38:31 -04:00
Tony Wickham
f3636d09e7 Set FLAG_RESUMED = false when expanding PiP
This allows us to play the icon alignment animation immediately, rather
than waiting for the expand to finish and launcher to be paused.

Test: Open Maps in PiP on home screen, expand it and watch taskbar
Fixes: 239506421
Change-Id: I5c04f778c4c39c2895db0a1ea1fca4d48d1f3093
2022-07-27 08:52:09 -07:00
Jeremy Sim
caacd73cfa Merge "Add comment regarding Overview TaskViews" into tm-qpr-dev 2022-07-26 23:00:20 +00:00
Schneider Victor-tulias
f6003ff070 Merge "Fade out the taskbar icons when animating to overview in 3 button nav." into tm-qpr-dev 2022-07-26 17:29:33 +00:00
TreeHugger Robot
5e6fe32818 Merge "Space out 3 button nav on taskbar" into tm-qpr-dev 2022-07-26 16:32:06 +00:00
Winson Chung
c6fb382132 Merge "Prevent setting max layer above the input consumer" into tm-qpr-dev 2022-07-26 16:28:21 +00:00
Alex Chau
66bac181ac Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev 2022-07-26 09:36:18 +00:00
Tony Wickham
bbfbe60f72 Merge "Hide the task icon during quick switch from home" into tm-qpr-dev 2022-07-26 00:43:55 +00:00
Jeremy Sim
74f7789f8b Add comment regarding Overview TaskViews
Just adds a comment explaining the elevation of Overview TaskViews. No code changes.

Bug: 208650434
Test: None needed.
Change-Id: I19c434f8473237a4a0f6fe36deecc9c80e7b8a49
2022-07-25 22:04:37 +00:00
Vinit Nayak
c7293179d0 Space out 3 button nav on taskbar
* Add additional margin on nav buttons if
there's overlap w/ contextual button
* End spacing is dependent on grid layout

Bug: 223724516
Test: Tested on unfolded with different
grid sizes.

Change-Id: Ie814f35cd1f35629744050ee3f7242c5a8599883
2022-07-25 13:15:11 -07:00
Alex Chau
62572c04e2 Revert "Move BaseActivityInterface task size methods to DevicePr..."
Revert "Move BaseActivityInterface task size methods to DevicePr..."

Revert submission 19279487-baseactivityinterface

Reason for revert: As per discussion in ag/19341332, make sure DeviceProfile can properly react to inset changes before moving task size calculations there
Reverted Changes:
I30324d34c:Move BaseActivityInterface task size methods to De...
Ia9c1d0387:Move BaseActivityInterface task size methods to De...

Bug: 238593212
Change-Id: I0d40fdd4a5d4468494e30cef32a284479ddd2feb
2022-07-25 18:38:03 +00:00
Winson Chung
8b0793f9ef Prevent setting max layer above the input consumer
- The leash is being set to max layer above the specified
  layer of the recents input consumer set by WM (in
  InputMonitor), revert this for legacy transitions

Bug: 239042246
Test: Swipe up to overview and quickly swipe again
Change-Id: I92ab2ae0917857b6b1154f6250e7fac6565a58f1
2022-07-25 16:21:49 +00:00
Winson Chung
a44c6b53c0 Quick change to unblock launching freeform from overview
- Finish the recents animation before starting the freeform task
- Remove MultiWindowFactory abstraction now that freeform is the only
  implementation that uses that

Bug: 239429564
Test: Enable freeform in developer options, launch task into freeform
      from overview

Change-Id: I48069aee322f6a275d2cdae5345b196f8d682bac
Signed-off-by: Winson Chung <winsonc@google.com>
2022-07-23 05:29:14 +00:00
Jeremy Sim
3430f7ade1 Merge "Remove unused TaskOutlineProvider from TaskView class" into tm-qpr-dev 2022-07-22 18:20:44 +00:00
Pat Manning
d5e7ad4ae9 Set overview progress on fling to 1 only if going to overview state.
Test: manual
Bug: 202826469
Change-Id: I328577653d26c74de7d82149b2a393674a09561a
2022-07-22 15:35:59 +01:00
Jeremy Sim
e5ba8fa7a5 Update animations for TM-QPR: OverviewSplitSelect > Home transition
The animation from OverviewSplitSelect to Home is now updated to the latest spec. See bug for details.
- New timings
- FloatingTaskView now translates out, instead of fading
- FloatingTaskView and SplitInstructionsView now disappear concurrently with the rest of Overview, instead of afterward

Fixes: 236761067
Test: Manual on tablet and phone
Change-Id: Iaa1c804a60859232f331950098b67968cc187e82
2022-07-21 20:46:43 -07:00
Tony Wickham
355b66d1ab Hide the task icon during quick switch from home
Test: manual
Fixes: 238753582
Change-Id: Ic1badf4479c5273fd4d182ef7da04797885a6a36
2022-07-20 15:29:24 -07:00
Ming-Shin Lu
4a48cf7827 Remove hideCurrentInputMethod from RecentsAnimationController
Since CL[1] migrate hide IME logic when quick switching split-screen
task to InputMonitor.

As a result, remove unused API since it would be no longer to
expose hideCurrentInputMethod for launcher to handle gesture.

[1]: Ibfcd48e623336c4690b71c4db0ce1ad8f5b26fc9

Bug: 166736352
Bug: 193990612

Test: manual test as steps
1) launch any apps with focusing an editor
2) from overview, select any app to enter split-screen mode
3) taping the editor to show the keyboard
4) swipe up to overview or quick switch app tasks
5) expect the keyboard will be hidden when starting the gesture.

Change-Id: I76b93af015db098e836795f72f31b663238d9a47
2022-07-20 00:15:53 +00:00
Jeremy Sim
e174143358 Merge "Fix small bug with Overview action button placement" into tm-qpr-dev 2022-07-19 23:29:32 +00:00
Jeremy Sim
90d29d2837 Remove unused TaskOutlineProvider from TaskView class
This change removes the custom TaskOutlineProvider class defined in TaskView. It appears to be serving no purpose currently, and is causing an issue with shadows on split tiles.

Fixes: 208650434
Test: Deployed change on local device. Observed no more shadows on split tiles, and all corners and outlines still seem to be functioning correctly.
Change-Id: I7e56401ccabcd19e598726cca5cf721a22c0d982
2022-07-19 16:20:41 -07:00
Tracy Zhou
3e64f94387 Merge "Add splitFromOverviewForTablet test" into tm-qpr-dev 2022-07-19 19:06:47 +00:00
Schneider Victor-tulias
3f6c473164 Fade out the taskbar icons when animating to overview in 3 button nav.
Bug: 231213105
Test: from home, opened recents, then went back home, then went back to recents, resumed an app, then went back to recents and resumed the same app (both in 3-button and gesture nav)

Change-Id: I83b1b33cafb95353f36a126b93fcaf3b536d3bf4
2022-07-19 11:35:37 -07:00
Pat Manning
01a7bcc665 Merge "Move BaseActivityInterface task size methods to DeviceProfile." into tm-qpr-dev 2022-07-19 10:31:51 +00:00
Tracy Zhou
86a844c976 Add splitFromOverviewForTablet test
Design doc: go/split_tapl

Bug: 238553914
Test: run this test

Change-Id: Ibb385d852f73dee10470d14c4962cf482740105d
2022-07-19 01:57:35 +00:00
Jeremy Sim
d97cf8ad6e Fix small bug with Overview action button placement
Overview actions will now be centered properly when 3-button nav is active on tablets in landscape.

On most tablet and foldable screens, we shift the Overview action buttons left to accommodate when 3-button nav is active. The only exception is large-screen tablets in landscape orientation, where there is enough room to center them. This patch adds a conditional for that case.

Fixes: 239247432
Test: Manual
Change-Id: I96f9d5e428273b0611463a1f0f5898910eefe5ce
2022-07-18 23:22:21 +00:00
Pat Manning
4e73e5e352 Move BaseActivityInterface task size methods to DeviceProfile.
Fix: 238593212
Test: DeviceProfilePhoneTest.kt
Test: DeviceProfileVerticalBarTest.kt
Test: DeviceProfilePhone3ButtonTest.kt
Test: DeviceProfileVerticalBar3ButtonTest.kt
Test: DeviceProfileTabletLandscapeTest.kt
Test: DeviceProfileTabletPortraitTest.kt
Test: DeviceProfileTabletLandscape3ButtonTest.kt
Test: DeviceProfileTabletPortrait3ButtonTest.kt
Test: DeviceProfileTwoPanelLandscapeTest.kt
Test: DeviceProfileTwoPanelPortraitTest.kt
Test: DeviceProfileTwoPanelLandscape3ButtonTest.kt
Test: DeviceProfileTwoPanelPortrait3ButtonTest.kt
Change-Id: I30324d34ca119a467f530b590949743c2ba7b91a
2022-07-18 16:35:02 +01:00
Pat Manning
351aadc4f5 Merge "Add missing overview progress calls, track grid progress for thumbnail splash." into tm-qpr-dev 2022-07-16 19:38:59 +00:00
Winson Chung
6c057718ac Merge "Replacing deprecated method" into tm-qpr-dev 2022-07-15 20:47:22 +00:00
Pat Manning
d61ccbb7ed Add missing overview progress calls, track grid progress for thumbnail splash.
Test: manual
Bug: 202826469
Change-Id: I29578f44fd87423437ad6c73dc2be1ad630a55d6
2022-07-15 16:41:56 +01:00
Tony Wickham
2765792793 Merge "Provide 0 insets to VoiceInteractionWindow in gesture nav" into tm-qpr-dev 2022-07-14 22:17:09 +00:00
Winson Chung
4c05fa3fba Replacing deprecated method
Bug: 219861883
Test: Builds
Change-Id: I8e008c042cb7fe74ced512b6a074892743ef25f8
2022-07-14 18:51:18 +00:00
Tony Wickham
8b3fda7eb8 Merge "Fix constant crash when setting MultiStateCallback.DEBUG_STATES=true" into tm-qpr-dev 2022-07-13 17:45:26 +00:00
Tony Wickham
fd170e25cb Provide 0 insets to VoiceInteractionWindow in gesture nav
Test: Invoke assistant on tablet on both geture nav and 3 button mode;
In gesture nav mode: assistant shows at the very bottom of the screen,
layered on top of the taskbar background (in z order)
In 3 button mode: assistant shows right above the taskbar, which only
shows the 3 buttons (no taskbar icons) while assistant is showing
Fixes: 225200928

Change-Id: I2fbc05e696b58e8801e704092aa2741cb57c05c4
2022-07-13 10:33:12 -07:00