- Call setTaskIconVisible(true) at the end of the gesture regardless of `setCurrentTask`.
- Resets the icon visibility when RecentsView resets to make sure the bad state won't get stuck.
Fix: 332744660
Flag: EXEMPT bug fix
Test: Manual test on device
Change-Id: Ie8b86efa4892298f0071ad304a8c77698c306d6a
Crash happened because the split config taskId couldn't be found in the
list of remote targets, however I can't reproduce this, so adding
additional logging in case it happens again
Fix: 411897545
Flag: EXEMPT. Bugfix
Test: N/A. Logs
Change-Id: Id6ad6f5dc94aa904e1ea89f3ec59cdcd4114ec73
Previously we updated many other things, such as the buttons and RV
decorators, but the latest UX guidance is to use the same colors
when blurs are enabled or disabled, other than the panel color.
Note: When Overview blur is enabled, the activity is recreated and
this change is redundant. So this is only done if that flag is off.
Demo with home and taskbar all apps (toggling blur with adb):
https://drive.google.com/file/d/1HzveExKpAERxMVdu7JXQSYeGRwaBNR4_/view?usp=sharing&resourcekey=0-l-dGWOS6aCQjj2KStvwySA
Fix: 413229346
Flag: com.android.launcher3.all_apps_blur
Test: Manual with battery saver and `adb shell wm disable-blur 1` / 0
Change-Id: I55c9b46f0999c574c29a6ac7ae557b1e30d91d15
This change adapts the "Done" button in the gesture navigation tutorial
according to new UX specs. Specifically, the button is wider and may
have a different font according to theme.
Fix: 416144733
Test: Run the gesture navigation tutorial and observe the done button
Flag: EXEMPT bugfix
Change-Id: I4732a21c76e5a0e95433a211cd747cb36aaeaa4d
- Using setFloat instead of setViewAlpha for animation. The difference between setViewAlpha
and setFloat is that the latter will flip the view visibility as a short circuit of its
implementation. Moving to setFloat ensures that we only mutate the alpha values themselves.
Bug: 414949943
Flag: EXEMPT Bug fix
Tested: Manually, simulated
Change-Id: Id0152ac4780568dd31224df8dcea5c7ad9d309d8
Updated icon and text font as well as scrim values to make the text and
icon visible in both themes and different wallpapers.
Fix: 408437743
Test: Go to overview in empty state(no tasks)
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic76d25f4a70bffa402950fc4c3c3fade32c66c2b
Fix: 413764920
Flag: EXEMPT. Bugfix
Test: Manual. Open recents, tap menu, "Close" should now be "Clear"
Change-Id: Ic727ae7dedf23af65a382e0c7bfe455653865819
- Add a blur layer to the Scaling Workspace Reveal to have a smooth
blur transition during animation
- As part of this, disable blur from DepthController (but still
use it for depth to match workspace scale)
- This mirrors the approach in LauncherBackAnimationController
- Use a snappier interpolator for the blur portion (666ms, emphasized)
- Reduce the alpha of floating view during animation, to reduce the
blur effect during the morph
- Increase the cross fade duration of the App Widget to App reveal
Demo video with various widgets and apps:
https://drive.google.com/file/d/1fYJc-TPAEltqParM957NMYbRe2Gn5OgJ/view?usp=sharing&resourcekey=0-AGiL7sqLNXDcNsY-qOzzYQ
Note: this is sort of a different approach to ag/33537973 without the
underlying refactor necessary.
Bug: 417269110
Test: Manual (see video)
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I2bb6c0114d42af7ed802fbcae03655befe19aa7e
* changes:
[5/5] Removed unused IPC call.
[4/5] Cover DragToBubbleController with tests.
[3/5] Implement DragToBubbleController.
[2/5] Hook up DragToBubbleController and prepare launcher to use it.
[1/5] Added DragToBubbleController
Flag: EXEMPT code cleanup
Bug: 416536400
Test: TaskAnimationManagerTest; ran test with and without change
Change-Id: I8bdee3adeeca07e386f3058910d5e2160359f7e9
Removed an IPC call to the shell that was introduced to display the
expanded view drop target.
Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: DragToBubbleControllerTest
Change-Id: Ief762d29051d9fe32dc3956903146655509162f6
Implement tests that check DragToBubbleController public API
Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: DragToBubbleController.kt
Change-Id: I48fe5f45921fbedbe0f1921dfd21e9ecb14406bc
- Adds a SpringSet to track all running springs.
- Rearranges the code into blocks: end runnable, reflow, dismiss, neighbor bounce, etc.
- Renames all instances of draggedTaskView to dismissedTaskView for consistency
- To stop blocking touch earlier, run grid end translation without waiting for the neighbor bouncing to finish.
- Update TAPL split screen launching logic to wait for dismiss animation to end.
Fix: 415327465
Test: TaplTestsQuickstep.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I59ade102e35e3528971907e898dac9555c6de796
Implement DragToBubbleController internal logic that utilises
DropTargetManager to show drop targets for the bubble bar drop zones.
Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Go to overview screen and drag app icons from the taskbar
over the bubble bar
Change-Id: I844151c5e11f237c475d8a26a7784c5662dad658
Updated DragController logic to set touch event XY coordinates if there
is no view returned by the DropTarget. Added wait call for all drop
targets views removed to the
TaskbarActivityContext#onDragEndOrViewRemoved() method.
Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: build launcher
Change-Id: Ie97b08f22ae8dc34bd9f4e3738704e4fc90345bb
The expanded view was misplaced due to a race condition. This occurred
because the BubbleBarController.onBubbleBarBoundsChanged() method was
invoked while
LauncherTaskbarUIController.onTaskbarInAppDisplayProgressUpdate() was in
progress (e.g. inAppDisplayOverrideProgress value was slightly higher
than 0). The latter method is also used to shift the three navigation
buttons for IME open/collapse events.
This concurrent execution led to an incorrect bubbleBarTranslationY
value being used in the BubbleBarView.getTopToScreenBottom() method,
ultimately causing the misplacement of the expanded view.
Fixes: 416158567
Flag: EXEMPT bugfix
Test: Manual.
- Long Press Chrome icon select "bubble" adds
- Press search bar inside Chrome app bubble to show IME
- Hide IME
- Press Chrome bubble
- Press search bar inside Chrome app bubble to show IME
- Hide IME
Change-Id: I44431f0eb47c3e9e0bea0274624e5b1db0aa15c9
See attached bug, we don't have good transition between lockscreen and
picker, so, we decided to dismiss it, given that this CUJ is less
common.
Additionally,
1. switch over to dagger dependencies instead of LauncherAppState
2. Remove unused flags for show_wallpaper / show_when_unlocked
Bug: 405068076
Flag: EXEMPT BUGFIX
Test: Manual (see demo in comments)
Change-Id: I8d0d5ebdbcca806e7fa24c57f80f1cad518bd035
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles
Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate
Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix
Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
I think this animation was broken, and my previous CL accidentally
fixed it, so that blur was actually applied during app launch. This
caused some app launch performance regressions, so we will at least
disable it whenever the All Apps blur flag is enabled.
Test: presubmit, forrest
Bug: 416476673
Flag: com.android.launcher3.all_apps_blur
Change-Id: I4c7001dc84f67dbef02fbc255613b94347df91b8
