Commit Graph

216 Commits

Author SHA1 Message Date
Sunny Goyal
e978f6cedb Converting some caching logic booleans to lookup flags
Bug: 366237794
Test: atest IconCacheTest
Flag: EXEMPT refactor

Change-Id: I0d25996181954df22e1cb61596be0a2694ee7068
2024-10-01 17:59:48 +00:00
Sunny Goyal
f7c32a29fd Requesting ApplicationInfo in cached object
Bug: 363324203
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I92f3d3ed8c267b895dc439ba1f01eb67d7f63965
2024-09-27 14:04:16 -07:00
Archisha Baranwal
10467a8cf3 Merge "Adding programmatic provision of WRITE_SECURE_SETTINGS permission to Launcher3Tests." into main 2024-09-27 08:35:45 +00:00
Archisha Baranwal
0d11c4a7ef Adding programmatic provision of WRITE_SECURE_SETTINGS permission to
Launcher3Tests.

Bug: 361222449
Test: atest Launcher3Tests
Flag: EXEMPT test fixes

Change-Id: I4226c4c50047d71a99944fc4e5d70080d134c3d3
2024-09-27 05:53:59 +00:00
Charlie Anderson
24061ff74f Merge "Update test activities with a non-default icon." into main 2024-09-26 19:16:41 +00:00
Charlie Anderson
65c1010029 Update test activities with a non-default icon.
Check against default app icon in FolderIconLoadTest

Bug: 357441807
Bug: 369222239
Bug: 369240511
Flag: EXEMPT bc-triaged bugfix
Test: FolderIconLoadTest
Change-Id: I0e224f5b8bf8c0a8c51d88abd7c562d8e1ff7a55
2024-09-26 03:59:10 +00:00
Sunny Goyal
37182de670 Fixing flakiness in robo tests
Bug: 352288591
Flag: EXEMPT test fix
Test: Presubmit
Change-Id: I15dd91815f7ae4d3cf3c9e1fd4c2b5e07052ab3f
2024-09-25 10:52:14 -07:00
Sunny Goyal
e1b7ca566e Merge "Moving various application into related methods to a separate class" into main 2024-09-24 22:05:52 +00:00
Randy Pfohl
31aefc3290 Merge changes from topic "windowRecents" into main
* changes:
  Cleaning up unusued handlers
  Moving RecentsWindowManager away from the singleton pattern
  Limited recents in window introductory cl
  abstracting fallback views to support container instead of activity
2024-09-24 16:13:30 +00:00
Sunny Goyal
28d6bbd6b4 Moving various application into related methods to a separate class
> This avoids duplicate RPCs when trying to get multiple properties
  from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
  logic in IconCache

Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
2024-09-23 22:09:24 -07:00
Sunny Goyal
f84b6edee7 Merge "Removing unnecessary package validation during grid migration" into main 2024-09-24 00:31:54 +00:00
Sunny Goyal
c3dd1c380f Removing unnecessary package validation during grid migration
package validation happens during loader anyway. And using MATCH_INSTALLED
for checking cross user apps may not work all the time

Bug: 363324203
Test: atest GridSizeMigrationUtilTest
Flag: EXEMPT bug fix
Change-Id: Id36e8fdff132242705ef53c85dc6567fbde5d952
2024-09-23 15:16:37 -07:00
Jagrut Desai
94c9fb7cf5 Refctor DisplayController#handleInfoChange
Test: Presubmit
Bug: 369140181
Flag: EXEMPT refactor DisplayController#handleInfoChange
Change-Id: I196fe0e843a60c518d882c25f9fbdcd3cb775ba6
2024-09-23 09:58:30 -07:00
randypfohl
c50aa8bf31 Limited recents in window introductory cl
Test: Built and tested locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: I5352ba0b6c5bc196fbd1322d435a7e27e884f7b5
2024-09-20 16:09:50 -07:00
Treehugger Robot
f0123c9129 Merge "Reset taskbarModePreference on tearDown()" into main 2024-09-20 16:10:26 +00:00
Sunny Goyal
621918feda Changing min-sdk version of Launcher to 31
Bug: 368071216
Flag: EXEMPT refactor -> dead code removal
Test: Presubmit
Change-Id: I1f0113c56de56f12f3a174eb31c3f8e8a09407e6
2024-09-20 06:00:10 +00:00
Toshiki Kikuchi
5cec59a41d Reset taskbarModePreference on tearDown()
This CL forcefully resets taskbarModePreference on tearDown() to ensure
the following tests are not affected by the changes made by
`testTaskbarPinningChangeInLockedTaskbarChange`.

Bug: 368322666
Flag: EXEMPT bug fix
Test: nexus_unit_test_multi_device_platform
Change-Id: I8bd8e8ca8b4b832ed17e86fbdfc9bda7bf9ab16e
2024-09-20 00:47:18 +00:00
Toshiki Kikuchi
6ddfe9b179 Allow to show pinned taskbar when Launcher is visible
This CL allows freeform-first devices to lock the taskbar in a pinned
state when Launcher is visible.

Bug: 361419732
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: DisplayControllerTest
Test: manual

Change-Id: Ic0d2740e33fee19c676d88aa2bcf370eb64366e8
2024-09-18 10:49:52 +00:00
Kevin Lim
f1b5855af7 [Testing] Renamed incorrectly named FloatingHeaderViewTest
FloatingHeaderviewTest was named with ...Tests (plural), preventing it from
being excluded from launcher-testing-helpers-robo and getting included
in some unintended tests.

Bug: b/341795751
Flag: EXEMPT test renaming.
Test: Running FloatingHeaderViewTest
Change-Id: I8149f0a5548e77674bb2a23a34bd7671e0a3b371
2024-09-12 20:57:14 +00:00
Treehugger Robot
c912c8fb8b Merge "Improving regex for detecting a local platform build" into main 2024-09-11 19:48:47 +00:00
Vadim Tryshev
460192588f Improving regex for detecting a local platform build
Platform build can now have versions line "eng.himans"

Bug: 187761685
Test: online regex verifier
Flag: NONE test change
Change-Id: I86b9324dfbbc36272215eae58af836e9a3741d70
2024-09-11 10:39:31 -07:00
Sunny Goyal
7a548377eb Remove obsolete features
Flag: EXEMPT legacy ENABLE_TWOLINE_DEVICESEARCH, ENABLE_ICON_IN_TEXT_HEADER, ENABLE_PREMIUM_HAPTICS_ALL_APPS
Bug: 270396358
Bug: 201388851
Bug: 270395143
Test: Verified manually
Change-Id: I88ca7b255d2ae4eba393c1aee52153ef0a459140
2024-08-30 13:04:08 -07:00
Sebastián Franco
6edce2ad75 Merge "Remove test to postsubmit while they are flaky" into main 2024-08-22 17:08:45 +00:00
Treehugger Robot
7369348ba8 Merge "Delete dead test SettingsActivityTest" into main 2024-08-22 10:01:55 +00:00
Alex Chau
eececf272e Merge "Reset mTopRowIdSet in applyLoadPlan" into main 2024-08-22 09:49:27 +00:00
Sebastian Franco
f989210f5b Remove test to postsubmit while they are flaky
Bug: 332527963
Test: ReorderAlgorithmUnitTest
Flag: TEST_ONLY
Change-Id: I29d631ba7dfe7f2c3a5323bfb414cb4da5b3321b
2024-08-21 15:20:18 -07:00
Alex Chau
9109b81a95 Reset mTopRowIdSet in applyLoadPlan
- All taskViewIds become obsolete after removing and re-adding, so we'll need to reset mTopRowIdSet when removing all taskViews
- OverviewActionsView.updateActionButtonsVisibility can be called before updateDimension (where mDp is set), so a null check is necessary
- Fixed TestStaibilityRule failing when running FallbackRecentsTest alone. FallbackRecentsTest runs with 3P Launcher, in that case launcherPackageName is our test activity, and launcherVersion can be null. This can only occur in a local run, thus return LOCAL in this case.

Fix: 355042336
Test: FallbackRecentsTest and manually testing dismiss
Flag: EXEMPT BUG_FIX
Change-Id: I9125ea38a567deb0d3028e7d7407397d1dc06ade
2024-08-21 12:37:14 +01:00
Uwais Ashraf
06ffcf8c61 Merge "Migrate model tests to multivalent" into main 2024-08-21 10:05:40 +00:00
Sihua Ma
58e8573085 Migrate model tests to multivalent
Also migrating some other tests that have been verified

Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I072201b8e7b98945ca88657fe813fef4727f16e4
2024-08-20 07:28:35 +00:00
Shamali Patwa
accd0f68c8 Merge "Update the scale on corner radii on scaled image drawable." into main 2024-08-16 20:37:57 +00:00
Treehugger Robot
a21058eb88 Merge "Move TouchEventGenerator to multivalent" into main 2024-08-16 06:04:22 +00:00
Shamali P
c7e1b5c975 Update the scale on corner radii on scaled image drawable.
The RoundedDrawableWrapper applies rounded corners on each draw, so,
on scaling, the corners look odd for small widgets.

This change, applies the same scale to corner radius as well.
There are some widgets whose preview images have embedded transparency,
but we don't do much for such previews.

Bug: 359860747
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I5e58e29765503454f286d99050b13b497531d306
2024-08-15 02:54:17 +00:00
Andrew Cole
d61fbd4140 IconCacheUpdateHandlerTest
This is the unit testing for the updates to IconCacheUpdateHandler

Bug: 357725795
Test: SELF
Flag: TEST_ONLY
Change-Id: I159f5ef70fcc9a5aae7bb319f06a3ff935f28246
2024-08-14 15:57:42 -07:00
Sihua Ma
97ed80634d Move TouchEventGenerator to multivalent
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I6603b4764de6708cb0c3d7c2a52c0ffb81607771
2024-08-14 21:17:44 +00:00
Uwais Ashraf
d39bc803c7 Merge "Improve performance of thumbnail retrieval - hot taskData flow" into main 2024-08-13 10:59:32 +00:00
Uwais Ashraf
60b62d734d Improve performance of thumbnail retrieval - hot taskData flow
Bug: 357542209
Test: TasksRepositoryTest, manual with reduced speed video
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie94daf61d8e41c4b9c12d67f5f45166104879325
2024-08-12 16:49:24 +00:00
Fengjiang Li
6554ab99e3 Revert AllAppsRecyclerViewPoolTest.kt
Manual revert of ag/28323761, will add it back after confirming preformance test regression has been resolved.

Fix: 354560500
Test: Revert of test
Flag: NONE
Change-Id: Ibc9ec7a641c7df80ac5a7f08933dadfdf0b8d1e6
2024-08-09 13:06:52 -07:00
My Name
b7b872e7a7 Delete dead test SettingsActivityTest
Settings activity tests are UI heavy, so unlikely anyone would fix this
such that they are not flaky.

These tests are @Ignored for long time (> 1 year).

Bug: 199309785
Test: presubmit
Flag: NONE not a change in production code
Change-Id: I8c9e167469266af624ae345e8eaac8bb92e8cd69
2024-08-08 23:47:05 +00:00
Sebastián Franco
99a76f1f64 Merge "Convert testing classest to Kotlin" into main 2024-08-06 00:21:18 +00:00
Fengjiang Li
77be7410c3 Merge "Fix jank regression from AllAppsRecyclerViewPoolTest" into main 2024-08-05 23:17:22 +00:00
Fengjiang Li
ce638d69b7 Fix jank regression from AllAppsRecyclerViewPoolTest
Unit test ag/28323761 delays the preInflationCount check after creating ActivityContext on main thread, thus causing jank regression. This CL is a forward fix.

Fix: 354560500
Flag: NONE - jank fix
Test: Presubmit
Change-Id: I0e91dd765f1805b98895ce90804ec187e50285b4
2024-08-05 09:39:05 -07:00
Charlie Anderson
6b8e362247 Adds new bugfix flag for using new app archiving icon
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Bug: 350758155
Test: locally
Change-Id: I7bacbacd85a8216e7975665e6d3c1ab98ed23235
2024-08-05 00:37:28 -04:00
Charlie Anderson
e5ace06d81 Merge "Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-08-05 04:24:32 +00:00
Sebastian Franco
ce4446c469 Convert testing classest to Kotlin
Bug: 324261526
Test: ImageTest
Test: FolderTest
Test: IntegrationReorderWidgets
Flag: TEST_ONLY
Change-Id: Ieb4e451cc44656fc98d87163203eaae379ec0512
2024-08-02 12:53:14 -07:00
Charlie Anderson
fe23e711fd Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 00fb1adab4.
Also fixes test applyIconAndLabel_setsImageSpan_whenInactiveArchivedApp.

Bug: 350758155
Fixes: 356166053
Test: unit test
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I93f2ac47dc3a8fa81d59e0f089385d2b3fe93306
2024-08-02 17:26:02 +00:00
Shamali Patwa
b74b05336c Merge "Fix the getWidgetsByPackageItem method to return a copy" into main 2024-08-01 21:59:28 +00:00
Sihua Ma
7eaf24840d Merge "Add unit test for LauncherAppWidgetHost" into main 2024-08-01 20:26:40 +00:00
Shamali P
74862f990b Fix the getWidgetsByPackageItem method to return a copy
Bug: 356545910
Fix: 356545910
Test: Unit test
Flag: EXEMPT BUGFIX
Change-Id: I90429983733eb5f2bb2d6df00799d2445eaeea31
2024-08-01 18:56:41 +00:00
Treehugger Robot
01a1169d57 Merge "Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-07-31 16:47:15 +00:00
Charlie Anderson
00fb1adab4 Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 114e84908f.

Reason for revert: b/356166053

Change-Id: I30dfbc5da1caecd89b4b23aafe4de8e9efede6a0
2024-07-31 14:08:16 +00:00