Commit Graph

20826 Commits

Author SHA1 Message Date
Treehugger Robot
a8f25d26ad Merge "[Launcher Memory Leak] Avoid leaking Folder/FolderIcon when removing FolderIcon from TaskbarView" into main 2024-11-26 20:37:21 +00:00
Uwais Ashraf
322b831d1d Merge "Make RV focusable when empty to read out content desc for TalkBack." into main 2024-11-26 15:25:25 +00:00
Uwais Ashraf
6c85912736 Make RV focusable when empty to read out content desc for TalkBack.
Fix: 379638096
Flag: EXEMPT BUG_FIX
Test: Manual - go to overview with and without tasks. Check TalkBack.
Change-Id: I1f3faace530ed3c9b0384b94dbc163f5b8c15dda
2024-11-26 11:42:42 +00:00
Chaitanya Cheemala (xWF)
1743fd9e77 Merge "Revert "Use the Coreographer's frame time for a more reliable ti..."" into main 2024-11-26 11:37:15 +00:00
Chaitanya Cheemala (xWF)
9155cf9066 Revert "Use the Coreographer's frame time for a more reliable ti..."
Revert submission 30509816-raf-timing

Reason for revert: Likely culprit for b/381006945  - verified through ABTD before revert submission as part of standard investigation process.

Reverted changes: /q/submissionid:30509816-raf-timing

Change-Id: Iaed968120be662df8d915bac61e7cfa5b936f35c
2024-11-26 11:35:00 +00:00
Alex Chau
1d720793fa Merge "Add TaskOverlay children for accessibility" into main 2024-11-26 10:49:34 +00:00
Treehugger Robot
cff3ade324 Merge "Remove padding from All Apps and Divider views for transient taskbar." into main 2024-11-26 04:02:56 +00:00
Treehugger Robot
f612dc1a5b Merge "Fix taskbar visibility when default-to-desktop" into main 2024-11-25 23:18:43 +00:00
Fengjiang Li
3daaad8498 [Launcher Memory Leak] Avoid leaking Folder/FolderIcon when removing FolderIcon from TaskbarView
Fix: 380868830
Flag: NONE - released code
Test: Presubmit
Change-Id: I57c179384df06015a7e95a173c399cfcda236e46
2024-11-25 11:30:53 -08:00
Alex Chau
0aee46e098 Add TaskOverlay children for accessibility
- ag/28947579 add a speicifc order for children of TaskView to be added for accessibility. All TaskView children will need to added through TaskContainer.addChildForAccessibility

Fix: 379802031
Fix: 380016834
Fix: 204280593
Test: Go to Select mode, ensures Talkback can cycle through text selection boxes
Flag: EXEMPT BUG_FIX
Change-Id: Id7991a8b3e76fe47f562e338e9967c8e85fa4908
2024-11-25 19:04:46 +00:00
Bill Yi
1cfdd3a833 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-25 18:54:47 +00:00
Saumya Prakash
43ecc1d0a1 Merge "Fix Taskbar not auto stashing from multi instance menu" into main 2024-11-25 18:34:35 +00:00
Jon Miranda
f86e0e4b88 Remove padding from All Apps and Divider views for transient taskbar.
(Initial CL removed padding always) I0f9cce376d47918e69a65ed288f10143930ee3be

Bug: 375661139
Test: confirmed with design team
Flag: EXEMPT bugfix
Change-Id: I467d0a5ae3ab48ebebc5a05f7a0902ddd01f8084
2024-11-25 18:16:26 +00:00
Schneider Victor-tulias
54e50f43a6 Merge "Start the home intent when swiping from home to home" into main 2024-11-25 17:53:27 +00:00
Luca Zuccarini
fb2525a850 Merge "Use the Coreographer's frame time for a more reliable timestamp." into main 2024-11-25 16:19:35 +00:00
Schneider Victor-Tulias
ccd08f4667 Start the home intent when swiping from home to home
This allows us to clean up the home screen properly (close all apps and floating views)

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 380049465
Fixes: 380049942
Test: TAPL tests
Test: swipe home from home all apps, with and without an open popup menu, with and without a 3P launcher
Change-Id: I3c3c8e832329afc3ffaa1de7cf646be79d84e9a3
2024-11-25 10:56:54 -05:00
Johannes Gallmann
0b0452eda9 Merge "Cancel predictive back when sliding off back button" into main 2024-11-25 08:17:56 +00:00
Johannes Gallmann
4af733d65f Merge "Only register Launcher back-callback when ROLE_HOME is held." into main 2024-11-25 08:13:05 +00:00
Dan Brunwasser
7005aff0dc Merge "Fix home gesture animation for 3rd party launchers." into main 2024-11-23 01:06:42 +00:00
Treehugger Robot
ba13bc11c6 Merge "[CD Taskbar] Refactor TaskbarManager to store TaskbarRootLayouts in a map" into main 2024-11-23 00:38:44 +00:00
Sukesh Ram
7516dd06d5 [CD Taskbar] Refactor TaskbarManager to store TaskbarRootLayouts in a map
Refactor the TaskbarManager's existing usages of TaskbarRootLayouts to use a map, so that there can be a 1:1 relationship between TaskbarRootLayouts and TaskbarActivityContexts.

Flag: EXEMPT not adding new behavior
Bug: 380351840
Test: Manual
Change-Id: Ib4379a9b6d50b8bdd64b70d7b15ce798ebb42731
2024-11-22 14:30:49 -08:00
Winson Chung
bf84fe574e Merge "Update OHM regions whenever other regions change" into main 2024-11-22 21:23:21 +00:00
Dan Brunwasser
e026b261b3 Fix home gesture animation for 3rd party launchers.
Previously home animations for 3rd party launchers were being cancelled by the recently added onFinishComplete call in AbsSwipeUpHandler.onTasksAppeared. This was because FallbackSwipeHandler.handleTasksAppeared was returning false even though mActiveAnimationFactory.handleHomeTaskAppeared was true. However, only fixing this so it returned true instead would allow AbsSwipeUpHandler.onTasksAppeared to continue to the following conditions which would fail, so this change also converts FallbackSwipeHandler.handleTasksAppeared to override onTasksAppeared instead. This allows home tasks to be handled first and skip splash screen handling since it is not needed.

Flag: NONE bug fix for recently introduced issue
Fixes: 362900007
Test: set 3rd party launcher as default and use home navigation gesture
Change-Id: I88015bd3bdbad94bd4897411714ff3f52a782499
2024-11-22 13:00:33 -08:00
Saumya Prakash
0028bed674 Fix Taskbar not auto stashing from multi instance menu
This change addresses an issue where touching the bottom of the screen would result in the dismissal of the multi instance menu, but leave the taskbar in a state that it would not auto stash. This is because the view was being removed through another way leading to taskbar being in a bad state. Now when the view is removed, the taskbar is correctly reset.

Fix: 380304394
Bug: 315989246
Test: Manually launch the menu then tap the bottom of the screen. Ensure that taskbar eventually auto stashes.
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: Ie6bae803a42cf0bcd0ff6362473a63cb22a841eb
2024-11-22 20:50:46 +00:00
Brian Isganitis
39837267eb Merge changes Ie1523446,I0263f704 into main
* changes:
  Do not pre-add All Apps icon in phone mode.
  Fix LayoutTransition All Apps divider logic for RTL.
2024-11-22 20:14:37 +00:00
Matt Sziklay
5763a6d0b7 Merge "Move shared logic to new package." into main 2024-11-22 18:53:58 +00:00
Winson Chung
ce1a73829f Update OHM regions whenever other regions change
- Speculative fix, there are some scenarios where we update the swipe
  touch/assistant regions without updating the OHM regions

Bug: 362039326
Flag: EXEMPT bugfix
Test: Manual
Change-Id: If5c558623073e5185827ae17a162dacf322c74a4
2024-11-22 16:53:22 +00:00
Johannes Gallmann
0610c625e0 Only register Launcher back-callback when ROLE_HOME is held.
When using a 3P Launcher, i.e. when the ROLE_HOME is not held by QuickstepLauncher, there should be no back callback registered with SystemUI.

Bug: 374882166
Flag: EXEMPT bugfix
Test: Manual, i.e. verified back-callback registration updates in SystemUI and also verified that back-to-home navigations in Nova Launcher are responsive.
Change-Id: I03187f80a4c3c893a6529f0a22613f6fdfe7b7b3
2024-11-22 13:49:00 +00:00
Johannes Gallmann
b28ff34177 Cancel predictive back when sliding off back button
Bug: 373544911
Test: Manual, i.e. verified that sliding away from the back button (within the taskbar window) cancels the predictive back animation
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I9a1448c7005211c87a8979261b13fe37ab64a5b2
2024-11-22 13:09:56 +00:00
Alex Chau
ba8bfc97b0 Merge "Swipe up from excludeFromRecents task should be shown left of desktop tasks" into main 2024-11-22 11:59:12 +00:00
Uwais Ashraf
61cff8b686 Move fully visible task logic to more centralised method.
This means that overlay is initialised in all cases, not just some. Also uses pre-existing method for `isTaskViewFullyVisible()`

Fix: 376264918
Test: Manual checking of flows in bug.
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ia898a2a869b79fb120a162fa5a3fe7df0fbf9800
2024-11-22 10:59:33 +00:00
Bill Yi
b24914be8d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idfd8628134eef581c45e3c0582e1173653f5767f
2024-11-21 21:17:39 -08:00
Brian Isganitis
6c0cd2278d Do not pre-add All Apps icon in phone mode.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ie152344613cf982183c4bb72b8dde138f4f74e37
2024-11-21 23:38:00 +00:00
Brian Isganitis
f04ae6b09f Fix LayoutTransition All Apps divider logic for RTL.
We were checking the wrong index (off by one), leading to a crash if the divider is already in the Taskbar at the correct index. However, we do need to add it after the expected index if the divider isn't there, otherwise it will push the icon that is at that position to the right of the divider (it should be to the left).

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Bug: 368522274
Test: go/testedequals
Change-Id: I0263f704728286b53da5b45828784b20aaae31ce
2024-11-21 23:38:00 +00:00
Treehugger Robot
423c85a2eb Merge "Remove padding from All Apps and Divider views." into main 2024-11-21 22:07:40 +00:00
mattsziklay
17212c441c Move shared logic to new package.
Bug: 337917761
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I72c6fe4382fbe66de306a5d1d243f1145ccadbce
2024-11-21 21:31:05 +00:00
Treehugger Robot
b85a1fdf3d Merge "Do not scale canvas if scale is 1 for predicted app icon animation." into main 2024-11-21 21:23:23 +00:00
Andy Wickham
05958c0d85 Merge "Don't store SettingsCache within ContextualSearchStateManager." into main 2024-11-21 21:07:54 +00:00
Winson Chung
f86cdbdd3a Merge "Adjust visibility for legacy top task tracker tasks when home moves to front" into main 2024-11-21 20:10:10 +00:00
Winson Chung
9eb6ed8879 Adjust visibility for legacy top task tracker tasks when home moves to front
- To workaround the fact that TTT does not get full task visibility info,
  we can existing tasks as not-visible whenever the occluding home task
  is moved to front
- Fix an issue where task icons were not loading for running tasks
  due to us skipping updating for running tasks in the recents
  transition (we will continue to skip updating the thumbnail though)
- Also skip updating the same taskview multiple times if the task
  container has multiple tasks that need to be updated

Bug: 372067617
Bug: 280812109
Flag: EXEMPT bugfix
Test: atest TaskThumbnailViewModelTest,TasksRepositoryTest,RecentsViewModelTest
Test: atest TaplTestsQuickstep#testExcludeFromRecents
Change-Id: Ifa33cfe53d44e5fe7778aecd5434abf9c29b3170
2024-11-21 20:09:58 +00:00
Brian Isganitis
852dccdff2 Merge changes from topic "taskbar-layout-transition-prepare" into main
* changes:
  Prepare for LayoutTransition with RTL support.
  Split up hotseat and recents into two methods.
  Filter out unsupported items immediately when updating Taskbar.
2024-11-21 19:39:05 +00:00
Jon Miranda
8981377ac0 Do not scale canvas if scale is 1 for predicted app icon animation.
Was not able to repo the initial bug, but this change leaves the
original path unchanged.

Fixes: 374579710
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I91e0235571b0736dcbe70c7730d7c90ec949a13e
2024-11-21 11:22:48 -08:00
Sukesh Ram
d4fb56f36b Merge "[Taskbar CD] Refactor TaskbarManager for Multiple TaskbarActivityContexts" into main 2024-11-21 18:09:41 +00:00
Brian Isganitis
c87f691e04 Prepare for LayoutTransition with RTL support.
Only remove divider when it needs to be removed or moved between All Apps and recents locations. Keep All Apps and QSB in Taskbar at all times. LayoutTransition does not work if views are being removed and then immediately readded (what current code branch does).
Overflow is not supported yet with the LayoutTransition flag.

Test: go/tested-equals
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 368522274, 343521765
Change-Id: I9ae1d7c52e853106cdf86329be6f221213e7cb86
2024-11-21 12:24:13 -05:00
Brian Isganitis
199f860b70 Split up hotseat and recents into two methods.
To support RTL with recents, will need to support calling updateRecents before updateHotseatItems. Splitting into two methods makes this doable.

Test: go/testedequals
Flag: EXEMPT refactor
Bug: 343521765, 368522274
Change-Id: I8756ea23fff1606ef4ab9f72d18dd4b21f135b25
2024-11-21 12:24:13 -05:00
Brian Isganitis
1782af7b6e Filter out unsupported items immediately when updating Taskbar.
Fixes an issue where hotseatItems may not reflect the number of hotseat views in Taskbar. Entries in the array can be null (e.g. no predictions but there is space in the hotseat for them). If these are filtered out immediately, hotseatItems.length will correspond to the number of hotseat views.

Test: go/testedequals
Flag: EXEMPT bugfix
Fix: 379704910
Change-Id: I375d8152fccb6df5a9b783842ecf5dcedf6894c1
2024-11-21 12:24:11 -05:00
Jon Miranda
1d7ac8b8a7 Remove padding from All Apps and Divider views.
Bug: 375661139
Test: confirmed with design team
Flag: EXEMPT bugfix
Change-Id: I0f9cce376d47918e69a65ed288f10143930ee3be
2024-11-21 09:21:57 -08:00
Saumya Prakash
a2dea487dc Merge "Fix background of multi instance menu in taskbar" into main 2024-11-21 17:00:31 +00:00
Luca Zuccarini
ac2b0503b8 Use the Coreographer's frame time for a more reliable timestamp.
Bug: 323863002
Flag: com.android.systemui.shared.return_animation_framework_library
Flag: com.android.systemui.shared.return_animation_framework_long_lived
Test: manual
Change-Id: I213bae365e7a10e9151febb7365623b1dc44c86b
2024-11-21 15:22:08 +00:00
Liran Binyamin
a673a1b456 Merge "Deflake BubbleBarViewAnimatorTest" into main 2024-11-21 14:53:22 +00:00