Commit Graph

5508 Commits

Author SHA1 Message Date
Yunfan Chen
e3f7624ecb Adjust the insets frame providing method per API change
The frameworks side made a change to provide different insets frames for
different types of insets. Update the corresponding code to reflect that
change.

Test: build
Bug: 215411414
Change-Id: I57ecbb778fd0f0d3a19cc6712d747cad6664644b
2022-04-04 17:59:54 +09:00
Hongwei Wang
ca9f9ebec5 Merge "Hide the Taskbar when user leaves PiP mode" into tm-dev 2022-03-23 22:38:48 +00:00
Sebastián Franco
da297fb0f1 Merge "Revert "Combining the Thumbnail bitmap with the background to fix background spilling in the front."" into tm-dev 2022-03-23 20:01:42 +00:00
Tracy Zhou
f3d81b0a1c Merge "Fix thumbnail disappearing during staged split animation" into tm-dev 2022-03-23 16:06:37 +00:00
Vinit Nayak
aa2f879c55 Merge "Null out mRemoteTargetHandles when swiping to home" into tm-dev 2022-03-23 14:58:19 +00:00
Tracy Zhou
67bc75a8a9 Fix thumbnail disappearing during staged split animation
Previous set the thumbnail view to be visible initially. After deciding not to do so, forgot to put the visibility statement back. Also the transform matrix needs to reset before posting new scales.

Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/6576df3a-6d14-4b7e-8fb2-1c0a335472e4
Fixes: 194414938
Change-Id: I25fe39ea99943a3c1e2257681df3eb379bc30e51
2022-03-22 22:01:27 -07:00
Vinit Nayak
1d6058c2cd Null out mRemoteTargetHandles when swiping to home
* Also all null check when trying to show divider
after swipe down animation from overview

Fixes: 223946009
Test: Steps in bug no longer cause crash
Change-Id: I2c8484c37b863c4cb6aba7e274c1eb76bce92b4a
2022-03-22 20:47:54 -07:00
Hongwei Wang
808d568367 Hide the Taskbar when user leaves PiP mode
This is to prevent the Taskbar from flickering when the app settles in
full-screen mode.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/dIgvinb9yEB8MYfYDx0Ijy
Bug: 218450853
Test: see video
Change-Id: I9cfb0ca151dea6951561f78798bb16bafa48eba0
2022-03-22 18:45:31 -07:00
Tracy Zhou
53ad207008 Use topComponent to get package name
task.topActivity can be null

Fixes: 226232720
Test: manual
Change-Id: I7d0c928871d01402bf41bc96514aae7854045baf
2022-03-22 17:13:52 -07:00
Tracy Zhou
8d06bb8991 Merge "Update initial staged split UX." into tm-dev 2022-03-22 22:44:33 +00:00
TreeHugger Robot
6c7b0f7db8 Merge "Fix issue cauing the taskbar to show in the all set page of the SUW." into tm-dev 2022-03-22 20:25:32 +00:00
Hongwei Wang
1acabce45b Merge "Add auto-enter-pip support in FallbackSwipeHandler" into tm-dev 2022-03-22 20:07:55 +00:00
Schneider Victor-tulias
44aadeaef6 Fix issue cauing the taskbar to show in the all set page of the SUW.
Some missing state handling was causing the taskbar to show in the all set page of the SUW.

Fixes: 218507703
Test: build change, flashed and factory reset device
Change-Id: If3a280ef6416f0821cf6a9b1ab0a65d58c5c8221
2022-03-22 10:50:26 -07:00
Brian Isganitis
98214d072c Merge changes from topics "presubmit-am-08ca1fad1fe94bf3ace5a708c5584d55", "presubmit-am-3c6c58a0fa374b92b1a5f8d5f5788871", "presubmit-am-6939eac1469540108813bd4ed4c60a9b" into tm-dev
* changes:
  Have taskbar all apps extend ActivityAllAppsContainerView.
  Refactor ActivityAllAppsContainerView to depend on ActivityContext.
  Refactor allapps.search package to depend on ActivityContext.
2022-03-22 16:11:35 +00:00
Vinit Nayak
b85e0afe70 Merge "Keep live tile running when TaskMenuView is showing" into tm-dev 2022-03-22 04:48:43 +00:00
Tracy Zhou
4ff3615b23 Update initial staged split UX.
- Introduce inset to the staged split view
- Update width of the staged split view
- Introduce rounded corners to staged split view. It's tricky to animate it in with smooth transition considering the rounded corners. The best way to handle it is to draw content as if part of it is off the screen, so that when it's animated in, the rounded corners can slide in onto the screen correctly.

Fixes: 219085340
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/09a99b75-3614-4d20-b6d4-a78108f769d8

Change-Id: I24d90cc9e2695d822cb2de8b21e2d5519f2e344d
2022-03-21 21:21:42 -07:00
Vinit Nayak
a5addf0e89 Keep live tile running when TaskMenuView is showing
* Doesn't fix the bug, but a nicer UX to have

Bug: 223317893
Test: Live tile was running after tapping app icon.
Was able to enter split just fine

Change-Id: I50c5d5623546d19d216beae09b76c310e8b3c815
2022-03-21 18:15:28 -07:00
Jeremy Sim
c789ade45e Merge "Fix crash condition by adding a null check in DigitalWellBeingToast" into tm-dev 2022-03-22 00:39:47 +00:00
Jeremy Sim
7a84442436 Merge "Fix UI overlap when rotating in split select mode" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim
8746367f40 Merge "Fix paired icon placement in landscape/seascape" into tm-dev 2022-03-22 00:17:43 +00:00
Hongwei Wang
ad9c83966b Add auto-enter-pip support in FallbackSwipeHandler
- Deprecate HomeAnimationFactory#supportSwipePipToHome and treat 3rd
  party Launcher supporting auto-enter-pip transition as well
- Add a new FallbackPipToHomeAnimationFactory if auto-enter-pip
  transition is to be launched
- Make sure Launcher is resumed at the end of auto-enter-pip transition
  to actually trigger the PiP task appearing

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/hMPkRXy4vAjC6sQYUIIWUP
Bug: 220665901
Test: `m -j Launcher3` and verify the auto-enter-pip transition \
      see also the video
Change-Id: I6d16f2559d173f695ccbc743eb55e964bf088d04
2022-03-21 14:39:23 -07:00
Sebastián Franco
02458386cf Revert "Combining the Thumbnail bitmap with the background to fix background spilling in the front."
This reverts commit 5a9dce518e.

Reason for revert: The solution is inefficient. There is already a solution in ag/17060224

Change-Id: I5b5862f1ae426c78062c5a0f481abfb13b3060cc
2022-03-21 20:26:21 +00:00
Vinit Nayak
68d5dd82db Merge "Use ComponentCallbacks to recreate on fold/unfold" into tm-dev 2022-03-21 19:05:52 +00:00
Vinit Nayak
c55c94880e Merge "Limit the number of commands in OverviewCommandHelper" into tm-dev 2022-03-21 18:49:42 +00:00
Alex Chau
c9f3cc36bb Merge "Update overview grid icon sizes and paddings" into tm-dev 2022-03-21 17:08:31 +00:00
Jon Miranda
d17cb2722c Merge "Allow depth animation when user swipes back to home." into tm-dev 2022-03-21 15:33:08 +00:00
Kholoud Mohamed
ac0574781c Merge "RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3" into tm-dev 2022-03-19 06:30:09 +00:00
Jeremy Sim
b4b79142d8 Fix UI overlap when rotating in split select mode
Fixes an issue where you could trigger a UI overlap by rotating the phone during split select. The issue occurred because devices with insets were calling TaskView#resetViewTransforms during rotation, and not accounting for the fact that an extra transform was applied for split staging.

Fixes: 220998096
Test: Manual test on inset and non-inset devices
Change-Id: I2d6c969231127aa16c9eae39cf69e08ceb96c44b
(cherry picked from commit 51bfabf8b7)
2022-03-19 00:10:44 +00:00
Jeremy Sim
b42345273c Fix paired icon placement in landscape/seascape
In grouped task view, paired icons will now align better with task thumbnails.

Fixes: 218783211

Test: Extensive manual testing on local device(s).
Change-Id: I372d2ee90302a8d96ace048ff4f82126d9b2b363
(cherry picked from commit d6826c74a4)
2022-03-19 00:10:16 +00:00
Jeremy Sim
64212c5439 Fix crash condition by adding a null check in DigitalWellBeingToast
Fixes a crash condition where TaskView#getRecentsView() could return null when being called from DigitalWellBeingToast#setBanner(), resulting in a crash.

Fixes: 217671133

Test: Manual
Change-Id: I964384d97d26336e9a5e8e4c025f66ab78c63e0a
2022-03-18 16:55:17 -07:00
Brian Isganitis
d478f555cb Have taskbar all apps extend ActivityAllAppsContainerView.
This step is necessary to have taskbar support search in all apps.
Search is not ready yet, so a fallback search manager is included.

Test: Manual
Bug: 216683257
Change-Id: Id118388bc4baae4b63ef205295caf46cbd541bc8
2022-03-18 15:39:54 -07:00
TreeHugger Robot
f1543cb520 Merge "Small improvement for ag/17016891 (unstash taskbar input area size)" into tm-dev 2022-03-18 18:38:42 +00:00
Jon Miranda
f6780f66c3 Allow depth animation when user swipes back to home.
Bug: 221196062
Test: open app, swipe back to home, ensure blurs
Change-Id: I9faff4e41c2e8d22df72e41c7753e2090fa0973d
2022-03-18 09:58:55 -07:00
Vinit Nayak
38397e46cf Limit the number of commands in OverviewCommandHelper
* Rapidly tapping recents button in 3 button nav
puts launcher in a strange state.
Reproing and understanding that state is complex
since so many state transitions are rapidly happening.
* Easier to limit the number of commands a user
will perform for valid use-cases.

Fixes: 207680265
Test: Rapidly pressing recents when unfolded
doesn't show live tile task on workspace.

Change-Id: I7db849e83c2cafc37a419e189479283f2057bde6
2022-03-17 16:26:56 -07:00
Vinit Nayak
bacd5e1d21 Use ComponentCallbacks to recreate on fold/unfold
* DisplayController callbacks were sometimes being
called too soon and providing stale window bounds,
which led to the incorrect DeviceProfile being used.
Switched to ComponentCallbacks on the window to get
the most up-to-date callbacks.
* Sadly, for navigation mode changes, ComponentCallbacks
get fired too soon and have a stale navigation mode
so we continue to rely on DisplayController for that
change for now.

Fixes: 219958843
Test: Tested folding/unfolding, no taskbar appears when
it shouldn't.
Tested with changing display/font size as well as
nav mode changes

Change-Id: I1b398934c0ea49f69bad19b13977b7b0906f3190
2022-03-17 12:03:14 -07:00
Alex Chau
8cee1ebed0 Fix splitPrimaryScrollOffset in RTL
Fix: 225165124
Test: split select in RTL and non-RTL, check min/max scroll
Change-Id: I5fb13e39560d9dceb4a53c9c79a355f72faf3dba
2022-03-17 14:55:14 +00:00
Alex Chau
2e48760e97 Update overview grid icon sizes and paddings
- Introduced additional page spacign for clear all button to match mocks

Fix: 222664142
Test: Quick switch to last task and immediately enter overview
Test: Dismiss last task in overview grid
Change-Id: I4d2f93d843c50b10051f3fb17027cd06e86707e1
2022-03-17 13:44:21 +00:00
Wei Sheng Shih
5d9a319c76 Merge "[Shell Transition]Release floating task view after second task select." into tm-dev 2022-03-17 00:25:34 +00:00
wilsonshih
7315e33630 [Shell Transition]Release floating task view after second task select.
Register animation start callback to RemoteSplitLaunchTransitionRunner,
so there can clear up the floating task view when entering recents.

Bug: 223397364
Test: verify no floating task view remaining on RecentsActivity.
Change-Id: Idedc7950b8954d1376960d5e74aa4c60fefa9c86
2022-03-16 11:30:46 +08:00
TreeHugger Robot
a66bbdab86 Merge "Fix failing test TaplTaskbarTest#testHideShowTaskbar" into tm-dev 2022-03-15 23:20:08 +00:00
kholoud mohamed
e210b47c20 RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3
Bug: 217388602
Bug: 218875965
Test: atest EnterpriseResourcesTests
Test: manual
Change-Id: I095a1da30766e4b4eab33f42b034601b3322eb3d
2022-03-15 17:24:04 +00:00
Schneider Victor-tulias
0cde81a5d2 Fix failing test TaplTaskbarTest#testHideShowTaskbar
Closing the Taskbar all apps page doesn't automatically close any open popup menus. This lead to the popup menu opened in TaplTaskbarTests#testOpenMenu_FromTaskbarAllApps remaining open after going home in setUp (before running TaplTaskbarTest#testHideShowTaskbar). The the workspace is not visible to the tests while the popup menu is open, so this test would consistenly fail.

Bug: 215218813
Fixes: 224597087
Test: Ran tests locally and remotely
Change-Id: I81d8eb1e99a264611749eb3c508f707988c0fcb1
2022-03-14 22:19:12 +00:00
Schneider Victor-tulias
b82d945953 Add event tracking to the gesture navigation tutorial.
- Added logs for tutorial step shown/completed and for tutorial skip.
- Added shared preference tracking for tutorial steps completed and for tutorial skip.

Bug:
Test: manual
Change-Id: I47dbdb394db80c5687e98fb034a3883b33f6fd3c
2022-03-14 13:14:05 -07:00
Shan Huang
b6ff87bb99 Merge "Clear back callback in SystemUiProxy." into tm-dev 2022-03-14 16:29:25 +00:00
Alex Chau
85978e7dc8 Merge "Use overview_actions_height from Resources to calculate OverviewActionsView alignment" into tm-dev 2022-03-14 11:21:32 +00:00
Shan Huang
b960ea2be1 Clear back callback in SystemUiProxy.
Bug: 223955009
Test: atest com.android.launcher3.jank.BinderTests#testPressHome

Change-Id: I00197732a6e50c0907afecff497702fc4b799925
2022-03-11 18:03:52 +00:00
TreeHugger Robot
19570f9b05 Merge "Close taskbar all apps when task stack changes." into tm-dev 2022-03-11 02:18:34 +00:00
TreeHugger Robot
1b4d9b3b23 Merge "Launcher side implementation of gesture seekable back to home animation." into tm-dev 2022-03-11 02:11:03 +00:00
Shan Huang
581429b3dc Launcher side implementation of gesture seekable back to home animation.
This is a two part animation. The first part is an animation that tracks gesture location to scale and move the leaving app window. Once the gesture is committed, the second part takes over the app window and plays the rest of app close transitions in one go.

This animation is used only for apps that enable back dispatching via {@link android.view.OnBackInvokedDispatcher}. The controller registers an {@link IOnBackInvokedCallback} with WM Shell and receives back dispatches when a back navigation to launcher starts.

Apps using the legacy back dispatching will keep triggering the WALLPAPER_OPEN remote transition registered in {@link QuickstepTransitionManager}.

Bug: b/195946584
Test: m -j
Test: Swipe back to home on pre-T and T apps, at different life cycle
stages.

Change-Id: I615c5171cd875130f10346fa3ca2a8e9670176cf
2022-03-11 00:11:21 +00:00
Brian Isganitis
7910a3ca0a Close taskbar all apps when task stack changes.
Test: Manual
Fix: 223898952
Change-Id: I4c5e41227f0ee199cc08931f4532d769f376a617
2022-03-10 16:03:30 -08:00