Commit Graph

11687 Commits

Author SHA1 Message Date
Himanshu Gupta
cf3a0ef2f0 Merge "Prompting the user to set Pixel/Quickstep as default Home app." into main 2024-06-12 21:13:19 +00:00
Brian Isganitis
e59b640ffc Merge "Initial TaskbarUnitTestRule with example overlay controller tests." into main 2024-06-12 19:26:17 +00:00
Mykola Podolian
590e662d70 Merge "Add outline to the bubble bar background view." into main 2024-06-12 16:46:55 +00:00
Jon Miranda
1e0ec5ebeb Merge "Delay taskbar background fade in animation - Taskbar background will fade in based on 1. Velocity threshold 2. End target gesture destination" into main 2024-06-12 16:02:20 +00:00
Schneider Victor-tulias
c4ed677501 Merge "Exclude home and recents activity types when overriding recents-excluded tasks" into main 2024-06-12 15:46:56 +00:00
Orhan Uysal
8f2a4e0854 Merge "Use RecentTasksListener to trigger TopTaskTracker" into main 2024-06-12 12:30:13 +00:00
Brian Isganitis
9eaae4b6a4 Initial TaskbarUnitTestRule with example overlay controller tests.
Flag: TEST_ONLY
Bug: 230027385
Test: TaskbarOverlayControllerTest
Change-Id: I858906ece7e67677962ec8b4432bfcca5ec30283
2024-06-11 23:48:13 -04:00
Tracy Zhou
80dbe9ae3e Merge "Initialize mRotationTouchHelper before onInputDeviceAdded" into main 2024-06-12 00:56:38 +00:00
Jon Miranda
4a4b7a8059 Delay taskbar background fade in animation
- Taskbar background will fade in based on
  1. Velocity threshold
  2. End target gesture destination

Bug: 298089923
Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
      swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation DISABLED

Change-Id: I2c16352e1c0c52a8afc49900a39b80383bacde62
2024-06-11 15:39:55 -07:00
Jagrut Desai
ec772f4995 Merge "Fix Taskbar All Apps Button to be Fixed in Minimal Taskbar State" into main 2024-06-11 21:27:27 +00:00
Tracy Zhou
16b2656ecf Merge "Fix crash from isTrackpadDevice" into main 2024-06-11 21:22:35 +00:00
Orhan Uysal
c948537a82 Use RecentTasksListener to trigger TopTaskTracker
Currently launcher gets task stack updates through WM core. Ideally we
would like to migrate into a model where launcher gets these updates
through shell instead.

Test: Manually check that the correct task info is delivered to launcher
from shell
Bug: 341932484
Bug: 344684650
Flag: NONE Just adding a listener, no logic added

Change-Id: Iaf534a4bfee968138d4a4ff282a66e62759af2c0
2024-06-11 21:00:22 +00:00
Liran Binyamin
27471df69c Merge "Animate new bubble when the bar is expanded" into main 2024-06-11 20:25:15 +00:00
Tracy Zhou
70041c88ad Initialize mRotationTouchHelper before onInputDeviceAdded
There is dependency there that can cause npe from mRotationTouchHelper not initialized yet

Fixes: 345893434
Test: N/A
Change-Id: Ib9009f23d71eccf6b554e21c51ba640304250af0
2024-06-11 13:06:03 -07:00
Schneider Victor-tulias
3eb4efac95 Exclude home and recents activity types when overriding recents-excluded tasks
These tasks could point to overview itself, causing a very confusing screenshot. By excluding these tasks, we will default to using the task preview

Flag: NONE bug fix
Fixes: 336334715
Test: used circle to search from home, swiped to home, then pressed "select" overview action button. also checked temp logs
Change-Id: I0b0ca50585413b479e4830f06b57b8b5e19670a8
2024-06-11 16:01:09 -04:00
Himanshu Gupta
261a62219b Prompting the user to set Pixel/Quickstep as default Home app.
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.

Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9

Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
2024-06-11 19:11:21 +01:00
mpodolian
84f9cfabb9 Add outline to the bubble bar background view.
Added outline to the bubble bar background. Updated pointer
appearing/disappearing animation - now pointer moves into the bubble
bar background.
Demo: http://recall/-/gx8ASgewUeUS3QYohfrd1J/e1wZMrFZTILq73ik8wwrwx

Fixes: 345489039
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: Manual. Expand and collapse bubble bar with the light and the
dark theme.

Change-Id: I095fdc12337955aa21ee0eb622a924ad424ef186
2024-06-11 19:03:24 +01:00
Tracy Zhou
1deac6777b Fix crash from isTrackpadDevice
Apparently InputManager.getInputDevice can return null when a device is added

Fixes: 344902395
Test: N/A
Change-Id: I79c3dd3431b1d4b079b8a6863688a13ea2741602
2024-06-11 10:40:17 -07:00
Jagrut Desai
31a65a08dc Fix Taskbar All Apps Button to be Fixed in Minimal Taskbar State
Test: Manual
Bug: 346387672
Flag: NONE taskbar all apps is not behind a flag
Change-Id: Iea63ccf57354a1e2941bd51f7f6f9e69187c4545
2024-06-11 09:23:23 -07:00
Jeremy Sim
5aa28b472a Merge "Expand touch target of split cancel button to meet a11y requirements" into main 2024-06-11 05:13:35 +00:00
Riddle Hsu
8fbf819737 Merge "Send source rect hint to Shell via stopSwipePipToHome" into main 2024-06-11 04:45:25 +00:00
Jeremy Sim
dafbaa5f1b Merge "Fix flaky test" into main 2024-06-11 04:12:58 +00:00
Jeremy Sim
e94e509413 Expand touch target of split cancel button to meet a11y requirements
This CL adds a TouchDelegate to the "Cancel" button on SplitInstructionsView so that it is always at least 48dp by 48dp. I.e. if the touch target is smaller than 48dp, it expands the TouchDelegate to be at least that size.

Fixes: 323108127
Test: Manually verified that the touch target is larger
Flag: EXEMPT bugfix
Change-Id: Id14bc39660ee7767991a3b5613f1282945a2ef96
2024-06-10 19:54:50 -07:00
Treehugger Robot
9aafa6bd76 Merge changes I8411fb83,I5b757558 into main
* changes:
  Move Desktop running apps support into TaskbarRecentAppsController
  Add flag for Recents in Taskbar
2024-06-11 02:16:56 +00:00
Tony Wickham
a2b510dc23 Move Desktop running apps support into TaskbarRecentAppsController
- Merged DesktopTaskbarRunningAppsController up into
  TaskbarRecentAppsController, which is now initialized directly
- The old TaskbarRecentAppsController was effectively a no-op
  that was always overridden, so merging the one subclass up makes
  things simpler (especially for the follow up CLs which will add
  support for switching between Running and Recent tasks using
  the same underlying data).

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Bug: 315354060
Change-Id: I8411fb832e5dd3d76201d2694dec0b11bd70bbf9
2024-06-11 00:18:23 +00:00
Liran Binyamin
f461eab5ca Merge "Fix state after dragging bubble to dismiss" into main 2024-06-10 23:42:00 +00:00
Treehugger Robot
cf68e59c02 Merge "Finish the running recents animation when the user locks their device mid-animation." into main 2024-06-10 22:31:19 +00:00
Jeremy Sim
c1470021c8 Fix flaky test
Attempts to fix a flaky test by ensuring that recents is always cleared before creating a split pair (so the split pair under test is always the same).

Bug: 340935208
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair(), testSplitTaskTapBothIconMenus()
Flag: TEST_ONLY
Change-Id: Ibc81b90fac531f0e78e93a494ff59073ab5e52cf
2024-06-10 14:51:53 -07:00
Liran Binyamin
48811c385c Animate new bubble when the bar is expanded
When a new bubble is added when the bubble bar is expanded,
we now scale in the new bubble.

This change only handles the case where we're not at the limit.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/hW4pwqpAttscedRMxnu5BN

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 345795791
Test: manual
      - Expand bubble bar
      - Push a new bubble and verify it scales in
Change-Id: Iafae1d0c8feb8e5a8853d54e7299db261df4ebf4
2024-06-10 16:45:22 -04:00
Schneider Victor-tulias
e2bdd1568c Finish the running recents animation when the user locks their device mid-animation.
Flag: NONE bug fix
Fixes: 319022192
Test: locked device during home animation and checked temp logs
Change-Id: I884694a4318348259b04c3b6073d3ea37eff98fb
2024-06-10 11:48:34 -04:00
Liran Binyamin
ce3bbc7b5e Fix state after dragging bubble to dismiss
After dragging a bubble in the bubble bar to dismiss it,
we remove it from the view and update the width of the bubble bar.

The issue here is that the drag state only gets cleared in
BubbleBarView after the dismiss animation is complete, so when
the width is updated, we don't reposition all the bubbles according
to the new width, and end up in a weird state.

The fix is to clear the drag state in onDragDismiss.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345482103
Test: manual
       - Add multiple bubbles to the bubble bar
       - Drag a bubble to dismiss it
       - Observe bubble bar updates correctly
       - Repeat with other bubbles
Change-Id: Ie94f8ace0f5660466686a261174b42c8d71b3e30
2024-06-10 10:17:13 -04:00
Mykola Podolian
d00bc8a0e7 Merge "Remove scrim view alpha when bubble manage menu is shown." into main 2024-06-07 17:30:57 +00:00
Treehugger Robot
d141b3094d Merge "Use animateClose in TaksMenuView even without animation" into main 2024-06-07 17:29:15 +00:00
Alex Chau
7656f3c604 Merge "Reserve space for system bars in both orientations in fake orientation" into main 2024-06-07 17:03:03 +00:00
Alex Chau
4a70e1c023 Use animateClose in TaksMenuView even without animation
- animateClose uses ObjectAnimator which is able to skip animation automatically

Fix: 332685379
Test: OverviewMenuImageTest
Test: Remove animations in Settings, open and close the menu in handheld
Flag: EXEMPT bugfix
Change-Id: I5bfe835cffc77ff7f835ff3c41bbd64fc7121ed2
2024-06-07 16:59:31 +01:00
Alex Chau
f7c9466c8f Reserve space for system bars in both orientations in fake orientation
- In BaseContainerInterface.calculateTaskSize, combine both portrait and landscape/seascape insets to leave space for status bar/nav bar in either orientations.
- Rotate the paddings to portrait before applying
- Don't use getOverviewActionsClaimedSpace() in fake landscape/seascape

Bug: 344727200
Test: We can't currnetly autotest fake orientaiton
Test: With gesture/3-button, rotate Overview to portriat/landscape/seascape/fake-landscape/fake-seascape, launch task and enter overview
Flag: EXEMPT bugfix
Change-Id: Icda0f483781921cae78f1ea3ef003562b60ad75a
2024-06-07 16:28:19 +01:00
Treehugger Robot
4c0ce55f7c Merge "Fix TaskView.getThumbnailBounds not combining bounds correctly if relativeToDragLayer is true" into main 2024-06-07 10:27:23 +00:00
Treehugger Robot
dcbd5e40c5 Merge "Use just the preview for drag and drop in the standalone activity" into main 2024-06-07 01:30:34 +00:00
Treehugger Robot
671d4e5384 Merge "Ensure starting position rect isn't empty in FloatingTaskView" into main 2024-06-07 00:28:31 +00:00
Shamali P
277a4f9d78 Use just the preview for drag and drop in the standalone activity
Bug: N/A
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I62c42b649e720826979123ae2ff6c5e238fe59dc
2024-06-07 00:00:31 +00:00
Shamali Patwa
fc4ff35e68 Merge "Ensure widgets from WidgetSections.xml are included in suggestions" into main 2024-06-07 00:00:03 +00:00
Treehugger Robot
c09cb9e345 Merge "Fix bubble visibility issue when collapsed" into main 2024-06-06 22:42:05 +00:00
Vinit Nayak
410681a955 Ensure starting position rect isn't empty in FloatingTaskView
* on rotation taskbar re-inflates it's hotseat views.
If we're already in split, then FloatingTaskView tries to do calculations
on the view's position in the window, but has a reference to the
old, pre-rotated view which is no longer in any window.
* This sets startingPosition to be an empty rect, which is used to
set LayoutParam values, which are used downstream in update() to calculate
scale, and thus we end up dividing by 0.
* TODO(b/345556328) figure out a better solution than checking for an
empty rect

Fixes: 342606096
Test: Repro steps don't cause crash
Flag: EXEMPT bugfix
Change-Id: Icb546a05d383d1997a92471fc1de3ffc37d06eca
2024-06-06 15:32:33 -07:00
Shamali P
d69e21f8fe Ensure widgets from WidgetSections.xml are included in suggestions
Additionally, let only prediction system provide suggestions, since the
UI surface has been there for a while, adding locally filtered widgets
from app package isn't required.

Bug: 345520128
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: Ia97f0743fefeae750e07a694bb19d24a5cc11ffe
2024-06-06 22:23:35 +00:00
Liran Binyamin
87e579ea2d Fix bubble visibility issue when collapsed
When the bubble bar collapses, explicitly set the alpha to 1
for bubbles that should not be hidden.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345283193
Test: manual
       - create 3 bubbles in the bar
       - tap to expand
       - select the last bubble
       - tap it again to collapse
       - observe it is visible
Change-Id: I1aed310b66433b88b08ccaf760fc8e82923b1b64
2024-06-06 16:35:22 -04:00
Winson Chung
533893e898 Merge "Always report mandatory insets for button nav" into main 2024-06-06 04:28:38 +00:00
Winson Chung
762b3b4685 Always report mandatory insets for button nav
Fixes: 340134342
Fixes: 343817842
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Test: Verify mandatory insets vs window bounds in various
      orientations when folded/unfolded
Change-Id: I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae
2024-06-06 04:26:48 +00:00
Hongwei Wang
7584e28833 Merge "Crop the center when no source rect hint" into main 2024-06-06 00:15:05 +00:00
mpodolian
4d8ad445c0 Remove scrim view alpha when bubble manage menu is shown.
Updated logic for taskbar scrim view alpha calculation, setting it to 0
when bubble manage menu is shown.

Fixes: 337169457
Flag: NONE
Test: Visual.
For gesture navigation:
1) On foldable phone while device is being folded expand any
bubble, click mange button, then unfold. Observe no scrim view is
visible.
2) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles are open.
3) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles and mange menu is open.
4) Enable persistent taskbar. Fold device. Open bubble and click manage
button. Unfold device. Observe no scrim view is visible.

For 3 button navigation
1) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles are open.
2) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles and mange menu is open.
3) Fold device, open bubble and click manage button. Unfold device.
Observe no scrim view is visible.

Change-Id: Ic011ae9bd11801a479062cc51c60377823a926fb
2024-06-06 00:32:08 +01:00
Ats Jenk
765cc415a3 Merge changes from topic "bubblebar-a11y" into main
* changes:
  Move bubble bar strings
  Add content description to bubble bar and bubbles
2024-06-05 19:04:22 +00:00