Commit Graph

10271 Commits

Author SHA1 Message Date
Tony Wickham
e1f770df2f Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: I48b4c809025a9bab0a37ada1317adee823b1a8f9
2023-11-20 23:41:01 +00:00
Pat Manning
54acb41e8c Merge "Do not hide persistent taskbar during input for physical keyboard." into main 2023-11-20 23:29:55 +00:00
Brian Isganitis
78ccf9c3e6 Merge "Adding TASKBAR entry state for Taskbar Toast." into main 2023-11-20 21:03:03 +00:00
Andreas Agvard
37eac5b585 Merge "Adds a debug & server configurable delay to search haptic hint" into main 2023-11-20 18:04:10 +00:00
Schneider Victor-tulias
ca7147b289 Merge "Add debug logs for TIS ACTION_DOWN handling" into main 2023-11-20 17:41:01 +00:00
Andreas Agvard
fc74c095d6 Adds a debug & server configurable delay to search haptic hint
Fix: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED

Change-Id: Ic050e8426ef91b28e6bf1dc4d86839eaa20b0dc0
2023-11-20 12:49:54 +01:00
Pat Manning
a401e15553 Do not hide persistent taskbar during input for physical keyboard.
Fix: 255818649
Test: TaplTestsQuickstep
Flag: NONE.
Change-Id: Id5495163f43464125bfcbd9e255f18e24183d67a
2023-11-20 10:45:05 +00:00
Pat Manning
d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Andreas Agvard
ef8df12ff8 Merge "Makes deep press for LPNH toggelable" into main 2023-11-17 07:51:16 +00:00
Winson Chung
92851c5030 Merge "Don't open PiP when freeform is opened from recent" into main am: 0c531d5dbb am: f3eb5388d1 am: d127c1108b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2743811

Change-Id: I48a134a3545eb190c4ef085641d0233e68660046
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-17 00:29:58 +00:00
Winson Chung
d127c1108b Merge "Don't open PiP when freeform is opened from recent" into main am: 0c531d5dbb am: f3eb5388d1
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2743811

Change-Id: If62d1d831854acf9b5ec2e8c27458594e72bba27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-16 23:58:07 +00:00
Winson Chung
f3eb5388d1 Merge "Don't open PiP when freeform is opened from recent" into main am: 0c531d5dbb
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2743811

Change-Id: I41d412ee0c6d5c6dacd875c549b724b439e1d542
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-16 23:24:23 +00:00
Pat Manning
43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Andreas Agvard
0fc7d52863 Makes deep press for LPNH toggelable
By default when deep press is detected (https://developer.android.com/reference/android/view/MotionEvent#CLASSIFICATION_DEEP_PRESS)
during LPNH triggers the long press action immediately. This change makes this toggelable.

Flag is set to enabled by default, which leads to the default behavior.

Fix: 310952290
Test: Manual
Flag: LEGACY ENABLE_LPNH_DEEP_PRESS ENABLED
Change-Id: I970fed697979ee528e54b8be0139d842f3a64c43
2023-11-16 17:55:34 +01:00
Schneider Victor-tulias
4b794d57de Add debug logs for TIS ACTION_DOWN handling
Flag: N/A
Bug: 311094603
Test: Ran launcher and attempted several gestures
Change-Id: I08c6544226ed0ad385821c3309b2845a485cf900
2023-11-16 10:05:33 -05:00
Sergey Pinkevich
172eb5896b Merge "Show split screen action for each task" into main 2023-11-16 10:03:44 +00:00
Fengjiang Li
1da44348cf Merge "Add unit test for RecentsAnimationDeviceState.java" into main 2023-11-15 23:05:32 +00:00
Achim Thesmann
daca6d0747 Merge "Opt in recents PendingIntent for BAL" into main 2023-11-15 22:27:27 +00:00
Fengjiang Li
b3007a9e3d Add unit test for RecentsAnimationDeviceState.java
Bug: 299466828
Flag: N/A
Test: test device boot without issue
Change-Id: Iaa1a7cff547e03eaacc950702c2e7cd34846e987
2023-11-15 13:01:51 -08:00
Sergey Pinkevich
ead5259f9a Show split screen action for each task
Remove previous condition:
1. `taskView.containsMultipleTasks()` - there is already a check to filter out "Split screen" item: https://googleplex-android.googlesource.com/platform/packages/apps/Launcher3/+/refs/heads/main/quickstep/src/com/android/quickstep/TaskOverlayFactory.java#68

Edit previous condition:
2. `notEnoughTasksToSplit` - condition saying if there is less than 2 recent tasks. We still should give the possibility to split the screen if Taskbar is not presented

Bug: 305958994
Flag: NONE
Test: manual - took a photo (https://screenshot.googleplex.com/7doU5z9AjxxETUo)

Change-Id: I3fdfea987c426d557a91b0a25af368069e8af3f8
2023-11-15 15:14:50 +00:00
Alex Chau
013af87a10 Merge "Use WindowConfiguration to match DeviceProfile in IDP.getDeviceProfile" into main 2023-11-15 10:06:53 +00:00
Robin Vinterbladh
018edc452d Don't open PiP when freeform is opened from recent
When opening freeform window from recents menu PiP should not
be started at the same time since the PiP transition can cause
freeform to not work as intended.

Bug: 299505542
Change-Id: I6392089b3ac9ce914fb37cc84780f28aa3fc75f8
2023-11-15 09:41:10 +01:00
Achim Thesmann
a1b0b31e77 Opt in recents PendingIntent for BAL
With BAL hardening in V PendingIntent creator's need to expliciitly opt
in to grant their BAL privileges.
The change is a noop unless the `bal_require_opt_in_by_pending_intent_creator` flag is enabled.

Bug: 296478951
Flag: NA
Test: atest NexusLauncherTests:com.android.quickstep.FallbackRecentsTest NexusLauncherTests:com.android.quickstep.StartLauncherViaGestureTests
Change-Id: I7f2f4f3613f70b6ec0c398803a140ab93dcf1a03
2023-11-15 02:57:29 +00:00
Tracy Zhou
bf021974f4 Merge "[Trackpad] Do not reverse two-finger gestures on the homescreen when reverse scrolling is on" into main 2023-11-15 02:22:20 +00:00
Schneider Victor-tulias
d58c0dbdca Merge "Clean up NPEs in AbsSwipeUpHandler" into main 2023-11-14 18:49:50 +00:00
Alex Chau
c09a98a87d Use WindowConfiguration to match DeviceProfile in IDP.getDeviceProfile
- Also fix WindowBounds.isLandscape to use full display bounds to determine isLandscape, otherwise both orientation will be treated as isLandscape when using availableSize

Bug: 309801705
Test: manual and presubmit
Flag: NONE
Change-Id: Ic7f4235e620d4760a9af356f23066fe5b23304e6
2023-11-14 18:38:51 +00:00
Schneider Victor-tulias
3b9d80d2d8 Clean up NPEs in AbsSwipeUpHandler
AbsSwipeUphandler has many potential and common NPEs. Added more null checks to AbsSwipeUpHandler

Flag: N/A
Fixes: 295905702
Fixes: 309535060
Test: StartLauncherViaGestureTests, quick switched and launched app from recents
Change-Id: I11f62eac423ae3c5792ce97ca49963f1e005b289
2023-11-14 10:48:10 -05:00
Uwais Ashraf
6dfa8521e5 Merge "Revert "Refactor/clean up Overview Actions buttons"" into main 2023-11-14 10:25:11 +00:00
Uwais Ashraf
60a2d85b68 Revert "Refactor/clean up Overview Actions buttons"
Revert submission 25292769-cleanup-action-buttons

Reason for revert: Causes a 100% failure of OverviewImageTest

Reverted changes: /q/submissionid:25292769-cleanup-action-buttons

Change-Id: Iedd51290e2d6fb7efafc814f1d3d51863b3d3ab7
2023-11-14 09:45:55 +00:00
Tracy Zhou
07e2e43311 Merge "Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig" into main 2023-11-13 22:49:44 +00:00
Jeremy Sim
ed56be4fbc Merge "Refactor/clean up Overview Actions buttons" into main 2023-11-13 22:20:47 +00:00
Tracy Zhou
859edd00e9 Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig
Bug: 270394122
Test: N/A
Change-Id: I9bacd906099518b4a4c43a9f80ab0c753beac89a
2023-11-13 13:12:09 -08:00
Jagrut Desai
2c7556d4c7 Merge "Fix RTL issue with all apps meta icon" into main 2023-11-13 20:13:34 +00:00
Jagrut Desai
bd997801e9 Merge "Migrate ENABLE_TASKBAR_PINNING to aconfig flag" into main 2023-11-13 20:13:15 +00:00
Vinit Nayak
1d3035e024 Prevent widgets from entering split
Bug: 296502210
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Change-Id: I1a166f6ca0fe5fd2fa1d29b97b8856e52985e0c1
2023-11-10 12:17:12 -08:00
Jagrut Desai
1ab8da20f5 Fix RTL issue with all apps meta icon
Test: Presubmit, Manual
Bug: 309453796
Flag: NONE
Change-Id: I5d8bda2c48a0815d7005a0727f67f871f75d4f0f
2023-11-10 09:44:51 -08:00
Jagrut Desai
90dd098c85 Migrate ENABLE_TASKBAR_PINNING to aconfig flag
Test: Manual, Presubmit
Bug: 265437087
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I4800230c04feceefa2398e189c493c8c4a7b2fe5
2023-11-09 23:20:03 +00:00
Tracy Zhou
d66d114944 Merge "Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION" into main 2023-11-09 18:47:59 +00:00
Randy Pfohl
583e48d915 Merge "Adding insets to prevent back gesture from triggering status bar" into main 2023-11-09 16:44:05 +00:00
Andreas Agvard
100b77e667 Merge "Translucent apps are kept in Recents while in the foreground" into main 2023-11-09 11:30:29 +00:00
Chris Li
6c2681049c Merge "Update PipContentOverlay usage" into main 2023-11-09 03:41:43 +00:00
randypfohl
640e65888c Adding insets to prevent back gesture from triggering status bar
Flag: NONE

Test: Built locally verified back gesture doesn't trigger status bar

Bug: 279252552

Change-Id: I3ad325b1937b5f26278354bc8cef0c94066eed25
2023-11-08 14:53:15 -08:00
Tracy Zhou
f2d7be1cec Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION
We want to turn on the flag when either of the dependent features is on

Bug: 299193589
Test: N/A
Change-Id: I7b48ff2be0cf9da3b6bc00d75370fa585ce4140d
2023-11-08 14:52:58 -08:00
Jeremy Sim
7030216f48 Refactor/clean up Overview Actions buttons
Since the number of Overview actions is growing, this patch factors out the button hiding logic so it's not all handled in OverviewActionsView.

Also, since splitscreen can now be carried out on Taskbar targets, the split button is no longer ever disabled (only hidden), so removed unused code for that.

Bug: 274835596
Test: Manual
Flag: NA
Change-Id: Icacdee6d0e6071ccb400dfc25a84572e7e9ce772
2023-11-08 13:43:19 -08:00
Tony Wickham
f57204c0dd Merge "Only run InputConsumerProxy callback for touch event" into main 2023-11-08 18:26:34 +00:00
Tracy Zhou
f6fdcf10c4 Merge "Migrate HIDE_NAVBAR_WINDOW to aconfig and rename is to enable_taskbar_navbar_unification" into main 2023-11-08 18:25:48 +00:00
Andreas Agvard
a71e664a61 Translucent apps are kept in Recents while in the foreground
Translucent apps that are exluded from Recents are not kept in Recents
while they are the foreground. This is to prevent jank while going to
Recents and thus morphing to another app, and to prevent confusion as
going back to an app might end you back into the excluded app experience
in case of an app like Omnient that is "on-top" of another application.

Fix: 305650114
Test: Manual
Flag: LEGACY INVOKE_OMNI_LPH DISABLED
Change-Id: I24d583434ce62c68436e8928cf3a47a5ce73ecaf
2023-11-08 17:04:31 +00:00
Liran Binyamin
4d9157be73 Merge "Adds content description to the overflow bubble." into main 2023-11-08 15:52:58 +00:00
Schneider Victor-tulias
b55971202e Merge "Fix unresponsive swipe up after launching a non-running app from overview" into main 2023-11-08 15:11:22 +00:00
Johannes Gallmann
b503e27ae2 Merge "Catch SecurityException in SystemUIProxy" into main 2023-11-08 10:33:17 +00:00