Commit Graph

3420 Commits

Author SHA1 Message Date
Zak Cohen
7f48b0aa34 Overview - position the modal task in the correct place.
video of new behavoir
https://drive.google.com/a/google.com/file/d/1vFTtjjpwamj5H7dhmB1-5JSFS6fv6vMw/view?usp=sharing


Test: local
Bug: 155205932
Change-Id: I7fe79c848af92013587de32a777645cc472ae910
2020-04-30 18:34:46 +00:00
Lucas Dupin
20051e22e5 Merge "Do not blur if all apps is fully visible" into ub-launcher3-rvc-dev 2020-04-30 17:11:53 +00:00
Sunny Goyal
8f96546e79 Generalizing LauncherState definition so that it can be used in RecentsActivity
> Removing 'Launcher' as parameter from state methods called by StateManager
> Converting state properties to methods for easier abstraction
> Moving state handling drom state definition to activity class

Change-Id: I997627df606a7e0bb3bf32688d045a942a47fc94
2020-04-30 01:01:51 -07:00
TreeHugger Robot
2d60935e1c Merge "Various multi-window fixes" into ub-launcher3-rvc-dev 2020-04-29 23:43:57 +00:00
TreeHugger Robot
875f381dbb Merge "Dump RecentsOrientationState for bug reports" into ub-launcher3-rvc-dev 2020-04-29 19:56:54 +00:00
Vinit Nayak
3aed7aeb67 Merge "Use appropriate start padding for clear all button" into ub-launcher3-rvc-dev 2020-04-29 19:31:38 +00:00
Vinit Nayak
a5877307d1 Dump RecentsOrientationState for bug reports
Bug: 154951045
Test: New output shows up when running
"adb shell dumpsys activity
com.google.android.apps.nexuslauncher.NexusLauncherActivity
[--all]"

Change-Id: I5e9ace7d370eb0e9d278d7d9f7f9156674ca1a50
2020-04-29 12:19:49 -07:00
Sunny Goyal
0addbf0512 Various multi-window fixes
> Fixing scale up calculator for swipe-down
> Offsetting pivot so that the preview is aligned to bottom-right
> Allowing insets to be available in multi-window mode as well
> Offsetting taskViewSimulator appropriately in multi-window mode

Change-Id: I7da4c145efca72ef219a5ffcaf23d726812df270
2020-04-29 11:50:33 -07:00
Lucas Dupin
264cb2ff68 Do not blur if all apps is fully visible
Fixes: 155093795
Fixes: 155203546
Test: manual
Change-Id: I30f4c027e5107a199791e908acbb7ffed94e6a77
2020-04-29 17:49:02 +00:00
Jonathan Miranda
0d9a9b9336 Merge "Fix floating icon view positioning when in multiwindow mode." into ub-launcher3-rvc-dev 2020-04-29 17:26:33 +00:00
Jonathan Miranda
7a79edd48a Merge "Ensure final values are set when StaggeredWorkspaceAnim is cancelled/ended." into ub-launcher3-rvc-dev 2020-04-29 16:37:50 +00:00
Jon Miranda
db02b11340 Ensure final values are set when StaggeredWorkspaceAnim is cancelled/ended.
Was able to repo the bug reliably when calling cancel() and
end() immediately after starting the StaggeredWorkspaceAnim.

Bug: 153584267
Change-Id: I954d38ad69e72a83535f4dd1ec21dba0f61a3cfb
2020-04-29 15:51:10 +00:00
Jon Miranda
f6225830d5 Fix floating icon view positioning when in multiwindow mode.
The rect we passed in was in screen space to match the window, but needs to be
be local to launcher.

Also updated code/comments to make it more readable.

Note that the bounds of the targets being off is a separate issue b/153581126

Bug: 135195169
Change-Id: I4a8c0aa2f504bdf69342a927725cd440fb324a36
2020-04-28 21:29:51 -07:00
Becky Qiu
1f31915b5b [Overview Actions] Fix the animation duration issue.
Test: local
Bug: 155205932

Change-Id: Ic64762b0c7647a5c38d182c24a8cba4a354a9a83
2020-04-28 17:24:48 -07:00
Vinit Nayak
e8269b3944 Merge "Enable edge back gesture on app launch" into ub-launcher3-rvc-dev 2020-04-29 00:18:22 +00:00
Vinit Nayak
3f3cc3e96e Enable edge back gesture on app launch
We don't clear state on EdgeBackGestureHandler
when we go to Recents or Home.
A more robust solution is in the works with
WM team and will probably be built on top of this.
Needs ag/11273364 to work.

Bug: 154580671
Test: Launch app directly in landscape,
should be able to swipe home on first try.

Change-Id: Ia4c685e16645d0237f278a611f6c61f252f3b79c
2020-04-28 13:51:43 -07:00
Vinit Nayak
48ea9e9502 Use appropriate start padding for clear all button
This still shows up a bit strange with
notched phones because we are using
RecentsView padding to give ClearAll the
right amount of spacing. However, we're only
adding padding to the left and right and not
the top/bottom.
That's captured here: b/154436527

Fixes: 150389833
Test: Tested landscape/portrait/seascape
launcher, w/ RTL as well

Change-Id: I49defd58048e609a1f7a821abb97374bcbb94b9f
2020-04-27 22:44:05 -07:00
Zak Cohen
a39544d562 OverviewActions - Use launcher state to track modal state.
Test:local

Change-Id: I44e25b95095b9a7aac4b4172c9c91fbfbf4d9ec7
2020-04-27 16:29:44 -07:00
Sreyas Rangaraju
2f04a9d271 Merge "Assistive chip: Adding background scrim for chip." into ub-launcher3-rvc-dev 2020-04-27 21:43:49 +00:00
Vinit Nayak
b219eeab48 Merge "Revert "Hide shelf in 2-Button Landscape"" into ub-launcher3-rvc-dev 2020-04-27 21:24:53 +00:00
Vinit Nayak
48b28027c0 Revert "Hide shelf in 2-Button Landscape"
This reverts commit 9b5795a579.

Reason for revert: b/155090034

Change-Id: If7decd54965a680d50e4474fb279ebe0002441bb
2020-04-27 20:48:49 +00:00
TreeHugger Robot
2ca219889b Merge "Fixing stagger animation not getting initialized properly" into ub-launcher3-rvc-dev 2020-04-27 20:17:16 +00:00
Sunny Goyal
017a8681c7 Fixing stagger animation not getting initialized properly
Bug: 155092237
Change-Id: I65ee6bddc0bf3bda24820d4680d71bab112b670c
2020-04-27 11:11:54 -07:00
Sunny Goyal
fd0f8b0d1a Fixing corner radius not properly scaled in TaskViewSimulator
Bug: 155016285
Change-Id: Ib49e79cb30fbd448f86806a98557ec27718e3499
2020-04-27 18:03:09 +00:00
TreeHugger Robot
fbb6d6a73a Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev 2020-04-25 21:03:52 +00:00
Bill Yi
0d3d73a402 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I9fc4e7de6693ab7fee98740c1c09e92dfbd82eda
2020-04-25 03:09:04 -07:00
TreeHugger Robot
1016bf410d Merge "Don't scale workspace when going to all apps if ENABLE_OVERVIEW_ACTIONS" into ub-launcher3-rvc-dev 2020-04-25 06:21:30 +00:00
Tony Wickham
00dc219309 Merge "Use OverviewWithoutFocusInputConsumer for sharesheets over home" into ub-launcher3-rvc-dev 2020-04-25 06:00:01 +00:00
Vinit Nayak
482435c01b Merge "Use DeviceProfile to check multiWindowMode" into ub-launcher3-rvc-dev 2020-04-25 02:11:50 +00:00
TreeHugger Robot
ea0c4f57be Merge "Hide shelf in 2-Button Landscape" into ub-launcher3-rvc-dev 2020-04-25 01:14:10 +00:00
Vinit Nayak
11c6671d27 Use DeviceProfile to check multiWindowMode
Prevent extra IPC calls when checking for
multiWindowMode by using existing DeviceProfile.
This might be made irrelevant by b/142282126

Fixes: 149571513
Change-Id: Ia41cbfd56c67dd78f4d9c10bf1469d0d2a9e581d
2020-04-24 17:22:30 -07:00
TreeHugger Robot
c6800e40e2 Merge "Creating default implementation for state lisnter method" into ub-launcher3-rvc-dev 2020-04-24 23:49:33 +00:00
Vinit Nayak
9b5795a579 Hide shelf in 2-Button Landscape
Disable overview rotation in 2-Button
until we can figure out the correct
transition/animation.
TODO: b/154665738

Fixes: 154181816
Test: Tested no button and 2 button,
overview actions worked as before.

Change-Id: Ib67906b11e24def870a39f57b5156e29db258fd7
2020-04-24 16:43:37 -07:00
TreeHugger Robot
2450f524c6 Merge "Clear swipe region cache on nav mode switch" into ub-launcher3-rvc-dev 2020-04-24 23:31:04 +00:00
Sreyas
6bb2be1526 Assistive chip: Adding background scrim for chip.
Change-Id: Ic6d0f0e0809c0c4acad4bb31c0e005d653cd0ae3
Bug: 153372670
2020-04-24 23:12:31 +00:00
Sunny Goyal
aeec80ddbb Creating default implementation for state lisnter method
> The transition start is used rarely

Change-Id: I0d33f0f6372eb4ef89bfbb66968612693b7c6033
2020-04-24 15:41:29 -07:00
Vinit Nayak
dcec265f0d Clear swipe region cache on nav mode switch
Fixes: 154955192, 150958400
Test: Switched from gesture nav to 3 button,
was no longer able to swipe up

Change-Id: Icc7b27eb7bd1eb5ddf25d7e7c3464a77a3a88f24
2020-04-24 15:05:17 -07:00
Tony Wickham
bf2f066fff Use OverviewWithoutFocusInputConsumer for sharesheets over home
Test:
- start sharesheet from overview action, swipe up
- start sharesheet after taking screenshot on home, swipe up
- start sharesheet from an app, e.g. Chrome
The first two use OWFIC, last one uses OtherActivityInputConsumer
as normal.

Bug: 153673244
Change-Id: I7d7887e1f6818346ada75776ec63b43aaf3708f1
2020-04-24 15:01:32 -05:00
TreeHugger Robot
a29a69943a Merge changes I38874b8b,I627ed7c6 into ub-launcher3-rvc-dev
* changes:
  Adds ripple effect for successful Back gestures in tutorial.
  Adds feedback to Home and Back tutorials.
2020-04-24 19:58:48 +00:00
TreeHugger Robot
acafb3a287 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev 2020-04-24 18:58:30 +00:00
Andy Wickham
e992fab187 Adds ripple effect for successful Back gestures in tutorial.
Emanates from where the gesture was started.

Demo: https://drive.google.com/open?id=1oaXOSUiZP6Hi7J6W4H2NIFVVu0tQfKWm
Bug: 148542211
Change-Id: I38874b8b731864cbfdf963a5e44a59c8c3d30c51
2020-04-24 18:16:43 +00:00
Andy Wickham
64a91132c5 Adds feedback to Home and Back tutorials.
Back feedback:
 - Too far from edge of screen
 - Cancelled (reversed gesture, swiped upwards, etc.)
 - Inside nav bar region
 - Demo: https://drive.google.com/open?id=1pc_hr7i-iZmgF37CN8oijPjhOvvsJoEG

Home feedback:
 - Too far from edge of screen
 - Paused too long (Overview detected)
 - Swiped sideways instead of up
 - Demo: https://drive.google.com/open?id=1NGYAlqV2wJtM2DOJ1pZM-r8N1SYVtMos

Bug: 148542211
Test: Manual
Change-Id: I627ed7c6e9b005d35794e4ae568529b5613cbf70
2020-04-24 18:15:23 +00:00
Andy Wickham
6b6287f414 Detects nav bar gestures to progress through Home tutorial.
Home gesture also exits Back and Home tutorials on the
completion screens (as does back gesture).

Test: Manually verified Back and Home tutorial flows.
Bug: 148542211
Change-Id: I8026745e875e9ccb8cfd60bc438213b2d896254d
2020-04-24 18:13:05 +00:00
Vinit Nayak
49d3fe598c Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev 2020-04-24 17:48:01 +00:00
Ming-Shin Lu
4f07525417 Fix AlwaysOnTop stack may covered by RemoteAnimation
Now with hierarachical animation, the layer of
RecentsAnimation / RemoteAnimation are controlled by system.

Now Launcher side don't need to have other way to set layer for ZBoost
case, so remove setLayer & withLayer related logics for cleaning up.

Fix: 151024899
Test: manual, launch google map app -> enter PiP mode,
      swipe up to overview screen or launch activity from shortcut,
      make sure the PiP window is not covered by other apps.

Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
(cherry picked from commit 99f7da7dd2)
2020-04-24 02:18:16 +00:00
TreeHugger Robot
d73d39b45a Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev 2020-04-23 03:22:31 +00:00
vadimt
b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
TreeHugger Robot
8d5a000071 Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev 2020-04-23 01:25:06 +00:00
TreeHugger Robot
1bb37acb5d Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev 2020-04-23 00:04:35 +00:00
Tony Wickham
6a6301c569 Always return RecentsView to translation 0 on drag end
After reaching overview, we let the user translate RecentsView
if they continue dragging around. But when they let go, we need
to return RecentsView to translation 0 since that's no longer
part of the state machine.

Change-Id: I30b51485339a3b6c3dd52bda113b1a05b6e885fa
2020-04-22 18:42:40 -05:00