Commit Graph

631 Commits

Author SHA1 Message Date
Vadim Tryshev
5c97cb689d Merge "Not assuming reverse order of menu shortcuts" into sc-dev 2021-03-18 18:41:04 +00:00
vadimt
6327dabc2a Not assuming reverse order of menu shortcuts
For Launcher3 tests the order can be either
Shortcut 0
Shortcut 1
Shortcut 2

or
Shortcut 2
Shortcut 1
Shortcut 0

Test: presubmit
Bug: 182006150
Change-Id: Ie014f5e5655a5b0bff05316c2a1457a5b5f703ef
2021-03-17 15:53:49 -07:00
Alina Zaidi
e17f4651d0 Merge changes from topic "SEARCH_INTEGRATE" into sc-dev
* changes:
  Add a WidgetsSearchBar(Launcher3) and a WidgetsSearchController.
  Have a recycler view to show search results.
2021-03-15 13:24:20 +00:00
Alina Zaidi
d07acba048 Add a WidgetsSearchBar(Launcher3) and a WidgetsSearchController.
- Make WidgetsSearchBar in Launcher3 initialize WidgetsSearchController with SimpleWidgetsSearchPipeline
- Modify SimpleWidgetsSearchPipeline to filter widgets entries on widgets/shortcut labels also.

Test: Tested prototype locally. Also added robolectric test.
Bug: b/157286785
Change-Id: I65f5fa0240ffb6d22023167e4e86d94d83bbd9f7
2021-03-15 11:25:08 +00:00
Vadim Tryshev
976bd24f57 Merge "Increase wait times in TAPL" into sc-dev 2021-03-12 22:53:22 +00:00
Pierre Barbier de Reuille
ab33b76dce Launcher changes to support dynamic coloring on static widgets.
Bug: 179783721
Test: By hand using the AppWidgetDynamicColors widget
Change-Id: I27863cac31f2f6c29f5a717ff8d4492325f936fb
2021-03-10 22:04:35 +00:00
vadimt
368dc79f55 Increase wait times in TAPL
This helps to avoid misleading errors when
the system has performance problems.

Test: presubmit
Bug: 179392551
Change-Id: I4de3c543f32f41af64bd6107885df82b03973d35
2021-03-10 12:19:12 -08:00
Samuel Fufa
d0bb42bf2e Pause onAppsUpdate when AllApps is converted to tabs.
To avoid onAppsUpdated conflicting with WorkTabEdu, this change pauses callback updates when AllApps is first converted to tabs. This should  avoid the need for additional  extended timeouts.

Bug: 159671700
Test: Presubmit
Change-Id: I0959629f47ae6d824e5886b2cf917635f5bfdf0e
2021-03-09 02:48:08 +00:00
Samuel Fufa
3531778a08 Defer AllAppsUpdate while edu test is running
Bug: 159671700
Test: Presubmit
Change-Id: I6f1421117286225d80a1538e45fbf2592229b586
2021-03-04 14:11:38 -06:00
TreeHugger Robot
161b27d5c5 Merge "Better diagnosing leaked activities." into sc-dev 2021-03-03 08:26:34 +00:00
Yogisha Dixit
a6554759aa Merge "Move widget files into widget folder + add tests." into sc-dev 2021-03-02 09:30:02 +00:00
Yogisha Dixit
741fae9ea2 Move widget files into widget folder + add tests.
I will use the newly created LauncherAppWidgetProviderInfoTest in a follow-up CL to add tests for the newly added widget sizing APIs.

Test: Automatic: Ran all robolectric tests in launcher3,
      Manual: Added a widget, edited the widget, removed the widget
Bug: 179807199
Change-Id: I540b2dbe284c6eb5aa2466a1d13a9581ee59425b
2021-03-01 13:59:52 +00:00
vadimt
ab469ac515 Better diagnosing leaked activities.
Test: manual
Bug: 181356264
Change-Id: I9bf843a1d26bc4cf255c1b8d2cce0febeaa4c4fe
2021-02-26 14:45:10 -08:00
Samuel Fufa
a18abf55b4 Add tracing to track every allApps rebind
Bug: 159671700
Test: presubmit
Change-Id: I1c7507ac2175d6e2f4514e4ad51c356aa75dd6e9
2021-02-26 16:40:27 -06:00
Steven Ng
e92bc55d12 Make all widgets collapsed in the full widget picker by default
Changes:
1. Add a WidgetListHeader view for showing icon, app name and a subtitle.
2. Only WidgetListHeaders are always visible to users in the full widget
   picker.
3. Only one widgets list from an app is visible in the full widget picker
   at any one time.

Test: Auto: run add robolectric tests under widget/picker
      Manual: Open full widgets picker. Then, expand and collapse apps.
      Video: https://drive.google.com/file/d/1gzfeEm5IOAu0qHsO77OTS2eMfU7CHJiL/view?usp=sharing

Bug: 179797520
Change-Id: Idac58be23dfeafcb79b3c61b4972d3addb462de1
2021-02-15 17:46:38 +00:00
Steven Ng
2f5648a911 Refactoring before adding a new view type in the WidgetsListAdapter
Changes made:
1. Model: added an abstract class for storing common information for
   entries shown in the full page widgets picker.
2. Introduced a ViewHolderBinder interface to split the logic of binding
   data to ViewHolder into separate classes.
3. Move the view holder binding of WidgetsListRow from WidgetListAdapter
   to its new class.
4. Move some widgets picker classes into a new picker package.

Test: Auto: Run WidgetsListAdapterTest, WidgetsListRowEntryTest and
      WidgetsListRowViewHolderBinderTest.
      Manual: open the all apps widgets tray and navigate the list.

Bug: 179797520
Change-Id: Iab29557842bb79156cad84d00a4c5d0db0c5aa06
2021-02-10 21:23:40 +00:00
TreeHugger Robot
f56efc0187 Merge "Adding debug tracing for Device.wait" 2021-01-20 18:58:21 +00:00
Vadim Tryshev
9e86e3b89d Merge "Removing automatic failure investigator" 2021-01-20 18:46:42 +00:00
vadimt
952471f675 Removing automatic failure investigator
It wasn't updated for a while,
creates a false impression that the failure
is already tracked, and hopefully soon
will be replaced by new clustering.

Test: presubmit
Bug: 161478674
Change-Id: Icc3716c1f534867d5e4b21d18c9cede273da8704
2021-01-19 15:14:03 -08:00
vadimt
ed86cb19bc Adding debug tracing for Device.wait
I suspect it may wait for a period of time less than
the specified one, causing flakes.

Test: presubmit
Bug: 177318681
Change-Id: I0be8790c6ee9a5831767fe83c36054ed5a84f8d7
2021-01-15 13:58:03 -08:00
vadimt
f48097f270 Correctly generating heap dumps for OOP tests
Not trying to dump the test process :)

Still using Debug.dumpHprofData for inproc because
using shell command for inproc can deadlock.

Test: manual
Bug: 177065099
Change-Id: I4b581954a01ecc8a1427409baa030aaa3b70d6b5
2021-01-14 19:43:28 -08:00
TreeHugger Robot
23f0dc318c Merge "Generating Hdumps for more leaks" 2021-01-14 07:01:55 +00:00
vadimt
c37058976d Generating Hdumps for more leaks
Test: presubmits
Bug: 177065099
Change-Id: I386229cf92a925d2953952ed0fab6c44dcdc61f0
2021-01-13 11:34:16 -08:00
Samuel Fufa
a5f289a605 Increase timeout and additional logs for WorkTabTest#testWorkEduFlow
Bug: 159671700
Test: WorkTabTest#testWorkEduFlow
Change-Id: I5c015fbb9555be0e3e74c721873da4edd0393c8a
2021-01-13 10:26:00 -06:00
vadimt
f4bb052ca0 Removing workaround for battery defender
The bug is supposed to be fixed.

Bug: 151613234
Change-Id: I8e803ead29e08e68fa75f61b5ad0e1198c9228ec
(cherry picked from commit ff39fd3e14)
2021-01-05 19:17:33 +00:00
vadimt
0d9cb19453 Checking menu item test to improve test fail diags
Test: atest
Bug: 75641613
Change-Id: Idb5c7fe744e4a3e69ee0fdb59d1a5a58bc6ce0b2
2020-12-14 19:57:59 -08:00
Samuel Fufa
b8df6a573a Resolve Flaky work tab tests
In cases where test execution and launcher relayout overlap, mLauncher.getAppsView().getContentView() returns a recyclerview instead of pagedView. This is resolved when rebindAdapters is later called with showTabs=true. The issue here is we are keeping a stale value of mLauncher.getAppsView().getContentView() in WorkEduView which is problematic as pagedView is required to set the right tab index for the test.

This behavior also affects work testWorkEduIntermittent as we need to verify the a pagedView is visible before text execution.
Bug: 149867607
Bug: 159671700
Test: flake -t com.android.launcher3.ui.WorkTabTest

Change-Id: I4b0968d6b9daa5c8fe741d4b1ed090f9c7acabed
2020-12-10 11:02:13 -06:00
Samuel Fufa
e5d2ad8e34 Even more logs for flaky work test
Bug: 159671700
Change-Id: I009f243b5e3076d15bc89a4755d5ddb9a5b3119e
2020-11-19 22:54:02 +00:00
Sunny Goyal
54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
TreeHugger Robot
2b2c448679 Merge "Add more logs for WorkTabTest flake investigation" into ub-launcher3-master 2020-11-05 18:08:34 +00:00
Samuel Fufa
d91bad956f Add more logs for WorkTabTest flake investigation
Bug: 159671700
Change-Id: I92f64bafa756a65d3e63514474028b82b059e357
2020-11-05 11:14:16 -06:00
Vadim Tryshev
c0ef31e38f Revert "Removing workaround for battery defender"
This reverts commit ff39fd3e14.

Reason for revert: The CL coincided with a start of flakes "phone is locked". Let's revert and see if it fixed that. https://flakes-clusters.corp.google.com/#/?androidAtpBranch=git_master&androidAtpModule=com.google.android.apps.nexuslauncher.out_of_proc_tests&d=30&cid=9fd6b65c-e48c-4bc3-b19b-f5c610a1999a&maxResults=20

Change-Id: I90f8abbb1794c19593ed8a235a82c0e53030c0a2
2020-10-31 01:50:29 +00:00
Winson Chung
f99351888c Revert "Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ...""
This reverts commit 087a9e39b6.

Change-Id: I05b17a6e4aaaef6de3c2fa26aad45a39eb2833f9
2020-10-23 09:27:48 -07:00
vadimt
ff39fd3e14 Removing workaround for battery defender
The bug is supposed to be fixed.

Bug: 151613234
Change-Id: I8e803ead29e08e68fa75f61b5ad0e1198c9228ec
2020-10-22 11:14:10 -07:00
Alistair Delva
087a9e39b6 Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ..."
Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert submission 12738409-merge_ub-launcher3-master_6877130

Reason for revert: Introduced crashes to global presubmit

Reverted Changes:
I624658ce6:Merge commit '8d14dbe041199d611839140f1c9285fd4174...
Iccd2f1e3a:Merging from ub-launcher3-master @ build 6877130
I791d64951:Merging from ub-launcher3-master @ build 6877130
Icdd32ab01:Merging from ub-launcher3-master @ build 6877130

Bug: 169963211
Change-Id: I77a4ae59e823147beae8dd7cb9b54ccdace2c7f4
2020-10-05 14:46:26 +00:00
Matt Casey
49a94be109 Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' into merge_ub-launcher3-master_6877130
Change-Id: I624658ce682b55042a12faacd4cf0cfd5d3a9a56
2020-10-01 18:55:38 +00:00
Samuel Fufa
9fa2d8812a Resolve race condition between @Before conditions
Bug: 159671700
Change-Id: I5c96c32c171b7b539ce0ea799cf45955c2bee670
2020-09-30 10:57:04 -07:00
Samuel Fufa
e806f95349 Additional logs to resolve flaky work profile
Bug: 159671700
Change-Id: I9bed08ef89b06f79ee1e6a4140a880eeeb76ee75
2020-09-22 12:57:45 -07:00
vadimt
b1ee0a020f Remove tracing for a non-repro flake
Change-Id: I53cc5020435bb3b630754a77d73590b35b595407
2020-09-17 11:53:44 -07:00
Treehugger Robot
ece21e957e Merge "optimization of searching apps in Chinese" am: a0357329e0 am: f655c6e433 am: b634086d6c am: 27ae39420e am: 44150f8da4
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1425241

Change-Id: I1b270e7153c41789fb6a7eba88f29b0baa27780e
2020-09-17 14:52:29 +00:00
Treehugger Robot
44150f8da4 Merge "optimization of searching apps in Chinese" am: a0357329e0 am: f655c6e433 am: b634086d6c am: 27ae39420e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1425241

Change-Id: Ic0b8025774c0c62e039ea9edd6f8f0e545107488
2020-09-17 14:12:18 +00:00
zhaoguomanong
97cc6df21d optimization of searching apps in Chinese
Signed-off-by: zhaoguomanong <zhaoguomanong@gmail.com>
Change-Id: Id322eb8b5249d6163da8a5d3476a6cf9500ad6bb
2020-09-10 22:58:15 -04:00
Mehdi Alizadeh
4595166bf5 Merging from ub-launcher3-master @ build 6767682
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6767682.html

Change-Id: I5e9c73a7ac3033fe82006c4bd72824f56b8988f8
2020-08-16 12:31:21 -07:00
Hyunyoung Song
bb71582658 Merge remote-tracking branch 'goog/ub-launcher3-master' into temp
Test: make builds

Change-Id: I4e845aa51c9247328159e5aa0d95d425bffa435c
2020-08-06 11:04:41 -07:00
Raman Tenneti
ab98166c36 AOSP/Launcher3 - Update language to comply with Android's inclusive language guidance.
See https://source.android.com/setup/contribute/respectful-code for reference

BUG=161896447

Test: make and Presubmit verify.

Change-Id: I44e903046dd4cd9c7c07872fc56a8d552eb09522
2020-08-04 00:35:03 +00:00
TreeHugger Robot
cb89edcbcc Merge "Changing minimum supported Launcher version to 26" into ub-launcher3-master 2020-08-03 22:24:14 +00:00
Yuchen He
30caccbbc2 Enable memory dump for Launcher
Bug: 154772063
Change-Id: I3b2bc2e341037746891658f2596999248ec272ef
(cherry picked from commit 12baaadeca)
2020-07-31 17:07:56 +00:00
Hyunyoung Song
45c0918f47 Merging ub-launcher3-rvc-qpr-dev to rvc-qpr-dev
Bug: 162366734
Test: system image builds

Change-Id: I6675431b180976798afacc7a99251ae36764a50a
Merged-In: Ibff46b3ef7ff89accb459db323f31179adb4ef21
2020-07-30 00:26:39 -07:00
Sunny Goyal
eaf7a95546 Changing minimum supported Launcher version to 26
Change-Id: I49fcf874430ac53c3246371e179fbd828e14e4da
2020-07-29 17:30:19 -07:00
TreeHugger Robot
89b670056f Merge "Moving all-apps predictions to Launcher model" into ub-launcher3-master 2020-07-29 22:02:59 +00:00