Commit Graph

5524 Commits

Author SHA1 Message Date
Thiru Ramasamy
dde19ea64d Rename "ONE_SEARCH" attributes to "WEB_SEARCH"
* Minor fix to logging

Bug: 210792253
Test: manual
Change-Id: Ib32b945e1fa7696b3b8360dae01e1bd00295ff8d
2022-04-01 23:10:43 +00:00
Jeremy Sim
db92b5d73f Merge "Fix issue with camera overlapping split staging UI" into tm-dev 2022-03-26 19:41:48 +00:00
Jeremy Sim
b8eeb41ee0 Fix issue with camera overlapping split staging UI
Fixes an issue on some devices where initiating a split in Overview would cause an icon to be placed partly under the camera cutout.

Fixed by adding some padding to FloatingTaskView#mSplitPlaceHolderView, so that it always respects the device's insets.

Fixes: 220997064
Test: Manual
Change-Id: I7270bde3320f562519ea8e36a38e49609e0d6cd7
2022-03-25 16:31:46 -07:00
Chavi Weingarten
ba653b3b92 Merge "Replace consumeNextDraw with SurfaceSyncer" into tm-dev 2022-03-25 22:08:17 +00:00
Evan Rosky
5a7d6e93af Merge "Implement switchtoScreenshot recents callback" into tm-dev 2022-03-25 21:26:12 +00:00
Tony Wickham
59d4896635 Merge "Don't recreate taskbar on rotation" into tm-dev 2022-03-25 16:14:04 +00:00
Nicolò Mazzucato
286dd249e0 Merge "Tune fold animation on top of apps" into tm-dev 2022-03-25 09:31:10 +00:00
Vinit Nayak
7ac2116fcc Merge "Hide taskbar when launcher receives nav and keyguard showing" into tm-dev 2022-03-24 22:01:15 +00:00
Evan Rosky
e81d9679c1 Implement switchtoScreenshot recents callback
This lets the recents animation trigger a switchToScreenshot
to avoid premature live-tile disappearance.

Bug: 223321653
Test: put app in pip, open another app, go to recents, expand pip
Change-Id: I7ddcd891978fca7e91d7d90c1c8d9b824f5652a6
2022-03-24 14:13:59 -07:00
Sebastián Franco
1c11c5319c Merge "Task thumbnail background is spilling to the front, making the BK 1px smaller to fix it" into tm-dev 2022-03-24 18:17:39 +00:00
Tony Wickham
3b7a391c2b Don't recreate taskbar on rotation
This was a regression due to ag/17241303, since technically the size changes when rotating (width and height swap). Now we detect that case and don't recreate, but instead propagate the new DeviceProfile via TaskbarActivityContext#updateDeviceProfile()

Test: Open an app, rotate device, ensure taskbar isn't recreated. Changing properties such as dark theme does still recreate taskbar.
Bug: 219981733
Change-Id: Ic827c8e697a284a085609ea8653d77900686306a
2022-03-24 10:35:10 -07:00
TreeHugger Robot
181f803258 Merge "Prevent removing the feedback view and callbacks when the user completes a gesture." into tm-dev 2022-03-24 12:17:42 +00:00
Nicolo' Mazzucato
ff84d2bc66 Tune fold animation on top of apps
On top of apps, the fold animation is triggered only after a threshold. On Launcher, there is not threshold.

In this way, we don't show fold animation while apps might be handling table top/half_folded state.

+ timeout to finish the animation made shorter

Test: atest DeviceFoldStateProviderTest
Bug: 225185239
Change-Id: I5adf82e853af9a5dee5af41a853abb84c9926ccd
2022-03-24 11:31:51 +00:00
Hongwei Wang
ca9f9ebec5 Merge "Hide the Taskbar when user leaves PiP mode" into tm-dev 2022-03-23 22:38:48 +00:00
Vinit Nayak
c750e3d3aa Hide taskbar when launcher receives nav and keyguard showing
* On large screen we receive notification shade expanded
signals even on keyguard.
* Add a check to not show taskbar if keyguard is showing

Fixes: 223465924
Test: Taskbar doesn't show on 3 button nav except
on bouncer, as expected.

Change-Id: I4a7ea14422eda13ae8571793ed7ba1a1964072d6
2022-03-23 14:09:25 -07:00
Sebastian Franco
12db27fe34 Task thumbnail background is spilling to the front, making the BK 1px smaller to fix it
This change ag/17003268 was meant as a solution for b/146521490 but
it's ineficient so this other solution is simpler and more performant.

This solution only makes the background 1px smaller and that prevents
it from spilling in the Anti Aliasing.

Test: Put Telegram in recent Task (shouldn't be the first one) and you won't see a white border. Also when a task was in multitask the backgroudn should be draw.
Fix: 223761979
Change-Id: I6855e9ecce1e06f7a9311c62a038d34b04fe2398
2022-03-23 13:11:20 -07:00
Sebastián Franco
da297fb0f1 Merge "Revert "Combining the Thumbnail bitmap with the background to fix background spilling in the front."" into tm-dev 2022-03-23 20:01:42 +00:00
Schneider Victor-tulias
c7dee917db Prevent removing the feedback view and callbacks when the user completes a gesture.
Touching the screen immediately removed the feedback view and any callbacks attached. When the user successfully completed a gesture, one of those callbacks progresses the tutorial to its next step.

Fixes: 226028473
Test: manual
Change-Id: Ic432a5b73aa4410cb0188f50a57e3df637afb52d
2022-03-23 11:08:08 -07:00
Tracy Zhou
f3d81b0a1c Merge "Fix thumbnail disappearing during staged split animation" into tm-dev 2022-03-23 16:06:37 +00:00
Vinit Nayak
aa2f879c55 Merge "Null out mRemoteTargetHandles when swiping to home" into tm-dev 2022-03-23 14:58:19 +00:00
Tracy Zhou
67bc75a8a9 Fix thumbnail disappearing during staged split animation
Previous set the thumbnail view to be visible initially. After deciding not to do so, forgot to put the visibility statement back. Also the transform matrix needs to reset before posting new scales.

Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/6576df3a-6d14-4b7e-8fb2-1c0a335472e4
Fixes: 194414938
Change-Id: I25fe39ea99943a3c1e2257681df3eb379bc30e51
2022-03-22 22:01:27 -07:00
Vinit Nayak
1d6058c2cd Null out mRemoteTargetHandles when swiping to home
* Also all null check when trying to show divider
after swipe down animation from overview

Fixes: 223946009
Test: Steps in bug no longer cause crash
Change-Id: I2c8484c37b863c4cb6aba7e274c1eb76bce92b4a
2022-03-22 20:47:54 -07:00
Hongwei Wang
808d568367 Hide the Taskbar when user leaves PiP mode
This is to prevent the Taskbar from flickering when the app settles in
full-screen mode.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/dIgvinb9yEB8MYfYDx0Ijy
Bug: 218450853
Test: see video
Change-Id: I9cfb0ca151dea6951561f78798bb16bafa48eba0
2022-03-22 18:45:31 -07:00
Tracy Zhou
53ad207008 Use topComponent to get package name
task.topActivity can be null

Fixes: 226232720
Test: manual
Change-Id: I7d0c928871d01402bf41bc96514aae7854045baf
2022-03-22 17:13:52 -07:00
Tracy Zhou
8d06bb8991 Merge "Update initial staged split UX." into tm-dev 2022-03-22 22:44:33 +00:00
TreeHugger Robot
6c7b0f7db8 Merge "Fix issue cauing the taskbar to show in the all set page of the SUW." into tm-dev 2022-03-22 20:25:32 +00:00
Hongwei Wang
1acabce45b Merge "Add auto-enter-pip support in FallbackSwipeHandler" into tm-dev 2022-03-22 20:07:55 +00:00
Schneider Victor-tulias
44aadeaef6 Fix issue cauing the taskbar to show in the all set page of the SUW.
Some missing state handling was causing the taskbar to show in the all set page of the SUW.

Fixes: 218507703
Test: build change, flashed and factory reset device
Change-Id: If3a280ef6416f0821cf6a9b1ab0a65d58c5c8221
2022-03-22 10:50:26 -07:00
Brian Isganitis
98214d072c Merge changes from topics "presubmit-am-08ca1fad1fe94bf3ace5a708c5584d55", "presubmit-am-3c6c58a0fa374b92b1a5f8d5f5788871", "presubmit-am-6939eac1469540108813bd4ed4c60a9b" into tm-dev
* changes:
  Have taskbar all apps extend ActivityAllAppsContainerView.
  Refactor ActivityAllAppsContainerView to depend on ActivityContext.
  Refactor allapps.search package to depend on ActivityContext.
2022-03-22 16:11:35 +00:00
Vinit Nayak
b85e0afe70 Merge "Keep live tile running when TaskMenuView is showing" into tm-dev 2022-03-22 04:48:43 +00:00
Tracy Zhou
4ff3615b23 Update initial staged split UX.
- Introduce inset to the staged split view
- Update width of the staged split view
- Introduce rounded corners to staged split view. It's tricky to animate it in with smooth transition considering the rounded corners. The best way to handle it is to draw content as if part of it is off the screen, so that when it's animated in, the rounded corners can slide in onto the screen correctly.

Fixes: 219085340
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/09a99b75-3614-4d20-b6d4-a78108f769d8

Change-Id: I24d90cc9e2695d822cb2de8b21e2d5519f2e344d
2022-03-21 21:21:42 -07:00
Vinit Nayak
a5addf0e89 Keep live tile running when TaskMenuView is showing
* Doesn't fix the bug, but a nicer UX to have

Bug: 223317893
Test: Live tile was running after tapping app icon.
Was able to enter split just fine

Change-Id: I50c5d5623546d19d216beae09b76c310e8b3c815
2022-03-21 18:15:28 -07:00
Jeremy Sim
c789ade45e Merge "Fix crash condition by adding a null check in DigitalWellBeingToast" into tm-dev 2022-03-22 00:39:47 +00:00
Jeremy Sim
7a84442436 Merge "Fix UI overlap when rotating in split select mode" into tm-dev 2022-03-22 00:17:43 +00:00
Jeremy Sim
8746367f40 Merge "Fix paired icon placement in landscape/seascape" into tm-dev 2022-03-22 00:17:43 +00:00
Hongwei Wang
ad9c83966b Add auto-enter-pip support in FallbackSwipeHandler
- Deprecate HomeAnimationFactory#supportSwipePipToHome and treat 3rd
  party Launcher supporting auto-enter-pip transition as well
- Add a new FallbackPipToHomeAnimationFactory if auto-enter-pip
  transition is to be launched
- Make sure Launcher is resumed at the end of auto-enter-pip transition
  to actually trigger the PiP task appearing

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/hMPkRXy4vAjC6sQYUIIWUP
Bug: 220665901
Test: `m -j Launcher3` and verify the auto-enter-pip transition \
      see also the video
Change-Id: I6d16f2559d173f695ccbc743eb55e964bf088d04
2022-03-21 14:39:23 -07:00
Sebastián Franco
02458386cf Revert "Combining the Thumbnail bitmap with the background to fix background spilling in the front."
This reverts commit 5a9dce518e.

Reason for revert: The solution is inefficient. There is already a solution in ag/17060224

Change-Id: I5b5862f1ae426c78062c5a0f481abfb13b3060cc
2022-03-21 20:26:21 +00:00
Vinit Nayak
68d5dd82db Merge "Use ComponentCallbacks to recreate on fold/unfold" into tm-dev 2022-03-21 19:05:52 +00:00
Vinit Nayak
c55c94880e Merge "Limit the number of commands in OverviewCommandHelper" into tm-dev 2022-03-21 18:49:42 +00:00
Alex Chau
c9f3cc36bb Merge "Update overview grid icon sizes and paddings" into tm-dev 2022-03-21 17:08:31 +00:00
Jon Miranda
d17cb2722c Merge "Allow depth animation when user swipes back to home." into tm-dev 2022-03-21 15:33:08 +00:00
Kholoud Mohamed
ac0574781c Merge "RESTRICT AUTOMERGE Moved enteprise resource updatability to Launcher3" into tm-dev 2022-03-19 06:30:09 +00:00
Jeremy Sim
b4b79142d8 Fix UI overlap when rotating in split select mode
Fixes an issue where you could trigger a UI overlap by rotating the phone during split select. The issue occurred because devices with insets were calling TaskView#resetViewTransforms during rotation, and not accounting for the fact that an extra transform was applied for split staging.

Fixes: 220998096
Test: Manual test on inset and non-inset devices
Change-Id: I2d6c969231127aa16c9eae39cf69e08ceb96c44b
(cherry picked from commit 51bfabf8b7)
2022-03-19 00:10:44 +00:00
Jeremy Sim
b42345273c Fix paired icon placement in landscape/seascape
In grouped task view, paired icons will now align better with task thumbnails.

Fixes: 218783211

Test: Extensive manual testing on local device(s).
Change-Id: I372d2ee90302a8d96ace048ff4f82126d9b2b363
(cherry picked from commit d6826c74a4)
2022-03-19 00:10:16 +00:00
Jeremy Sim
64212c5439 Fix crash condition by adding a null check in DigitalWellBeingToast
Fixes a crash condition where TaskView#getRecentsView() could return null when being called from DigitalWellBeingToast#setBanner(), resulting in a crash.

Fixes: 217671133

Test: Manual
Change-Id: I964384d97d26336e9a5e8e4c025f66ab78c63e0a
2022-03-18 16:55:17 -07:00
Brian Isganitis
d478f555cb Have taskbar all apps extend ActivityAllAppsContainerView.
This step is necessary to have taskbar support search in all apps.
Search is not ready yet, so a fallback search manager is included.

Test: Manual
Bug: 216683257
Change-Id: Id118388bc4baae4b63ef205295caf46cbd541bc8
2022-03-18 15:39:54 -07:00
chaviw
29b8135260 Replace consumeNextDraw with SurfaceSyncer
Test: Builds
Bug: 200284684
Change-Id: I46e9cd89fd6b7c767bb867205400197b305e86a8
2022-03-18 16:20:42 -05:00
TreeHugger Robot
f1543cb520 Merge "Small improvement for ag/17016891 (unstash taskbar input area size)" into tm-dev 2022-03-18 18:38:42 +00:00
Jon Miranda
f6780f66c3 Allow depth animation when user swipes back to home.
Bug: 221196062
Test: open app, swipe back to home, ensure blurs
Change-Id: I9faff4e41c2e8d22df72e41c7753e2090fa0973d
2022-03-18 09:58:55 -07:00
Vinit Nayak
38397e46cf Limit the number of commands in OverviewCommandHelper
* Rapidly tapping recents button in 3 button nav
puts launcher in a strange state.
Reproing and understanding that state is complex
since so many state transitions are rapidly happening.
* Easier to limit the number of commands a user
will perform for valid use-cases.

Fixes: 207680265
Test: Rapidly pressing recents when unfolded
doesn't show live tile task on workspace.

Change-Id: I7db849e83c2cafc37a419e189479283f2057bde6
2022-03-17 16:26:56 -07:00