Commit Graph

3120 Commits

Author SHA1 Message Date
Kevin Lim
c3909d970b Merge "[Tiger] Re-adding PlatinumTest annotation" into main 2023-11-10 21:56:12 +00:00
Vadim Tryshev
d315ffcb8f Merge "Increasing wait time for Launcher restart after enabling test provider" into main 2023-11-10 19:58:20 +00:00
Vadim Tryshev
a333756f0c Increasing wait time for Launcher restart after enabling test provider
Of the the logcats indicates that Launcher gets killed eventually, but
it takes 17 sec, while the test waits for the Launcher restart to
compete in 10 sec.

Perhaps restart take longer than usual because the system is still busy
killing setup wizard.

Bug: 308489613
Test: presubmit
Flag: N/A
Change-Id: Idd576cacc300bce071bb40743209b4a111f18473
2023-11-10 10:31:14 -08:00
Pat Manning
da5baa981a Merge "Fix focus nav of AllApps when Searching." into main 2023-11-10 18:20:01 +00:00
Pat Manning
e7cb65009e Fix focus nav of AllApps when Searching.
- Do not focus the Icon in Small Icon Result Rows
- Use FocusIndicatorHelper when focusing search result icons

Flag: NONE
Bug: 296844600
Fix: 310173226
Test: Test: TaplKeyboardFocusTest
Change-Id: Icfc82ae41ffc8ef7c7ad42950f98f3d2dc805795
2023-11-10 16:48:21 +00:00
Kevin Lim
9bb62ee9c1 [Tiger] Re-adding PlatinumTest annotation
This undoes ag/24559527 as this test is no longer flaky.

Actual PlatinumTest presubmit restoration is done in cl/581071347

Bug: b/293944634
Flag: N/A
Test: Test only change
Change-Id: I605f8911fa3a3658c49642efee8d6166545ae89b
2023-11-10 01:37:15 +00:00
Uwais Ashraf
8e1e2a5155 Merge "Use instrumentation arg to prevent unnecessary delays in unit tests" into main 2023-11-09 16:03:20 +00:00
Uwais Ashraf
b5d08b246e Use instrumentation arg to prevent unnecessary delays in unit tests
Bug: 308792359
Flag: NA
Test: presubmits passing
Change-Id: Ib38db86057998fcf859a44fa190e6cc4d82263dd
2023-11-09 12:07:18 +00:00
Vadim Tryshev
572b5b09fd Merge "Allowing ACTION_CANCEL events to come from device 0" into main 2023-11-09 01:42:16 +00:00
Vadim Tryshev
a3f581d733 Merge "Diagnosing when Launcher is in invalid state" into main 2023-11-09 01:40:03 +00:00
Vadim Tryshev
7a1beb559f Allowing ACTION_CANCEL events to come from device 0
Tests assert that input events come to Launcher only from tests, which
sets deviceId to 0. This way, we spot when a cable touches a lab device
and breaks the tests, in which case deviceId will be != -1.

But CANCEL event, which is programmatic, now can legitimately come from
device 0.

Bug: 308489875
Test: presubmit
Flag: N/A
Change-Id: I84ee9ed8e008043f83e82d57b17b64a10677ee8d
2023-11-08 13:20:57 -08:00
Vadim Tryshev
f0732e73d5 Merge "Workarounding setup wizard non-disappearance only in presubmit" into main 2023-11-08 20:29:00 +00:00
Vadim Tryshev
1c8e30b54c Merge "Making keyguard dismissal a permanent solution" into main 2023-11-08 20:24:11 +00:00
Jordan Silva
72bc6f53f7 Merge changes from topic "comet-landscape" into main
* changes:
  Update Responsive Grid tests with aspect ratio group
  Refactoring Responsive Grid XML specs for more flexibility
2023-11-08 11:16:21 +00:00
Vadim Tryshev
84aa57b2d1 Diagnosing when Launcher is in invalid state
Due to bugs, Launcher may end up showing incorrectly, i.e. Launcher app
is present, but no workspace, all apps etc is visible.
Improving diagnostics when this is the case.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ibd0228bd26d2ba9ad710895ed8d2e5ece294db21
2023-11-07 16:22:58 -08:00
Vadim Tryshev
e5a1b89220 Making keyguard dismissal a permanent solution
Before, it was considered to be a workaround while System UI has
keyguard bugs. But these bugs will happen in future, and they are
unlikely to be prevented by presubmit tests since they are usually flakes.

The solution that this CL makes permanent is: in presubmit attempt
to unlock SysUI if it's locked. In postsubmit, just make sure it's
unlocked. This way, in postsubmit, we'll know whether tere are active
keyguard bugs.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ia9602bc6e9cc8400e939051c45aba92bc197d428
2023-11-07 14:45:58 -08:00
Vadim Tryshev
341e5598b5 Workarounding setup wizard non-disappearance only in presubmit
In postsubmit, we want to see the actual behavior to be aware of real e2e issues.

Bug: 309008042
Test: presubmit
Flag: N/A
Change-Id: Icedf381545dda32ea1dbdd8d215581265627bf3f
2023-11-07 12:33:21 -08:00
Federico Baron
bc1d5791cd Merge "Ensure shortcuts show up in widget picker screenshot test" into main 2023-11-07 16:53:53 +00:00
Jordan Silva
d7c7eaf837 Update Responsive Grid tests with aspect ratio group
Adding aspect ratio group and updating the responsive grid tests to match the refactored classes.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: AllAppsSpecsTest
Test: CalculatedAllAppsSpecTest
Test: HotseatSpecsTest
Test: CalculatedHotseatSpecTest
Test: WorkspaceSpecsTest
Test: CalculatedWorkspaceSpecTest
Test: ResponsiveFolderTest
Test: CalculatedFolderSpecTest
Change-Id: I918f4e28eb310bc9300fc6cc2b5b2af67d758a96
2023-11-07 11:51:28 +00:00
Himanshu Gupta
7d56e6ea23 Merge "Adding Prework for Private Space integration in Launcher" into main 2023-11-07 08:45:41 +00:00
Vadim Tryshev
06de17be39 Merge "Adding a TODO to productize killing/dismissal of setup wizard" into main 2023-11-06 22:19:23 +00:00
Vinit Nayak
b16e4d8e18 Merge "Cleanup logs" into main 2023-11-06 22:16:48 +00:00
Vinit Nayak
cca9148c68 Cleanup logs
Flag: None
Test: None
Fixes: 302551868
Change-Id: I617358b8c9ed3293efacff47ad3b1d7b275d5865
2023-11-06 12:45:56 -08:00
Vadim Tryshev
ca90b8d7d9 Removing assert that setup wizard is visible
Bug: 309496273
Test: presubmit
Flag: N/A
Change-Id: Ie6b77673c120a94d211662c71467635923dda622
2023-11-06 12:38:35 -08:00
Vadim Tryshev
a7e283b605 Adding a TODO to productize killing/dismissal of setup wizard
Bug: 309471958
Test: presubmit
Flag: N/A
Change-Id: I8ef3a7310829333132b03453dbb6f3c37b88c364
2023-11-06 10:31:29 -08:00
Vadim Tryshev
8b1881223b Merge "Waiting for the setup wizard to go away" into main 2023-11-06 18:17:46 +00:00
Himanshu Gupta
9aab4d4603 Adding Prework for Private Space integration in Launcher
This Cl adds the following:
1. Fixes for Quite Mode check maintained by Launcher
2. Addition of new Quite Mode broadcasts
3. Fixes for determining work profile user correctly.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I5f6158b213723339e70ff99e66c5f439f5879e12
2023-11-05 12:31:10 +00:00
Vadim Tryshev
0fe753af2a Waiting for the setup wizard to go away
This is a workaround for b/309008042 where it appears that after being
dismissed by the test infra, setup wizard doesn't immediately go away.

This CL will wait 2 minutes for the dismissal, and provide a better
diags when the wizard doesn't go away after 2 min.

Bug: 309008042
Test: presubmit
Flag: N/A
Change-Id: I26eb2f202842702af08c424929d74fbd21eb872d
2023-11-04 21:37:25 -07:00
Priyanka Advani
ebc9a3b5e1 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-11-03 22:10:27 +00:00
Priyanka Advani
9aed56096c Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Reason for revert: Likely culprit for b/309158105

Reverted changes: /q/submissionid:24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Change-Id: I8ee560f7e599bcfde09eff53f049309ba25ce77f
2023-11-03 21:31:45 +00:00
Pat Manning
89bd90927d Merge "Fix focus navigation of All Apps when using external keyboard." into main 2023-11-03 18:42:37 +00:00
Tony Wickham
075a67da15 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-11-03 18:35:54 +00:00
Alex Chau
9c07fc1350 Re-land "Update Tapl tests for enable_grid_only_overview"
- Fix getCurrentTask() to correctly get the top-right tasks in grid only overview. It'll first get the widest task, and then top, and then rightmost task
- Fix scrollLeftByDistance() to correctly account for leftGestureMargin to make sure it scroll by distance provided
- Fix scrollCurrentTaskOffScreen() to actually scroll the task off screen
- Fix createAndLaunchASplitPair() to use Task menu instead of Overview actions for grid only overview
- Skip testOverviewActions() in grid only overview, where Overview actions isn't available
- Fix testOverivewForTablet to expect the correct task in grid only overview; also disabled part of a test due to an animation bug in Overview
- Fix dismissBySwipingUp() to swipe from bottom of task, which is required to effectively dismiss top row tasks
- Also fixed OverviewTask to correctly get objects in FallbackOverview
- Fix touchOutsideContainer() to calcualte y base on container's middle correctly

Bug: 283246928
Test: presubmit
Flag: None
Change-Id: I77e91dcc1a404ade356b29fba6cf967c534c08f4
2023-11-02 22:37:26 +00:00
fbaron
1bc36b93b4 Ensure shortcuts show up in widget picker screenshot test
Bug: 295901350
Flag: NONE
Test: WidgetPickerImageTest
Change-Id: Ib16739aa04838a6f133cf2728dbb3fcd52a9c2ed
2023-11-02 17:49:40 +00:00
Alex Chau
39c548bd03 Merge "Revert "Update Tapl tests for enable_grid_only_overview"" into main 2023-11-02 13:36:34 +00:00
Sam Dubey
0552d37f34 Revert "Update Tapl tests for enable_grid_only_overview"
Revert submission 25220083-b/283246928

Reason for revert: b/308930958

Reverted changes: /q/submissionid:25220083-b/283246928

Bug: 283246928
Change-Id: I69ce128061f7ffad213f8f193122b18e5ee9378d
2023-11-02 13:33:55 +00:00
Alex Chau
25cd358a27 Merge "Update Tapl tests for enable_grid_only_overview" into main 2023-11-02 11:06:03 +00:00
Tony Wickham
eccf070bae Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ib6e592a31a55a912a7ea991a421a9c60bca51c80
2023-11-01 23:16:10 +00:00
Vinit Nayak
a0ed884dfd Merge "Add logs when sysuiProxy clears binder refs" into main 2023-11-01 22:49:17 +00:00
Alex Chau
3029b8314e Update Tapl tests for enable_grid_only_overview
- Add "task" as id for TaskView, and use it instead of "snapshot" when creating OverviewTask, so that for split tasks are caputred as a whole in getCurrentTask and getTasks
- Fix getCurrentTask() to correctly get the top-right tasks in grid only overview. It'll first get the widest task, and then top, and then rightmost task
- Fix scrollLeftByDistance() to correctly account for leftGestureMargin to make sure it scroll by distance provided
- Fix scrollCurrentTaskOffScreen() to actually scroll the task off screen
- Fix createAndLaunchASplitPair() to use Task menu instead of Overview actions for grid only overview
- Skip testOverviewActions() in grid only overview, where Overview actions isn't available
- Fix testOverivewForTablet to expect the correct task in grid only overview; also disabled part of a test due to an animation bug in Overview
- Fix dismissBySwipingUp() to swipe from bottom of task, which is required to effectively dismiss top row tasks
- Also fixed OverviewTask to correctly get objects in FallbackOverview

Bug: 283246928
Test: presubmit
Flag: None
Change-Id: I5dd39b1779ea02738556f921169dbe38aa4cba8c
2023-11-01 22:15:12 +00:00
Vadim Tryshev
864c02a47d Merge "Clean up comment" into main 2023-11-01 21:39:42 +00:00
Thales Lima
9623aaa470 Merge "Change AllApps padding to use a Rect" into main 2023-11-01 12:21:53 +00:00
Vadim Tryshev
5ad63608f7 Clean up comment
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ibe17cd8142689598db1ce5700ef122b67b37e1a7
2023-10-31 15:49:52 -07:00
Stefan Andonian
7117c55578 Merge "Robustly fixed issue where migration from different versions of DB data tables was causing crashes upon grid size switching." into main 2023-10-31 22:44:06 +00:00
Stefan Andonian
e8b86db34d Robustly fixed issue where migration from different versions of DB data
tables was causing crashes upon grid size switching.

Bug: 304687723
Test: Verified behavior through unit test. Also manually tested that
factory resetting device -> adding shortcuts to the workspace ->
changing the grid size didn't cause any issues and resulted in normal
behavior.

Change-Id: I1945004d2c9a2d6f2b74d9597b39763ed4962e7b
2023-10-31 20:27:26 +00:00
Thales Lima
b433c9c312 Change AllApps padding to use a Rect
AllApps uses different values for left and right padding in some places (e.g. ActivityAllAppsContainerView uses workspacePadding.left/right), and this change is the first step into moving those values into DeviceProfile.

Bug: 269632571
Test: NexusLauncherTest
Flag: NONE
Change-Id: I14c4edf55ca74f256b1aaa336fff246a0c78e25d
2023-10-31 16:19:40 +00:00
Uwais Ashraf
4fc9a1001f Replace usage of deprecated initAllFlagsToReleaseConfigDefault() method
Bug: 306088813
Flag: NA
Test: Presubmits passing
Change-Id: Iff852702424f4e18c67a6bd3b110beb528b39e3b
2023-10-31 15:31:18 +00:00
Pat Manning
b53d8d6360 Fix focus navigation of All Apps when using external keyboard.
- All apps icons do not show the focus rectangle when focused as mIconFocusListener is null in BaseAllAppsAdapter when onCreateViewHolder is called.
- All apps recyclerview does not scroll down when focus goes from top to bottom of list, as AllAppsToastUiDelegate calls hideKeyboard which clears focus.
- Focus goes behind AllApps into hotseat, so update hotseat setDescendantFocusability.

Flag: NONE
Fix: 296844600
Test: TaplKeyboardFocusTest
Change-Id: I65f6fbb6f4df0be4b4ff922dda267d27da16effe
2023-10-31 13:47:12 +00:00
Vinit Nayak
d1e9cacfdc Add logs when sysuiProxy clears binder refs
Bug: 302551868
Flags: None
Change-Id: Iec9fc3cd52a3e3bac0ba61d0f38dbc05933e573c
2023-10-30 16:13:51 -07:00
Jeremy Sim
1819868da9 Merge "Fix bug with TAPL tests not recognizing full height/width of split tasks" into main 2023-10-30 21:53:58 +00:00