Commit Graph

11392 Commits

Author SHA1 Message Date
Sihua Ma
ff0f98dd03 Clear drag views during swipe up animation progress
This is to avoid clearing it too lately, at a point where the user starts to see a flicker on the screen.

There was already a report of this bug. Filing a bug report on my own because the original one is hard to find. I will mark that as fixed once I find it again.

Test: Manual
Fix: 259157574
Change-Id: Idc9bb67ebf6fc3ff6d78880f28c46d916a02ab77
2022-11-17 13:52:26 -08:00
Schneider Victor-tulias
193f8992f1 Merge "Fix null-pointer exception in all set activity first reveal animation" into tm-qpr-dev 2022-11-17 21:47:18 +00:00
Ats Jenk
4b4e4a39df Add onTaskMovedToFront to close floating views
Fixes a bug with allapps not being closed if the launching activity does
not trigger a onTaskStackChange callback. For example this is the case
when allapps launches a task in freeform mode. In this case the previous
task is still visible and won't be paused. The onTaskStackChange
callback is not triggered. Leaving the allapps view visible.

Bug: 259264346
Test: enable destop mode, open gmail, open allapps and open chrome,
  observe allapps view is closed
Change-Id: I5e60baa15ebc04b5094a84ed977eb9f3bc73d4a6
2022-11-17 13:09:19 -08:00
Brian Isganitis
61b01e2c2a Add a11y titles for taskbar windows.
Test: Manual with Talkback.
Fix: 228389333
Change-Id: If30311166fde155d04cf1c9a6865c98d380a93ea
2022-11-17 20:56:04 +00:00
Stefan Andonian
a04de842d1 Fix ConcurrentModificationExceptions during binding.
The same lists of extra items stored in BgModelData are also stored in
UI components. This is causing ConcurrentModificationExceptions. The
solution is to clone these lists or mark them as immutable before storing
them in their respective components.

Bug: 206918543
Test: Verified that crash no longer occurs after fix.
Change-Id: I571a2c451af58137aa7513b372b6a8ecf9bd3ff6
2022-11-17 20:46:51 +00:00
Schneider Victor-tulias
6386d4b55b Update All set page subtitle to use the same device name used acrss the SUW
Fixes: 252972556
Test: launched the all set page on a large screen, foldable and phone
Change-Id: Id6cb86ff85aeb1453f96e707dc4921d23513c406
2022-11-17 10:58:55 -08:00
TreeHugger Robot
1eb1e03651 Merge "Check NPE and log error condition for enableBlockingTimeout in test harness." into tm-qpr-dev 2022-11-17 18:33:23 +00:00
Stefan Andonian
146701ca3e Move SharedPreferences code to its own class.
Bug: 251502424
Test: Code compiled correctly.
Change-Id: Iea0d6ab2999504117546ee0f7adc0c7b8b45c065
2022-11-17 17:22:47 +00:00
Pat Manning
33fa3ffeec End live tile when quick settings expands, not just notification shade.
This is needed for split-shade and for two-finger pull down of shade which goes directly to quick settings.

Fix: 256090552
Fix: 259417195
Test: manual
Change-Id: Ief28ae69d4142ddabb4d4b1a9f821abecd81be1e
2022-11-17 14:47:52 +00:00
Alex Chau
aee9c12a8b Fix janky close animation when taskbar is unstashed
- Updated startRect for close animation when taskbar is unstashed

Fix: 258167450
Test: Use back gesture to close app when taskbarw is stashed or unstashed
Change-Id: I56913c2770024bcb47a74c28941bc59f60b4666b
2022-11-17 10:57:40 +00:00
Pat Manning
50b335fbba Set grid progress even when task count is 0.
Fix: 256090552
Test: manual
Change-Id: I2a0ccaf007af71bbe3338453553a7dff59a7d6d2
2022-11-17 10:55:34 +00:00
Tracy Zhou
a71d353ff8 Merge "Implement split from workspace to workspace" into tm-qpr-dev 2022-11-17 07:04:48 +00:00
Jeremy Sim
c480c268e8 Merge "Allow user to tap on stashed app to launch task in fullscreen" into tm-qpr-dev 2022-11-17 04:19:04 +00:00
TreeHugger Robot
1b30bab1e1 Merge "Update transient taskbar transition duration to match spec (417ms)." into tm-qpr-dev 2022-11-17 02:58:33 +00:00
TreeHugger Robot
3ea398ecb7 Merge "Cleaning Utilities.java" into tm-qpr-dev 2022-11-17 02:39:38 +00:00
Sihua Ma
c6bd4ad21f Merge changes If022ec8d,I34341937 into tm-qpr-dev
* changes:
  Move LauncherWidgetHolder to widget package
  Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
2022-11-17 01:46:55 +00:00
TreeHugger Robot
579ddc7aff Merge "Removing unnecessary event dispatching via touch-controller. Instead using a poll method similar to other touch controllers" into tm-qpr-dev 2022-11-17 01:22:54 +00:00
Sunny Goyal
47d4d81b4f Cleaning Utilities.java
> Removing some unused methods
> Moving some specialized methods to corresponding classes
> Removing GridProvider check as it is released

Bug: 257555083
Test: Presubmit
Change-Id: Ib0f8c673d018071d3f4b7d9247e0a35718ab009c
Merged-In: Ib0f8c673d018071d3f4b7d9247e0a35718ab009c
2022-11-17 01:06:16 +00:00
Jon Miranda
30cc324117 Check NPE and log error condition for enableBlockingTimeout in test harness.
Similar to enableTransientTaskbar changes in
ag/Ifa929dca18437ae101cf3290feda4209790604d2

This method differs from enableManualTaskbarStashing in that we call it during setup/teardown and so in these cases TaskbarActivityContext
being null may be valid. For instance, as part of the teardown,
taskbar may have already been destroyed so enabling blocking timeout
may be a moot point — adding logs can help verify that assumption.

Bug: 259337908
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I2eeb02573670a503687ca7aa364d14f3124cd0ef
2022-11-16 23:52:11 +00:00
Hawkwood Glazier
dc83786339 Update PluginManager Import
Bug: 258424862
Test: Rebuilt Launcher
Change-Id: I7a8b343533e8d8eb8fddc3683c57ece664af8736
2022-11-16 23:31:16 +00:00
Jeremy Sim
6692f78229 Allow user to tap on stashed app to launch task in fullscreen
This patch implements a new feature that allows the user to tap on the staged app rectangle in split staging mode. When the user does so, split selection will be canceled, and the staged app will animate out to fill the screen and launch in fullscreen.

Done by creating a new onClick listener on mFirstFloatingTaskView that sets up the screen-filling animation, and then calls a new RecentsView function, launchStagedTask(), that launches mSplitHiddenTaskView and cleans up RecentsView afterwards (similar to what happens when a split pair is selected, but only one app is launched).

Open issues:
- After the staged task animates out to fill the screen, the task itself loads instantly without animating in. Ideally, it should fade in, similar to what happens when two split tasks are loaded in.

Bug: 257513449
Test: Manual on tablet
Change-Id: I2ae8e13e1c9848aae1978a536766c370949fd08b
2022-11-16 15:28:31 -08:00
Sihua Ma
8bbfcb6581 Move LauncherWidgetHolder to widget package
Making LauncherAppWidgetHost package-private as well

Bug: 235358918
Test: N/A
Change-Id: If022ec8d429579a972991872b2dc11db76719341
2022-11-16 14:31:14 -08:00
Sihua Ma
aa2b872d1c Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
Test: N/A
Bug: 235358918
Change-Id: I343419376491203a195154f2766b12e5def38879
2022-11-16 14:30:08 -08:00
Sunny Goyal
6abdd5c735 Removing unnecessary event dispatching via touch-controller.
Instead using a poll method similar to other touch controllers

Bug: 259447608
Test: Verified on device
Change-Id: I5c29c7c1b87acb668ea93e9f44fb685379de54fb
2022-11-16 13:58:05 -08:00
TreeHugger Robot
17bafeecd6 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-11-16 20:59:57 +00:00
Vinit Nayak
03695ba0f2 Merge "Add test for vertical and horizontal split apps" into tm-qpr-dev 2022-11-16 20:45:01 +00:00
Jon Miranda
c3fc8da433 Merge "Check NPE and log error condition for enableTransientTaskbar in test harness." into tm-qpr-dev 2022-11-16 20:43:27 +00:00
Jon Miranda
12771e002c Merge "Revert "Revert "Allow transient taskbar to unstash over soft ime""" into tm-qpr-dev 2022-11-16 20:18:27 +00:00
Jon Miranda
f641ddd27e Revert "Revert "Allow transient taskbar to unstash over soft ime""
This reverts commit c8c81a3425.

Reason for revert: fix tests by not auto stashing when ime comes up, but still allow taskbar to show if user initiaties it

Bug: 255818649
Change-Id: Id3ab27dcc205e5a72dbd0481e3eabc10b2e1b643
Test: pull up ime, swipe to reveal taskbar
2022-11-16 16:13:26 +00:00
Jon Miranda
182d1e93dd Check NPE and log error condition for enableTransientTaskbar in test harness.
Fixes: 259337908
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: Ifa929dca18437ae101cf3290feda4209790604d2
2022-11-16 08:04:57 -08:00
Sam Dubey
b6acf00e3c Merge "Revert "Allow transient taskbar to unstash over soft ime"" into tm-qpr-dev 2022-11-16 15:20:30 +00:00
Sam Dubey
c8c81a3425 Revert "Allow transient taskbar to unstash over soft ime"
This reverts commit 9787ae6ad9.

Reason for revert: Breaking launcher tests on Tablet

Bug: 259347305

Change-Id: Idfd9e412f143370b6b8a4c6f86aac94d17bc1846
2022-11-16 11:31:55 +00:00
Bill Yi
62ecf75669 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idc8d0b1ff108bc98af48e961ee661579124da526
2022-11-16 02:38:36 -08:00
Tracy Zhou
7e0f5d8a57 Implement split from workspace to workspace
Fixes: 239824922
Test: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/b745433d-cba7-4f7a-a28d-4223d9950c0b
Change-Id: I9bfd5844bb9ccb6e65e77fedb7fbccb37692f812
2022-11-15 22:11:28 -08:00
Jon Miranda
49c7469672 Merge "Allow transient taskbar to unstash over soft ime" into tm-qpr-dev 2022-11-15 23:59:16 +00:00
TreeHugger Robot
c2f03ae080 Merge "Add ImpressionLogger to StatsLogManager" into tm-qpr-dev 2022-11-15 23:35:21 +00:00
TreeHugger Robot
87ccecb6fc Merge "Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""" into tm-qpr-dev 2022-11-15 22:31:55 +00:00
Schneider Victor-tulias
912a53e677 Fix null-pointer exception in all set activity first reveal animation
Fixes: 259296310
Test: started all set activity and started the first reveal animation
Change-Id: I371f62be81e7f28ce5ecee150abb5d294bb2264d
2022-11-15 12:12:17 -08:00
Vinit Nayak
bddda819d2 Merge "Update unsupported split app error text" into tm-qpr-dev 2022-11-15 20:06:46 +00:00
Vinit Nayak
7545f20268 Add test for vertical and horizontal split apps
* More work still needs to be done for portrait
split apps with stashed taskbar

Bug: 258714015
Test: Existing tests pass, visually saw slight
improvement in stashed portrait gesture clipping.

Change-Id: Id1b9bb28a1a2676a5da1b5e5824e0835290cb616
2022-11-15 11:23:38 -08:00
TreeHugger Robot
ab61359a81 Merge "Update string for "swipe to go home" when in button nav." into tm-qpr-dev 2022-11-15 16:30:32 +00:00
Pat Manning
39a3ac6fe5 Update string for "swipe to go home" when in button nav.
Bug: 252938555
Test: manual
Change-Id: Id52867ec6a9b82a44ab0a803a9824258d9ad4044
2022-11-15 11:19:32 +00:00
Vinit Nayak
b2711a81e6 Update unsupported split app error text
Bug: 258822425
Change-Id: I8ac24d094d14a5f65a1d83303a9fd087c76bf066
2022-11-14 15:20:25 -08:00
Schneider Victor-tulias
62b9f80d1e Merge "Return to home when overview command fails." into tm-qpr-dev 2022-11-14 20:44:52 +00:00
Jon Miranda
5eba9000df Update transient taskbar transition duration to match spec (417ms).
Bug: 246632728
Bug: 246641848
Test: manual
Change-Id: If3f73774444c6074a81101d91d291ef33edcaf9c
2022-11-14 12:28:20 -08:00
Jon Miranda
9787ae6ad9 Allow transient taskbar to unstash over soft ime
Bug: 255818649
Test: pull up ime, swipe to reveal taskbar
Change-Id: Ibae77c8a29d06093823f2421fbf851979f9babed
2022-11-14 11:30:55 -08:00
Vinit Nayak
50306445a1 Merge "Prevent dropping a drag from TaskbarAllApps in Overview" into tm-qpr-dev 2022-11-14 19:07:59 +00:00
Jerry Chang
168c204f49 Merge "Make multi-instances split opt-in based" into tm-qpr-dev 2022-11-14 13:29:46 +00:00
Anushree Ganjam
96c72745ae Add ImpressionLogger to StatsLogManager
go/toast-search-impression-logging

Bug: 204781396
Test: Manual
Change-Id: If00027581000d315590ce2fac46428cbf173da49
2022-11-11 18:23:25 +00:00
Vinit Nayak
eae4c99434 Prevent dropping a drag from TaskbarAllApps in Overview
* Don't close TaskbarAllApps once drag starts
(see comment in code regarding needing multiple shared drag
layers)
* Hide app menu split options for taskbar in overview
* One TODO is that the animation needs to be tweaked
because the scale of the icon when it's returned is too large.
* I think maybe we have to change the
TaskbarDragController#mDragIconSize since that gets directly
set from a resource. Unclear.

Test: Dragged in TaskbarAllApps in overivew and in split
select, app returned to original position and not taskbar
Bug: 251747761

Change-Id: I785f34b0bdb0b0abfc440450494074f8dfe7c31a
2022-11-10 16:17:26 -08:00