Commit Graph

6667 Commits

Author SHA1 Message Date
Vinit Nayak
a4e5a9eebe Prevent double selection of second split app
* Also fix small other bug where we were
checking only for LauncherState
OVERVIEW_SPLIT_SELECT and not for equivalent
3P RecentsState

Fixes: 227419997
Test: Repro steps don't cause bug. Yay.
Change-Id: Ibb8238185b959d22d8455b6812d29b2e268d9739
2022-04-14 11:06:47 -07:00
Hongwei Wang
5f5bd84d99 Fix flicker when entering PiP from split-screen / overview
This is a follow-up of ag/16418447 where we hide the Tasks in
split-screen mode on swipe-home-to-pip and here we use the same
mechanism when we are entering PiP from the overview and the pip-able
task is in split-screen mode.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/bNtg3ZOhuTBKm9nU9CPeNQ
Bug: 228289777
Test: follow the reproduce steps in bug, see video
Change-Id: Icab11d52cedaf94af0ee72023cebca8ec51d8851
2022-04-14 10:49:29 -07:00
TreeHugger Robot
3c3649d9a2 Merge "Creaet separate pull back animation for AllApps" into tm-dev am: 7ea312db9b am: e063262626
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17636490

Change-Id: I68d876317749b9449cd720ae55310c1d915da412
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14 14:53:36 +00:00
TreeHugger Robot
7ea312db9b Merge "Creaet separate pull back animation for AllApps" into tm-dev 2022-04-14 14:07:58 +00:00
TreeHugger Robot
00aba03657 Merge "Use bottomMargin to align OverviewActions with 3 button" into tm-dev am: bf5a0d5fe3 am: 3aeefbe017
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17729757

Change-Id: I2f1b2f0de571b02ae5f2e04abf3aeeddf74c6983
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-14 11:49:59 +00:00
TreeHugger Robot
bf5a0d5fe3 Merge "Use bottomMargin to align OverviewActions with 3 button" into tm-dev 2022-04-14 10:56:43 +00:00
Alex Chau
a74a8595fb Creaet separate pull back animation for AllApps
- In tablet, only animate recyclerView on pullback to be consistent with widget bottom sheet, and avoid showing a gap below mAppsView

Fix: 220345008
Test: manual on small and large screen
Change-Id: I1f7d03b6bd16af7a91a51a0985ef163d9e365261
2022-04-14 11:01:25 +01:00
Evan Rosky
c5b8c4d05c Merge "Finish recents animation always" into tm-qpr-dev 2022-04-14 01:16:11 +00:00
Vinit Nayak
37ce441089 Merge "Listen for density changes through DisplayController callbacks" into tm-dev 2022-04-13 22:57:00 +00:00
Evan Rosky
19002551bc Finish recents animation always
Previously, some launcher-side state would be finished, but the
actual animation would never be finished until the next touch-down.

This is a problem for shell-transitions because it relies on
animations finishing. This change handles the scenario where
the gesture finishes before the animation even starts by slotting
in a placeholder listener that just immediately finishes. If the
animation has started but there was no motion, then it directly
finishes the recents animation.

Bug: 228898164
Test: open an app, tap on the bottom-bar. With logging it should
      be evident that the transition finishes.
Change-Id: I27e00ceb4b21a2c37dc556bfecb4a90ef7155a85
2022-04-13 14:44:43 -07:00
Alex Chau
b1508b8023 Use bottomMargin to align OverviewActions with 3 button
- This ensure the updated OverviewActions position is considered when calculating modal task size

Fix: 228976149
Test: manual
Change-Id: I635e00096fdb26c164bc76fc94f6bf203f5c9c71
2022-04-13 18:51:40 +01:00
Hongwei Wang
d34d3b4834 Merge "Pass sourceRectHint to auto-enter-pip transition" into tm-dev 2022-04-13 17:38:34 +00:00
Sunny Goyal
afb6e23500 Updating code due to TaskStackChangeListener changes
Bug: 221961069
Test: Presubmit
Change-Id: I40b2e5a12c4cd6faa53ee788939c31b25bf5c37b
2022-04-13 10:31:18 -07:00
András Klöczl
fed1182660 Merge "Change page snapping logic for large screen devices" into tm-dev 2022-04-13 11:18:39 +00:00
Shikha Malhotra
80a315e50f Merge "Review comments followup" into tm-dev 2022-04-13 08:00:31 +00:00
TreeHugger Robot
d9939d8174 Merge "Adjust the insets frame providing method per API change" into tm-dev 2022-04-13 01:53:04 +00:00
Andras Kloczl
07111f25f4 Change page snapping logic for large screen devices
Use 15% of the screen width instead of 40% of the page
width currently used for phones.

Test: try page snapping on Launcher home
Bug: 213305066
Change-Id: I6a525100bf942c5089f580a27250c425ca95cf00
2022-04-12 20:23:23 +01:00
Shikha Malhotra
f78da1bae3 Review comments followup
These are review comments followup from ag/17399997

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: I9865a37c1ed663370dc28e7678994f3d961e3cd1
2022-04-12 14:33:07 +00:00
Pat Manning
29fbab4ddd Animate clear all button's alpha after last task has scrolled beyond its edge.
Test: manual
Fix: 208879377
Change-Id: Iad43abbe36d11317869a0c5aa6a8d59fd1fddb67
2022-04-12 15:32:06 +01:00
Brian Isganitis
4ad53f1268 Defer unstashing taskbar on all apps close if gesture in progress.
This behavior is more consistent with how we update taskbar stashing when IME is dismissed.

Test: Verified stashing behavior with gestures, 3-button, and bottom sheet dismiss.
Fix: 223837786
Change-Id: Ib85ebe629f33f0bddc36bbc8d99136711105b279
2022-04-11 19:54:53 -07:00
Tracy Zhou
c2538d748a Add originalView of the menu to SystemShortcut
Split from home animation needs to originate from the app icon instead of the menu item icon. This can be useful for other animations in the future.

Bug: 226395821
Test: N/A
Change-Id: If45d80e347ba275bd550b6acd6ad81b319e753a3
2022-04-11 17:13:35 -07:00
Tracy Zhou
b5d7744c1b Merge "Play icon alignment animation in live tile mode" into tm-dev 2022-04-12 00:05:34 +00:00
Tracy Zhou
abc2288399 Merge "Update task bar icon alignment logic when launcher is paused and resumed in Overview" into tm-dev 2022-04-12 00:03:15 +00:00
Tracy Zhou
d4ed2f7717 Update task bar icon alignment logic when launcher is paused and resumed in Overview
If launcher is paused and resumed in overview, goingToUnstashedLauncherStateChanged doesn't change, so we should not use goingToUnstashedLauncherState as a signal for the end value of mIconAlignmentForResumedState anim

Bug: 223109070
Test: go to overview, use the share functionality, share to drive, and make sure task bar ends up in stashed state. Making sure that it never unstashes is out of scope for this change
Change-Id: I5684be6b58279a9b41e257dd72591f7d692c2fbc
2022-04-11 23:12:49 +00:00
Tracy Zhou
42e30963c3 Play icon alignment animation in live tile mode
aka launcher is not resumed but recents animation is running

Fixes: 210047102
Test: Go to overview in live tile mode, tap on somewhere outside any task in overview, and make sure icon alignment animation is played.
Change-Id: Ic300ee296049b6fdcdf6d2595916cc84c09d95fa
2022-04-11 16:11:28 -07:00
Hongwei Wang
51cf7d18a7 Pass sourceRectHint to auto-enter-pip transition
Bug: 198309223
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/eODHpvqAQPfbwjFamtRYC1
Test: manual, see video
Change-Id: I169603c5285f9a226ab0423dbd36d8e3e2ca51a1
2022-04-11 14:33:44 -07:00
Brian Isganitis
5b89b31b12 Log taskbar all apps entrypoint, launches, and drags
Test: wwdebug, wwlogcat, ensure container is formatted as follows:
    container_info {
      all_apps_container {
        taskbar {
        }
      }
    }
Bug: 204696617
Change-Id: I2492b133f95fccb059010bc9e5ed6cce73c211f9
2022-04-11 12:14:14 -07:00
Josh Tsuji
538581639e Merge "Add the staggered ring appear animation!" into tm-dev 2022-04-11 14:32:44 +00:00
Alex Chau
e7b727e88e Merge "Force update orientation handler for initial recents view state." into tm-dev 2022-04-11 12:43:54 +00:00
wilsonshih
671d44b36b Force update orientation handler for initial recents view state.
Force execute updateSizeAndPadding at onGestureAnimationStart to ensure
there has computed the initial task size even if orientation didn't
changed.

Bug: 228565696
Test: run "atest NexusLauncherTests" on tablet device.
Change-Id: I175754a68e91039dffdfd4035414885417882a07
2022-04-11 10:53:18 +08:00
Jeremy Sim
5d2a1f47c0 Merge "Fix placement bug with split staging icon in RtL" into tm-dev 2022-04-10 01:48:53 +00:00
Jeremy Sim
e15927eec7 Merge "Implement splitting from Taskbar long-press" into tm-dev 2022-04-09 01:21:14 +00:00
Jeremy Sim
43c79704ed Fix placement bug with split staging icon in RtL
Fixes a bug where switching the phone to RtL caused Overview's split staging icon to be placed incorrectly.

The bug was caused by the fact that FrameLayout margins were not working consistently in RtL. This may be another bug; more investigation required (b/201920967).

This fix makes it so that the icon is positioned using setX and setY rather than margins.

Fixes: 227372971
Test: Manual
Change-Id: I6e5371d20e8e2e4e6f41ba93d0dfa36ed085c103
2022-04-08 18:05:05 -07:00
Vinit Nayak
9ef75227c0 Merge "Revert "Animate overivew actions view hiding on scroll."" into tm-dev 2022-04-08 22:12:46 +00:00
Jeremy Sim
abdf25d226 Implement splitting from Taskbar long-press
Implements the ability to split the screen by long-pressing a Taskbar icon.

Bug: 217964720
Test: Manual
Change-Id: I5d324d8ca912c10cc3c3de21cae98fad546b85ac
2022-04-08 12:15:16 -07:00
Vinit Nayak
f5f14acba3 Revert "Animate overivew actions view hiding on scroll."
This reverts commit 458dcdbe1e.

Reason for revert: b/228137694

Change-Id: I6992b380d9cacee2afa98e02ba406793a440e703
2022-04-08 17:26:46 +00:00
Tracy Zhou
b34b442032 Merge "Set finishedToApp = false when rotating in Overview" into tm-dev 2022-04-08 16:05:21 +00:00
Sunny Goyal
1eb1140129 Merge "Fixing spring animation for fallback launcher activity" into tm-dev 2022-04-08 07:19:51 +00:00
Jon Miranda
812feca9ef Merge "Revert "Revert "Sync hotseat/taskbar handoff""" into tm-dev 2022-04-08 01:39:42 +00:00
Wei Sheng Shih
342446d105 Merge "Update orientation state while gesture animation start." into tm-dev 2022-04-08 00:39:04 +00:00
Schneider Victor-tulias
2ff0a66b8e Merge "Add logging to debug incorrect taskbar states caught by flaky tests." into tm-dev 2022-04-07 21:05:39 +00:00
Tracy Zhou
655627f70b Set finishedToApp = false when rotating in Overview
The issue is that we always assume finishedToApp = true when recents animation is cancelled and use that to set FLAG_IN_APP. However, we don't return to app in overview after the device is rotated. Ideally we want to get signal from onRecentsAnimationCancelled, but at this point in the release it's probably ok to use launcher state to determine it.

Fixes: 227565959
Test: manual
Change-Id: I6be800aff8108b382ca3947cd1d0a45c9e9571eb
2022-04-07 20:34:00 +00:00
Sunny Goyal
c327e6bad4 Fixing spring animation for fallback launcher activity
Bug: 228260232
Test: Verified on device
Change-Id: I7b630fd6936b49214cffd01981e75aeb6b3b5d24
2022-04-07 18:49:41 +00:00
Jason Chang
4d3995b399 Merge "Fix One-handed mode tutorial broken on large screen device" into tm-dev 2022-04-07 13:58:52 +00:00
TreeHugger Robot
833c210550 Merge "Clone mInsets when copying DeviceProfile to taskbar" into tm-dev 2022-04-07 13:44:14 +00:00
Alex Chau
9e9dd8fa43 Merge "Make AllApps bottom sheet follow finger and snap after 30% progress" into tm-dev 2022-04-07 09:50:04 +00:00
TreeHugger Robot
e633cca3bc Merge "Adding finish signal to GestureNavContract." into tm-dev 2022-04-07 03:24:01 +00:00
Schneider Victor-tulias
1823bdba6e Add logging to debug incorrect taskbar states caught by flaky tests.
- Various TAPL tasts are flaking because the taskbar is present when navigating home. Several TAPL taskbar tests are also flaking because the taskbar is missing when opening an app. Adding logging to catch when FLAG_IN_APP is being set and why it isn't being applied.

Bug: 227657604
Bug: 225205246
Test: manual
Change-Id: Ia976bb0a6c7764e571fab3ac98ee21ff22ef7674
2022-04-06 14:26:47 -07:00
Sunny Goyal
5c20fdd73f Adding finish signal to GestureNavContract.
Also fixing also-closing behavior for FloatingSurfaceView for Android S

Bug: 228260232
Test: Verified manually on device
Change-Id: I83f6417a756c1459533294d681e83abba6ea58aa
2022-04-06 13:42:59 -07:00
Alex Chau
e0227551cf Clone mInsets when copying DeviceProfile to taskbar
- Set mInsets with windowBounds.insets when initialized, and set windowBounds.insets when cloning DeviceProfile
- Added more bottom sheet / all apps in DeviceProfile dump
- Also dump taskbar's device profile in dumpsys

Fix: 226968237
Test: Taskbar AllApps should have correct top padding
Test: adb shell dumpsys activity com.google.android.apps.nexuslauncher
Test: adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
Change-Id: I7739c699fb16544b92dc820354a643f745694c25
2022-04-06 19:44:43 +01:00